)]}'
{"doc/source/command-objects/port.rst":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"19c0a5842da5543522ac2c5d5579006a4001b3ce","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":".. option:: --fixed-ip subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    Desired IP and/or subnet for this port:"},{"line_number":138,"context_line":"    subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e"},{"line_number":139,"context_line":"    (you can repeat this option)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. option:: --no-fixed-ip"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a061dce_3b7f5167","line":139,"range":{"start_line":137,"start_character":4,"end_line":139,"end_character":32},"updated":"2016-04-07 01:41:09.000000000","message":"nit: This comment is not consistent with the one in the source code.\n\n* missing \"(name or ID)\" after subnet\n* \"(you can repeat this option)\" -\u003e \"(this option can be repeated)\"","commit_id":"84efdcafc79c3478eced91c29dc449f879d6718a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"24f47934688a6a6aaf9451d797946c9c141be9dd","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":".. option:: --fixed-ip subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    Desired IP and/or subnet for this port:"},{"line_number":138,"context_line":"    subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e"},{"line_number":139,"context_line":"    (you can repeat this option)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. option:: --no-fixed-ip"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a061dce_5b8045f7","line":139,"range":{"start_line":137,"start_character":4,"end_line":139,"end_character":32},"in_reply_to":"9a061dce_3b7f5167","updated":"2016-04-07 01:59:23.000000000","message":"Fixed in the followup patch:https://review.openstack.org/302492","commit_id":"84efdcafc79c3478eced91c29dc449f879d6718a"}],"openstackclient/network/v2/port.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"94a7118420893fa6d1914c464f52491aaecf7266","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                 \u0027subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e \u0027"},{"line_number":358,"context_line":"                 \u0027(this option can be repeated)\u0027)"},{"line_number":359,"context_line":"        fixed_ip.add_argument("},{"line_number":360,"context_line":"            \u0027--unset-fixed-ip\u0027,"},{"line_number":361,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":362,"context_line":"            help\u003d\u0027Clear existing information of fixed-ips\u0027)"},{"line_number":363,"context_line":"        binding_profile \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_d3bb67c2","line":360,"updated":"2016-04-01 11:09:23.000000000","message":"These should be done via an unset command, not set.","commit_id":"29e17a8ad12c0d5c6f93dc63321b1b1047ab292f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2dbed12a18549e87ae7ad4d87da72c9315445204","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                 \u0027subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e \u0027"},{"line_number":358,"context_line":"                 \u0027(this option can be repeated)\u0027)"},{"line_number":359,"context_line":"        fixed_ip.add_argument("},{"line_number":360,"context_line":"            \u0027--unset-fixed-ip\u0027,"},{"line_number":361,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":362,"context_line":"            help\u003d\u0027Clear existing information of fixed-ips\u0027)"},{"line_number":363,"context_line":"        binding_profile \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_eb410b0d","line":360,"in_reply_to":"9a061dce_6909a731","updated":"2016-04-05 00:59:45.000000000","message":"Much clearer now...\nBut I would say, that if we implement options with multiple values, we do not need an Unset command explicitly.\nUser can just use the --no-XYZ command to unset a value, then use a new UNSET command","commit_id":"29e17a8ad12c0d5c6f93dc63321b1b1047ab292f"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a2fef88fb1c32d9940950f62d445b976669ddca7","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                 \u0027subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e \u0027"},{"line_number":358,"context_line":"                 \u0027(this option can be repeated)\u0027)"},{"line_number":359,"context_line":"        fixed_ip.add_argument("},{"line_number":360,"context_line":"            \u0027--unset-fixed-ip\u0027,"},{"line_number":361,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":362,"context_line":"            help\u003d\u0027Clear existing information of fixed-ips\u0027)"},{"line_number":363,"context_line":"        binding_profile \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_6909a731","line":360,"in_reply_to":"ba0121b8_b43b0438","updated":"2016-04-04 13:10:15.000000000","message":"If you want to clear all values, then it is okay to do it on set via a --no option (per \"Options with Multiple Values\" in https://github.com/openstack/python-openstackclient/blob/master/doc/source/command-options.rst).  However, I saw this patch set was for blueprint network-property-unset.  That blueprint is for adding unset commands to allow a single value to be unset.","commit_id":"29e17a8ad12c0d5c6f93dc63321b1b1047ab292f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b05ad77c0b843e52e48cb839ef5e07f19d52522a","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                 \u0027subnet\u003d\u003csubnet\u003e,ip-address\u003d\u003cip-address\u003e \u0027"},{"line_number":358,"context_line":"                 \u0027(this option can be repeated)\u0027)"},{"line_number":359,"context_line":"        fixed_ip.add_argument("},{"line_number":360,"context_line":"            \u0027--unset-fixed-ip\u0027,"},{"line_number":361,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":362,"context_line":"            help\u003d\u0027Clear existing information of fixed-ips\u0027)"},{"line_number":363,"context_line":"        binding_profile \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_b43b0438","line":360,"in_reply_to":"ba0121b8_d3bb67c2","updated":"2016-04-04 00:59:23.000000000","message":"Not clear, can you elaborate?","commit_id":"29e17a8ad12c0d5c6f93dc63321b1b1047ab292f"}]}