)]}'
{"id":"openstack%2Fpython-openstackclient~301799","triplet_id":"openstack%2Fpython-openstackclient~master~I1ff422e6a7585bc48b04b8f5c4cc1e7e9ddab1bc","project":"openstack/python-openstackclient","branch":"master","hashtags":[],"change_id":"I1ff422e6a7585bc48b04b8f5c4cc1e7e9ddab1bc","subject":"Use fixtures and addCleanup instead of tearDown","status":"MERGED","created":"2016-04-05 16:04:11.000000000","updated":"2016-04-06 14:05:18.000000000","submitted":"2016-04-06 14:05:17.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c8187a0f2452c5b9f166275734f8d8fb05a49f87","_number":301799,"virtual_id_number":301799,"owner":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-04-06 14:05:17.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-04-05 16:17:56.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-04-06 13:04:54.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":1,"date":"2016-04-06 13:35:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-04-06 13:04:54.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-05 16:17:56.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-04-06 13:04:54.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-04-06 13:35:08.000000000","updated_by":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"reviewer":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"state":"REVIEWER"},{"updated":"2016-04-06 14:05:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5374fed408108fddd29d2981e3497b4ef6210519","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2016-04-05 16:04:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a39c850eb4bfb00bfeae3b2b59763e4d555d72ef","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-04-05 16:17:56.000000000","message":"Patch Set 1: Code-Review+2\n\nanyway i can convince you to add it to our functional tests too? here: https://github.com/openstack/python-openstackclient/blob/master/functional/common/test.py since we mutate the environment a bunch: https://github.com/openstack/python-openstackclient/blob/master/functional/tests/identity/v3/test_identity.py#L57-L62","accounts_in_message":[],"_revision_number":1},{"id":"abd13bff1ba648203949780ad0bf631de6d1d091","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-05 18:02:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/99/301799/1/check/gate-python-openstackclient-docs/49c41ff//doc/build/html/ : SUCCESS in 4m 41s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/99/301799/1/check/gate-python-openstackclient-pep8/a24a358/ : SUCCESS in 3m 24s\n- gate-python-openstackclient-python27 http://logs.openstack.org/99/301799/1/check/gate-python-openstackclient-python27/ff008fd/ : SUCCESS in 4m 23s\n- gate-python-openstackclient-python34 http://logs.openstack.org/99/301799/1/check/gate-python-openstackclient-python34/c2006e2/ : SUCCESS in 4m 45s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/99/301799/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/0d03df5/ : SUCCESS in 58m 24s\n- check-osc-plugins http://logs.openstack.org/99/301799/1/check/check-osc-plugins/f1bc430/ : SUCCESS in 4m 50s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/99/301799/1/check/gate-osc-dsvm-functional/4fd0161/ : SUCCESS in 28m 45s","accounts_in_message":[],"_revision_number":1},{"id":"55fb9d6641c8c103e4157081cddd473bf250894b","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-04-06 13:04:54.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"1a10c87aba1212ed44e8a5e5515f2fbbaa33868f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-06 13:05:03.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"731c81656cdadd2970837f2ac4e3eedff35952a9","author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"date":"2016-04-06 13:35:08.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d9e177571149037fa8f345084a323fad70976b72","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-06 14:05:17.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/99/301799/1/gate/gate-python-openstackclient-docs/3716a6a//doc/build/html/ : SUCCESS in 3m 50s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/99/301799/1/gate/gate-python-openstackclient-pep8/47bee3e/ : SUCCESS in 1m 46s\n- gate-python-openstackclient-python27 http://logs.openstack.org/99/301799/1/gate/gate-python-openstackclient-python27/af1942b/ : SUCCESS in 2m 02s\n- gate-python-openstackclient-python34 http://logs.openstack.org/99/301799/1/gate/gate-python-openstackclient-python34/79e271f/ : SUCCESS in 4m 54s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/99/301799/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/b1096d5/ : SUCCESS in 53m 14s\n- gate-osc-dsvm-functional http://logs.openstack.org/99/301799/1/gate/gate-osc-dsvm-functional/706a010/ : SUCCESS in 16m 27s","accounts_in_message":[],"_revision_number":1},{"id":"c8187a0f2452c5b9f166275734f8d8fb05a49f87","date":"2016-04-06 14:05:18.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bad21594be3a38cce44742b406f35b30040193eb","revisions":{"bad21594be3a38cce44742b406f35b30040193eb":{"kind":"REWORK","_number":1,"created":"2016-04-05 16:04:11.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/99/301799/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/99/301799/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/99/301799/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/99/301799/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/99/301799/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/99/301799/1"}}},"commit":{"parents":[{"commit":"97492c168f395eb80009162eb2e242dde23e0ba5","subject":"rxtx factor should be a float","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/97492c168f395eb80009162eb2e242dde23e0ba5"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2016-04-05 15:57:55.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2016-04-05 15:57:55.000000000","tz":120},"subject":"Use fixtures and addCleanup instead of tearDown","message":"Use fixtures and addCleanup instead of tearDown\n\nNothing ensures tearDown call as tearDown is called only if test\nsucceeds. This change replaces tearDown use with:\n\n* addCleanup use to stop mocks\n* EnvFixture which ensures to unmock environment thanks to useFixture.\n\nChange-Id: I1ff422e6a7585bc48b04b8f5c4cc1e7e9ddab1bc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bad21594be3a38cce44742b406f35b30040193eb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/bad21594be3a38cce44742b406f35b30040193eb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}