)]}'
{"openstackclient/network/v2/router.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e1d06297796c1aef47d81ffd5967e635a9935cd7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        return \u0027\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"_formatters \u003d {"},{"line_number":37,"context_line":"    \u0027admin_state_up\u0027: _format_admin_state,"},{"line_number":38,"context_line":"    \u0027external_gateway_info\u0027: _format_external_gateway_info,"},{"line_number":39,"context_line":"    \u0027availability_zones\u0027: utils.format_list,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_b90305b8","line":36,"updated":"2016-04-15 15:55:44.000000000","message":"The formatters don\u0027t handle routes today and thus data passed in for gateway is display as nexthop:\n\n[{u\u0027nexthop\u0027: u\u0027172.24.4.22\u0027, u\u0027destination\u0027: u\u002710.10.11.0/24\u0027}]\n\nWould you like me to change this as well?","commit_id":"6973d7914d2b68d6e4a7a688e4897a680696091e"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"ee1848c4eba591ab7507d2d3f01c4e011e691018","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        return \u0027\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"_formatters \u003d {"},{"line_number":37,"context_line":"    \u0027admin_state_up\u0027: _format_admin_state,"},{"line_number":38,"context_line":"    \u0027external_gateway_info\u0027: _format_external_gateway_info,"},{"line_number":39,"context_line":"    \u0027availability_zones\u0027: utils.format_list,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_b9bf40fa","line":36,"in_reply_to":"1a122d0e_b90305b8","updated":"2016-04-18 15:47:33.000000000","message":"Yes, please","commit_id":"6973d7914d2b68d6e4a7a688e4897a680696091e"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"d401765be6cabffc2da1678baf38ada65593f446","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        return \u0027\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"_formatters \u003d {"},{"line_number":37,"context_line":"    \u0027admin_state_up\u0027: _format_admin_state,"},{"line_number":38,"context_line":"    \u0027external_gateway_info\u0027: _format_external_gateway_info,"},{"line_number":39,"context_line":"    \u0027availability_zones\u0027: utils.format_list,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_224db43e","line":36,"in_reply_to":"1a122d0e_b9bf40fa","updated":"2016-04-18 18:36:37.000000000","message":"Done","commit_id":"6973d7914d2b68d6e4a7a688e4897a680696091e"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"72bf8b1bee6cee1a5af9af17d8aff4245a957202","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            # Map the route keys and append to the current routes."},{"line_number":398,"context_line":"            # The REST API will handle route validation and duplicates."},{"line_number":399,"context_line":"            for route in parsed_args.routes:"},{"line_number":400,"context_line":"                route[\u0027nexthop\u0027] \u003d route.pop(\u0027gateway\u0027)"},{"line_number":401,"context_line":"            attrs[\u0027routes\u0027] \u003d obj.routes + parsed_args.routes"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if attrs \u003d\u003d {}:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_78585d57","line":400,"updated":"2016-04-11 22:00:48.000000000","message":"IMO, the trouble is that users should provide a \"gateway\" when it\u0027s \"nexthop\" in neutronclient, in neutron APIs and when \"nexthop\" is semantically way better than \"gateway\"[1].\n\n[1] https://en.wikipedia.org/wiki/Hop_%28networking%29#Next_hop","commit_id":"6973d7914d2b68d6e4a7a688e4897a680696091e"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fa19f2299fd48b677bb2276e0f9c3d2ad8e67690","unresolved":false,"context_lines":[{"line_number":397,"context_line":"            # Map the route keys and append to the current routes."},{"line_number":398,"context_line":"            # The REST API will handle route validation and duplicates."},{"line_number":399,"context_line":"            for route in parsed_args.routes:"},{"line_number":400,"context_line":"                route[\u0027nexthop\u0027] \u003d route.pop(\u0027gateway\u0027)"},{"line_number":401,"context_line":"            attrs[\u0027routes\u0027] \u003d obj.routes + parsed_args.routes"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if attrs \u003d\u003d {}:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a18252c_bf48fb2e","line":400,"in_reply_to":"5a18252c_78585d57","updated":"2016-04-12 13:43:52.000000000","message":"Hi Cedric, thank you for the review.  This naming was discussed in the original patch set (see https://review.openstack.org/#/c/276042/ which replaced https://review.openstack.org/#/c/261053/).  Also, the subnet create and set commands already use \"gateway\" for --host-route option.\n\nThe good news is that the --route option didn\u0027t work here and subnet create and set commands have yet to be released so we have the opportunity to change things without breaking compatibility.  However, I\u0027d like to get consensus before proceeding.","commit_id":"6973d7914d2b68d6e4a7a688e4897a680696091e"}],"openstackclient/tests/network/v2/fakes.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fa26a0e097cca1488c69882ee3c8736b38d99dac","unresolved":false,"context_lines":[{"line_number":341,"context_line":"            status, tenant_id"},{"line_number":342,"context_line":"        \"\"\""},{"line_number":343,"context_line":"        if attrs is None:"},{"line_number":344,"context_line":"            attrs \u003d {}"},{"line_number":345,"context_line":"        if methods is None:"},{"line_number":346,"context_line":"            methods \u003d {}"},{"line_number":347,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_a29cf65d","line":344,"updated":"2016-04-06 14:27:33.000000000","message":"You can do \n\n    attrs \u003d attrs or {}\n\nWill save two lines( if loops)...","commit_id":"ef85d8b1921e3a9b21af49555e8e463ea86bcb08"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"af68f0dca40c7ae7a096f4b361ae5e004961b8d8","unresolved":false,"context_lines":[{"line_number":341,"context_line":"            status, tenant_id"},{"line_number":342,"context_line":"        \"\"\""},{"line_number":343,"context_line":"        if attrs is None:"},{"line_number":344,"context_line":"            attrs \u003d {}"},{"line_number":345,"context_line":"        if methods is None:"},{"line_number":346,"context_line":"            methods \u003d {}"},{"line_number":347,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_b866d14e","line":344,"in_reply_to":"9a061dce_a29cf65d","updated":"2016-04-06 20:01:03.000000000","message":"Done","commit_id":"ef85d8b1921e3a9b21af49555e8e463ea86bcb08"}]}