)]}'
{"id":"openstack%2Fpython-openstackclient~301957","triplet_id":"openstack%2Fpython-openstackclient~master~I728ab96381ca9f3fd1f899dd50e5ceb5e97b9397","project":"openstack/python-openstackclient","branch":"master","topic":"tempfile","hashtags":[],"change_id":"I728ab96381ca9f3fd1f899dd50e5ceb5e97b9397","subject":"Improve tmpfile cleanup in functests","status":"MERGED","created":"2016-04-05 22:41:25.000000000","updated":"2016-04-06 14:10:05.000000000","submitted":"2016-04-06 14:10:05.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6356752302a5c9ba0d1f0dba7c6773bdaefd956d","_number":301957,"virtual_id_number":301957,"owner":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-04-06 14:10:05.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-04-06 05:08:58.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-04-06 09:10:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":2,"date":"2016-04-06 13:09:31.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":1,"date":"2016-04-06 13:17:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":1,"date":"2016-04-06 13:09:31.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-06 05:08:58.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-04-06 09:10:07.000000000","updated_by":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"reviewer":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"state":"REVIEWER"},{"updated":"2016-04-06 13:09:31.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-04-06 13:17:49.000000000","updated_by":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"reviewer":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"state":"REVIEWER"},{"updated":"2016-04-06 14:10:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b2fac9769339a7ecccefa81cacd30b5ce9e94752","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2016-04-05 22:41:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"272fccff56ae8978750d43ca3e57f0aacf05d8d0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-05 23:33:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/57/301957/1/check/gate-python-openstackclient-docs/8e8671f//doc/build/html/ : SUCCESS in 5m 36s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/57/301957/1/check/gate-python-openstackclient-pep8/0dd1ece/ : SUCCESS in 4m 17s\n- gate-python-openstackclient-python27 http://logs.openstack.org/57/301957/1/check/gate-python-openstackclient-python27/e76ba56/ : SUCCESS in 4m 31s\n- gate-python-openstackclient-python34 http://logs.openstack.org/57/301957/1/check/gate-python-openstackclient-python34/dd46e3f/ : SUCCESS in 6m 13s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/57/301957/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/df1e1ad/ : SUCCESS in 50m 23s\n- check-osc-plugins http://logs.openstack.org/57/301957/1/check/check-osc-plugins/7b97718/ : SUCCESS in 4m 37s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/57/301957/1/check/gate-osc-dsvm-functional/cc68043/ : SUCCESS in 25m 58s","accounts_in_message":[],"_revision_number":1},{"id":"7168850c5e03bbab6a3eff7694a6926e94901791","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-04-06 05:08:58.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7ccfadb4498e4d514cbfc273cecd905482a70b09","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2016-04-06 09:10:07.000000000","message":"Patch Set 1: Code-Review+1\n\nThank you","accounts_in_message":[],"_revision_number":1},{"id":"edd6c64dab2c6e7a50a9a7c38f751b0065a6a3c8","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-04-06 13:09:31.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"755078fd20c6a420904c8cae6ce4e4381e71b459","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-06 13:09:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"b3a36b1d02c45222719370caa2b792df6656a3a1","author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"date":"2016-04-06 13:17:49.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"7481d103b68e80ac131ec2298d17911e4215d560","date":"2016-04-06 14:10:05.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"f1e45d41cbd900894372a3435283c4a63ef3c00d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-06 14:10:05.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/57/301957/1/gate/gate-python-openstackclient-docs/a1bc6c8//doc/build/html/ : SUCCESS in 3m 34s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/57/301957/1/gate/gate-python-openstackclient-pep8/b12e42b/ : SUCCESS in 2m 22s\n- gate-python-openstackclient-python27 http://logs.openstack.org/57/301957/1/gate/gate-python-openstackclient-python27/4ffa658/ : SUCCESS in 4m 18s\n- gate-python-openstackclient-python34 http://logs.openstack.org/57/301957/1/gate/gate-python-openstackclient-python34/bf67c84/ : SUCCESS in 4m 42s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/57/301957/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/4f20fb3/ : SUCCESS in 1h 00m 05s\n- gate-osc-dsvm-functional http://logs.openstack.org/57/301957/1/gate/gate-osc-dsvm-functional/a05c793/ : SUCCESS in 16m 17s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3c82c0e62e5b661d03ad7d9a3e93f95876805c2d","revisions":{"3c82c0e62e5b661d03ad7d9a3e93f95876805c2d":{"kind":"REWORK","_number":1,"created":"2016-04-05 22:41:25.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/57/301957/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/57/301957/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/301957/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/301957/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/301957/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/57/301957/1"}}},"commit":{"parents":[{"commit":"139a45bb71ca2e99b0c8947c43c8d0165dec165e","subject":"Remove unused method cleanup_tmpfile","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/139a45bb71ca2e99b0c8947c43c8d0165dec165e"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2016-04-05 22:37:16.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2016-04-05 22:40:44.000000000","tz":120},"subject":"Improve tmpfile cleanup in functests","message":"Improve tmpfile cleanup in functests\n\nThis change replaces when possible homemade temporary file management by\ntempfile.NamedTemporaryFile[1][2] and defines only when needed a cleanup\nfor a temporary file[2].\n\n[1] functional/tests/compute/v2/test_keypair.py\n[2] functional/tests/object/v1/test_object.py\n\nChange-Id: I728ab96381ca9f3fd1f899dd50e5ceb5e97b9397\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3c82c0e62e5b661d03ad7d9a3e93f95876805c2d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3c82c0e62e5b661d03ad7d9a3e93f95876805c2d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}