)]}'
{"id":"openstack%2Fpython-openstackclient~301964","triplet_id":"openstack%2Fpython-openstackclient~master~I4da541b7552d06eaffafda446e389bb552422cda","project":"openstack/python-openstackclient","branch":"master","topic":"addCleanup","hashtags":[],"change_id":"I4da541b7552d06eaffafda446e389bb552422cda","subject":"Correct addCleanup use in functests","status":"MERGED","created":"2016-04-05 23:02:59.000000000","updated":"2016-04-07 16:32:07.000000000","submitted":"2016-04-07 16:32:06.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":16,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4b0bea3c13d279b6c9c9a3750ed450ad7e3221ba","_number":301964,"virtual_id_number":301964,"owner":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-04-07 16:32:06.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"recommended":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-04-07 08:23:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":2,"date":"2016-04-07 14:34:49.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2016-04-07 14:48:59.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2016-04-07 14:48:59.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-06 05:11:02.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-04-07 08:23:08.000000000","updated_by":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"reviewer":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"state":"REVIEWER"},{"updated":"2016-04-07 14:34:49.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-04-07 14:48:59.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-04-07 16:32:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ff809e4cf7b58cc1dc92da5716a0b26e1dae3428","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2016-04-05 23:02:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dcf23f6d7ac8c02947be91dbd111c35e4681b6ab","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-06 00:16:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/64/301964/1/check/gate-python-openstackclient-docs/1eee9dd//doc/build/html/ : SUCCESS in 6m 01s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/64/301964/1/check/gate-python-openstackclient-pep8/5a00e6b/ : SUCCESS in 4m 48s\n- gate-python-openstackclient-python27 http://logs.openstack.org/64/301964/1/check/gate-python-openstackclient-python27/26d3b53/ : SUCCESS in 2m 06s\n- gate-python-openstackclient-python34 http://logs.openstack.org/64/301964/1/check/gate-python-openstackclient-python34/6fcde02/ : SUCCESS in 5m 48s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/64/301964/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/d066a55/ : SUCCESS in 1h 12m 19s\n- check-osc-plugins http://logs.openstack.org/64/301964/1/check/check-osc-plugins/4da9013/ : SUCCESS in 2m 10s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/64/301964/1/check/gate-osc-dsvm-functional/ac5f466/ : SUCCESS in 24m 54s","accounts_in_message":[],"_revision_number":1},{"id":"6d49442f592591c553eb648d548cb73bec29f1ca","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-04-06 05:11:02.000000000","message":"Patch Set 1: Code-Review+2\n\ngood catch","accounts_in_message":[],"_revision_number":1},{"id":"983c3079b4d1e3db6ad58773ec8adc0eb1fa7b49","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2016-04-06 08:14:02.000000000","message":"Patch Set 1: Code-Review-1\n\n(8 comments)\n\nsome points need to be fixed.","accounts_in_message":[],"_revision_number":1},{"id":"9b36b16292665c1864d56e9fa3586d0841308cdc","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2016-04-06 18:56:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0b8a83a2d4c8aab1777a4735587bf0c208bd301e","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2016-04-06 18:56:56.000000000","message":"Patch Set 1:\n\n(8 comments)","accounts_in_message":[],"_revision_number":1},{"id":"db60890e864bc505aae98dae1575402c4c14280f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-06 20:06:28.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/64/301964/2/check/gate-python-openstackclient-docs/5520e54//doc/build/html/ : SUCCESS in 3m 55s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/64/301964/2/check/gate-python-openstackclient-pep8/8a61cf0/ : SUCCESS in 2m 47s\n- gate-python-openstackclient-python27 http://logs.openstack.org/64/301964/2/check/gate-python-openstackclient-python27/32f194e/ : SUCCESS in 2m 15s\n- gate-python-openstackclient-python34 http://logs.openstack.org/64/301964/2/check/gate-python-openstackclient-python34/86093bb/ : SUCCESS in 10m 13s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/64/301964/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/2775303/ : SUCCESS in 1h 05m 20s\n- check-osc-plugins http://logs.openstack.org/64/301964/2/check/check-osc-plugins/dfea5b7/ : SUCCESS in 2m 20s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/64/301964/2/check/gate-osc-dsvm-functional/850935b/ : SUCCESS in 22m 33s","accounts_in_message":[],"_revision_number":2},{"id":"49fd3a762895d4c238c971ca47d12376e877a8ea","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2016-04-07 08:23:08.000000000","message":"Patch Set 2: Code-Review+1\n\nThank you addressing my comments :-)","accounts_in_message":[],"_revision_number":2},{"id":"1e6fff641492b4d8db40791e8f5c493983c3fe72","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-04-07 14:34:49.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b20fb4a0717fed0a254eed6069b1b172a3e3c842","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-04-07 14:48:59.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"710a13af5caf75a3a33dcd837a29ae00ee851ec8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-07 15:02:26.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"a96b72f763317c1bfae79f1fc0e847a79703e9e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-07 16:32:06.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/64/301964/2/gate/gate-python-openstackclient-docs/6bc9813//doc/build/html/ : SUCCESS in 2m 18s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/64/301964/2/gate/gate-python-openstackclient-pep8/f5a04f5/ : SUCCESS in 1m 53s\n- gate-python-openstackclient-python27 http://logs.openstack.org/64/301964/2/gate/gate-python-openstackclient-python27/54a02c8/ : SUCCESS in 2m 28s\n- gate-python-openstackclient-python34 http://logs.openstack.org/64/301964/2/gate/gate-python-openstackclient-python34/b4a3109/ : SUCCESS in 3m 44s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/64/301964/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/fe285ab/ : SUCCESS in 1h 17m 18s\n- gate-osc-dsvm-functional http://logs.openstack.org/64/301964/2/gate/gate-osc-dsvm-functional/da99e59/ : SUCCESS in 26m 40s","accounts_in_message":[],"_revision_number":2},{"id":"1688a8d1d2af2e746900b576364e265d04f7d294","date":"2016-04-07 16:32:07.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e2e9c49cd920947eec1f873e74a98ec5ab6834fd","revisions":{"2804b98d49b52f5b8e63c18bcc63ac4c944985bf":{"kind":"REWORK","_number":1,"created":"2016-04-05 23:02:59.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/64/301964/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/64/301964/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/64/301964/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/64/301964/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/64/301964/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/64/301964/1"}}},"commit":{"parents":[{"commit":"c3f6ee95709d1ccb7de7818e4403645a1e9a5662","subject":"Trivial: Rename FakehypervisorStats to FakeHypervisorStats","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c3f6ee95709d1ccb7de7818e4403645a1e9a5662"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2016-04-05 22:54:31.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2016-04-05 22:54:31.000000000","tz":120},"subject":"Correct addCleanup use in functests","message":"Correct addCleanup use in functests\n\nThis change replaces in many identity functests the pattern:\n\n raw_resource \u003d create_resource(...)\n check(raw_resource)\n self.addCleanup(delete_resource, ...)\n ...\n\nby the pattern:\n\n raw_resource \u003d create_resource(...)\n self.addCleanup(delete_resource, ...)\n check(raw_resource)\n ...\n\nwhich ensures that cleanup is defined and called after the test even if\ncheck(resource) fails.\n\nChange-Id: I4da541b7552d06eaffafda446e389bb552422cda\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2804b98d49b52f5b8e63c18bcc63ac4c944985bf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2804b98d49b52f5b8e63c18bcc63ac4c944985bf"}]},"branch":"refs/heads/master"},"e2e9c49cd920947eec1f873e74a98ec5ab6834fd":{"kind":"REWORK","_number":2,"created":"2016-04-06 18:56:49.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/64/301964/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/64/301964/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/64/301964/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/64/301964/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/64/301964/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/64/301964/2"}}},"commit":{"parents":[{"commit":"c3f6ee95709d1ccb7de7818e4403645a1e9a5662","subject":"Trivial: Rename FakehypervisorStats to FakeHypervisorStats","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c3f6ee95709d1ccb7de7818e4403645a1e9a5662"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2016-04-05 22:54:31.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2016-04-06 18:43:21.000000000","tz":120},"subject":"Correct addCleanup use in functests","message":"Correct addCleanup use in functests\n\nThis change replaces in many identity functests the pattern:\n\n raw_resource \u003d create_resource(...)\n check(raw_resource)\n self.addCleanup(delete_resource, ...)\n ...\n\nby the pattern:\n\n raw_resource \u003d create_resource(...)\n self.addCleanup(delete_resource, ...)\n check(raw_resource)\n ...\n\nwhich ensures that cleanup is defined and called after the test even if\ncheck(resource) fails.\n\nChange-Id: I4da541b7552d06eaffafda446e389bb552422cda\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e2e9c49cd920947eec1f873e74a98ec5ab6834fd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e2e9c49cd920947eec1f873e74a98ec5ab6834fd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}