)]}'
{"id":"openstack%2Fpython-openstackclient~301970","triplet_id":"openstack%2Fpython-openstackclient~master~I9ffcaf9c6e6a1ff5df6ea2d79be3fb4496db4b85","project":"openstack/python-openstackclient","branch":"master","topic":"canonical-asserts","hashtags":[],"change_id":"I9ffcaf9c6e6a1ff5df6ea2d79be3fb4496db4b85","subject":"Prefer assertEqual/assertIn over assertOutput/assertInOutput","status":"MERGED","created":"2016-04-05 23:20:45.000000000","updated":"2016-04-14 19:55:26.000000000","submitted":"2016-04-14 19:55:26.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e77bebaaff9b82808f1e1fbd9c10b07b0363b31a","_number":301970,"virtual_id_number":301970,"owner":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-04-14 19:55:26.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"recommended":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"all":[{"value":1,"date":"2016-04-06 22:59:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-04-07 08:20:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":2,"date":"2016-04-07 20:21:09.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":2,"date":"2016-04-14 18:34:57.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":1,"date":"2016-04-14 18:34:57.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-06 05:14:02.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-04-06 22:59:18.000000000","updated_by":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"reviewer":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"state":"REVIEWER"},{"updated":"2016-04-07 08:20:10.000000000","updated_by":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"reviewer":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"state":"REVIEWER"},{"updated":"2016-04-07 20:21:09.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-04-14 18:34:57.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-04-14 19:55:26.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"37ada3b8e020c430fd5b567eb49a593c74f69f7a","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2016-04-05 23:20:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e8a7ac45bf332d19dc6057aa0ca67a327b2f4397","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2016-04-05 23:26:03.000000000","message":"Topic changed from addCleanup to canonical-asserts","accounts_in_message":[],"_revision_number":1},{"id":"3a04e930dac8787a67c8fc9038a7cf923065e663","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-06 00:31:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/70/301970/1/check/gate-python-openstackclient-docs/16ef9d2//doc/build/html/ : SUCCESS in 6m 45s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/70/301970/1/check/gate-python-openstackclient-pep8/22448f4/ : SUCCESS in 2m 22s\n- gate-python-openstackclient-python27 http://logs.openstack.org/70/301970/1/check/gate-python-openstackclient-python27/44278d5/ : SUCCESS in 4m 14s\n- gate-python-openstackclient-python34 http://logs.openstack.org/70/301970/1/check/gate-python-openstackclient-python34/cfaab44/ : SUCCESS in 7m 48s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/70/301970/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/06f3003/ : SUCCESS in 1h 10m 59s\n- check-osc-plugins http://logs.openstack.org/70/301970/1/check/check-osc-plugins/20f164c/ : SUCCESS in 3m 00s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/70/301970/1/check/gate-osc-dsvm-functional/5ab9833/ : SUCCESS in 34m 03s","accounts_in_message":[],"_revision_number":1},{"id":"0058934cf3648044320b24186980f7e398378159","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-04-06 05:14:02.000000000","message":"Patch Set 1:\n\nif we are going to do this, then we should do it across all functional tests to remain consistent","accounts_in_message":[],"_revision_number":1},{"id":"63f0981af15acc1a0eb7af994862f81a18152b2b","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2016-04-06 07:02:06.000000000","message":"Patch Set 1: Code-Review+1\n\nThank you do these, more readable code, and I think we should only use assertOutput and assertInOutput in setUpClass and teardownClass.","accounts_in_message":[],"_revision_number":1},{"id":"08942c003e12ed445869ed77ebdf9fedc36f4eeb","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2016-04-06 19:01:10.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9195f076ed23feba6299361a79d5f6dd4864bc36","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2016-04-06 19:04:12.000000000","message":"Topic changed from addCleanup to canonical-asserts","accounts_in_message":[],"_revision_number":2},{"id":"8756010ebf36b2dd00822ec7801bcdd40ca1d8e6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-06 20:11:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/70/301970/2/check/gate-python-openstackclient-docs/e600aae//doc/build/html/ : SUCCESS in 2m 07s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/70/301970/2/check/gate-python-openstackclient-pep8/465b344/ : SUCCESS in 1m 51s\n- gate-python-openstackclient-python27 http://logs.openstack.org/70/301970/2/check/gate-python-openstackclient-python27/ff5b90a/ : SUCCESS in 2m 17s\n- gate-python-openstackclient-python34 http://logs.openstack.org/70/301970/2/check/gate-python-openstackclient-python34/e6cd946/ : SUCCESS in 5m 36s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/70/301970/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/744b571/ : SUCCESS in 1h 03m 24s\n- check-osc-plugins http://logs.openstack.org/70/301970/2/check/check-osc-plugins/5fc3883/ : SUCCESS in 2m 16s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/70/301970/2/check/gate-osc-dsvm-functional/b5960c5/ : SUCCESS in 16m 25s","accounts_in_message":[],"_revision_number":2},{"id":"1490691d9c7cdd35efcfd728ad6fdc44177517e7","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-04-06 22:59:18.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"de53cbbe00377a78f106f6a873947e60051b1185","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2016-04-07 08:20:10.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"71afd96784139a8455f86d17727922e6b428d084","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-04-07 20:21:09.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"325bab2ac1c964d38ed44259fe41e27197309363","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-04-14 18:34:57.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"80b46c32c57712fd614a62dbf6a3f6462043b515","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-14 18:35:17.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"872e44d4bd8719be7dcdb8f5ee21fd4af63c30a2","date":"2016-04-14 19:55:26.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"e77bebaaff9b82808f1e1fbd9c10b07b0363b31a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-14 19:55:26.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/70/301970/2/gate/gate-python-openstackclient-docs/4e4a774//doc/build/html/ : SUCCESS in 1m 57s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/70/301970/2/gate/gate-python-openstackclient-pep8/b703397/ : SUCCESS in 3m 08s\n- gate-python-openstackclient-python27 http://logs.openstack.org/70/301970/2/gate/gate-python-openstackclient-python27/a6bc454/ : SUCCESS in 1m 48s\n- gate-python-openstackclient-python34 http://logs.openstack.org/70/301970/2/gate/gate-python-openstackclient-python34/9afd0c2/ : SUCCESS in 3m 57s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/70/301970/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/f14ee28/ : SUCCESS in 1h 16m 47s\n- gate-osc-dsvm-functional http://logs.openstack.org/70/301970/2/gate/gate-osc-dsvm-functional/1b116c6/ : SUCCESS in 32m 06s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b13ec98467f2d374e741efa5888937c5f2b86ebb","revisions":{"08daf50c1be7cbd41d7d42282d21d9fcc364a281":{"kind":"REWORK","_number":1,"created":"2016-04-05 23:20:45.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/70/301970/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/70/301970/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/70/301970/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/70/301970/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/70/301970/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/70/301970/1"}}},"commit":{"parents":[{"commit":"2804b98d49b52f5b8e63c18bcc63ac4c944985bf","subject":"Correct addCleanup use in functests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2804b98d49b52f5b8e63c18bcc63ac4c944985bf"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2016-04-05 23:12:40.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2016-04-05 23:16:14.000000000","tz":120},"subject":"Prefer assertEqual/assertIn over assertOutput/assertInOutput","message":"Prefer assertEqual/assertIn over assertOutput/assertInOutput\n\nfunctional.common.tests moduledefines:\n\n * assertOutput (similar to assertEqual)\n * assertInOutput (similar to assertIn)\n\nin order to allow the usage of assertions in testcase classmethods but\nthere is no reason to use them in testcase instancemethods at least\nbecause they raise Exception instances instead of AssertionError\ninstances.\n\nChange-Id: I9ffcaf9c6e6a1ff5df6ea2d79be3fb4496db4b85\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/08daf50c1be7cbd41d7d42282d21d9fcc364a281"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/08daf50c1be7cbd41d7d42282d21d9fcc364a281"}]},"branch":"refs/heads/master"},"b13ec98467f2d374e741efa5888937c5f2b86ebb":{"kind":"REWORK","_number":2,"created":"2016-04-06 19:01:10.000000000","uploader":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"ref":"refs/changes/70/301970/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/70/301970/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/70/301970/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/70/301970/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/70/301970/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/70/301970/2"}}},"commit":{"parents":[{"commit":"e2e9c49cd920947eec1f873e74a98ec5ab6834fd","subject":"Correct addCleanup use in functests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/e2e9c49cd920947eec1f873e74a98ec5ab6834fd"}]}],"author":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2016-04-05 23:12:40.000000000","tz":120},"committer":{"name":"Cedric Brandily","email":"zzelle@gmail.com","date":"2016-04-06 18:59:59.000000000","tz":120},"subject":"Prefer assertEqual/assertIn over assertOutput/assertInOutput","message":"Prefer assertEqual/assertIn over assertOutput/assertInOutput\n\nfunctional.common.tests module defines:\n\n * assertOutput (similar to assertEqual)\n * assertInOutput (similar to assertIn)\n\nin order to allow the usage of assertions in testcase classmethods but\nthere is no reason to use them in testcase instancemethods at least\nbecause they raise Exception instances instead of AssertionError\ninstances.\n\nChange-Id: I9ffcaf9c6e6a1ff5df6ea2d79be3fb4496db4b85\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b13ec98467f2d374e741efa5888937c5f2b86ebb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b13ec98467f2d374e741efa5888937c5f2b86ebb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}