)]}'
{"doc/source/command-objects/server.rst":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"067eb5db044e2a365d2e178f5559a344464ea3e9","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    Network to allocate the fixed IP address from (name or ID)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"server add floating ip"},{"line_number":28,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_15ae512d","line":25,"range":{"start_line":25,"start_character":13,"end_line":25,"end_character":14},"updated":"2016-04-08 04:59:23.000000000","message":"Can we rewrite it as Network from which fixed IP address is allocated?\n\nIts just that I like my prepositions in the middle of the sentence than at the end ( Latin influence maybe ... though I dont have any clue about Latin :) )","commit_id":"5e84c1f235ee724b1cf9063254f03a0161614f31"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ac4a4985ca71b1a62198e43592ef8be17f217cbf","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. describe:: \u003cnetwork\u003e"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    Network to allocate the fixed IP address from (name or ID)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"server add floating ip"},{"line_number":28,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_10001f33","line":25,"range":{"start_line":25,"start_character":13,"end_line":25,"end_character":14},"in_reply_to":"9a061dce_15ae512d","updated":"2016-04-08 06:03:50.000000000","message":"But I\u0027d like to keep the comment as short as possible. When we decide to do so, I think I can change them all. I\u0027m OK with either of them. :)","commit_id":"5e84c1f235ee724b1cf9063254f03a0161614f31"}],"doc/source/commands.rst":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"067eb5db044e2a365d2e178f5559a344464ea3e9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"* ``extension``: (**Compute**, **Identity**, **Network**, **Volume**) OpenStack server API extensions"},{"line_number":88,"context_line":"* ``federation protocol``: (**Identity**) the underlying protocol used while federating identities"},{"line_number":89,"context_line":"* ``flavor``: (**Compute**) predefined server configurations: ram, root disk, etc"},{"line_number":90,"context_line":"* ``fixedi ip``: (**Compute**, **Network**) - an internal IP address assigned to a server"},{"line_number":91,"context_line":"* ``floating ip``: (**Compute**, **Network**) - a public IP address that can be mapped to a server"},{"line_number":92,"context_line":"* ``floating ip pool``: (**Compute**, **Network**) - a pool of public IP addresses"},{"line_number":93,"context_line":"* ``group``: (**Identity**) a grouping of users"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_f56bddee","line":90,"updated":"2016-04-08 04:59:23.000000000","message":"fixedi ??\nWow... :)","commit_id":"5e84c1f235ee724b1cf9063254f03a0161614f31"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ac4a4985ca71b1a62198e43592ef8be17f217cbf","unresolved":false,"context_lines":[{"line_number":87,"context_line":"* ``extension``: (**Compute**, **Identity**, **Network**, **Volume**) OpenStack server API extensions"},{"line_number":88,"context_line":"* ``federation protocol``: (**Identity**) the underlying protocol used while federating identities"},{"line_number":89,"context_line":"* ``flavor``: (**Compute**) predefined server configurations: ram, root disk, etc"},{"line_number":90,"context_line":"* ``fixedi ip``: (**Compute**, **Network**) - an internal IP address assigned to a server"},{"line_number":91,"context_line":"* ``floating ip``: (**Compute**, **Network**) - a public IP address that can be mapped to a server"},{"line_number":92,"context_line":"* ``floating ip pool``: (**Compute**, **Network**) - a pool of public IP addresses"},{"line_number":93,"context_line":"* ``group``: (**Identity**) a grouping of users"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a061dce_d045076f","line":90,"in_reply_to":"9a061dce_f56bddee","updated":"2016-04-08 06:03:50.000000000","message":"Done","commit_id":"5e84c1f235ee724b1cf9063254f03a0161614f31"}],"openstackclient/compute/v2/fixedip.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"1ff5d43f3778f6bcc0cd991152ccfeb602333f83","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return parser"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def take_action(self, parsed_args):"},{"line_number":52,"context_line":"        self.log.warning(_(\u0027This command has been deprecated. \u0027"},{"line_number":53,"context_line":"                           \u0027Please use \"server add fixed ip\" instead.\u0027))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        compute_client \u003d self.app.client_manager.compute"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a9d85d2_4dee43b5","line":52,"range":{"start_line":52,"start_character":25,"end_line":52,"end_character":26},"updated":"2016-06-21 11:39:53.000000000","message":"nits: \u0027_LW\u0027 should be used in warning log i18n.","commit_id":"d6e4d12a44acc4121bc453390a46dd40707ae5a2"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ab901ad0df66d91e6316901fbdcf6efbfa76d65a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        return parser"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def take_action(self, parsed_args):"},{"line_number":52,"context_line":"        self.log.warning(_(\u0027This command has been deprecated. \u0027"},{"line_number":53,"context_line":"                           \u0027Please use \"server add fixed ip\" instead.\u0027))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        compute_client \u003d self.app.client_manager.compute"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a9d85d2_1cf46ef0","line":52,"range":{"start_line":52,"start_character":25,"end_line":52,"end_character":26},"in_reply_to":"5a9d85d2_4dee43b5","updated":"2016-06-21 12:06:40.000000000","message":"OK, I see. But in OSC, we just fixed the i18n issue, and only _() is used. So I\u0027d prefer to use _() here. After all, these wrapper classes will be removed finally. \n\nOf course, if we decide to use _LW(), _LI(), _LE(), I think we can fix them all in one single patch.","commit_id":"d6e4d12a44acc4121bc453390a46dd40707ae5a2"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"1ff5d43f3778f6bcc0cd991152ccfeb602333f83","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        return parser"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def take_action(self, parsed_args):"},{"line_number":92,"context_line":"        self.log.warning(_(\u0027This command has been deprecated. \u0027"},{"line_number":93,"context_line":"                           \u0027Please use \"server remove fixed ip\" instead.\u0027))"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        compute_client \u003d self.app.client_manager.compute"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a9d85d2_8d2e6bf8","line":92,"range":{"start_line":92,"start_character":25,"end_line":92,"end_character":26},"updated":"2016-06-21 11:39:53.000000000","message":"nits: ditto","commit_id":"d6e4d12a44acc4121bc453390a46dd40707ae5a2"}],"openstackclient/compute/v2/server.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"067eb5db044e2a365d2e178f5559a344464ea3e9","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            compute_client.servers, parsed_args.server)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        network \u003d utils.find_resource("},{"line_number":211,"context_line":"            compute_client.networks, parsed_args.network)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        server.add_fixed_ip(network.id)"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_b5332513","line":211,"updated":"2016-04-08 04:59:23.000000000","message":"shouldnt we add ignore_missing\u003dFalse?","commit_id":"5e84c1f235ee724b1cf9063254f03a0161614f31"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ac4a4985ca71b1a62198e43592ef8be17f217cbf","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            compute_client.servers, parsed_args.server)"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        network \u003d utils.find_resource("},{"line_number":211,"context_line":"            compute_client.networks, parsed_args.network)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        server.add_fixed_ip(network.id)"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_702ebba5","line":211,"in_reply_to":"9a061dce_b5332513","updated":"2016-04-08 06:03:50.000000000","message":"utils.find_resource() doesn\u0027t have \"ignore_missing\" argument. If it cannot find the resource, it will raise an exception.","commit_id":"5e84c1f235ee724b1cf9063254f03a0161614f31"}],"openstackclient/tests/compute/v2/test_server.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"1ff5d43f3778f6bcc0cd991152ccfeb602333f83","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # Get a shortcut to the compute client ServerManager Mock"},{"line_number":97,"context_line":"        self.networks_mock \u003d self.app.client_manager.compute.networks"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        self.servers_mock.add_fixed_ip.return_value \u003d None"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Get the command object to test"},{"line_number":102,"context_line":"        self.cmd \u003d server.AddFixedIP(self.app, None)"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a9d85d2_488c717f","line":99,"updated":"2016-06-21 11:39:53.000000000","message":"we call server object add_fixed_ip() method, so the mock is useless.","commit_id":"d6e4d12a44acc4121bc453390a46dd40707ae5a2"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ab901ad0df66d91e6316901fbdcf6efbfa76d65a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        # Get a shortcut to the compute client ServerManager Mock"},{"line_number":97,"context_line":"        self.networks_mock \u003d self.app.client_manager.compute.networks"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        self.servers_mock.add_fixed_ip.return_value \u003d None"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # Get the command object to test"},{"line_number":102,"context_line":"        self.cmd \u003d server.AddFixedIP(self.app, None)"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a9d85d2_9cba1e22","line":99,"in_reply_to":"5a9d85d2_488c717f","updated":"2016-06-21 12:06:40.000000000","message":"Oh, yes...I just copied the old code. :)\n\nI also fixed the same problem in floating_ip patch.","commit_id":"d6e4d12a44acc4121bc453390a46dd40707ae5a2"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"1ff5d43f3778f6bcc0cd991152ccfeb602333f83","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        servers[0].add_fixed_ip.assert_called_with("},{"line_number":127,"context_line":"            network.id,"},{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        self.assertIsNone(result)"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a9d85d2_68568dd3","line":126,"updated":"2016-06-21 11:39:53.000000000","message":"assert_called_once_with() is more exact.","commit_id":"d6e4d12a44acc4121bc453390a46dd40707ae5a2"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ab901ad0df66d91e6316901fbdcf6efbfa76d65a","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        servers[0].add_fixed_ip.assert_called_with("},{"line_number":127,"context_line":"            network.id,"},{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        self.assertIsNone(result)"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a9d85d2_bc855a5a","line":126,"in_reply_to":"5a9d85d2_68568dd3","updated":"2016-06-21 12:06:40.000000000","message":"Done","commit_id":"d6e4d12a44acc4121bc453390a46dd40707ae5a2"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"1ff5d43f3778f6bcc0cd991152ccfeb602333f83","unresolved":false,"context_lines":[{"line_number":926,"context_line":"    def setUp(self):"},{"line_number":927,"context_line":"        super(TestServerRemoveFixedIP, self).setUp()"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"        self.servers_mock.remove_fixed_ip.return_value \u003d None"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"        # Get the command object to test"},{"line_number":932,"context_line":"        self.cmd \u003d server.RemoveFixedIP(self.app, None)"}],"source_content_type":"text/x-python","patch_set":20,"id":"5a9d85d2_086ee995","line":929,"updated":"2016-06-21 11:39:53.000000000","message":"ditto","commit_id":"d6e4d12a44acc4121bc453390a46dd40707ae5a2"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"1ff5d43f3778f6bcc0cd991152ccfeb602333f83","unresolved":false,"context_lines":[{"line_number":951,"context_line":""},{"line_number":952,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"        servers[0].remove_fixed_ip.assert_called_with(\u00271.2.3.4\u0027)"},{"line_number":955,"context_line":"        self.assertIsNone(result)"},{"line_number":956,"context_line":""},{"line_number":957,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"5a9d85d2_28fac5bd","line":954,"updated":"2016-06-21 11:39:53.000000000","message":"ditto","commit_id":"d6e4d12a44acc4121bc453390a46dd40707ae5a2"}],"releasenotes/notes/ip-command-rework-8d3fe0858f51e6b8.yaml":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"459a8624cd4fee6e326bcad43e0d978e599cd4bd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":10,"context_line":"  - Add new command ``server add/remove fixed ip``. It is used to replace"},{"line_number":11,"context_line":"    the old command ``ip fixed add/remove``."},{"line_number":12,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - Deprecate command ``ip floating pool list``."},{"line_number":15,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5a9d85d2_0839df41","line":12,"updated":"2016-06-21 02:17:05.000000000","message":"Please include the blueprint name in the link.","commit_id":"a7ed2715a41d37c89bf7afd70d17e32ae5617c69"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"0fc6aacc0f9d5493ba8bd850b797626e3dffe928","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":10,"context_line":"  - Add new command ``server add/remove fixed ip``. It is used to replace"},{"line_number":11,"context_line":"    the old command ``ip fixed add/remove``."},{"line_number":12,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":13,"context_line":"deprecations:"},{"line_number":14,"context_line":"  - Deprecate command ``ip floating pool list``."},{"line_number":15,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5a9d85d2_470d8d8f","line":12,"in_reply_to":"5a9d85d2_0839df41","updated":"2016-06-21 08:06:01.000000000","message":"Done","commit_id":"a7ed2715a41d37c89bf7afd70d17e32ae5617c69"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"459a8624cd4fee6e326bcad43e0d978e599cd4bd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  - Deprecate command ``ip floating add/remove``."},{"line_number":17,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":18,"context_line":"  - Deprecate command ``ip fixed add/remove``."},{"line_number":19,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5a9d85d2_483be738","line":19,"updated":"2016-06-21 02:17:05.000000000","message":"Same as above.","commit_id":"a7ed2715a41d37c89bf7afd70d17e32ae5617c69"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"0fc6aacc0f9d5493ba8bd850b797626e3dffe928","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  - Deprecate command ``ip floating add/remove``."},{"line_number":17,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":18,"context_line":"  - Deprecate command ``ip fixed add/remove``."},{"line_number":19,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5a9d85d2_271041a8","line":19,"in_reply_to":"5a9d85d2_483be738","updated":"2016-06-21 08:06:01.000000000","message":"Done","commit_id":"a7ed2715a41d37c89bf7afd70d17e32ae5617c69"}]}