)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"914303abca81d03ca827777c88d273936fa50123","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Transfer \"ip floating CRUD\" to \"floating ip CRUD\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch does the following things to transfer"},{"line_number":10,"context_line":"\"ip fixed add/remove\" to \"server add/remove fixed ip\":"},{"line_number":11,"context_line":"* Change position argument \"network\" of \"ip floating create\" command "},{"line_number":12,"context_line":"  to \"--source \u003cnetwork-or-pool\u003e\" option so that Neutron and Nova "},{"line_number":13,"context_line":"  networks could share the same option."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"5a9d85d2_d2600f38","line":10,"updated":"2016-06-21 12:35:54.000000000","message":"please update the line according to the patch implement.","commit_id":"dd3fd71c52b08678c5583976791993f87f0885f7"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"7e49bfb7dfebc6bd046b605587367da9529fb8b4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Transfer \"ip floating CRUD\" to \"floating ip CRUD\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch does the following things to transfer"},{"line_number":10,"context_line":"\"ip fixed add/remove\" to \"server add/remove fixed ip\":"},{"line_number":11,"context_line":"* Change position argument \"network\" of \"ip floating create\" command "},{"line_number":12,"context_line":"  to \"--source \u003cnetwork-or-pool\u003e\" option so that Neutron and Nova "},{"line_number":13,"context_line":"  networks could share the same option."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"3aaa91ec_b96f5f91","line":10,"in_reply_to":"5a9d85d2_d2600f38","updated":"2016-06-22 06:30:05.000000000","message":"Done","commit_id":"dd3fd71c52b08678c5583976791993f87f0885f7"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"914303abca81d03ca827777c88d273936fa50123","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch does the following things to transfer"},{"line_number":10,"context_line":"\"ip fixed add/remove\" to \"server add/remove fixed ip\":"},{"line_number":11,"context_line":"* Change position argument \"network\" of \"ip floating create\" command "},{"line_number":12,"context_line":"  to \"--source \u003cnetwork-or-pool\u003e\" option so that Neutron and Nova "},{"line_number":13,"context_line":"  networks could share the same option."},{"line_number":14,"context_line":"* Add new command \"floating ip create/delete/list/show\", and doc."},{"line_number":15,"context_line":"* Deprecate \"ip floating create/delete/list/show\" command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"5a9d85d2_52553f4e","line":12,"updated":"2016-06-21 12:35:54.000000000","message":"please remove the blank at line tail","commit_id":"dd3fd71c52b08678c5583976791993f87f0885f7"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"7e49bfb7dfebc6bd046b605587367da9529fb8b4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch does the following things to transfer"},{"line_number":10,"context_line":"\"ip fixed add/remove\" to \"server add/remove fixed ip\":"},{"line_number":11,"context_line":"* Change position argument \"network\" of \"ip floating create\" command "},{"line_number":12,"context_line":"  to \"--source \u003cnetwork-or-pool\u003e\" option so that Neutron and Nova "},{"line_number":13,"context_line":"  networks could share the same option."},{"line_number":14,"context_line":"* Add new command \"floating ip create/delete/list/show\", and doc."},{"line_number":15,"context_line":"* Deprecate \"ip floating create/delete/list/show\" command."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"3aaa91ec_196dd398","line":12,"in_reply_to":"5a9d85d2_52553f4e","updated":"2016-06-22 06:30:05.000000000","message":"Done","commit_id":"dd3fd71c52b08678c5583976791993f87f0885f7"}],"doc/source/command-objects/floating-ip.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2645580fe9970c93fb45f6189f64f3e92373edc4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"ip floating"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Compute v2, Network v2"}],"source_content_type":"text/x-rst","patch_set":17,"id":"7aa08908_1c3ade98","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":11},"updated":"2016-06-15 19:52:05.000000000","message":"floating ip","commit_id":"0c8601710371721fa09a4b77631d9c8535ec91a1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0a4b59d00ddd43455b95c52dd34328fb3eecba5d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"floating ip delete"},{"line_number":49,"context_line":"------------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Delete floating IP"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. program:: floating ip delete"},{"line_number":54,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":19,"id":"5a9d85d2_08a39f50","line":51,"updated":"2016-06-21 02:32:32.000000000","message":"Multiple resources can be deleted.","commit_id":"e06196e9f28f28b4e8b451bd62b1845bd261a36b"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d18ac2955bb1fe21c644128d8b8fd151fba593cd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"floating ip delete"},{"line_number":49,"context_line":"------------------"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"Delete floating IP"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. program:: floating ip delete"},{"line_number":54,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":19,"id":"5a9d85d2_e74d999a","line":51,"in_reply_to":"5a9d85d2_08a39f50","updated":"2016-06-21 08:21:16.000000000","message":"Done","commit_id":"e06196e9f28f28b4e8b451bd62b1845bd261a36b"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f2c141158a65b8ce45d8e43ff452dacfd02679d5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"floating ip create"},{"line_number":8,"context_line":"------------------"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Create new floating IP address"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. program:: floating ip create"},{"line_number":13,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":23,"id":"dada55a8_7b611e39","line":10,"updated":"2016-07-19 19:10:07.000000000","message":"The code uses \"Create floating IP\"","commit_id":"c9a2115e53296d19ee39d9ece9ece53cea150558"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"2a2c9250e720ee32c388385f3e432244ddec1666","unresolved":false,"context_lines":[{"line_number":7,"context_line":"floating ip create"},{"line_number":8,"context_line":"------------------"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Create new floating IP address"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. program:: floating ip create"},{"line_number":13,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":23,"id":"dada55a8_9cc31989","line":10,"in_reply_to":"dada55a8_7b611e39","updated":"2016-07-20 06:31:26.000000000","message":"Done","commit_id":"c9a2115e53296d19ee39d9ece9ece53cea150558"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f2c141158a65b8ce45d8e43ff452dacfd02679d5","unresolved":false,"context_lines":[{"line_number":22,"context_line":".. option:: --subnet \u003csubnet\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Subnet on which you want to create the floating IP (name or ID)"},{"line_number":25,"context_line":"    (Network v2 only)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --port \u003cport\u003e"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"dada55a8_fb550e50","line":25,"updated":"2016-07-19 19:10:07.000000000","message":"Other documentation uses \"*Network version 2 only*\".  I think we should be consistent.","commit_id":"c9a2115e53296d19ee39d9ece9ece53cea150558"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"2a2c9250e720ee32c388385f3e432244ddec1666","unresolved":false,"context_lines":[{"line_number":22,"context_line":".. option:: --subnet \u003csubnet\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    Subnet on which you want to create the floating IP (name or ID)"},{"line_number":25,"context_line":"    (Network v2 only)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --port \u003cport\u003e"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"dada55a8_7c3f4587","line":25,"in_reply_to":"dada55a8_fb550e50","updated":"2016-07-20 06:31:26.000000000","message":"Done","commit_id":"c9a2115e53296d19ee39d9ece9ece53cea150558"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f2c141158a65b8ce45d8e43ff452dacfd02679d5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"floating ip list"},{"line_number":61,"context_line":"----------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"List floating IP addresses"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":".. program:: floating ip list"},{"line_number":66,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":23,"id":"dada55a8_1be2a29f","line":63,"updated":"2016-07-19 19:10:07.000000000","message":"Code uses \"List floating IP(s)\"","commit_id":"c9a2115e53296d19ee39d9ece9ece53cea150558"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"2a2c9250e720ee32c388385f3e432244ddec1666","unresolved":false,"context_lines":[{"line_number":60,"context_line":"floating ip list"},{"line_number":61,"context_line":"----------------"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"List floating IP addresses"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":".. program:: floating ip list"},{"line_number":66,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":23,"id":"dada55a8_fc0175b0","line":63,"in_reply_to":"dada55a8_1be2a29f","updated":"2016-07-20 06:31:26.000000000","message":"Done","commit_id":"c9a2115e53296d19ee39d9ece9ece53cea150558"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f2c141158a65b8ce45d8e43ff452dacfd02679d5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"floating ip show"},{"line_number":71,"context_line":"----------------"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Display floating IP details"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. program:: floating ip show"},{"line_number":76,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":23,"id":"dada55a8_bbe9d682","line":73,"updated":"2016-07-19 19:10:07.000000000","message":"Code uses \"Show floating IP details\"","commit_id":"c9a2115e53296d19ee39d9ece9ece53cea150558"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"2a2c9250e720ee32c388385f3e432244ddec1666","unresolved":false,"context_lines":[{"line_number":70,"context_line":"floating ip show"},{"line_number":71,"context_line":"----------------"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Display floating IP details"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. program:: floating ip show"},{"line_number":76,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":23,"id":"dada55a8_9cf839c5","line":73,"in_reply_to":"dada55a8_bbe9d682","updated":"2016-07-20 06:31:26.000000000","message":"Most other docs use Display, so I changed the code to keep the consistency.","commit_id":"c9a2115e53296d19ee39d9ece9ece53cea150558"}],"functional/tests/network/v2/test_floating_ip.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f2c141158a65b8ce45d8e43ff452dacfd02679d5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        )"},{"line_number":36,"context_line":"        opts \u003d cls.get_opts(cls.FIELDS)"},{"line_number":37,"context_line":"        raw_output \u003d cls.openstack("},{"line_number":38,"context_line":"            \u0027floating ip create \u0027 + cls.NETWORK_NAME + opts)"},{"line_number":39,"context_line":"        cls.ID \u003d raw_output.strip(\u0027\\n\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_3b4b26cb","line":38,"updated":"2016-07-19 19:10:07.000000000","message":"Please change functional/tests/compute/v2/test_server as well since ip floating is used.","commit_id":"c9a2115e53296d19ee39d9ece9ece53cea150558"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"2a2c9250e720ee32c388385f3e432244ddec1666","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        )"},{"line_number":36,"context_line":"        opts \u003d cls.get_opts(cls.FIELDS)"},{"line_number":37,"context_line":"        raw_output \u003d cls.openstack("},{"line_number":38,"context_line":"            \u0027floating ip create \u0027 + cls.NETWORK_NAME + opts)"},{"line_number":39,"context_line":"        cls.ID \u003d raw_output.strip(\u0027\\n\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_9c0b192a","line":38,"in_reply_to":"dada55a8_3b4b26cb","updated":"2016-07-20 06:31:26.000000000","message":"Done","commit_id":"c9a2115e53296d19ee39d9ece9ece53cea150558"}],"openstackclient/network/v2/floating_ip.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"914303abca81d03ca827777c88d273936fa50123","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        parser.add_argument("},{"line_number":66,"context_line":"            \u0027--source\u0027,"},{"line_number":67,"context_line":"            metavar\u003d\u0027\u003cnetwork-or-pool\u003e\u0027,"},{"line_number":68,"context_line":"            required\u003dTrue,"},{"line_number":69,"context_line":"            help\u003d_(\"Allocate new floating IP address from ``\u003cnetwork\u003e`` \""},{"line_number":70,"context_line":"                   \"(name or ID) if Network v2 API is enabled, or from \""},{"line_number":71,"context_line":"                   \"``\u003cpool\u003e`` (name or ID) if Compute v2 networking \""}],"source_content_type":"text/x-python","patch_set":22,"id":"5a9d85d2_5227ff11","line":68,"updated":"2016-06-21 12:35:54.000000000","message":"the current command \"ip floating create\" is inherited from the class, so the required position argument \"--source\" will break usage like this:\n\n    ip floating create \u003cnet-uuid\u003e\n\nI think we should give users a smooth way to transfer to new commands, the old command behavior should be keep one release version at least after the command is marked as \"deprecated\".","commit_id":"dd3fd71c52b08678c5583976791993f87f0885f7"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"7e49bfb7dfebc6bd046b605587367da9529fb8b4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        parser.add_argument("},{"line_number":66,"context_line":"            \u0027--source\u0027,"},{"line_number":67,"context_line":"            metavar\u003d\u0027\u003cnetwork-or-pool\u003e\u0027,"},{"line_number":68,"context_line":"            required\u003dTrue,"},{"line_number":69,"context_line":"            help\u003d_(\"Allocate new floating IP address from ``\u003cnetwork\u003e`` \""},{"line_number":70,"context_line":"                   \"(name or ID) if Network v2 API is enabled, or from \""},{"line_number":71,"context_line":"                   \"``\u003cpool\u003e`` (name or ID) if Compute v2 networking \""}],"source_content_type":"text/x-python","patch_set":22,"id":"3aaa91ec_d9250bc3","line":68,"in_reply_to":"5a9d85d2_5227ff11","updated":"2016-06-22 06:30:05.000000000","message":"Let me think about it. Maybe we can implement the old way in the wrapper class.","commit_id":"dd3fd71c52b08678c5583976791993f87f0885f7"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f2c141158a65b8ce45d8e43ff452dacfd02679d5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                        ignore_missing\u003dFalse)"},{"line_number":50,"context_line":"        attrs[\u0027port_id\u0027] \u003d port.id"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    if parsed_args.floating_ip_address:"},{"line_number":53,"context_line":"        attrs[\u0027floating_ip_address\u0027] \u003d parsed_args.floating_ip_address"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    if parsed_args.fixed_ip_address:"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_5b16daa7","line":52,"updated":"2016-07-19 19:10:07.000000000","message":"Is it okay to ignore an empty floating IP address?","commit_id":"c9a2115e53296d19ee39d9ece9ece53cea150558"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"2a2c9250e720ee32c388385f3e432244ddec1666","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                        ignore_missing\u003dFalse)"},{"line_number":50,"context_line":"        attrs[\u0027port_id\u0027] \u003d port.id"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    if parsed_args.floating_ip_address:"},{"line_number":53,"context_line":"        attrs[\u0027floating_ip_address\u0027] \u003d parsed_args.floating_ip_address"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    if parsed_args.fixed_ip_address:"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_7fe577da","line":52,"in_reply_to":"dada55a8_5b16daa7","updated":"2016-07-20 06:31:26.000000000","message":"_get_attrs() is only called by CreateFloatingIP. It is OK that we create a floating ip without specifying one.","commit_id":"c9a2115e53296d19ee39d9ece9ece53cea150558"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f2c141158a65b8ce45d8e43ff452dacfd02679d5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    if parsed_args.floating_ip_address:"},{"line_number":53,"context_line":"        attrs[\u0027floating_ip_address\u0027] \u003d parsed_args.floating_ip_address"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    if parsed_args.fixed_ip_address:"},{"line_number":56,"context_line":"        attrs[\u0027fixed_ip_address\u0027] \u003d parsed_args.fixed_ip_address"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    return attrs"}],"source_content_type":"text/x-python","patch_set":23,"id":"dada55a8_9b1052aa","line":55,"updated":"2016-07-19 19:10:07.000000000","message":"Same as above.","commit_id":"c9a2115e53296d19ee39d9ece9ece53cea150558"}],"releasenotes/notes/ip-command-rework-8d3fe0858f51e6b8.yaml":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0a4b59d00ddd43455b95c52dd34328fb3eecba5d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  - Add new command ``server add/remove fixed ip``. It is used to replace"},{"line_number":11,"context_line":"    the old command ``ip fixed add/remove``."},{"line_number":12,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":13,"context_line":"  - Add new command ``floating ip create/delete/list/show``. It is used to"},{"line_number":14,"context_line":"    replace the old command ``ip floating create/delete/list/show``."},{"line_number":15,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":16,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5a9d85d2_28d2dbd2","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":19},"updated":"2016-06-21 02:32:32.000000000","message":"There are multiple commands not a single command.  Similar comment applies below.","commit_id":"e06196e9f28f28b4e8b451bd62b1845bd261a36b"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d18ac2955bb1fe21c644128d8b8fd151fba593cd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  - Add new command ``server add/remove fixed ip``. It is used to replace"},{"line_number":11,"context_line":"    the old command ``ip fixed add/remove``."},{"line_number":12,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":13,"context_line":"  - Add new command ``floating ip create/delete/list/show``. It is used to"},{"line_number":14,"context_line":"    replace the old command ``ip floating create/delete/list/show``."},{"line_number":15,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":16,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5a9d85d2_82c0037e","line":13,"range":{"start_line":13,"start_character":12,"end_line":13,"end_character":19},"in_reply_to":"5a9d85d2_28d2dbd2","updated":"2016-06-21 08:21:16.000000000","message":"Done","commit_id":"e06196e9f28f28b4e8b451bd62b1845bd261a36b"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0a4b59d00ddd43455b95c52dd34328fb3eecba5d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":13,"context_line":"  - Add new command ``floating ip create/delete/list/show``. It is used to"},{"line_number":14,"context_line":"    replace the old command ``ip floating create/delete/list/show``."},{"line_number":15,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":16,"context_line":"upgrade:"},{"line_number":17,"context_line":"  - The positional argument ``network`` in command ``ip floating create`` is"},{"line_number":18,"context_line":"    ambiguous. If Network v2 API is enabled, it means allocate a floating ip"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5a9d85d2_48d767bf","line":15,"updated":"2016-06-21 02:32:32.000000000","message":"Please include blueprint name in the link.  Similar comment applies below.","commit_id":"e06196e9f28f28b4e8b451bd62b1845bd261a36b"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d18ac2955bb1fe21c644128d8b8fd151fba593cd","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":13,"context_line":"  - Add new command ``floating ip create/delete/list/show``. It is used to"},{"line_number":14,"context_line":"    replace the old command ``ip floating create/delete/list/show``."},{"line_number":15,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":16,"context_line":"upgrade:"},{"line_number":17,"context_line":"  - The positional argument ``network`` in command ``ip floating create`` is"},{"line_number":18,"context_line":"    ambiguous. If Network v2 API is enabled, it means allocate a floating ip"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5a9d85d2_077a65f1","line":15,"in_reply_to":"5a9d85d2_48d767bf","updated":"2016-06-21 08:21:16.000000000","message":"Done","commit_id":"e06196e9f28f28b4e8b451bd62b1845bd261a36b"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0a4b59d00ddd43455b95c52dd34328fb3eecba5d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    replace the old command ``ip floating create/delete/list/show``."},{"line_number":15,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":16,"context_line":"upgrade:"},{"line_number":17,"context_line":"  - The positional argument ``network`` in command ``ip floating create`` is"},{"line_number":18,"context_line":"    ambiguous. If Network v2 API is enabled, it means allocate a floating ip"},{"line_number":19,"context_line":"    from a network, while if Compute v2 networking is enabled, it means"},{"line_number":20,"context_line":"    allocate a floating ip from a floating ip pool. So change it to option"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5a9d85d2_28e93b81","line":17,"updated":"2016-06-21 02:32:32.000000000","message":"I thought Dean didn\u0027t want the behavior of the old command to change?","commit_id":"e06196e9f28f28b4e8b451bd62b1845bd261a36b"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d18ac2955bb1fe21c644128d8b8fd151fba593cd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    replace the old command ``ip floating create/delete/list/show``."},{"line_number":15,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":16,"context_line":"upgrade:"},{"line_number":17,"context_line":"  - The positional argument ``network`` in command ``ip floating create`` is"},{"line_number":18,"context_line":"    ambiguous. If Network v2 API is enabled, it means allocate a floating ip"},{"line_number":19,"context_line":"    from a network, while if Compute v2 networking is enabled, it means"},{"line_number":20,"context_line":"    allocate a floating ip from a floating ip pool. So change it to option"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5a9d85d2_42861b14","line":17,"in_reply_to":"5a9d85d2_28e93b81","updated":"2016-06-21 08:21:16.000000000","message":"Well, I thought he wanted me to change it in this patch. \u0027pool\u0027 in Nova and \u0027network\u0027 in Neutron mean the same thing from which to allocate the floating IPs. So I would suggest to change it.","commit_id":"e06196e9f28f28b4e8b451bd62b1845bd261a36b"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"8fa2bcff061f84a698342761b6f6ced852d74536","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    replace the old command ``ip floating create/delete/list/show``."},{"line_number":15,"context_line":"    [BP `\u003chttps://blueprints.launchpad.net/python-openstackclient/+spec/rework-ip-commands\u003e`_]"},{"line_number":16,"context_line":"upgrade:"},{"line_number":17,"context_line":"  - The positional argument ``network`` in command ``ip floating create`` is"},{"line_number":18,"context_line":"    ambiguous. If Network v2 API is enabled, it means allocate a floating ip"},{"line_number":19,"context_line":"    from a network, while if Compute v2 networking is enabled, it means"},{"line_number":20,"context_line":"    allocate a floating ip from a floating ip pool. So change it to option"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5a9d85d2_48c0f12a","line":17,"in_reply_to":"5a9d85d2_42861b14","updated":"2016-06-21 11:43:45.000000000","message":"Okay, I\u0027ll hold my approval pending review from Dean.","commit_id":"e06196e9f28f28b4e8b451bd62b1845bd261a36b"}]}