)]}'
{"doc/source/command-objects/network.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"aa900a56f3a57d26b06001cd692733c03db52b1e","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    Set this network as an external network."},{"line_number":184,"context_line":"    Requires the \"external-net\" extension to be enabled."},{"line_number":185,"context_line":"    (Network v2 only)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":".. option:: --internal"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5a18252c_4dfacf43","line":185,"range":{"start_line":185,"start_character":4,"end_line":185,"end_character":21},"updated":"2016-04-12 18:17:16.000000000","message":"Please change this and the others below to \"*Network version 2 only*\" and add a newline before it.  This matches the network create documentation.","commit_id":"f85bf335d6d517e02b87018e38f85fe053f7c691"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e43eb7fe397a9a7abe192b591e71cdb791d2e80a","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    Set this network as an external network."},{"line_number":200,"context_line":"    Requires the \"external-net\" extension to be enabled."},{"line_number":201,"context_line":"    (Network v2 only)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":".. option:: --internal"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a18252c_1881c5c3","line":201,"range":{"start_line":201,"start_character":4,"end_line":201,"end_character":21},"updated":"2016-04-14 14:15:46.000000000","message":"This can be removed since the entire command is labeled above as Network version 2 only.","commit_id":"156f8224fe9a95086a6860ea9e92f645cfc8081c"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e43eb7fe397a9a7abe192b591e71cdb791d2e80a","unresolved":false,"context_lines":[{"line_number":203,"context_line":".. option:: --internal"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    Set this network as an internal network"},{"line_number":206,"context_line":"    (Network v2 only)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":".. option:: --default"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a18252c_d8610d3b","line":206,"range":{"start_line":206,"start_character":4,"end_line":206,"end_character":21},"updated":"2016-04-14 14:15:46.000000000","message":"same as above...","commit_id":"156f8224fe9a95086a6860ea9e92f645cfc8081c"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e43eb7fe397a9a7abe192b591e71cdb791d2e80a","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    Specify if this network should be used as"},{"line_number":211,"context_line":"    the default external network"},{"line_number":212,"context_line":"    (Network v2 only)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":".. option:: --no-default"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a18252c_b866d14e","line":212,"range":{"start_line":212,"start_character":3,"end_line":212,"end_character":21},"updated":"2016-04-14 14:15:46.000000000","message":"same as above...","commit_id":"156f8224fe9a95086a6860ea9e92f645cfc8081c"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e43eb7fe397a9a7abe192b591e71cdb791d2e80a","unresolved":false,"context_lines":[{"line_number":214,"context_line":".. option:: --no-default"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    Do not use the network as the default external network."},{"line_number":217,"context_line":"    (Network v2 only)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":".. _network_set-network:"},{"line_number":220,"context_line":".. describe:: \u003cnetwork\u003e"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5a18252c_58569d5c","line":217,"range":{"start_line":217,"start_character":3,"end_line":217,"end_character":21},"updated":"2016-04-14 14:15:46.000000000","message":"same as above...","commit_id":"156f8224fe9a95086a6860ea9e92f645cfc8081c"}],"openstackclient/network/v2/network.py":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"fecc7831a4613207dcddb1b423172caf2e201003","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    return attrs"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def _update_external_network_options(attrs, parsed_args):"},{"line_number":97,"context_line":"    if parsed_args.internal:"},{"line_number":98,"context_line":"        attrs[\u0027router:external\u0027] \u003d False"},{"line_number":99,"context_line":"    if parsed_args.external:"},{"line_number":100,"context_line":"        attrs[\u0027router:external\u0027] \u003d True"},{"line_number":101,"context_line":"        if parsed_args.no_default:"},{"line_number":102,"context_line":"            attrs[\u0027is_default\u0027] \u003d False"},{"line_number":103,"context_line":"        if parsed_args.default:"},{"line_number":104,"context_line":"            attrs[\u0027is_default\u0027] \u003d True"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class CreateNetwork(common.NetworkAndComputeShowOne):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a1b2928_d3786bfb","line":104,"range":{"start_line":96,"start_character":0,"end_line":104,"end_character":38},"updated":"2016-04-11 07:22:12.000000000","message":"Can we merge these into _get_attrs() ?","commit_id":"31a1dddd6601ddcbae90230e10ef182361d986fe"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"72c5d708c9834ae52a15cb7a2129647e313b4f48","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    return attrs"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def _update_external_network_options(attrs, parsed_args):"},{"line_number":97,"context_line":"    if parsed_args.internal:"},{"line_number":98,"context_line":"        attrs[\u0027router:external\u0027] \u003d False"},{"line_number":99,"context_line":"    if parsed_args.external:"},{"line_number":100,"context_line":"        attrs[\u0027router:external\u0027] \u003d True"},{"line_number":101,"context_line":"        if parsed_args.no_default:"},{"line_number":102,"context_line":"            attrs[\u0027is_default\u0027] \u003d False"},{"line_number":103,"context_line":"        if parsed_args.default:"},{"line_number":104,"context_line":"            attrs[\u0027is_default\u0027] \u003d True"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class CreateNetwork(common.NetworkAndComputeShowOne):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a1b2928_9190abee","line":104,"range":{"start_line":96,"start_character":0,"end_line":104,"end_character":38},"in_reply_to":"7a1b2928_d3786bfb","updated":"2016-04-11 08:11:22.000000000","message":"Yes we can, but it looked good , handling the external network options separately :)","commit_id":"31a1dddd6601ddcbae90230e10ef182361d986fe"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"fecc7831a4613207dcddb1b423172caf2e201003","unresolved":false,"context_lines":[{"line_number":388,"context_line":"            \u0027--external\u0027,"},{"line_number":389,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":390,"context_line":"            help\u003d\u0027Set this network as an external network. \u0027"},{"line_number":391,"context_line":"                 \u0027Requires the \"external-net\" extension to be enabled.\u0027)"},{"line_number":392,"context_line":"        external_router_grp.add_argument("},{"line_number":393,"context_line":"            \u0027--internal\u0027,"},{"line_number":394,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a1b2928_f35e4775","line":391,"range":{"start_line":391,"start_character":56,"end_line":391,"end_character":61},"updated":"2016-04-11 07:22:12.000000000","message":"nit: Remove \"to be\".","commit_id":"31a1dddd6601ddcbae90230e10ef182361d986fe"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9befd203bc6a86f6dc9c13df867fa25fb32d6270","unresolved":false,"context_lines":[{"line_number":388,"context_line":"            \u0027--external\u0027,"},{"line_number":389,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":390,"context_line":"            help\u003d\u0027Set this network as an external network. \u0027"},{"line_number":391,"context_line":"                 \u0027Requires the \"external-net\" extension to be enabled.\u0027)"},{"line_number":392,"context_line":"        external_router_grp.add_argument("},{"line_number":393,"context_line":"            \u0027--internal\u0027,"},{"line_number":394,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_853912da","line":391,"range":{"start_line":391,"start_character":56,"end_line":391,"end_character":61},"in_reply_to":"5a18252c_fe2450b0","updated":"2016-04-14 00:41:02.000000000","message":"\"To be\" is not exactly future tense,  nor is it syntactically mentioning it.\nWhat the above lines means that before you run this command, the requirement of  external-net extension  enabled should be complete.","commit_id":"31a1dddd6601ddcbae90230e10ef182361d986fe"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"77f4d132261e1f76b1f377da14199decf0545ced","unresolved":false,"context_lines":[{"line_number":388,"context_line":"            \u0027--external\u0027,"},{"line_number":389,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":390,"context_line":"            help\u003d\u0027Set this network as an external network. \u0027"},{"line_number":391,"context_line":"                 \u0027Requires the \"external-net\" extension to be enabled.\u0027)"},{"line_number":392,"context_line":"        external_router_grp.add_argument("},{"line_number":393,"context_line":"            \u0027--internal\u0027,"},{"line_number":394,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_fe2450b0","line":391,"range":{"start_line":391,"start_character":56,"end_line":391,"end_character":61},"in_reply_to":"7a1b2928_11bbfb73","updated":"2016-04-12 02:56:42.000000000","message":"Ur...we should enable \"external-net\" first, and then use this option. So syntactically speaking, \"to be\" is future tense, which is not suitable for the previously required option. Just my opinion. :)","commit_id":"31a1dddd6601ddcbae90230e10ef182361d986fe"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"72c5d708c9834ae52a15cb7a2129647e313b4f48","unresolved":false,"context_lines":[{"line_number":388,"context_line":"            \u0027--external\u0027,"},{"line_number":389,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":390,"context_line":"            help\u003d\u0027Set this network as an external network. \u0027"},{"line_number":391,"context_line":"                 \u0027Requires the \"external-net\" extension to be enabled.\u0027)"},{"line_number":392,"context_line":"        external_router_grp.add_argument("},{"line_number":393,"context_line":"            \u0027--internal\u0027,"},{"line_number":394,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a1b2928_11bbfb73","line":391,"range":{"start_line":391,"start_character":56,"end_line":391,"end_character":61},"in_reply_to":"7a1b2928_f35e4775","updated":"2016-04-11 08:11:22.000000000","message":"I actually find it correct.\nAny reason why I should remove it?","commit_id":"31a1dddd6601ddcbae90230e10ef182361d986fe"}],"releasenotes/notes/bug-1545537-7a66219d263bb1e5.yaml":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"aa900a56f3a57d26b06001cd692733c03db52b1e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    These options are available for NetworkV2 only."},{"line_number":7,"context_line":"    [Bug `1545537 \u003chttps://bugs.launchpad.net/bugs/1545537\u003e`_]"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Add the external options mentioned above to the ``network set`` command."},{"line_number":10,"context_line":"    Again, these options are available in NetworkV2 only."},{"line_number":11,"context_line":"    [Bug `1545537 \u003chttps://bugs.launchpad.net/bugs/1545537\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5a18252c_6d598b5a","line":9,"updated":"2016-04-12 18:17:16.000000000","message":"You should combine this with the note above.","commit_id":"f85bf335d6d517e02b87018e38f85fe053f7c691"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e43eb7fe397a9a7abe192b591e71cdb791d2e80a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add external network options ``--external|--internal`` and ``--external``"},{"line_number":5,"context_line":"    suboptions ``--default|--no-default`` to the ``network create`` \u0026"},{"line_number":6,"context_line":"    ``network set`` commands."},{"line_number":7,"context_line":"    These options are available for Network version 2 only."},{"line_number":8,"context_line":"    [Bug `1545537 \u003chttps://bugs.launchpad.net/bugs/1545537\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5a18252c_d8646d23","line":5,"updated":"2016-04-14 14:15:46.000000000","message":"please change \"\u0026\" to \"and\"","commit_id":"156f8224fe9a95086a6860ea9e92f645cfc8081c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"68e6d29887e78a093385b994fabb7c3f37dfde19","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add external network options ``--external|--internal`` and ``--external``"},{"line_number":5,"context_line":"    suboptions ``--default|--no-default`` to the ``network create`` \u0026"},{"line_number":6,"context_line":"    ``network set`` commands."},{"line_number":7,"context_line":"    These options are available for Network version 2 only."},{"line_number":8,"context_line":"    [Bug `1545537 \u003chttps://bugs.launchpad.net/bugs/1545537\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5a18252c_01fdb2b3","line":5,"in_reply_to":"5a18252c_d8646d23","updated":"2016-04-15 00:29:36.000000000","message":"Just want to know if there is any specific reason for the same?\n\nThe creator of email used @ because it was the most rarely used symbol ( except now email and twitter make it the second key to be destroyed on the keyboard after Enter)\nJust wanted the \u0026 to be used a bit more often :)","commit_id":"156f8224fe9a95086a6860ea9e92f645cfc8081c"}]}