)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"d6adfad387544dad4a510b5ada1bc749901aa04b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tang Chen \u003cchen.tang@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-12 10:24:26 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make \"--subnet\" option of \"network create\" required"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\"--subnet\" option \"network create\" of Compute network"},{"line_number":10,"context_line":"is required."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a18252c_19e66fb4","line":7,"updated":"2016-04-12 13:23:24.000000000","message":"I suggest opening a bug report and adding a release note for this fix.","commit_id":"82f3f7eced7681bac7ceec029b42d266a135895a"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"6985f681295159ac5f5aa691802c05cce5eaa34e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tang Chen \u003cchen.tang@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-12 10:24:26 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make \"--subnet\" option of \"network create\" required"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\"--subnet\" option \"network create\" of Compute network"},{"line_number":10,"context_line":"is required."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a18252c_b78f60cb","line":7,"in_reply_to":"5a18252c_19e66fb4","updated":"2016-04-13 06:26:12.000000000","message":"Done","commit_id":"82f3f7eced7681bac7ceec029b42d266a135895a"}],"doc/source/command-objects/network.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"503a7425c61d36a1e8a0af8b79cfe64af3aae81e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        --subnet \u003csubnet\u003e"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a1b2928_9a0c3196","line":24,"updated":"2016-04-11 13:48:32.000000000","message":"I find this a little confusing since this is only for Compute v2.  Maybe keep the brackets around it since it isn\u0027t required nor is it an option for Network v2.","commit_id":"ac27914625cbfa80f916725cb72f2fd2c5e6101c"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"d0bb7578c7990c1de79cf847b2a878af8ae73bdf","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        --subnet \u003csubnet\u003e"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a18252c_6a17dbed","line":24,"in_reply_to":"7a1b2928_9a0c3196","updated":"2016-04-12 02:23:32.000000000","message":"Done","commit_id":"ac27914625cbfa80f916725cb72f2fd2c5e6101c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"daf9fc981a02c82e38d8766f1790d3fb251dbe5a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        [--subnet \u003csubnet\u003e]"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_a1811992","line":24,"updated":"2016-04-12 04:50:26.000000000","message":"This should not be here... It is very confusing for users who are already using neutronclient.\nThese users would believe that --subnet option is now available for Networkv2 during the creation of network.\n\nBesides, here --subnet seems optional Even though you have put required\u003dTrue.\nThis ideally should be a positional argument","commit_id":"08d44faaa901c06cacfb88b8d1705376f45ae9e8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a1bc98eeacbb303ef0c7d2d5fe43867967f56c0e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        [--subnet \u003csubnet\u003e]"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_0d5d9ce9","line":24,"in_reply_to":"5a18252c_12b93dea","updated":"2016-04-12 07:33:27.000000000","message":"Hi Tang, \nOkay, got it .. yes, then I think separation may clear some doubts","commit_id":"08d44faaa901c06cacfb88b8d1705376f45ae9e8"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"28b5dfd5fd76690789ab3734bcadf97e0eca0139","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        [--subnet \u003csubnet\u003e]"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_12b93dea","line":24,"in_reply_to":"5a18252c_32ca79a2","updated":"2016-04-12 07:04:33.000000000","message":"No, Reedip. \"openstack network create -h\" won\u0027t list neutron options if nova network is being used, vice versa. The help message is from source code, not from this doc.\n\nI was suggesting split this doc.","commit_id":"08d44faaa901c06cacfb88b8d1705376f45ae9e8"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"7f3db37c5d8db5458e5671305fccee5074f756a4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        [--subnet \u003csubnet\u003e]"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_f75e3375","line":24,"in_reply_to":"5a18252c_a1811992","updated":"2016-04-12 06:33:26.000000000","message":"No matter it is a positional argument or an option, we will face the same problem: it is for compute network only. It may confuse users in this doc. \n\nI tried to find a similar option for neutron network, but they are really different. In neutron, a subnet belongs to a network. And the network is specified when a subnet is created. \n\nI think, we\u0027d better split nova and neutron network doc. How do you think ?","commit_id":"08d44faaa901c06cacfb88b8d1705376f45ae9e8"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"79d23e01ff9d11e3946a76dbc86f95a5e43ce10c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        [--subnet \u003csubnet\u003e]"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_19ae6f85","line":24,"in_reply_to":"5a18252c_f75e3375","updated":"2016-04-12 13:23:04.000000000","message":"Since nova and neutron network are significantly different, I think it makes sense to split the documentation.","commit_id":"08d44faaa901c06cacfb88b8d1705376f45ae9e8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1e7f6f0afb658729131a1cff39f954ee58927cc8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        [--subnet \u003csubnet\u003e]"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a18252c_32ca79a2","line":24,"in_reply_to":"5a18252c_f75e3375","updated":"2016-04-12 06:54:35.000000000","message":"Splitting Nova and Neutron Doc would not help much, would it?\nIf a user is using Network V2, still \"openstack network create\" would list --subnet parameter, which would not be useful.\n\nI am just thinking if it is possible to show --subnet IF the calling object is Compute V2 and not Network V2","commit_id":"08d44faaa901c06cacfb88b8d1705376f45ae9e8"}],"openstackclient/network/v2/network.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"18221ba5471797cae520c05dcc3eb1f194113671","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        attrs[\u0027share_address\u0027] \u003d True"},{"line_number":88,"context_line":"    if parsed_args.no_share:"},{"line_number":89,"context_line":"        attrs[\u0027share_address\u0027] \u003d False"},{"line_number":90,"context_line":"    if parsed_args.subnet is not None:"},{"line_number":91,"context_line":"        attrs[\u0027cidr\u0027] \u003d parsed_args.subnet"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    return attrs"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_43512562","line":90,"range":{"start_line":90,"start_character":4,"end_line":90,"end_character":37},"updated":"2016-04-12 08:30:47.000000000","message":"if \"subnet\" option is required, the \"if\" isn\u0027t necessary.","commit_id":"08d44faaa901c06cacfb88b8d1705376f45ae9e8"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"ec0e0af42c47c2281bc23fcb337dfd3dcf40b545","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        attrs[\u0027share_address\u0027] \u003d True"},{"line_number":88,"context_line":"    if parsed_args.no_share:"},{"line_number":89,"context_line":"        attrs[\u0027share_address\u0027] \u003d False"},{"line_number":90,"context_line":"    if parsed_args.subnet is not None:"},{"line_number":91,"context_line":"        attrs[\u0027cidr\u0027] \u003d parsed_args.subnet"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    return attrs"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_a355981e","line":90,"range":{"start_line":90,"start_character":4,"end_line":90,"end_character":37},"in_reply_to":"5a18252c_43512562","updated":"2016-04-12 08:52:11.000000000","message":"Done","commit_id":"08d44faaa901c06cacfb88b8d1705376f45ae9e8"}]}