)]}'
{"id":"openstack%2Fpython-openstackclient~304006","triplet_id":"openstack%2Fpython-openstackclient~master~I799822c8715b9ac4f95b98f8350f196757d79d3e","project":"openstack/python-openstackclient","branch":"master","topic":"move-keys-20160411","hashtags":[],"change_id":"I799822c8715b9ac4f95b98f8350f196757d79d3e","subject":"Move keys() methods in each resource class to FakeResource","status":"MERGED","created":"2016-04-11 10:08:35.000000000","updated":"2016-04-11 15:07:34.000000000","submitted":"2016-04-11 15:07:33.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ee98a852d8c34eaa7874be01632c7895b88091dc","_number":304006,"virtual_id_number":304006,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-04-11 15:07:33.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-04-11 14:06:35.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-04-11 12:35:21.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":1,"date":"2016-04-11 13:19:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2016-04-11 14:06:35.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-11 12:35:21.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-04-11 13:19:36.000000000","updated_by":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"reviewer":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"state":"REVIEWER"},{"updated":"2016-04-11 14:06:35.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-04-11 15:07:33.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"51e47beb048df725c3e29edca4277d9ba51b0b42","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-04-11 10:08:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"340b8a114a86657bbad842ba97a0ccef96a7b90f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-11 11:17:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/06/304006/1/check/gate-python-openstackclient-docs/3df3138//doc/build/html/ : SUCCESS in 1m 53s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/06/304006/1/check/gate-python-openstackclient-pep8/6a10a2c/ : SUCCESS in 2m 49s\n- gate-python-openstackclient-python27 http://logs.openstack.org/06/304006/1/check/gate-python-openstackclient-python27/300f508/ : SUCCESS in 3m 25s\n- gate-python-openstackclient-python34 http://logs.openstack.org/06/304006/1/check/gate-python-openstackclient-python34/3ce35a2/ : SUCCESS in 4m 38s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/06/304006/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/62d2b42/ : SUCCESS in 1h 05m 40s\n- check-osc-plugins http://logs.openstack.org/06/304006/1/check/check-osc-plugins/b6e40f4/ : SUCCESS in 2m 10s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/06/304006/1/check/gate-osc-dsvm-functional/85a104f/ : SUCCESS in 24m 02s","accounts_in_message":[],"_revision_number":1},{"id":"298d509027ffccf09c48898857fffcf28af933ee","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-04-11 12:35:21.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d2e93bee110f04910889929c25c010f7634bd823","author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"date":"2016-04-11 13:19:36.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"cec8d7e69d5c70550569abf77356419b75d824e4","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-04-11 14:06:35.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"6a79c74f07c05ed6d61747beb31dbfb7ca4bde5c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-11 14:07:56.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"c6c308c347e0a7ef9bca181a0d912ea67b97addb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-11 15:07:33.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/06/304006/1/gate/gate-python-openstackclient-docs/e1d2c9c//doc/build/html/ : SUCCESS in 4m 02s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/06/304006/1/gate/gate-python-openstackclient-pep8/ef86642/ : SUCCESS in 3m 18s\n- gate-python-openstackclient-python27 http://logs.openstack.org/06/304006/1/gate/gate-python-openstackclient-python27/7dd0e4c/ : SUCCESS in 2m 08s\n- gate-python-openstackclient-python34 http://logs.openstack.org/06/304006/1/gate/gate-python-openstackclient-python34/7e954ff/ : SUCCESS in 3m 00s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/06/304006/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/376feac/ : SUCCESS in 51m 51s\n- gate-osc-dsvm-functional http://logs.openstack.org/06/304006/1/gate/gate-osc-dsvm-functional/09b61b9/ : SUCCESS in 15m 37s","accounts_in_message":[],"_revision_number":1},{"id":"1b0e6d5bcfb4d0c83848ca1430462d8c95dc3e50","date":"2016-04-11 15:07:34.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"827be8fb8cf4508c7ac0488652c4e0e93ec443f5","revisions":{"827be8fb8cf4508c7ac0488652c4e0e93ec443f5":{"kind":"REWORK","_number":1,"created":"2016-04-11 10:08:35.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/06/304006/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/06/304006/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/06/304006/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/06/304006/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/06/304006/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/06/304006/1"}}},"commit":{"parents":[{"commit":"cb8f757779ded16b769bce2c990650662dfa5223","subject":"Merge \"Refactor security group rule list to use SDK\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cb8f757779ded16b769bce2c990650662dfa5223"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-04-11 08:32:58.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-04-11 10:07:50.000000000","tz":480},"subject":"Move keys() methods in each resource class to FakeResource","message":"Move keys() methods in each resource class to FakeResource\n\nFakeXXX classes in network don\u0027t need to fake any method,\nexcept keys(). But keys() can be put in FakeResource since\nit just returns all attributes in _info.\n\nThis patch moves removes all unnecessary fake methods code,\nmoves keys() method to FakeResource.\n\nThis patch also finds out some missing attributes in\nnetwork and router tests.\n\nChange-Id: I799822c8715b9ac4f95b98f8350f196757d79d3e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/827be8fb8cf4508c7ac0488652c4e0e93ec443f5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/827be8fb8cf4508c7ac0488652c4e0e93ec443f5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}