)]}'
{"id":"openstack%2Fpython-openstackclient~304402","triplet_id":"openstack%2Fpython-openstackclient~master~Ie6a46ef6a3042641e55a7002573ef501db7b60e1","project":"openstack/python-openstackclient","branch":"master","topic":"move-keys-20160411","hashtags":[],"change_id":"Ie6a46ef6a3042641e55a7002573ef501db7b60e1","subject":"Remove fake methods code from compute network","status":"MERGED","created":"2016-04-12 05:53:46.000000000","updated":"2016-04-14 16:47:00.000000000","submitted":"2016-04-14 16:47:00.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"19e9b293fe869ee33dadfcdb7c9176a4c02d7f92","_number":304402,"virtual_id_number":304402,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-04-14 16:47:00.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"recommended":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-04-13 03:31:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":2,"date":"2016-04-14 13:22:50.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":2,"date":"2016-04-14 15:33:03.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":1,"date":"2016-04-14 15:33:03.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-13 03:31:26.000000000","updated_by":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"reviewer":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"state":"REVIEWER"},{"updated":"2016-04-14 13:22:50.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-04-14 15:33:03.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-04-14 16:47:00.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4e36b2337029015e490e3397ad96bc9dca3ca4d1","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-04-12 05:53:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e179cf77ed30c326f61a3d900a394f7d4c71976a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-12 06:46:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/02/304402/1/check/gate-python-openstackclient-docs/98a4927//doc/build/html/ : SUCCESS in 2m 03s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/02/304402/1/check/gate-python-openstackclient-pep8/88b6da3/ : SUCCESS in 1m 41s\n- gate-python-openstackclient-python27 http://logs.openstack.org/02/304402/1/check/gate-python-openstackclient-python27/ada36c8/ : SUCCESS in 3m 26s\n- gate-python-openstackclient-python34 http://logs.openstack.org/02/304402/1/check/gate-python-openstackclient-python34/a4b903b/ : SUCCESS in 4m 33s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/02/304402/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/02469af/ : SUCCESS in 52m 12s\n- check-osc-plugins http://logs.openstack.org/02/304402/1/check/check-osc-plugins/961f18c/ : SUCCESS in 4m 03s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/02/304402/1/check/gate-osc-dsvm-functional/9bfca8d/ : SUCCESS in 24m 29s","accounts_in_message":[],"_revision_number":1},{"id":"b68f713a320f84d3ed111fc50897c98b27c75f13","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2016-04-12 08:08:29.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nlooks like some fake object is omitted.","accounts_in_message":[],"_revision_number":1},{"id":"b0dc25cfceb600322e04f8553ddd24f1c36a3686","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-04-12 10:53:25.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"41cb82d56ab2d2369bdea93aa00b28482bb8bea7","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-04-12 10:57:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2c3e6417e95c1e42bfb81835aa86ed81c5f6482d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-12 11:56:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/02/304402/2/check/gate-python-openstackclient-docs/548b1de//doc/build/html/ : SUCCESS in 1m 58s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/02/304402/2/check/gate-python-openstackclient-pep8/944d995/ : SUCCESS in 1m 37s\n- gate-python-openstackclient-python27 http://logs.openstack.org/02/304402/2/check/gate-python-openstackclient-python27/6aed985/ : SUCCESS in 3m 31s\n- gate-python-openstackclient-python34 http://logs.openstack.org/02/304402/2/check/gate-python-openstackclient-python34/c58ca27/ : SUCCESS in 3m 06s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/02/304402/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/fd4634c/ : SUCCESS in 56m 18s\n- check-osc-plugins http://logs.openstack.org/02/304402/2/check/check-osc-plugins/e2841db/ : SUCCESS in 2m 13s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/02/304402/2/check/gate-osc-dsvm-functional/1317155/ : SUCCESS in 16m 05s","accounts_in_message":[],"_revision_number":2},{"id":"bf39b55ed43223061e82c55bb7318606d2685956","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2016-04-13 03:31:26.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"e757db1c2f0b2b65bd9e963e1751c4902c83e80d","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-04-13 13:45:19.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8068bc5b37b174f48841cd7b44249d07126fafe9","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-04-14 03:51:25.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9e68f7285d33e87c785f8cfd43fd868c83620eb3","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-04-14 13:22:50.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c2f1a5bdfac984beebb06fd6a4815045e6a445d2","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-04-14 15:33:03.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"8e1b5b8fa98b207620468b96259ebb460f63caa9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-14 15:33:08.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"072f73812693067d23c962098e546999fb724340","date":"2016-04-14 16:47:00.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"92e52338b89d4ed8928b2c0ead53689bd73aab58","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-14 16:47:00.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/02/304402/2/gate/gate-python-openstackclient-docs/c855ef8//doc/build/html/ : SUCCESS in 3m 05s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/02/304402/2/gate/gate-python-openstackclient-pep8/bf4c7da/ : SUCCESS in 3m 32s\n- gate-python-openstackclient-python27 http://logs.openstack.org/02/304402/2/gate/gate-python-openstackclient-python27/734efe4/ : SUCCESS in 2m 39s\n- gate-python-openstackclient-python34 http://logs.openstack.org/02/304402/2/gate/gate-python-openstackclient-python34/1653ca8/ : SUCCESS in 5m 48s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/02/304402/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/95f20c4/ : SUCCESS in 1h 13m 14s\n- gate-osc-dsvm-functional http://logs.openstack.org/02/304402/2/gate/gate-osc-dsvm-functional/beb703b/ : SUCCESS in 20m 05s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a281ef89a502a9e1a1def22fcba77cc666e6c610","revisions":{"a9148cf1d01967568e6edf2d7a0d17c63618f7b0":{"kind":"REWORK","_number":1,"created":"2016-04-12 05:53:46.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/02/304402/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/02/304402/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/02/304402/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/02/304402/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/02/304402/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/02/304402/1"}}},"commit":{"parents":[{"commit":"3be49a8abe9fc77cd2ab257ecf180d527c06cbce","subject":"Merge \"Move keys() methods in each resource class to FakeResource\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3be49a8abe9fc77cd2ab257ecf180d527c06cbce"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-04-12 05:41:52.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-04-12 05:41:52.000000000","tz":480},"subject":"Remove fake methods code from compute network","message":"Remove fake methods code from compute network\n\nNetwork objects don\u0027t have any method needs to fake.\n\nkeys() method is only used by _get_columns() helper\nto obtain all attributes of an object. But in compute\nnetwork implementation, attributes are obtained from\nobj._info directly, which is a dictionary itself. So\nthere is no need to fake this method.\n\nChange-Id: Ie6a46ef6a3042641e55a7002573ef501db7b60e1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a9148cf1d01967568e6edf2d7a0d17c63618f7b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a9148cf1d01967568e6edf2d7a0d17c63618f7b0"}]},"branch":"refs/heads/master"},"a281ef89a502a9e1a1def22fcba77cc666e6c610":{"kind":"REWORK","_number":2,"created":"2016-04-12 10:57:12.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/02/304402/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/02/304402/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/02/304402/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/02/304402/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/02/304402/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/02/304402/2"}}},"commit":{"parents":[{"commit":"3be49a8abe9fc77cd2ab257ecf180d527c06cbce","subject":"Merge \"Move keys() methods in each resource class to FakeResource\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/3be49a8abe9fc77cd2ab257ecf180d527c06cbce"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-04-12 05:41:52.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-04-12 05:41:52.000000000","tz":480},"subject":"Remove fake methods code from compute network","message":"Remove fake methods code from compute network\n\nNetwork objects don\u0027t have any method needs to fake.\n\nkeys() method is only used by _get_columns() helper\nto obtain all attributes of an object. But in compute\nnetwork implementation, attributes are obtained from\nobj._info directly, which is a dictionary itself. So\nthere is no need to fake this method.\n\nChange-Id: Ie6a46ef6a3042641e55a7002573ef501db7b60e1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a281ef89a502a9e1a1def22fcba77cc666e6c610"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a281ef89a502a9e1a1def22fcba77cc666e6c610"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}