)]}'
{"doc/source/command-objects/subnet.rst":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"66cff063f2d54f553ce8cb18204248a574550d91","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":".. option:: --dns-nameserver \u003cdns-nameserver\u003e"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"     DNS server to be removed this subnet"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":".. option:: --allocation-pool start\u003d\u003cip-address\u003e,end\u003d\u003cip-address\u003e"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"bab6814e_5a6da231","line":246,"range":{"start_line":246,"start_character":22,"end_line":246,"end_character":29},"updated":"2016-05-18 08:15:01.000000000","message":"nits: s/removed/removed from/","commit_id":"844bea3274f8e147feddbf8b23d855e4456cd777"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9a0ba7d00dea731f948a978c2e8534a58729e471","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":".. option:: --dns-nameserver \u003cdns-nameserver\u003e"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"     DNS server to be removed from this subnet"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":".. option:: --allocation-pool start\u003d\u003cip-address\u003e,end\u003d\u003cip-address\u003e"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab6814e_44085cda","line":246,"range":{"start_line":246,"start_character":5,"end_line":246,"end_character":46},"updated":"2016-05-23 08:00:27.000000000","message":"How to specify the DNS server? By name, IP, or ID ? I suggest to write this info in doc.","commit_id":"43540e056f590a5d0af49a790487ad5f3c651a9f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fe10a310a7611ea62a0991bce55658b95ced034e","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":".. option:: --dns-nameserver \u003cdns-nameserver\u003e"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"     DNS server to be removed from this subnet"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":".. option:: --allocation-pool start\u003d\u003cip-address\u003e,end\u003d\u003cip-address\u003e"},{"line_number":249,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"bab6814e_8ae9aab9","line":246,"range":{"start_line":246,"start_character":5,"end_line":246,"end_character":46},"in_reply_to":"bab6814e_44085cda","updated":"2016-05-23 09:34:25.000000000","message":"It is in the same format as specified in Create.\nDont you think we need to mention it in Create/Set CLIs as well?","commit_id":"43540e056f590a5d0af49a790487ad5f3c651a9f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9b8919391b4088490f468219b759838e33a8ca17","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":".. option:: --allocation-pool start\u003d\u003cip-address\u003e,end\u003d\u003cip-address\u003e"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    Allocation pool to be removed from this subnet e.g.:"},{"line_number":261,"context_line":"    ``start\u003d192.168.199.2,end\u003d192.168.199.254``"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":".. option:: --host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3aaa91ec_ad058f14","line":261,"range":{"start_line":260,"start_character":0,"end_line":261,"end_character":47},"updated":"2016-06-27 07:20:59.000000000","message":"Cannot be repeated ?","commit_id":"9af35b99bfe01d16dc5e24571d111d58fe442bbe"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"4541fdb565bac45c3af98933aa80994e3300e818","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":".. option:: --allocation-pool start\u003d\u003cip-address\u003e,end\u003d\u003cip-address\u003e"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    Allocation pool to be removed from this subnet e.g.:"},{"line_number":261,"context_line":"    ``start\u003d192.168.199.2,end\u003d192.168.199.254``"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":".. option:: --host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3aaa91ec_60b3a14d","line":261,"range":{"start_line":260,"start_character":0,"end_line":261,"end_character":47},"in_reply_to":"3aaa91ec_33e61ce8","updated":"2016-06-27 11:31:36.000000000","message":"I think all these 3 options can be repeated to unset multiple objects. Please refer to  _get_common_parse_arguments().","commit_id":"9af35b99bfe01d16dc5e24571d111d58fe442bbe"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"5f57c1e7c4c91005a416edfff9e87a3d79e6470b","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":".. option:: --allocation-pool start\u003d\u003cip-address\u003e,end\u003d\u003cip-address\u003e"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    Allocation pool to be removed from this subnet e.g.:"},{"line_number":261,"context_line":"    ``start\u003d192.168.199.2,end\u003d192.168.199.254``"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":".. option:: --host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e"},{"line_number":264,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"3aaa91ec_33e61ce8","line":261,"range":{"start_line":260,"start_character":0,"end_line":261,"end_character":47},"in_reply_to":"3aaa91ec_ad058f14","updated":"2016-06-27 08:05:05.000000000","message":"Not clear what you mean","commit_id":"9af35b99bfe01d16dc5e24571d111d58fe442bbe"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9b8919391b4088490f468219b759838e33a8ca17","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":".. option:: --host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"     Route to be removed from this subnet e.g.:"},{"line_number":266,"context_line":"     ``destination\u003d10.10.0.0/16,gateway\u003d192.168.71.254``"},{"line_number":267,"context_line":"     destination: destination subnet (in CIDR notation)"},{"line_number":268,"context_line":"     gateway: nexthop IP address"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":".. _subnet_unset-subnet:"},{"line_number":271,"context_line":".. describe:: \u003csubnet\u003e"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3aaa91ec_0d3dc3dc","line":268,"range":{"start_line":265,"start_character":0,"end_line":268,"end_character":32},"updated":"2016-06-27 07:20:59.000000000","message":"Cannot be repeated ？","commit_id":"9af35b99bfe01d16dc5e24571d111d58fe442bbe"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"5f57c1e7c4c91005a416edfff9e87a3d79e6470b","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":".. option:: --host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"     Route to be removed from this subnet e.g.:"},{"line_number":266,"context_line":"     ``destination\u003d10.10.0.0/16,gateway\u003d192.168.71.254``"},{"line_number":267,"context_line":"     destination: destination subnet (in CIDR notation)"},{"line_number":268,"context_line":"     gateway: nexthop IP address"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":".. _subnet_unset-subnet:"},{"line_number":271,"context_line":".. describe:: \u003csubnet\u003e"}],"source_content_type":"text/x-rst","patch_set":19,"id":"3aaa91ec_53cf6855","line":268,"range":{"start_line":265,"start_character":0,"end_line":268,"end_character":32},"in_reply_to":"3aaa91ec_0d3dc3dc","updated":"2016-06-27 08:05:05.000000000","message":"Not clear what you mean","commit_id":"9af35b99bfe01d16dc5e24571d111d58fe442bbe"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f556bb96209a2671865525e14764d4fcddfe5307","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":".. option:: --allocation-pool start\u003d\u003cip-address\u003e,end\u003d\u003cip-address\u003e"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    Allocation pool to be removed from this subnet e.g.:"},{"line_number":261,"context_line":"    ``start\u003d192.168.199.2,end\u003d192.168.199.254``"},{"line_number":262,"context_line":"    (repeat option to unset multiple Allocation pools)"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-rst","patch_set":26,"id":"3aaa91ec_06bfd560","line":260,"updated":"2016-06-29 11:59:01.000000000","message":"I think the terminology used for this option should be similar to that used on create and set or vice versa.  This is missing \"IP addresses\".","commit_id":"45b026d7c8e4675a598192bcf4c88f22005cc1d2"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f556bb96209a2671865525e14764d4fcddfe5307","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    Allocation pool to be removed from this subnet e.g.:"},{"line_number":261,"context_line":"    ``start\u003d192.168.199.2,end\u003d192.168.199.254``"},{"line_number":262,"context_line":"    (repeat option to unset multiple Allocation pools)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":".. option:: --host-route destination\u003d\u003csubnet\u003e,gateway\u003d\u003cip-address\u003e"},{"line_number":265,"context_line":""}],"source_content_type":"text/x-rst","patch_set":26,"id":"3aaa91ec_e6be09fe","line":262,"range":{"start_line":262,"start_character":37,"end_line":262,"end_character":47},"updated":"2016-06-29 11:59:01.000000000","message":"This can be lowercase.","commit_id":"45b026d7c8e4675a598192bcf4c88f22005cc1d2"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f556bb96209a2671865525e14764d4fcddfe5307","unresolved":false,"context_lines":[{"line_number":272,"context_line":".. _subnet_unset-subnet:"},{"line_number":273,"context_line":".. describe:: \u003csubnet\u003e"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    subnet to modify (name or ID)"}],"source_content_type":"text/x-rst","patch_set":26,"id":"3aaa91ec_46443d1a","line":275,"range":{"start_line":275,"start_character":4,"end_line":275,"end_character":10},"updated":"2016-06-29 11:59:01.000000000","message":"This can be uppercase","commit_id":"45b026d7c8e4675a598192bcf4c88f22005cc1d2"}],"openstackclient/network/v2/subnet.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"66cff063f2d54f553ce8cb18204248a574550d91","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            action\u003dparseractions.MultiKeyValueAction,"},{"line_number":427,"context_line":"            required_keys\u003d[\u0027start\u0027, \u0027end\u0027],"},{"line_number":428,"context_line":"            help\u003d\u0027Allocation pool to be removed from this subnet e.g.:\u0027"},{"line_number":429,"context_line":"                 \u0027e.g.: start\u003d192.168.199.2,end\u003d192.168.199.254 \u0027,"},{"line_number":430,"context_line":"        )"},{"line_number":431,"context_line":"        parser.add_argument("},{"line_number":432,"context_line":"            \u0027--dns-nameserver\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_0d20069b","line":429,"range":{"start_line":429,"start_character":18,"end_line":429,"end_character":24},"updated":"2016-05-18 08:15:01.000000000","message":"nits: duplicate \"e.g.\"","commit_id":"844bea3274f8e147feddbf8b23d855e4456cd777"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"66cff063f2d54f553ce8cb18204248a574550d91","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            metavar\u003d\u0027\u003cdns-nameserver\u003e\u0027,"},{"line_number":434,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":435,"context_line":"            dest\u003d\u0027dns_nameservers\u0027,"},{"line_number":436,"context_line":"            help\u003d\u0027DNS server to be removed this subnet\u0027,"},{"line_number":437,"context_line":"        )"},{"line_number":438,"context_line":"        parser.add_argument("},{"line_number":439,"context_line":"            \u0027--host-route\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_9a81ca92","line":436,"range":{"start_line":436,"start_character":35,"end_line":436,"end_character":42},"updated":"2016-05-18 08:15:01.000000000","message":"nits: s/removed/removed from/","commit_id":"844bea3274f8e147feddbf8b23d855e4456cd777"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"66cff063f2d54f553ce8cb18204248a574550d91","unresolved":false,"context_lines":[{"line_number":442,"context_line":"            action\u003dparseractions.MultiKeyValueAction,"},{"line_number":443,"context_line":"            required_keys\u003d[\u0027destination\u0027, \u0027gateway\u0027],"},{"line_number":444,"context_line":"            help\u003d\u0027Route to be removed from this subnet e.g.:\u0027"},{"line_number":445,"context_line":"                 \u0027e.g.: destination\u003d10.10.0.0/16,gateway\u003d192.168.71.254 \u0027"},{"line_number":446,"context_line":"                 \u0027destination: destination subnet (in CIDR notation) \u0027"},{"line_number":447,"context_line":"                 \u0027gateway: nexthop IP address \u0027,"},{"line_number":448,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_6d1a7270","line":445,"range":{"start_line":445,"start_character":18,"end_line":445,"end_character":23},"updated":"2016-05-18 08:15:01.000000000","message":"nits: duplicate \"e.g.\"","commit_id":"844bea3274f8e147feddbf8b23d855e4456cd777"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9a0ba7d00dea731f948a978c2e8534a58729e471","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        parser.add_argument("},{"line_number":432,"context_line":"            \u0027--dns-nameserver\u0027,"},{"line_number":433,"context_line":"            metavar\u003d\u0027\u003cdns-nameserver\u003e\u0027,"},{"line_number":434,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":435,"context_line":"            dest\u003d\u0027dns_nameservers\u0027,"},{"line_number":436,"context_line":"            help\u003d\u0027DNS server to be removed from this subnet\u0027,"},{"line_number":437,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_1f64ddb6","line":434,"range":{"start_line":434,"start_character":20,"end_line":434,"end_character":26},"updated":"2016-05-23 08:00:27.000000000","message":"So, we can repeat this option, right? We should add this info to the doc.\n\nAnd BTW, the help, warning and error messages should be wrap with _() from i18n.","commit_id":"43540e056f590a5d0af49a790487ad5f3c651a9f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9a0ba7d00dea731f948a978c2e8534a58729e471","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                                   parsed_args.dns_nameservers)"},{"line_number":465,"context_line":"            except exceptions.CommandError as error:"},{"line_number":466,"context_line":"                msg \u003d (_(\"%s not in dns-nameservers\") % str(error))"},{"line_number":467,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":468,"context_line":"            attrs[\u0027dns_nameservers\u0027] \u003d tmp_obj.dns_nameservers"},{"line_number":469,"context_line":"        if parsed_args.host_routes:"},{"line_number":470,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_9fe56d0a","line":467,"range":{"start_line":467,"start_character":16,"end_line":467,"end_character":50},"updated":"2016-05-23 08:00:27.000000000","message":"The same comment as those in https://review.openstack.org/#/c/302530/, raise the exception at last.","commit_id":"43540e056f590a5d0af49a790487ad5f3c651a9f"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9b8919391b4088490f468219b759838e33a8ca17","unresolved":false,"context_lines":[{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def _updated_arguments(obj_list, parsed_args_list):"},{"line_number":32,"context_line":"    for item in parsed_args_list:"},{"line_number":33,"context_line":"        if item in obj_list:"},{"line_number":34,"context_line":"            obj_list.remove(item)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_10115604","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":12},"updated":"2016-06-27 07:20:59.000000000","message":"nit: updated -\u003e update ?","commit_id":"9af35b99bfe01d16dc5e24571d111d58fe442bbe"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9b8919391b4088490f468219b759838e33a8ca17","unresolved":false,"context_lines":[{"line_number":462,"context_line":"            metavar\u003d\u0027\u003cdns-nameserver\u003e\u0027,"},{"line_number":463,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":464,"context_line":"            dest\u003d\u0027dns_nameservers\u0027,"},{"line_number":465,"context_line":"            help\u003d_(\u0027DNS server to be removed from this subnet\u0027"},{"line_number":466,"context_line":"                   \u0027(repeat option to set multiple DNS servers)\u0027),"},{"line_number":467,"context_line":"        )"},{"line_number":468,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_50f75ed2","line":465,"range":{"start_line":465,"start_character":61,"end_line":465,"end_character":62},"updated":"2016-06-27 07:20:59.000000000","message":"Missing space here.","commit_id":"9af35b99bfe01d16dc5e24571d111d58fe442bbe"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9b8919391b4088490f468219b759838e33a8ca17","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            attrs[\u0027dns_nameservers\u0027] \u003d tmp_obj.dns_nameservers"},{"line_number":499,"context_line":"        if parsed_args.host_routes:"},{"line_number":500,"context_line":"            try:"},{"line_number":501,"context_line":"                _updated_arguments("},{"line_number":502,"context_line":"                    tmp_obj.host_routes,"},{"line_number":503,"context_line":"                    convert_entries_to_nexthop(parsed_args.host_routes))"},{"line_number":504,"context_line":"            except exceptions.CommandError as error:"},{"line_number":505,"context_line":"                msg \u003d (_(\"%s not in host-routes\") % str(error))"},{"line_number":506,"context_line":"                raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_5070fe71","line":503,"range":{"start_line":501,"start_character":0,"end_line":503,"end_character":72},"updated":"2016-06-27 07:20:59.000000000","message":"If we have raised exception in _updated_arguments(), why raise exception again below ?","commit_id":"9af35b99bfe01d16dc5e24571d111d58fe442bbe"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"5f57c1e7c4c91005a416edfff9e87a3d79e6470b","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            attrs[\u0027dns_nameservers\u0027] \u003d tmp_obj.dns_nameservers"},{"line_number":499,"context_line":"        if parsed_args.host_routes:"},{"line_number":500,"context_line":"            try:"},{"line_number":501,"context_line":"                _updated_arguments("},{"line_number":502,"context_line":"                    tmp_obj.host_routes,"},{"line_number":503,"context_line":"                    convert_entries_to_nexthop(parsed_args.host_routes))"},{"line_number":504,"context_line":"            except exceptions.CommandError as error:"},{"line_number":505,"context_line":"                msg \u003d (_(\"%s not in host-routes\") % str(error))"},{"line_number":506,"context_line":"                raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_538768b4","line":503,"range":{"start_line":501,"start_character":0,"end_line":503,"end_character":72},"in_reply_to":"3aaa91ec_5070fe71","updated":"2016-06-27 08:05:05.000000000","message":"That exception would be caught here, right?","commit_id":"9af35b99bfe01d16dc5e24571d111d58fe442bbe"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"4541fdb565bac45c3af98933aa80994e3300e818","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            attrs[\u0027dns_nameservers\u0027] \u003d tmp_obj.dns_nameservers"},{"line_number":499,"context_line":"        if parsed_args.host_routes:"},{"line_number":500,"context_line":"            try:"},{"line_number":501,"context_line":"                _updated_arguments("},{"line_number":502,"context_line":"                    tmp_obj.host_routes,"},{"line_number":503,"context_line":"                    convert_entries_to_nexthop(parsed_args.host_routes))"},{"line_number":504,"context_line":"            except exceptions.CommandError as error:"},{"line_number":505,"context_line":"                msg \u003d (_(\"%s not in host-routes\") % str(error))"},{"line_number":506,"context_line":"                raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_9bbb9ec3","line":503,"range":{"start_line":501,"start_character":0,"end_line":503,"end_character":72},"in_reply_to":"3aaa91ec_538768b4","updated":"2016-06-27 11:31:36.000000000","message":"Sorry, I mean just use obj_list.remove(item) directly, and it will raise an exception if it fails. We don\u0027t need to raise an exception in _updated_arguments() and catch it here. Or we just raise it in _updated_argument(), and don\u0027t need to raise it here agein.","commit_id":"9af35b99bfe01d16dc5e24571d111d58fe442bbe"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9b8919391b4088490f468219b759838e33a8ca17","unresolved":false,"context_lines":[{"line_number":502,"context_line":"                    tmp_obj.host_routes,"},{"line_number":503,"context_line":"                    convert_entries_to_nexthop(parsed_args.host_routes))"},{"line_number":504,"context_line":"            except exceptions.CommandError as error:"},{"line_number":505,"context_line":"                msg \u003d (_(\"%s not in host-routes\") % str(error))"},{"line_number":506,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":507,"context_line":"            attrs[\u0027host_routes\u0027] \u003d tmp_obj.host_routes"},{"line_number":508,"context_line":"        if parsed_args.allocation_pools:"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_50c2be85","line":505,"range":{"start_line":505,"start_character":25,"end_line":505,"end_character":47},"updated":"2016-06-27 07:20:59.000000000","message":"I\u0027d like to keep this message the same as other unset commands.","commit_id":"9af35b99bfe01d16dc5e24571d111d58fe442bbe"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9b8919391b4088490f468219b759838e33a8ca17","unresolved":false,"context_lines":[{"line_number":510,"context_line":"                _updated_arguments(tmp_obj.allocation_pools,"},{"line_number":511,"context_line":"                                   parsed_args.allocation_pools)"},{"line_number":512,"context_line":"            except exceptions.CommandError as error:"},{"line_number":513,"context_line":"                msg \u003d (_(\"%s not in allocation-pools\") %"},{"line_number":514,"context_line":"                       str(error))"},{"line_number":515,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":516,"context_line":"            attrs[\u0027allocation_pools\u0027] \u003d tmp_obj.allocation_pools"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_10431614","line":513,"range":{"start_line":513,"start_character":26,"end_line":513,"end_character":53},"updated":"2016-06-27 07:20:59.000000000","message":"I\u0027d like to keep this message the same as other unset commands.","commit_id":"9af35b99bfe01d16dc5e24571d111d58fe442bbe"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9b8919391b4088490f468219b759838e33a8ca17","unresolved":false,"context_lines":[{"line_number":514,"context_line":"                       str(error))"},{"line_number":515,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":516,"context_line":"            attrs[\u0027allocation_pools\u0027] \u003d tmp_obj.allocation_pools"},{"line_number":517,"context_line":"        if attrs \u003d\u003d {}:"},{"line_number":518,"context_line":"            msg \u003d \"Nothing specified to be unset\""},{"line_number":519,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":520,"context_line":"        client.update_subnet(obj, **attrs)"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_90e1c62c","line":519,"range":{"start_line":517,"start_character":0,"end_line":519,"end_character":46},"updated":"2016-06-27 07:20:59.000000000","message":"Make set/unset commands return normally when nothing specified.","commit_id":"9af35b99bfe01d16dc5e24571d111d58fe442bbe"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f556bb96209a2671865525e14764d4fcddfe5307","unresolved":false,"context_lines":[{"line_number":461,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":462,"context_line":"            dest\u003d\u0027dns_nameservers\u0027,"},{"line_number":463,"context_line":"            help\u003d_(\u0027DNS server to be removed from this subnet \u0027"},{"line_number":464,"context_line":"                   \u0027(repeat option to set multiple DNS servers)\u0027)"},{"line_number":465,"context_line":"        )"},{"line_number":466,"context_line":"        parser.add_argument("},{"line_number":467,"context_line":"            \u0027--host-route\u0027,"}],"source_content_type":"text/x-python","patch_set":26,"id":"3aaa91ec_660fb9e1","line":464,"range":{"start_line":464,"start_character":38,"end_line":464,"end_character":41},"updated":"2016-06-29 11:59:01.000000000","message":"unset","commit_id":"45b026d7c8e4675a598192bcf4c88f22005cc1d2"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f556bb96209a2671865525e14764d4fcddfe5307","unresolved":false,"context_lines":[{"line_number":492,"context_line":"                _update_arguments(tmp_obj.dns_nameservers,"},{"line_number":493,"context_line":"                                  parsed_args.dns_nameservers)"},{"line_number":494,"context_line":"            except ValueError as error:"},{"line_number":495,"context_line":"                msg \u003d (_(\"%s not in dns-nameservers\") % str(error))"},{"line_number":496,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":497,"context_line":"            attrs[\u0027dns_nameservers\u0027] \u003d tmp_obj.dns_nameservers"},{"line_number":498,"context_line":"        if parsed_args.host_routes:"}],"source_content_type":"text/x-python","patch_set":26,"id":"3aaa91ec_a6f8817d","line":495,"range":{"start_line":495,"start_character":26,"end_line":495,"end_character":51},"updated":"2016-06-29 11:59:01.000000000","message":"Why is this not similar to the other error messages?","commit_id":"45b026d7c8e4675a598192bcf4c88f22005cc1d2"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f556bb96209a2671865525e14764d4fcddfe5307","unresolved":false,"context_lines":[{"line_number":501,"context_line":"                    tmp_obj.host_routes,"},{"line_number":502,"context_line":"                    convert_entries_to_nexthop(parsed_args.host_routes))"},{"line_number":503,"context_line":"            except ValueError as error:"},{"line_number":504,"context_line":"                msg \u003d (_(\"Subnet does not have %s in host-routes\") %"},{"line_number":505,"context_line":"                       str(error))"},{"line_number":506,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":507,"context_line":"            attrs[\u0027host_routes\u0027] \u003d tmp_obj.host_routes"}],"source_content_type":"text/x-python","patch_set":26,"id":"3aaa91ec_a66d2134","line":504,"range":{"start_line":504,"start_character":57,"end_line":504,"end_character":58},"updated":"2016-06-29 11:59:01.000000000","message":"I don\u0027t think the dash is needed in these messages.","commit_id":"45b026d7c8e4675a598192bcf4c88f22005cc1d2"}],"openstackclient/tests/network/v2/test_subnet.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"17ae7b451bea4f76512733a02f82b64ee846063a","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        # Get the command object to test"},{"line_number":651,"context_line":"        self.cmd \u003d subnet_v2.UnsetSubnet(self.app, self.namespace)"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    def test_set_this(self):"},{"line_number":654,"context_line":"        arglist \u003d ["},{"line_number":655,"context_line":"            \u0027--dns-nameserver\u0027, \u00278.8.8.8\u0027,"},{"line_number":656,"context_line":"            \u0027--host-route\u0027, \u0027destination\u003d10.30.30.30/24,gateway\u003d10.30.30.1\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_7abc2406","line":653,"range":{"start_line":653,"start_character":8,"end_line":653,"end_character":21},"updated":"2016-04-20 05:55:45.000000000","message":"test_unset_subnet (or something similar)","commit_id":"67cf018718991dca3f4a08dc3a204e5f255ed297"}],"releasenotes/notes/subnet-unset-5b458cdbaf93d766.yaml":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9b8919391b4088490f468219b759838e33a8ca17","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new command ``subnet unset`` to clear the information"},{"line_number":5,"context_line":"    of allocation-pools, host-routes or DNS servers from the subnet."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3aaa91ec_50111e51","line":5,"range":{"start_line":4,"start_character":0,"end_line":5,"end_character":68},"updated":"2016-06-27 07:20:59.000000000","message":"Please link the BP.","commit_id":"9af35b99bfe01d16dc5e24571d111d58fe442bbe"}]}
