)]}'
{"doc/source/command-objects/subnet-pool.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"df65ea137a2c4b8dd9da06a1ac59ecfdf8c2d9b9","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    Subnet pool to display (name or ID)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"subnet pool unset"},{"line_number":160,"context_line":"----------"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Unset information from subnet pool attributes"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_28e3fca4","line":160,"range":{"start_line":160,"start_character":0,"end_line":160,"end_character":10},"updated":"2016-04-18 06:20:05.000000000","message":"missing a few ---\u0027s here","commit_id":"92494e28fe1ef163343cb619ea49e6d147a1480a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"96544f4822765c6afad06654c9b1894977d652c0","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    Subnet pool to display (name or ID)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"subnet pool unset"},{"line_number":160,"context_line":"----------"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Unset information from subnet pool attributes"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_8bd04a55","line":160,"range":{"start_line":160,"start_character":0,"end_line":160,"end_character":10},"in_reply_to":"1a122d0e_28e3fca4","updated":"2016-04-18 06:44:27.000000000","message":"Done","commit_id":"92494e28fe1ef163343cb619ea49e6d147a1480a"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"df65ea137a2c4b8dd9da06a1ac59ecfdf8c2d9b9","unresolved":false,"context_lines":[{"line_number":159,"context_line":"subnet pool unset"},{"line_number":160,"context_line":"----------"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Unset information from subnet pool attributes"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":".. program:: subnet pool unset"},{"line_number":165,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_284c9cc6","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":45},"updated":"2016-04-18 06:20:05.000000000","message":"this doesn\u0027t match what is in subnet_pools.py","commit_id":"92494e28fe1ef163343cb619ea49e6d147a1480a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"96544f4822765c6afad06654c9b1894977d652c0","unresolved":false,"context_lines":[{"line_number":159,"context_line":"subnet pool unset"},{"line_number":160,"context_line":"----------"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"Unset information from subnet pool attributes"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":".. program:: subnet pool unset"},{"line_number":165,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_6bd5ee41","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":45},"in_reply_to":"1a122d0e_284c9cc6","updated":"2016-04-18 06:44:27.000000000","message":"Done","commit_id":"92494e28fe1ef163343cb619ea49e6d147a1480a"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"d373347e84ee2c86d25fe2cc117dac0f3ec02a22","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":".. option:: --pool-prefix \u003cpool-prefix\u003e"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    Set subnet pool prefixes (in CIDR notation)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":".. _subnet_pool_unset-subnet-pool:"},{"line_number":206,"context_line":".. describe:: \u003csubnet\u003e"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_abad628a","line":203,"range":{"start_line":203,"start_character":4,"end_line":203,"end_character":7},"updated":"2016-05-18 08:45:36.000000000","message":"s/Unset/Set/","commit_id":"541589dd0dcb51f27f72d53fb478458d07461d60"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"d373347e84ee2c86d25fe2cc117dac0f3ec02a22","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    Set subnet pool prefixes (in CIDR notation)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":".. _subnet_pool_unset-subnet-pool:"},{"line_number":206,"context_line":".. describe:: \u003csubnet\u003e"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    subnet pool to modify (name or ID)"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bab6814e_10e8197c","line":206,"range":{"start_line":206,"start_character":15,"end_line":206,"end_character":21},"updated":"2016-05-18 08:45:36.000000000","message":"should be \"subnet-pool\"","commit_id":"541589dd0dcb51f27f72d53fb478458d07461d60"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ee002b30326f4eb4d61dd2cfeb8509fd2c035468","unresolved":false,"context_lines":[{"line_number":201,"context_line":".. option:: --pool-prefix \u003cpool-prefix\u003e"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    Remove subnet pool prefixes (in CIDR notation)."},{"line_number":204,"context_line":"    This option can be repeated."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":".. _subnet_pool_unset-subnet-pool:"},{"line_number":207,"context_line":".. describe:: \u003csubnet-pool\u003e"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3aaa91ec_4eff6c67","line":204,"updated":"2016-06-22 17:01:00.000000000","message":"For consistency with other documentation, this should be (repeat option to remove multiple ...)","commit_id":"08a8c9b97564c2a4038e71fa3a20ae22e0cf9c6a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6c182c6a90f2748a9516c388f6d6e824fc23143c","unresolved":false,"context_lines":[{"line_number":201,"context_line":".. option:: --pool-prefix \u003cpool-prefix\u003e"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    Remove subnet pool prefixes (in CIDR notation)."},{"line_number":204,"context_line":"    This option can be repeated."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":".. _subnet_pool_unset-subnet-pool:"},{"line_number":207,"context_line":".. describe:: \u003csubnet-pool\u003e"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3aaa91ec_6c7dfeb0","line":204,"in_reply_to":"3aaa91ec_4eff6c67","updated":"2016-06-23 02:27:38.000000000","message":"Done","commit_id":"08a8c9b97564c2a4038e71fa3a20ae22e0cf9c6a"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"563aaab756c8baab04293a1e271b47d21b703aa5","unresolved":false,"context_lines":[{"line_number":195,"context_line":".. code:: bash"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    os subnet pool unset"},{"line_number":198,"context_line":"        [--pool-prefix \u003cpool-prefix\u003e]"},{"line_number":199,"context_line":"        \u003csubnet-pool\u003e"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":".. option:: --pool-prefix \u003cpool-prefix\u003e"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3aaa91ec_3f5c1d4a","line":198,"updated":"2016-06-27 10:02:54.000000000","message":"please keep consistent with other repeatable options\n\n    [--pool-prefix \u003cpool-prefix\u003e [...] ]","commit_id":"3a9313ce22d03251673d8fdbcd6a23aedbe0640a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2e2c7b69bce12362124862353454ae6f4ee3d33a","unresolved":false,"context_lines":[{"line_number":201,"context_line":".. option:: --pool-prefix \u003cpool-prefix\u003e"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    Remove subnet pool prefixes (in CIDR notation)."},{"line_number":204,"context_line":"    (repeat option to unset multiple pool-prefixes)."},{"line_number":205,"context_line":""},{"line_number":206,"context_line":".. _subnet_pool_unset-subnet-pool:"},{"line_number":207,"context_line":".. describe:: \u003csubnet-pool\u003e"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3aaa91ec_93816992","line":204,"range":{"start_line":204,"start_character":37,"end_line":204,"end_character":42},"updated":"2016-06-28 18:52:42.000000000","message":"I don\u0027t think this is necessary.","commit_id":"348212393f29a1c2848c0f1a8309cf9ed94edff6"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2e2c7b69bce12362124862353454ae6f4ee3d33a","unresolved":false,"context_lines":[{"line_number":206,"context_line":".. _subnet_pool_unset-subnet-pool:"},{"line_number":207,"context_line":".. describe:: \u003csubnet-pool\u003e"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    subnet pool to modify (name or ID)"}],"source_content_type":"text/x-rst","patch_set":16,"id":"3aaa91ec_13445972","line":209,"range":{"start_line":209,"start_character":4,"end_line":209,"end_character":10},"updated":"2016-06-28 18:52:42.000000000","message":"Uppercase \"Subnet\"","commit_id":"348212393f29a1c2848c0f1a8309cf9ed94edff6"}],"openstackclient/network/v2/subnet_pool.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"0eecfd8f4b611083292c6af3d4389a12e31853c3","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"class UnsetSubnetPool(command.Command):"},{"line_number":277,"context_line":"    \"\"\"Unset/Clear subnet_pool specific details\"\"\""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def get_parser(self, prog_name):"},{"line_number":280,"context_line":"        parser \u003d super(UnsetSubnetPool, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_72f32374","line":277,"range":{"start_line":277,"start_character":19,"end_line":277,"end_character":30},"updated":"2016-04-18 03:49:00.000000000","message":"remove the underscore \"_\" here","commit_id":"822ffd54cbd07e7231e58c93656fc3672dea39d4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"0eecfd8f4b611083292c6af3d4389a12e31853c3","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        parser.add_argument("},{"line_number":288,"context_line":"            \u0027subnet_pool\u0027,"},{"line_number":289,"context_line":"            metavar\u003d\"\u003csubnet-pool\u003e\","},{"line_number":290,"context_line":"            help\u003d\"Subnet Pool to modify (name or ID)\""},{"line_number":291,"context_line":"        )"},{"line_number":292,"context_line":"        return parser"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_32e36ba5","line":290,"range":{"start_line":290,"start_character":25,"end_line":290,"end_character":29},"updated":"2016-04-18 03:49:00.000000000","message":"lower case pool*","commit_id":"822ffd54cbd07e7231e58c93656fc3672dea39d4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"df65ea137a2c4b8dd9da06a1ac59ecfdf8c2d9b9","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"class UnsetSubnetPool(command.Command):"},{"line_number":277,"context_line":"    \"\"\"Unset/Clear subnet pool specific details\"\"\""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def get_parser(self, prog_name):"},{"line_number":280,"context_line":"        parser \u003d super(UnsetSubnetPool, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_28fadc42","line":277,"range":{"start_line":277,"start_character":7,"end_line":277,"end_character":18},"updated":"2016-04-18 06:20:05.000000000","message":"i don\u0027t remember what we have been using for `unset` commands, but i think it\u0027s something like:\n\n  \"Unset \u003cobject\u003e properties\"\n\nIn this case it would be:\n\n  \"Unset subnet pool properties\"\n\nDo you think that makes sense and can scale to the other network specific objects we have in osc now?","commit_id":"92494e28fe1ef163343cb619ea49e6d147a1480a"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"df65ea137a2c4b8dd9da06a1ac59ecfdf8c2d9b9","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"class UnsetSubnetPool(command.Command):"},{"line_number":277,"context_line":"    \"\"\"Unset/Clear subnet pool specific details\"\"\""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def get_parser(self, prog_name):"},{"line_number":280,"context_line":"        parser \u003d super(UnsetSubnetPool, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_c8d1a8cf","line":277,"range":{"start_line":277,"start_character":7,"end_line":277,"end_character":47},"updated":"2016-04-18 06:20:05.000000000","message":"see comment in .rst","commit_id":"92494e28fe1ef163343cb619ea49e6d147a1480a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"96544f4822765c6afad06654c9b1894977d652c0","unresolved":false,"context_lines":[{"line_number":274,"context_line":""},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"class UnsetSubnetPool(command.Command):"},{"line_number":277,"context_line":"    \"\"\"Unset/Clear subnet pool specific details\"\"\""},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def get_parser(self, prog_name):"},{"line_number":280,"context_line":"        parser \u003d super(UnsetSubnetPool, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_2bef76e9","line":277,"range":{"start_line":277,"start_character":7,"end_line":277,"end_character":47},"in_reply_to":"1a122d0e_c8d1a8cf","updated":"2016-04-18 06:44:27.000000000","message":"Done","commit_id":"92494e28fe1ef163343cb619ea49e6d147a1480a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f96466564a8495ea04364c6d116c4f4d566492c9","unresolved":false,"context_lines":[{"line_number":330,"context_line":"            \u0027--pool-prefix\u0027,"},{"line_number":331,"context_line":"            metavar\u003d\u0027\u003cpool-prefix\u003e\u0027,"},{"line_number":332,"context_line":"            dest\u003d\u0027prefixes\u0027,"},{"line_number":333,"context_line":"            help\u003d\u0027Remove subnet pool prefixes (in CIDR notation) \u0027,"},{"line_number":334,"context_line":"        )"},{"line_number":335,"context_line":"        parser.add_argument("},{"line_number":336,"context_line":"            \u0027subnet_pool\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_d2134363","line":333,"updated":"2016-05-23 19:00:44.000000000","message":"Please wrap help in _()","commit_id":"122c2c8c9e4714bb2728b1aed1adfab84c452f55"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"deb5cec76f67be7167864666e605f3ef565a9e64","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def get_parser(self, prog_name):"},{"line_number":328,"context_line":"        parser \u003d super(UnsetSubnetPool, self).get_parser(prog_name)"},{"line_number":329,"context_line":"        parser.add_argument("},{"line_number":330,"context_line":"            \u0027--pool-prefix\u0027,"},{"line_number":331,"context_line":"            metavar\u003d\u0027\u003cpool-prefix\u003e\u0027,"},{"line_number":332,"context_line":"            dest\u003d\u0027prefixes\u0027,"},{"line_number":333,"context_line":"            help\u003d\u0027Remove subnet pool prefixes (in CIDR notation) \u0027,"},{"line_number":334,"context_line":"        )"},{"line_number":335,"context_line":"        parser.add_argument("},{"line_number":336,"context_line":"            \u0027subnet_pool\u0027,"},{"line_number":337,"context_line":"            metavar\u003d\"\u003csubnet-pool\u003e\","}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_1f697df9","line":334,"range":{"start_line":329,"start_character":0,"end_line":334,"end_character":9},"updated":"2016-05-23 08:13:38.000000000","message":"I think this option can be repeated. We can specify multiple prefixes when creating a subnet pool.","commit_id":"122c2c8c9e4714bb2728b1aed1adfab84c452f55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"60f25edc59c9cfb3ca3186bace35c95a15b2c8cb","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def get_parser(self, prog_name):"},{"line_number":328,"context_line":"        parser \u003d super(UnsetSubnetPool, self).get_parser(prog_name)"},{"line_number":329,"context_line":"        parser.add_argument("},{"line_number":330,"context_line":"            \u0027--pool-prefix\u0027,"},{"line_number":331,"context_line":"            metavar\u003d\u0027\u003cpool-prefix\u003e\u0027,"},{"line_number":332,"context_line":"            dest\u003d\u0027prefixes\u0027,"},{"line_number":333,"context_line":"            help\u003d\u0027Remove subnet pool prefixes (in CIDR notation) \u0027,"},{"line_number":334,"context_line":"        )"},{"line_number":335,"context_line":"        parser.add_argument("},{"line_number":336,"context_line":"            \u0027subnet_pool\u0027,"},{"line_number":337,"context_line":"            metavar\u003d\"\u003csubnet-pool\u003e\","}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_ead15624","line":334,"range":{"start_line":329,"start_character":0,"end_line":334,"end_character":9},"in_reply_to":"bab6814e_1f697df9","updated":"2016-05-23 09:25:26.000000000","message":"Is it necessary to support repetition for Unset Subnet-pool if the option is supported in create?","commit_id":"122c2c8c9e4714bb2728b1aed1adfab84c452f55"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f96466564a8495ea04364c6d116c4f4d566492c9","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def get_parser(self, prog_name):"},{"line_number":328,"context_line":"        parser \u003d super(UnsetSubnetPool, self).get_parser(prog_name)"},{"line_number":329,"context_line":"        parser.add_argument("},{"line_number":330,"context_line":"            \u0027--pool-prefix\u0027,"},{"line_number":331,"context_line":"            metavar\u003d\u0027\u003cpool-prefix\u003e\u0027,"},{"line_number":332,"context_line":"            dest\u003d\u0027prefixes\u0027,"},{"line_number":333,"context_line":"            help\u003d\u0027Remove subnet pool prefixes (in CIDR notation) \u0027,"},{"line_number":334,"context_line":"        )"},{"line_number":335,"context_line":"        parser.add_argument("},{"line_number":336,"context_line":"            \u0027subnet_pool\u0027,"},{"line_number":337,"context_line":"            metavar\u003d\"\u003csubnet-pool\u003e\","}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_5229139a","line":334,"range":{"start_line":329,"start_character":0,"end_line":334,"end_character":9},"in_reply_to":"bab6814e_ead15624","updated":"2016-05-23 19:00:44.000000000","message":"I think it should be support for consistency.","commit_id":"122c2c8c9e4714bb2728b1aed1adfab84c452f55"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f96466564a8495ea04364c6d116c4f4d566492c9","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":344,"context_line":"        obj \u003d client.find_subnet_pool("},{"line_number":345,"context_line":"            parsed_args.subnet_pool, ignore_missing\u003dFalse)"},{"line_number":346,"context_line":"        tmp_obj \u003d copy.deepcopy(obj)"},{"line_number":347,"context_line":"        attrs \u003d {}"},{"line_number":348,"context_line":"        if parsed_args.prefixes:"},{"line_number":349,"context_line":"            tmp_obj.prefixes.remove(parsed_args.prefixes)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_b024b8b2","line":346,"updated":"2016-05-23 19:00:44.000000000","message":"I don\u0027t think the entire object should be deep copied. This *may* not work after the pending SDK refactor.","commit_id":"122c2c8c9e4714bb2728b1aed1adfab84c452f55"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f96466564a8495ea04364c6d116c4f4d566492c9","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        tmp_obj \u003d copy.deepcopy(obj)"},{"line_number":347,"context_line":"        attrs \u003d {}"},{"line_number":348,"context_line":"        if parsed_args.prefixes:"},{"line_number":349,"context_line":"            tmp_obj.prefixes.remove(parsed_args.prefixes)"},{"line_number":350,"context_line":"            attrs[\u0027prefixes\u0027] \u003d tmp_obj.prefixes"},{"line_number":351,"context_line":"        if attrs \u003d\u003d {}:"},{"line_number":352,"context_line":"            msg \u003d \"Nothing specified to be unset\""}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_d0717caa","line":349,"updated":"2016-05-23 19:00:44.000000000","message":"If the prefix doesn\u0027t exist, should this result in an error like is done for the other unset commands?","commit_id":"122c2c8c9e4714bb2728b1aed1adfab84c452f55"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"909ed9e5d5a546b850347a315b148b7581e74daa","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def get_parser(self, prog_name):"},{"line_number":328,"context_line":"        parser \u003d super(UnsetSubnetPool, self).get_parser(prog_name)"},{"line_number":329,"context_line":"        parser.add_argument("},{"line_number":330,"context_line":"            \u0027--pool-prefix\u0027,"},{"line_number":331,"context_line":"            metavar\u003d\u0027\u003cpool-prefix\u003e\u0027,"},{"line_number":332,"context_line":"            dest\u003d\u0027prefixes\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_2e24a0ad","line":329,"updated":"2016-06-22 16:57:26.000000000","message":"This option requires and append action to be repeated.","commit_id":"08a8c9b97564c2a4038e71fa3a20ae22e0cf9c6a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6c182c6a90f2748a9516c388f6d6e824fc23143c","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"    def get_parser(self, prog_name):"},{"line_number":328,"context_line":"        parser \u003d super(UnsetSubnetPool, self).get_parser(prog_name)"},{"line_number":329,"context_line":"        parser.add_argument("},{"line_number":330,"context_line":"            \u0027--pool-prefix\u0027,"},{"line_number":331,"context_line":"            metavar\u003d\u0027\u003cpool-prefix\u003e\u0027,"},{"line_number":332,"context_line":"            dest\u003d\u0027prefixes\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_6ca69e54","line":329,"in_reply_to":"3aaa91ec_2e24a0ad","updated":"2016-06-23 02:27:38.000000000","message":"Done","commit_id":"08a8c9b97564c2a4038e71fa3a20ae22e0cf9c6a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"909ed9e5d5a546b850347a315b148b7581e74daa","unresolved":false,"context_lines":[{"line_number":351,"context_line":"            try:"},{"line_number":352,"context_line":"                tmp_prefixes.remove(parsed_args.prefixes)"},{"line_number":353,"context_line":"            except ValueError:"},{"line_number":354,"context_line":"                msg \u003d _("},{"line_number":355,"context_line":"                    \"Subnet pool does not\""},{"line_number":356,"context_line":"                    \"contain prefix %s.\\n\") % parsed_args.prefixes"},{"line_number":357,"context_line":"            attrs[\u0027prefixes\u0027] \u003d tmp_prefixes"},{"line_number":358,"context_line":"        if attrs \u003d\u003d {}:"},{"line_number":359,"context_line":"            raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_ee3a9897","line":356,"range":{"start_line":354,"start_character":16,"end_line":356,"end_character":66},"updated":"2016-06-22 16:57:26.000000000","message":"It\u0027s probably better to fail immediately.","commit_id":"08a8c9b97564c2a4038e71fa3a20ae22e0cf9c6a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6c182c6a90f2748a9516c388f6d6e824fc23143c","unresolved":false,"context_lines":[{"line_number":351,"context_line":"            try:"},{"line_number":352,"context_line":"                tmp_prefixes.remove(parsed_args.prefixes)"},{"line_number":353,"context_line":"            except ValueError:"},{"line_number":354,"context_line":"                msg \u003d _("},{"line_number":355,"context_line":"                    \"Subnet pool does not\""},{"line_number":356,"context_line":"                    \"contain prefix %s.\\n\") % parsed_args.prefixes"},{"line_number":357,"context_line":"            attrs[\u0027prefixes\u0027] \u003d tmp_prefixes"},{"line_number":358,"context_line":"        if attrs \u003d\u003d {}:"},{"line_number":359,"context_line":"            raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_ac66c626","line":356,"range":{"start_line":354,"start_character":16,"end_line":356,"end_character":66},"in_reply_to":"3aaa91ec_ee3a9897","updated":"2016-06-23 02:27:38.000000000","message":"Done","commit_id":"08a8c9b97564c2a4038e71fa3a20ae22e0cf9c6a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"909ed9e5d5a546b850347a315b148b7581e74daa","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                    \"Subnet pool does not\""},{"line_number":356,"context_line":"                    \"contain prefix %s.\\n\") % parsed_args.prefixes"},{"line_number":357,"context_line":"            attrs[\u0027prefixes\u0027] \u003d tmp_prefixes"},{"line_number":358,"context_line":"        if attrs \u003d\u003d {}:"},{"line_number":359,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":360,"context_line":"        client.update_subnet_pool(obj, **attrs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_ce919c9b","line":359,"range":{"start_line":358,"start_character":0,"end_line":359,"end_character":46},"updated":"2016-06-22 16:57:26.000000000","message":"Tang has been fixing OSC set and unset commands to no longer fail when nothing to set/unset.  This should do the same.","commit_id":"08a8c9b97564c2a4038e71fa3a20ae22e0cf9c6a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6c182c6a90f2748a9516c388f6d6e824fc23143c","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                    \"Subnet pool does not\""},{"line_number":356,"context_line":"                    \"contain prefix %s.\\n\") % parsed_args.prefixes"},{"line_number":357,"context_line":"            attrs[\u0027prefixes\u0027] \u003d tmp_prefixes"},{"line_number":358,"context_line":"        if attrs \u003d\u003d {}:"},{"line_number":359,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":360,"context_line":"        client.update_subnet_pool(obj, **attrs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_4c7802c5","line":359,"range":{"start_line":358,"start_character":0,"end_line":359,"end_character":46},"in_reply_to":"3aaa91ec_ce919c9b","updated":"2016-06-23 02:27:38.000000000","message":"As the error is immediately raised, therefore no use of this statement","commit_id":"08a8c9b97564c2a4038e71fa3a20ae22e0cf9c6a"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9ead112c619519df42448d6ec919be043a730bb0","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        parser.add_argument("},{"line_number":338,"context_line":"            \u0027subnet_pool\u0027,"},{"line_number":339,"context_line":"            metavar\u003d\"\u003csubnet-pool\u003e\","},{"line_number":340,"context_line":"            help\u003d\"Subnet pool to modify (name or ID)\""},{"line_number":341,"context_line":"        )"},{"line_number":342,"context_line":"        return parser"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_ca1721a1","line":340,"range":{"start_line":340,"start_character":18,"end_line":340,"end_character":53},"updated":"2016-06-27 06:26:15.000000000","message":"Missing _()","commit_id":"3d2179c700a1c35e440ae7c2217e37d234b6b29b"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9ead112c619519df42448d6ec919be043a730bb0","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        attrs \u003d {}"},{"line_number":350,"context_line":"        if parsed_args.prefixes:"},{"line_number":351,"context_line":"            try:"},{"line_number":352,"context_line":"                tmp_prefixes.remove(parsed_args.prefixes)"},{"line_number":353,"context_line":"            except ValueError:"},{"line_number":354,"context_line":"                msg \u003d _("},{"line_number":355,"context_line":"                    \"Subnet pool does not\""}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_4a3df129","line":352,"range":{"start_line":352,"start_character":16,"end_line":352,"end_character":57},"updated":"2016-06-27 06:26:15.000000000","message":"Missing a for loop here. list.remove() cannot remove a list from a list.","commit_id":"3d2179c700a1c35e440ae7c2217e37d234b6b29b"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9ead112c619519df42448d6ec919be043a730bb0","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            except ValueError:"},{"line_number":354,"context_line":"                msg \u003d _("},{"line_number":355,"context_line":"                    \"Subnet pool does not\""},{"line_number":356,"context_line":"                    \"contain prefix %s.\\n\") % parsed_args.prefixes"},{"line_number":357,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":358,"context_line":"            attrs[\u0027prefixes\u0027] \u003d tmp_prefixes"},{"line_number":359,"context_line":"        client.update_subnet_pool(obj, **attrs)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_aa48d5cc","line":356,"range":{"start_line":356,"start_character":39,"end_line":356,"end_character":41},"updated":"2016-06-27 06:26:15.000000000","message":"nit: \\n not necessary.","commit_id":"3d2179c700a1c35e440ae7c2217e37d234b6b29b"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"15a7f20bddb3066882f0b5b9a49ea17022862018","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        parser.add_argument("},{"line_number":338,"context_line":"            \u0027subnet_pool\u0027,"},{"line_number":339,"context_line":"            metavar\u003d\"\u003csubnet-pool\u003e\","},{"line_number":340,"context_line":"            help\u003d\"Subnet pool to modify (name or ID)\""},{"line_number":341,"context_line":"        )"},{"line_number":342,"context_line":"        return parser"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3aaa91ec_50a11e93","line":340,"range":{"start_line":340,"start_character":17,"end_line":340,"end_character":53},"updated":"2016-06-27 07:30:46.000000000","message":"Missing _()","commit_id":"7f14b4854cafaa7782901fcb36091d58b2258376"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"15a7f20bddb3066882f0b5b9a49ea17022862018","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        attrs \u003d {}"},{"line_number":350,"context_line":"        print(parsed_args.prefixes)"},{"line_number":351,"context_line":"        if parsed_args.prefixes:"},{"line_number":352,"context_line":"            for prefix in parsed_args.prefixes:"},{"line_number":353,"context_line":"                try:"},{"line_number":354,"context_line":"                    tmp_prefixes.remove(prefix)"},{"line_number":355,"context_line":"                except ValueError:"}],"source_content_type":"text/x-python","patch_set":14,"id":"3aaa91ec_d0e22ed4","line":352,"range":{"start_line":352,"start_character":11,"end_line":352,"end_character":47},"updated":"2016-06-27 07:30:46.000000000","message":"Please move this loop into try block to keep the consistence.","commit_id":"7f14b4854cafaa7782901fcb36091d58b2258376"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"15a7f20bddb3066882f0b5b9a49ea17022862018","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                except ValueError:"},{"line_number":356,"context_line":"                    msg \u003d _("},{"line_number":357,"context_line":"                        \"Subnet pool does not \""},{"line_number":358,"context_line":"                        \"contain prefix %s.\\n\") % parsed_args.prefixes"},{"line_number":359,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":360,"context_line":"            attrs[\u0027prefixes\u0027] \u003d tmp_prefixes"},{"line_number":361,"context_line":"        client.update_subnet_pool(obj, **attrs)"}],"source_content_type":"text/x-python","patch_set":14,"id":"3aaa91ec_50cf5e55","line":358,"range":{"start_line":358,"start_character":43,"end_line":358,"end_character":45},"updated":"2016-06-27 07:30:46.000000000","message":"Not necessary.","commit_id":"7f14b4854cafaa7782901fcb36091d58b2258376"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"563aaab756c8baab04293a1e271b47d21b703aa5","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            parsed_args.subnet_pool, ignore_missing\u003dFalse)"},{"line_number":348,"context_line":"        tmp_prefixes \u003d copy.deepcopy(obj.prefixes)"},{"line_number":349,"context_line":"        attrs \u003d {}"},{"line_number":350,"context_line":"        print(parsed_args.prefixes)"},{"line_number":351,"context_line":"        if parsed_args.prefixes:"},{"line_number":352,"context_line":"            try:"},{"line_number":353,"context_line":"                for prefix in parsed_args.prefixes:"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_7129b99a","line":350,"updated":"2016-06-27 10:02:54.000000000","message":"debug code?","commit_id":"3a9313ce22d03251673d8fdbcd6a23aedbe0640a"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"563aaab756c8baab04293a1e271b47d21b703aa5","unresolved":false,"context_lines":[{"line_number":355,"context_line":"            except ValueError:"},{"line_number":356,"context_line":"                msg \u003d _("},{"line_number":357,"context_line":"                    \"Subnet pool does not \""},{"line_number":358,"context_line":"                    \"contain prefix %s.\\n\") % parsed_args.prefixes"},{"line_number":359,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":360,"context_line":"            attrs[\u0027prefixes\u0027] \u003d tmp_prefixes"},{"line_number":361,"context_line":"        client.update_subnet_pool(obj, **attrs)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_9fc71163","line":358,"range":{"start_line":358,"start_character":39,"end_line":358,"end_character":41},"updated":"2016-06-27 10:02:54.000000000","message":"please follow @Tang Chen\u0027s comment.","commit_id":"3a9313ce22d03251673d8fdbcd6a23aedbe0640a"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"563aaab756c8baab04293a1e271b47d21b703aa5","unresolved":false,"context_lines":[{"line_number":358,"context_line":"                    \"contain prefix %s.\\n\") % parsed_args.prefixes"},{"line_number":359,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":360,"context_line":"            attrs[\u0027prefixes\u0027] \u003d tmp_prefixes"},{"line_number":361,"context_line":"        client.update_subnet_pool(obj, **attrs)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_b4e2efd2","line":361,"updated":"2016-06-27 10:02:54.000000000","message":"subnet pool update method is outside of \"if\" code block, so attrs\u003d{} will be updated for subnet pool when we don\u0027t specify \"--pool-prefix\" option, what will happen in the situation?","commit_id":"3a9313ce22d03251673d8fdbcd6a23aedbe0640a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2e2c7b69bce12362124862353454ae6f4ee3d33a","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":333,"context_line":"            dest\u003d\u0027prefixes\u0027,"},{"line_number":334,"context_line":"            help\u003d_(\u0027Remove subnet pool prefixes (in CIDR notation). \u0027"},{"line_number":335,"context_line":"                   \u0027(repeat option to unset multiple pool-prefixes).\u0027),"},{"line_number":336,"context_line":"        )"},{"line_number":337,"context_line":"        parser.add_argument("},{"line_number":338,"context_line":"            \u0027subnet_pool\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_332075b0","line":335,"range":{"start_line":335,"start_character":53,"end_line":335,"end_character":58},"updated":"2016-06-28 18:52:42.000000000","message":"I don\u0027t think this is necessary.","commit_id":"348212393f29a1c2848c0f1a8309cf9ed94edff6"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2e2c7b69bce12362124862353454ae6f4ee3d33a","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            except ValueError:"},{"line_number":355,"context_line":"                msg \u003d _("},{"line_number":356,"context_line":"                    \"Subnet pool does not \""},{"line_number":357,"context_line":"                    \"contain prefix %s\") % parsed_args.prefixes"},{"line_number":358,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":359,"context_line":"            attrs[\u0027prefixes\u0027] \u003d tmp_prefixes"},{"line_number":360,"context_line":"        if attrs:"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_5641af38","line":357,"range":{"start_line":357,"start_character":43,"end_line":357,"end_character":63},"updated":"2016-06-28 18:52:42.000000000","message":"This is all prefixes.  I assume that you wanted to display the prefix that couldn\u0027t be found.","commit_id":"348212393f29a1c2848c0f1a8309cf9ed94edff6"}],"openstackclient/tests/network/v2/test_subnet_pool.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"2588dcf63888cd2f5c245e756bede71d46672a24","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        # Get the command object to test"},{"line_number":560,"context_line":"        self.cmd \u003d subnet_pool.UnsetSubnetPool(self.app, self.namespace)"},{"line_number":561,"context_line":""},{"line_number":562,"context_line":"    def test_set_this(self):"},{"line_number":563,"context_line":"        arglist \u003d ["},{"line_number":564,"context_line":"            \u0027--pool-prefix\u0027, \u002710.0.10.0/24\u0027,"},{"line_number":565,"context_line":"            self._subnetpool.name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_1a4a5026","line":562,"range":{"start_line":562,"start_character":8,"end_line":562,"end_character":21},"updated":"2016-04-20 05:56:29.000000000","message":"fix up the test name","commit_id":"c2e1dc7f743843b4d5ca7f5797ed0ed4f8d08b8b"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"d373347e84ee2c86d25fe2cc117dac0f3ec02a22","unresolved":false,"context_lines":[{"line_number":653,"context_line":"            {\u0027prefixes\u0027: [\u002710.0.10.0/24\u0027, \u002710.1.10.0/24\u0027], })"},{"line_number":654,"context_line":"        self.network.find_subnet_pool \u003d mock.Mock("},{"line_number":655,"context_line":"            return_value\u003dself._subnetpool)"},{"line_number":656,"context_line":"        self.network.update_subnet_pool \u003d mock.Mock(return_value\u003dNone)"},{"line_number":657,"context_line":"        # Get the command object to test"},{"line_number":658,"context_line":"        self.cmd \u003d subnet_pool.UnsetSubnetPool(self.app, self.namespace)"},{"line_number":659,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_2b44d272","line":656,"range":{"start_line":656,"start_character":52,"end_line":656,"end_character":69},"updated":"2016-05-18 08:45:36.000000000","message":"the \"return_value\" isn\u0027t necessary.","commit_id":"541589dd0dcb51f27f72d53fb478458d07461d60"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3e24f14f43bdb8956242ca563040f04266111ad8","unresolved":false,"context_lines":[{"line_number":653,"context_line":"            {\u0027prefixes\u0027: [\u002710.0.10.0/24\u0027, \u002710.1.10.0/24\u0027], })"},{"line_number":654,"context_line":"        self.network.find_subnet_pool \u003d mock.Mock("},{"line_number":655,"context_line":"            return_value\u003dself._subnetpool)"},{"line_number":656,"context_line":"        self.network.update_subnet_pool \u003d mock.Mock(return_value\u003dNone)"},{"line_number":657,"context_line":"        # Get the command object to test"},{"line_number":658,"context_line":"        self.cmd \u003d subnet_pool.UnsetSubnetPool(self.app, self.namespace)"},{"line_number":659,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_cb625fd8","line":656,"range":{"start_line":656,"start_character":52,"end_line":656,"end_character":69},"in_reply_to":"bab6814e_2b44d272","updated":"2016-05-18 10:06:50.000000000","message":"But it helps in understanding :)","commit_id":"541589dd0dcb51f27f72d53fb478458d07461d60"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"7a34d4fad541ab1f2d421cb111a28903d36c5b23","unresolved":false,"context_lines":[{"line_number":653,"context_line":"            {\u0027prefixes\u0027: [\u002710.0.10.0/24\u0027, \u002710.1.10.0/24\u0027], })"},{"line_number":654,"context_line":"        self.network.find_subnet_pool \u003d mock.Mock("},{"line_number":655,"context_line":"            return_value\u003dself._subnetpool)"},{"line_number":656,"context_line":"        self.network.update_subnet_pool \u003d mock.Mock(return_value\u003dNone)"},{"line_number":657,"context_line":"        # Get the command object to test"},{"line_number":658,"context_line":"        self.cmd \u003d subnet_pool.UnsetSubnetPool(self.app, self.namespace)"},{"line_number":659,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_f786ddd9","line":656,"range":{"start_line":656,"start_character":52,"end_line":656,"end_character":69},"in_reply_to":"bab6814e_cb625fd8","updated":"2016-05-19 11:46:46.000000000","message":"ok, not a big deal","commit_id":"541589dd0dcb51f27f72d53fb478458d07461d60"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"909ed9e5d5a546b850347a315b148b7581e74daa","unresolved":false,"context_lines":[{"line_number":659,"context_line":""},{"line_number":660,"context_line":"    def test_unset_subnet_pool(self):"},{"line_number":661,"context_line":"        arglist \u003d ["},{"line_number":662,"context_line":"            \u0027--pool-prefix\u0027, \u002710.0.10.0/24\u0027,"},{"line_number":663,"context_line":"            self._subnetpool.name,"},{"line_number":664,"context_line":"        ]"},{"line_number":665,"context_line":"        verifylist \u003d [(\u0027prefixes\u0027, \u002710.0.10.0/24\u0027)]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_0e00c400","line":662,"updated":"2016-06-22 16:57:26.000000000","message":"It may be good to test multiple prefixes to unset.","commit_id":"08a8c9b97564c2a4038e71fa3a20ae22e0cf9c6a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6c182c6a90f2748a9516c388f6d6e824fc23143c","unresolved":false,"context_lines":[{"line_number":659,"context_line":""},{"line_number":660,"context_line":"    def test_unset_subnet_pool(self):"},{"line_number":661,"context_line":"        arglist \u003d ["},{"line_number":662,"context_line":"            \u0027--pool-prefix\u0027, \u002710.0.10.0/24\u0027,"},{"line_number":663,"context_line":"            self._subnetpool.name,"},{"line_number":664,"context_line":"        ]"},{"line_number":665,"context_line":"        verifylist \u003d [(\u0027prefixes\u0027, \u002710.0.10.0/24\u0027)]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_2c73f6e8","line":662,"in_reply_to":"3aaa91ec_0e00c400","updated":"2016-06-23 02:27:38.000000000","message":"Done","commit_id":"08a8c9b97564c2a4038e71fa3a20ae22e0cf9c6a"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9ead112c619519df42448d6ec919be043a730bb0","unresolved":false,"context_lines":[{"line_number":657,"context_line":"        # Get the command object to test"},{"line_number":658,"context_line":"        self.cmd \u003d subnet_pool.UnsetSubnetPool(self.app, self.namespace)"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"    def test_unset_subnet_pool(self):"},{"line_number":661,"context_line":"        arglist \u003d ["},{"line_number":662,"context_line":"            \u0027--pool-prefix\u0027, \u002710.0.10.0/24\u0027,"},{"line_number":663,"context_line":"            self._subnetpool.name,"}],"source_content_type":"text/x-python","patch_set":13,"id":"3aaa91ec_6a70ad0b","line":660,"range":{"start_line":660,"start_character":7,"end_line":660,"end_character":31},"updated":"2016-06-27 06:26:15.000000000","message":"Maybe add a test for more than one prefix.","commit_id":"3d2179c700a1c35e440ae7c2217e37d234b6b29b"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2e2c7b69bce12362124862353454ae6f4ee3d33a","unresolved":false,"context_lines":[{"line_number":658,"context_line":"        # Get the command object to test"},{"line_number":659,"context_line":"        self.cmd \u003d subnet_pool.UnsetSubnetPool(self.app, self.namespace)"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    def test_unset_subnet_pool(self):"},{"line_number":662,"context_line":"        arglist \u003d ["},{"line_number":663,"context_line":"            \u0027--pool-prefix\u0027, \u002710.0.10.0/24\u0027,"},{"line_number":664,"context_line":"            \u0027--pool-prefix\u0027, \u002710.1.10.0/24\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_b69d73bd","line":661,"updated":"2016-06-28 18:52:42.000000000","message":"A test for unsetting a prefix that doesn\u0027t exist would be nice.","commit_id":"348212393f29a1c2848c0f1a8309cf9ed94edff6"}],"releasenotes/notes/unset-subnet-pool-333052dd85b95653.yaml":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"0eecfd8f4b611083292c6af3d4389a12e31853c3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new command ``subnetpool unset`` to clear the information"},{"line_number":5,"context_line":"    of pool-prefixes from the subnet pools."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_52e6e7b4","line":4,"range":{"start_line":4,"start_character":24,"end_line":4,"end_character":34},"updated":"2016-04-18 03:49:00.000000000","message":"missing a space here","commit_id":"822ffd54cbd07e7231e58c93656fc3672dea39d4"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"909ed9e5d5a546b850347a315b148b7581e74daa","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new command ``subnet pool unset`` to clear the information"},{"line_number":5,"context_line":"    of pool-prefixes from the subnet pools."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3aaa91ec_0b327610","line":6,"updated":"2016-06-22 16:57:26.000000000","message":"Most release notes reference the blueprint or bug here.","commit_id":"08a8c9b97564c2a4038e71fa3a20ae22e0cf9c6a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6c182c6a90f2748a9516c388f6d6e824fc23143c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new command ``subnet pool unset`` to clear the information"},{"line_number":5,"context_line":"    of pool-prefixes from the subnet pools."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3aaa91ec_8c82ea92","line":6,"in_reply_to":"3aaa91ec_0b327610","updated":"2016-06-23 02:27:38.000000000","message":"Done","commit_id":"08a8c9b97564c2a4038e71fa3a20ae22e0cf9c6a"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"563aaab756c8baab04293a1e271b47d21b703aa5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add a new command ``subnet pool unset`` to clear the information"},{"line_number":5,"context_line":"    of pool-prefixes from the subnet pools."},{"line_number":6,"context_line":"    [ Blueprint `network-property-unset \u003chttps://blueprints.launchpad.net/openstack/?searchtext\u003dnetwork-property-unset\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3aaa91ec_51a63dae","line":6,"range":{"start_line":6,"start_character":84,"end_line":6,"end_character":118},"updated":"2016-06-27 10:02:54.000000000","message":"A suggestion:\n\nplease use the direct URL instead of the search URL, because we couldn\u0027t link to the blueprint from search URL if the status of BP is complete.\n\nhttps://blueprints.launchpad.net/python-openstackclient/+spec/network-property-unset","commit_id":"3a9313ce22d03251673d8fdbcd6a23aedbe0640a"}]}