)]}'
{"id":"openstack%2Fpython-openstackclient~306291","triplet_id":"openstack%2Fpython-openstackclient~master~I288f71b412beb3e583e957a9fd99210bc6f3f543","project":"openstack/python-openstackclient","branch":"master","topic":"remove-methods-20160415","hashtags":[],"change_id":"I288f71b412beb3e583e957a9fd99210bc6f3f543","subject":"Remove methods argument from FakeHypervisorStats","status":"MERGED","created":"2016-04-15 08:26:30.000000000","updated":"2016-04-16 23:58:36.000000000","submitted":"2016-04-16 23:58:36.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3220c8188af1d1e24c935722afd2dd2d70e938bb","_number":306291,"virtual_id_number":306291,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-04-16 23:58:36.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-04-16 23:03:30.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":2,"date":"2016-04-16 12:02:19.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-04-16 23:03:30.000000000","_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-16 12:02:19.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-04-16 23:03:30.000000000","updated_by":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"reviewer":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"state":"REVIEWER"},{"updated":"2016-04-16 23:58:36.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d78e4a28e9b4b8f42d196d443aed6ee6ac85c4ee","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-04-15 08:26:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"56856ec8c886fc258aa9b8cffcd8e4d3f97fe5a8","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-04-15 08:30:20.000000000","message":"Patch Set 1:\n\nHi Richard,\n\nYou have pointed out \"methods\" is still used in class FakeHypervisorStats. I thought it is necessary to fake to_dict(). But it isn\u0027t actually. we don\u0027t need to set it as an argument. So sent this followup patch to remove it. I should have removed it in https://review.openstack.org/#/c/304402/.\n\nSorry for the miss.\n\nThanks.","accounts_in_message":[],"_revision_number":1},{"id":"cc213deabf28764660766baa12a3671a4a5ec714","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-04-15 11:04:03.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ff0084d40604372705cfb456125650b8408bc379","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-04-16 01:45:44.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5540fa508fbc9115060b2ff9062cab2d34a0724b","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-04-16 01:45:51.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"603643096b241c5d7c2fcbe07e6f924a6639820b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-16 02:55:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/91/306291/1/check/gate-python-openstackclient-docs/306646a//doc/build/html/ : SUCCESS in 3m 20s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/91/306291/1/check/gate-python-openstackclient-pep8/9b50cc8/ : SUCCESS in 1m 36s\n- gate-python-openstackclient-python27 http://logs.openstack.org/91/306291/1/check/gate-python-openstackclient-python27/ce4dcbf/ : SUCCESS in 1m 43s\n- gate-python-openstackclient-python34 http://logs.openstack.org/91/306291/1/check/gate-python-openstackclient-python34/db657e1/ : SUCCESS in 4m 33s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/91/306291/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/6e69ca6/ : SUCCESS in 1h 08m 12s\n- check-osc-plugins http://logs.openstack.org/91/306291/1/check/check-osc-plugins/978a03e/ : SUCCESS in 3m 53s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/91/306291/1/check/gate-osc-dsvm-functional/1af2ffe/ : SUCCESS in 26m 55s","accounts_in_message":[],"_revision_number":1},{"id":"ed7dbcc66988a8db69d5cab13c8e84a7780bced9","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-04-16 12:02:19.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b9aea67d8f44c83b1573bae147e2e7760784bbd9","author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"date":"2016-04-16 23:03:30.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\ngood call, if its unused might as well remove it less code to maintain","accounts_in_message":[],"_revision_number":1},{"id":"6de07043e2177ef163a683f09b352aa8c30162d8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-16 23:03:35.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"20e14e7a0ce18a7a8406ed80e3b49cf52db84cc0","date":"2016-04-16 23:58:36.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"8ef8b8b3b5438a3635812c6aa7b5477d6b61ab0a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-16 23:58:36.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/91/306291/1/gate/gate-python-openstackclient-docs/668b14a//doc/build/html/ : SUCCESS in 4m 21s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/91/306291/1/gate/gate-python-openstackclient-pep8/9815192/ : SUCCESS in 1m 37s\n- gate-python-openstackclient-python27 http://logs.openstack.org/91/306291/1/gate/gate-python-openstackclient-python27/1f21630/ : SUCCESS in 3m 49s\n- gate-python-openstackclient-python34 http://logs.openstack.org/91/306291/1/gate/gate-python-openstackclient-python34/8dc032d/ : SUCCESS in 4m 05s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/91/306291/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/8533392/ : SUCCESS in 55m 00s\n- gate-osc-dsvm-functional http://logs.openstack.org/91/306291/1/gate/gate-osc-dsvm-functional/2e0e2d6/ : SUCCESS in 23m 48s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"df3ee61be37fc4e841b7c20c4847d50cb1fc23fe","revisions":{"df3ee61be37fc4e841b7c20c4847d50cb1fc23fe":{"kind":"REWORK","_number":1,"created":"2016-04-15 08:26:30.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/91/306291/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/91/306291/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/306291/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/306291/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/306291/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/91/306291/1"}}},"commit":{"parents":[{"commit":"52a12e743ea1047b6c34cd66dcb60cd61638ce1f","subject":"Merge \"Add project options to security group rule create\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/52a12e743ea1047b6c34cd66dcb60cd61638ce1f"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-04-15 08:10:09.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-04-15 08:10:09.000000000","tz":480},"subject":"Remove methods argument from FakeHypervisorStats","message":"Remove methods argument from FakeHypervisorStats\n\nmethods argument is not necessary in FakeHypervisorStats class.\nRemove it.\n\nChange-Id: I288f71b412beb3e583e957a9fd99210bc6f3f543\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/df3ee61be37fc4e841b7c20c4847d50cb1fc23fe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/df3ee61be37fc4e841b7c20c4847d50cb1fc23fe"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}