)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"332fcd341688375348c0ceb47256ef3e9badfe51","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add VLAN Transparent option to ``osc network``"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"osc network set and network create now support"},{"line_number":10,"context_line":"--vlan-transparent|--non-vlan-transparent options"},{"line_number":11,"context_line":"to add/remove vlan transparency from the network."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I845eb8f541cd32a4c4b28f929a63b205e7e31756"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1a122d0e_329c0b69","line":10,"range":{"start_line":10,"start_character":19,"end_line":10,"end_character":24},"updated":"2016-04-22 12:50:58.000000000","message":"This is --no now.","commit_id":"f47db720bbc562c636b266e6949fff767f40c32a"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9dfee8554ea376e2aa5bebf7a5611e81936a4ce5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add VLAN Transparent option to ``osc network``"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"osc network set and network create now support"},{"line_number":10,"context_line":"--vlan-transparent|--non-vlan-transparent options"},{"line_number":11,"context_line":"to add/remove vlan transparency from the network."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I845eb8f541cd32a4c4b28f929a63b205e7e31756"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"dab17558_03c33558","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":41},"updated":"2016-05-16 07:44:56.000000000","message":"Should be --transparent-vlan and --no-transparent-vlan","commit_id":"43a9e6fbc3962a44e72f76bbc5a5a3e2eda66236"}],"doc/source/command-objects/network.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ebf58bbf87cf9116167685c6dc2c42199acdc6ed","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        [--vlan-transparent|--non-vlan-transparent]"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_0dd5e0e6","line":24,"range":{"start_line":24,"start_character":27,"end_line":24,"end_character":28},"updated":"2016-04-20 14:29:00.000000000","message":"Please add spaces around \"|\"","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ebf58bbf87cf9116167685c6dc2c42199acdc6ed","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        [--vlan-transparent|--non-vlan-transparent]"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_cde648e7","line":24,"range":{"start_line":24,"start_character":30,"end_line":24,"end_character":33},"updated":"2016-04-20 14:29:00.000000000","message":"This should be \"no\".","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0d47f5d12ec942541118ff672aed3e553c4e5d61","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        [--vlan-transparent|--non-vlan-transparent]"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_845c104c","line":24,"range":{"start_line":24,"start_character":27,"end_line":24,"end_character":28},"in_reply_to":"1a122d0e_0dd5e0e6","updated":"2016-04-21 00:24:00.000000000","message":"Done","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"efff06abbf4fbf1459b71168a91910aacf111145","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        [--vlan-transparent|--non-vlan-transparent]"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_445cb87c","line":24,"range":{"start_line":24,"start_character":30,"end_line":24,"end_character":33},"in_reply_to":"1a122d0e_cde648e7","updated":"2016-04-21 00:22:53.000000000","message":"I am not sure about \"no\"\nGrammatically it( --no-vlan-transparent ) doesnt make sense.\nIt should either be --non-vlan-transparent or no-vlan-transparency\n\nIf you agree I think we should discuss it if --no is absolutely required or can it be modulated to fit the grammar","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ebf58bbf87cf9116167685c6dc2c42199acdc6ed","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":189,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":190,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":191,"context_line":"        [--vlan-transparent|--non-vlan-transparent]"},{"line_number":192,"context_line":"        \u003cnetwork\u003e"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_4dc4f83e","line":191,"range":{"start_line":191,"start_character":27,"end_line":191,"end_character":28},"updated":"2016-04-20 14:29:00.000000000","message":"Please add spaces around \"|\"","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ebf58bbf87cf9116167685c6dc2c42199acdc6ed","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":189,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":190,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":191,"context_line":"        [--vlan-transparent|--non-vlan-transparent]"},{"line_number":192,"context_line":"        \u003cnetwork\u003e"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_ad84ac0a","line":191,"range":{"start_line":191,"start_character":30,"end_line":191,"end_character":33},"updated":"2016-04-20 14:29:00.000000000","message":"This should be \"no\"","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0d47f5d12ec942541118ff672aed3e553c4e5d61","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":189,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":190,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":191,"context_line":"        [--vlan-transparent|--non-vlan-transparent]"},{"line_number":192,"context_line":"        \u003cnetwork\u003e"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_04500031","line":191,"range":{"start_line":191,"start_character":27,"end_line":191,"end_character":28},"in_reply_to":"1a122d0e_4dc4f83e","updated":"2016-04-21 00:24:00.000000000","message":"Done","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ebf58bbf87cf9116167685c6dc2c42199acdc6ed","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    Make the network VLAN transparent"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    *Network version 2 only*"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":".. option:: --non-vlan-transparent"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_addf8c38","line":248,"range":{"start_line":248,"start_character":4,"end_line":248,"end_character":28},"updated":"2016-04-20 14:29:00.000000000","message":"Please remove.  This entire command is network v2 only.","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0d47f5d12ec942541118ff672aed3e553c4e5d61","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    Make the network VLAN transparent"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    *Network version 2 only*"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":".. option:: --non-vlan-transparent"},{"line_number":251,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_4446787b","line":248,"range":{"start_line":248,"start_character":4,"end_line":248,"end_character":28},"in_reply_to":"1a122d0e_addf8c38","updated":"2016-04-21 00:24:00.000000000","message":"Done","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ebf58bbf87cf9116167685c6dc2c42199acdc6ed","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    Do not make the network VLAN transparent"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    *Network version 2 only*"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":".. _network_set-network:"},{"line_number":257,"context_line":".. describe:: \u003cnetwork\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_0deb20e0","line":254,"range":{"start_line":254,"start_character":4,"end_line":254,"end_character":28},"updated":"2016-04-20 14:29:00.000000000","message":"Please remove.  This entire command is network v2 only.","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0d47f5d12ec942541118ff672aed3e553c4e5d61","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    Do not make the network VLAN transparent"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    *Network version 2 only*"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":".. _network_set-network:"},{"line_number":257,"context_line":".. describe:: \u003cnetwork\u003e"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_a4614c07","line":254,"range":{"start_line":254,"start_character":4,"end_line":254,"end_character":28},"in_reply_to":"1a122d0e_0deb20e0","updated":"2016-04-21 00:24:00.000000000","message":"Done","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"d6cf813ec01f195e26b6ba03543fc0519afde00b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        [--vlan-transparent| --non-vlan-transparent]"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_7b706e0b","line":24,"range":{"start_line":24,"start_character":27,"end_line":24,"end_character":29},"updated":"2016-04-21 01:41:05.000000000","message":"nit: lack left blank space","commit_id":"54fba3cd456e3782b8a58192799d0fc444b8f6e4"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"d6cf813ec01f195e26b6ba03543fc0519afde00b","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":189,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":190,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":191,"context_line":"        [--vlan-transparent| --non-vlan-transparent]"},{"line_number":192,"context_line":"        \u003cnetwork\u003e"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a122d0e_bb768603","line":191,"range":{"start_line":191,"start_character":27,"end_line":191,"end_character":29},"updated":"2016-04-21 01:41:05.000000000","message":"ditto","commit_id":"54fba3cd456e3782b8a58192799d0fc444b8f6e4"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"849c3ddd66bd7ce09585556eaffcbba90620226e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        [--vlan-transparent | --non-vlan-transparent]"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a122d0e_fad1eb30","line":24,"range":{"start_line":24,"start_character":32,"end_line":24,"end_character":35},"updated":"2016-04-21 18:30:54.000000000","message":"I read http://docs.openstack.org/developer/python-openstackclient/command-options.html and http://docs.openstack.org/developer/python-openstackclient/humaninterfaceguide.html as requiring \"no\" to be used or a naturally occurring pair of words.","commit_id":"6ed2a0dba9e4e0c041eaa39f3ad5fda76e957f75"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"41c3e34312e083b6647a1dae3a1dcbeda86f2887","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        [--vlan-transparent | --non-vlan-transparent]"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1a122d0e_b17b1929","line":24,"in_reply_to":"1a122d0e_fad1eb30","updated":"2016-04-21 19:29:09.000000000","message":"How about --transparent-vlan | --no-transparent-vlan\n\nor --opaque-vlan (no idea if that even means anything)\n\nThe rule regarding --no- for negative options is pretty clear, even when it knowingly is bad grammar/tense/whatever.","commit_id":"6ed2a0dba9e4e0c041eaa39f3ad5fda76e957f75"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"9dfee8554ea376e2aa5bebf7a5611e81936a4ce5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        [--provider-network-type \u003cprovider-network-type\u003e]"},{"line_number":22,"context_line":"        [--provider-physical-network \u003cprovider-physical-network\u003e]"},{"line_number":23,"context_line":"        [--provider-segment \u003cprovider-segment\u003e]"},{"line_number":24,"context_line":"        [--vlan-transparent | --no-transparent-vlan]"},{"line_number":25,"context_line":"        \u003cname\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --project \u003cproject\u003e"}],"source_content_type":"text/x-rst","patch_set":10,"id":"dab17558_23ef59ea","line":24,"range":{"start_line":24,"start_character":9,"end_line":24,"end_character":27},"updated":"2016-05-16 07:44:56.000000000","message":"Should be --transparent-vlan.","commit_id":"43a9e6fbc3962a44e72f76bbc5a5a3e2eda66236"}],"openstackclient/network/v2/network.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"22d3b9cb24d9bbf8ec02ef330bebea423967e9a6","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    # Update VLAN Transparency for networks"},{"line_number":97,"context_line":"    if parsed_args.vlan_transparent:"},{"line_number":98,"context_line":"        attrs[\u0027vlan_transparent\u0027] \u003d True"},{"line_number":99,"context_line":"    elif parsed_args.non_vlan_transparent:"},{"line_number":100,"context_line":"        attrs[\u0027vlan_transparent\u0027] \u003d False"},{"line_number":101,"context_line":"    return attrs"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_33cdb2b7","line":99,"range":{"start_line":99,"start_character":4,"end_line":99,"end_character":8},"updated":"2016-04-20 09:10:15.000000000","message":"nit: should be \"if\" for the boolean option.\n\nRef:\n\nhttp://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ebf58bbf87cf9116167685c6dc2c42199acdc6ed","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    # Update VLAN Transparency for networks"},{"line_number":97,"context_line":"    if parsed_args.vlan_transparent:"},{"line_number":98,"context_line":"        attrs[\u0027vlan_transparent\u0027] \u003d True"},{"line_number":99,"context_line":"    elif parsed_args.non_vlan_transparent:"},{"line_number":100,"context_line":"        attrs[\u0027vlan_transparent\u0027] \u003d False"},{"line_number":101,"context_line":"    return attrs"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_ed3d042c","line":99,"range":{"start_line":99,"start_character":4,"end_line":99,"end_character":8},"in_reply_to":"1a122d0e_33cdb2b7","updated":"2016-04-20 14:29:00.000000000","message":"+1","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"5759f992f7508eef61e02e48e91a989a4023509d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    # Update VLAN Transparency for networks"},{"line_number":97,"context_line":"    if parsed_args.vlan_transparent:"},{"line_number":98,"context_line":"        attrs[\u0027vlan_transparent\u0027] \u003d True"},{"line_number":99,"context_line":"    elif parsed_args.non_vlan_transparent:"},{"line_number":100,"context_line":"        attrs[\u0027vlan_transparent\u0027] \u003d False"},{"line_number":101,"context_line":"    return attrs"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_640bb47d","line":99,"range":{"start_line":99,"start_character":4,"end_line":99,"end_character":8},"in_reply_to":"1a122d0e_33cdb2b7","updated":"2016-04-21 00:17:33.000000000","message":"ok , I will fix it, but answer me this :)\n\nvlan_transparent and non_vlan_transparent both have an action \u0027store_true\u0027, right?\n\nIf user specifies any one option, that would be True.\nUser cannot specify both options because we have Mutually_exclusive_arguments\n\nSo , it means either vlan_transparent/non_vlan_transparent can be specified by user in one CLI.\nWhatever is specified would be True, and the other, due to the \u0027action\u003dstore_true\u0027 would be False as it is not specified.\n\nLogically , it means I can easily use elif here, isnt it?","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a0a9674b764abe646fed214b9d0b365cc7d260fb","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    # Update VLAN Transparency for networks"},{"line_number":97,"context_line":"    if parsed_args.vlan_transparent:"},{"line_number":98,"context_line":"        attrs[\u0027vlan_transparent\u0027] \u003d True"},{"line_number":99,"context_line":"    elif parsed_args.non_vlan_transparent:"},{"line_number":100,"context_line":"        attrs[\u0027vlan_transparent\u0027] \u003d False"},{"line_number":101,"context_line":"    return attrs"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_eed2fe5a","line":99,"range":{"start_line":99,"start_character":4,"end_line":99,"end_character":8},"in_reply_to":"1a122d0e_5b75b2c8","updated":"2016-04-21 01:56:13.000000000","message":"in the case of a mutex argument we can use if/elif, the devref is just a reference, it shouldn\u0027t dictate everything","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"e52e242daacb22d15db4d947e8cfdbbc46363f28","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    # Update VLAN Transparency for networks"},{"line_number":97,"context_line":"    if parsed_args.vlan_transparent:"},{"line_number":98,"context_line":"        attrs[\u0027vlan_transparent\u0027] \u003d True"},{"line_number":99,"context_line":"    elif parsed_args.non_vlan_transparent:"},{"line_number":100,"context_line":"        attrs[\u0027vlan_transparent\u0027] \u003d False"},{"line_number":101,"context_line":"    return attrs"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_7b7fce14","line":99,"range":{"start_line":99,"start_character":4,"end_line":99,"end_character":8},"in_reply_to":"1a122d0e_640bb47d","updated":"2016-04-21 01:42:48.000000000","message":"yep, \"elif\" is ok at here, but I think all the implement of boolean option should be consistent with developer document and each other, that make other developer less confusion, and consistent code reference.","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7361c38fc7421070bf5303d5030e42b890ee5f7d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    # Update VLAN Transparency for networks"},{"line_number":97,"context_line":"    if parsed_args.vlan_transparent:"},{"line_number":98,"context_line":"        attrs[\u0027vlan_transparent\u0027] \u003d True"},{"line_number":99,"context_line":"    elif parsed_args.non_vlan_transparent:"},{"line_number":100,"context_line":"        attrs[\u0027vlan_transparent\u0027] \u003d False"},{"line_number":101,"context_line":"    return attrs"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_5b75b2c8","line":99,"range":{"start_line":99,"start_character":4,"end_line":99,"end_character":8},"in_reply_to":"1a122d0e_7b7fce14","updated":"2016-04-21 01:49:05.000000000","message":"But thats what my point is, \nI agree devref is important, but it should not be so binding as to dictate if a developer should use if or elif\n\nThe point of the devref is that user can specify any or all of the options. And user can specify neither as well.\nWe need to handle all the cases.\nAnd if a logic is capable of handling all scenarios, then it can be used.\n\nBesides, I know this is a ridiculous point but I am saving one Machine Cycle :)\nI would like this point, however, to be noted from the devref point of view.","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"22d3b9cb24d9bbf8ec02ef330bebea423967e9a6","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def _add_additional_network_options(parser):"},{"line_number":105,"context_line":"    # Add provider network options"},{"line_number":106,"context_line":"    parser.add_argument("},{"line_number":107,"context_line":"        \u0027--provider-network-type\u0027,"},{"line_number":108,"context_line":"        metavar\u003d\u0027\u003cprovider-network-type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_081a057d","line":105,"range":{"start_line":105,"start_character":10,"end_line":105,"end_character":18},"updated":"2016-04-20 09:10:15.000000000","message":"nit: need to update","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"e52e242daacb22d15db4d947e8cfdbbc46363f28","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def _add_additional_network_options(parser):"},{"line_number":105,"context_line":"    # Add provider network options"},{"line_number":106,"context_line":"    parser.add_argument("},{"line_number":107,"context_line":"        \u0027--provider-network-type\u0027,"},{"line_number":108,"context_line":"        metavar\u003d\u0027\u003cprovider-network-type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_1b37ba4d","line":105,"range":{"start_line":105,"start_character":10,"end_line":105,"end_character":18},"in_reply_to":"1a122d0e_047f60e0","updated":"2016-04-21 01:42:48.000000000","message":"Hmmm, I don\u0027t know neutron much, not sure, that should be? :\n\n    # Add additional network options","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"efff06abbf4fbf1459b71168a91910aacf111145","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def _add_additional_network_options(parser):"},{"line_number":105,"context_line":"    # Add provider network options"},{"line_number":106,"context_line":"    parser.add_argument("},{"line_number":107,"context_line":"        \u0027--provider-network-type\u0027,"},{"line_number":108,"context_line":"        metavar\u003d\u0027\u003cprovider-network-type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_047f60e0","line":105,"range":{"start_line":105,"start_character":10,"end_line":105,"end_character":18},"in_reply_to":"1a122d0e_081a057d","updated":"2016-04-21 00:22:53.000000000","message":"Why?\nI am not sure what you mean, sorry ...","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7361c38fc7421070bf5303d5030e42b890ee5f7d","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def _add_additional_network_options(parser):"},{"line_number":105,"context_line":"    # Add provider network options"},{"line_number":106,"context_line":"    parser.add_argument("},{"line_number":107,"context_line":"        \u0027--provider-network-type\u0027,"},{"line_number":108,"context_line":"        metavar\u003d\u0027\u003cprovider-network-type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_3b43966d","line":105,"range":{"start_line":105,"start_character":10,"end_line":105,"end_character":18},"in_reply_to":"1a122d0e_1b37ba4d","updated":"2016-04-21 01:49:05.000000000","message":"oh ok, but this is not a docstring\nThis is a generic comment about what is followed.\nI can update it however and remove Line#126","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ebf58bbf87cf9116167685c6dc2c42199acdc6ed","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    vlan_transparent_grp.add_argument("},{"line_number":129,"context_line":"        \u0027--vlan-transparent\u0027,"},{"line_number":130,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":131,"context_line":"        help\u003d_(\"Create a vlan transparent network.\"))"},{"line_number":132,"context_line":"    vlan_transparent_grp.add_argument("},{"line_number":133,"context_line":"        \u0027--non-vlan-transparent\u0027,"},{"line_number":134,"context_line":"        action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_8d7c50ed","line":131,"range":{"start_line":131,"start_character":16,"end_line":131,"end_character":50},"updated":"2016-04-20 14:29:00.000000000","message":"This doesn\u0027t match the documentation and must apply to both create and set.","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0d47f5d12ec942541118ff672aed3e553c4e5d61","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    vlan_transparent_grp.add_argument("},{"line_number":129,"context_line":"        \u0027--vlan-transparent\u0027,"},{"line_number":130,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":131,"context_line":"        help\u003d_(\"Create a vlan transparent network.\"))"},{"line_number":132,"context_line":"    vlan_transparent_grp.add_argument("},{"line_number":133,"context_line":"        \u0027--non-vlan-transparent\u0027,"},{"line_number":134,"context_line":"        action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_e457c423","line":131,"range":{"start_line":131,"start_character":16,"end_line":131,"end_character":50},"in_reply_to":"1a122d0e_8d7c50ed","updated":"2016-04-21 00:24:00.000000000","message":"Done","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ebf58bbf87cf9116167685c6dc2c42199acdc6ed","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    vlan_transparent_grp.add_argument("},{"line_number":133,"context_line":"        \u0027--non-vlan-transparent\u0027,"},{"line_number":134,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":135,"context_line":"        help\u003d_(\"Do not create a vlan transparent network.\"))"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"def _get_attrs_compute(client_manager, parsed_args):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_ed6b441c","line":135,"range":{"start_line":135,"start_character":16,"end_line":135,"end_character":57},"updated":"2016-04-20 14:29:00.000000000","message":"This doesn\u0027t match the documentation and must apply to both create and set.","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0d47f5d12ec942541118ff672aed3e553c4e5d61","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    vlan_transparent_grp.add_argument("},{"line_number":133,"context_line":"        \u0027--non-vlan-transparent\u0027,"},{"line_number":134,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":135,"context_line":"        help\u003d_(\"Do not create a vlan transparent network.\"))"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"def _get_attrs_compute(client_manager, parsed_args):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_c4528834","line":135,"range":{"start_line":135,"start_character":16,"end_line":135,"end_character":57},"in_reply_to":"1a122d0e_ed6b441c","updated":"2016-04-21 00:24:00.000000000","message":"Done","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"}],"releasenotes/notes/add-vlan-transparent-option-4fa72fbfbbe3f31e.yaml":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ebf58bbf87cf9116167685c6dc2c42199acdc6ed","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``network create`` and ``network set`` now support "},{"line_number":5,"context_line":"    ``--vlan-transparent`` and ``--non-vlan-transparent``"},{"line_number":6,"context_line":"    options to add/remove Vlan transparency attributes"},{"line_number":7,"context_line":"    from networks."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a122d0e_cd592890","line":4,"updated":"2016-04-20 14:29:00.000000000","message":"nit, trailing blank space","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0d47f5d12ec942541118ff672aed3e553c4e5d61","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``network create`` and ``network set`` now support "},{"line_number":5,"context_line":"    ``--vlan-transparent`` and ``--non-vlan-transparent``"},{"line_number":6,"context_line":"    options to add/remove Vlan transparency attributes"},{"line_number":7,"context_line":"    from networks."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a122d0e_24341cfa","line":4,"in_reply_to":"1a122d0e_cd592890","updated":"2016-04-21 00:24:00.000000000","message":"Done","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ebf58bbf87cf9116167685c6dc2c42199acdc6ed","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    ``network create`` and ``network set`` now support "},{"line_number":5,"context_line":"    ``--vlan-transparent`` and ``--non-vlan-transparent``"},{"line_number":6,"context_line":"    options to add/remove Vlan transparency attributes"},{"line_number":7,"context_line":"    from networks."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a122d0e_4d4eb8c1","line":7,"updated":"2016-04-20 14:29:00.000000000","message":"Pleas add the bug link.","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0d47f5d12ec942541118ff672aed3e553c4e5d61","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    ``network create`` and ``network set`` now support "},{"line_number":5,"context_line":"    ``--vlan-transparent`` and ``--non-vlan-transparent``"},{"line_number":6,"context_line":"    options to add/remove Vlan transparency attributes"},{"line_number":7,"context_line":"    from networks."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a122d0e_643a94e8","line":7,"in_reply_to":"1a122d0e_4d4eb8c1","updated":"2016-04-21 00:24:00.000000000","message":"Forgot!","commit_id":"75ae2cdc435a585063b4bb5f60094dc0e96da219"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"332fcd341688375348c0ceb47256ef3e9badfe51","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``network create`` and ``network set`` now support"},{"line_number":5,"context_line":"    ``--vlan-transparent`` and ``--non-vlan-transparent``"},{"line_number":6,"context_line":"    options to add/remove Vlan transparency attributes"},{"line_number":7,"context_line":"    from networks."},{"line_number":8,"context_line":"    This option is available in Network V2 only."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a122d0e_92a07fa7","line":5,"range":{"start_line":5,"start_character":33,"end_line":5,"end_character":38},"updated":"2016-04-22 12:50:58.000000000","message":"This is --no now.","commit_id":"f47db720bbc562c636b266e6949fff767f40c32a"}]}