)]}'
{"doc/source/command-objects/address-scope.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"921d5cb21ca776029bc77cc76820f22301480e71","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"address scope"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Network v2"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"address scope create"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_097f22ab","line":4,"updated":"2016-05-07 12:19:31.000000000","message":"Please add a general description of address scope here.  See other commands for examples.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8dbbe554f7ccbfe3c20623d3ce8dd282c6790d4e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"address scope"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Network v2"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"address scope create"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_cb9cdb5f","line":4,"in_reply_to":"dab17558_097f22ab","updated":"2016-05-09 09:10:20.000000000","message":"Done.Thank you.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ff1f1ee87bddb30de96f44a4deaed9dce330bba2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"address scope"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Network v2"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"address scope create"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_380d0d91","line":4,"in_reply_to":"dab17558_097f22ab","updated":"2016-05-08 05:26:44.000000000","message":"something like:\n\nAn **address scope** is a ... that may be shared between projects.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8dbbe554f7ccbfe3c20623d3ce8dd282c6790d4e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"address scope"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Network v2"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"address scope create"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_cbb33be8","line":4,"in_reply_to":"dab17558_380d0d91","updated":"2016-05-09 09:10:20.000000000","message":"Thank you for your suggestion!","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ff1f1ee87bddb30de96f44a4deaed9dce330bba2","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    os address scope create"},{"line_number":16,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":17,"context_line":"        [--ip-version {4,6}]"},{"line_number":18,"context_line":"        [--share | --no-share]"},{"line_number":19,"context_line":"        \u003cname\u003e"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_f879c5fd","line":17,"range":{"start_line":17,"start_character":22,"end_line":17,"end_character":27},"updated":"2016-05-08 05:26:44.000000000","message":"we don\u0027t have a pattern for adding the \"choices\" in a the help text yet. for now you can write this as:\n\n  [-- ip-version \u003cip-version\u003e]","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"20519efb15c30e815d3ddc6c9c8f9a1fed386049","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    os address scope create"},{"line_number":16,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":17,"context_line":"        [--ip-version {4,6}]"},{"line_number":18,"context_line":"        [--share | --no-share]"},{"line_number":19,"context_line":"        \u003cname\u003e"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_3f20d7f6","line":17,"range":{"start_line":17,"start_character":22,"end_line":17,"end_character":27},"in_reply_to":"dab17558_17644f20","updated":"2016-05-11 05:42:05.000000000","message":"ah, i see that now... this is fine for now. i think we need to clean up all the help examples where \"choices\" are used.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a7025a676987c2d5ac329b2f5d100cdab6808eab","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    os address scope create"},{"line_number":16,"context_line":"        [--project \u003cproject\u003e [--project-domain \u003cproject-domain\u003e]]"},{"line_number":17,"context_line":"        [--ip-version {4,6}]"},{"line_number":18,"context_line":"        [--share | --no-share]"},{"line_number":19,"context_line":"        \u003cname\u003e"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_17644f20","line":17,"range":{"start_line":17,"start_character":22,"end_line":17,"end_character":27},"in_reply_to":"dab17558_f879c5fd","updated":"2016-05-09 03:52:18.000000000","message":"Hi,Steve,I saw there is a pattem for adding the \"choices\" in the subnet.rst,whether should I match the subnet commands?","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"921d5cb21ca776029bc77cc76820f22301480e71","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":".. option:: --ip-version {4,6}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"     IP version (4 or 6, default:4)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. option:: --share"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_8949528e","line":32,"range":{"start_line":32,"start_character":16,"end_line":32,"end_character":35},"updated":"2016-05-07 12:19:31.000000000","message":"Since the options are listed above, you could change this to \"(default is 4)\" to match the subnet command.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ff1f1ee87bddb30de96f44a4deaed9dce330bba2","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":".. option:: --ip-version {4,6}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"     IP version (4 or 6, default:4)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. option:: --share"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_d87cc1ed","line":32,"range":{"start_line":32,"start_character":16,"end_line":32,"end_character":35},"in_reply_to":"dab17558_8949528e","updated":"2016-05-08 05:26:44.000000000","message":"++\n\n  .. option:: -- ip-version \u003cip-version\u003e\n\n    IP version (defaults to 4)","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e8f0fee54f6099556b8e8898e724cb8fd0ce8dae","unresolved":false,"context_lines":[{"line_number":2,"context_line":"address scope"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"An **address scope** is a scope of IPv4 or IPv6 address that belongs to"},{"line_number":6,"context_line":"a given project and may be shared between projects."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Network v2"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_6b30419f","line":5,"range":{"start_line":5,"start_character":48,"end_line":5,"end_character":55},"updated":"2016-05-09 14:27:46.000000000","message":"addresses","commit_id":"6cd12845f54d6e590d20d2ba35402715070bb6b9"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"6eb7a4fd9173abfa50c76e774bd4f9bc3796459d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"address scope"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"An **address scope** is a scope of IPv4 or IPv6 address that belongs to"},{"line_number":6,"context_line":"a given project and may be shared between projects."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Network v2"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_5ef842c3","line":5,"range":{"start_line":5,"start_character":48,"end_line":5,"end_character":55},"in_reply_to":"dab17558_6b30419f","updated":"2016-05-11 02:09:14.000000000","message":"Done.Thank you.","commit_id":"6cd12845f54d6e590d20d2ba35402715070bb6b9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e8f0fee54f6099556b8e8898e724cb8fd0ce8dae","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. option:: --ip-version \u003cip-version\u003e"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    IP version (default is 4)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":".. option:: --share"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_cb104d04","line":35,"range":{"start_line":35,"start_character":15,"end_line":35,"end_character":29},"updated":"2016-05-09 14:27:46.000000000","message":"You\u0027ll need to document the choices too.","commit_id":"6cd12845f54d6e590d20d2ba35402715070bb6b9"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"55485cc7b13b7021789dbf7cb02238f5d54a9aad","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. option:: --ip-version \u003cip-version\u003e"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    IP version (default is 4)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":".. option:: --share"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_f57879f4","line":35,"range":{"start_line":35,"start_character":15,"end_line":35,"end_character":29},"in_reply_to":"dab17558_cb104d04","updated":"2016-05-10 11:33:02.000000000","message":"Like this?\n.. option:: --ip-version {4,6}\n\n    IP version (default is 4)\n\nOr this?\n.. option:: --ip-version \u003cip-version\u003e\n\n    IP version (4 or 6,default is 4)","commit_id":"6cd12845f54d6e590d20d2ba35402715070bb6b9"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"6eb7a4fd9173abfa50c76e774bd4f9bc3796459d","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. option:: --ip-version \u003cip-version\u003e"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    IP version (default is 4)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":".. option:: --share"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_3e245e5e","line":35,"range":{"start_line":35,"start_character":15,"end_line":35,"end_character":29},"in_reply_to":"dab17558_e971a777","updated":"2016-05-11 02:09:14.000000000","message":"Done.Thank you :)","commit_id":"6cd12845f54d6e590d20d2ba35402715070bb6b9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"a97dc88c4733dd82853c2a75141421b9bb16d690","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. option:: --ip-version \u003cip-version\u003e"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    IP version (default is 4)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":".. option:: --share"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_e971a777","line":35,"range":{"start_line":35,"start_character":15,"end_line":35,"end_character":29},"in_reply_to":"dab17558_f57879f4","updated":"2016-05-10 11:40:39.000000000","message":"I\u0027m okay with either, but you\u0027ll find that the second way is consistent with most options.\n\n\n.. option:: --ip-version \u003cip-version\u003e\n\n    IP version (4 or 6, default is 4)","commit_id":"6cd12845f54d6e590d20d2ba35402715070bb6b9"}],"doc/source/commands.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"921d5cb21ca776029bc77cc76820f22301480e71","unresolved":false,"context_lines":[{"line_number":70,"context_line":"referring to both Compute and Volume quotas."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* ``access token``: (**Identity**) long-lived OAuth-based token"},{"line_number":73,"context_line":"* ``address scope``: (**Network**) a scope of address"},{"line_number":74,"context_line":"* ``aggregate``: (**Compute**) a grouping of compute hosts"},{"line_number":75,"context_line":"* ``availability zone``: (**Compute**, **Network**, **Volume**) a logical partition of hosts or block storage or network services"},{"line_number":76,"context_line":"* ``backup``: (**Volume**) a volume copy"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_e95e1e44","line":73,"range":{"start_line":73,"start_character":35,"end_line":73,"end_character":53},"updated":"2016-05-07 12:19:31.000000000","message":"A little more details would be nice.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8dbbe554f7ccbfe3c20623d3ce8dd282c6790d4e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"referring to both Compute and Volume quotas."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* ``access token``: (**Identity**) long-lived OAuth-based token"},{"line_number":73,"context_line":"* ``address scope``: (**Network**) a scope of address"},{"line_number":74,"context_line":"* ``aggregate``: (**Compute**) a grouping of compute hosts"},{"line_number":75,"context_line":"* ``availability zone``: (**Compute**, **Network**, **Volume**) a logical partition of hosts or block storage or network services"},{"line_number":76,"context_line":"* ``backup``: (**Volume**) a volume copy"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_4b72ab4a","line":73,"range":{"start_line":73,"start_character":35,"end_line":73,"end_character":53},"in_reply_to":"dab17558_5869f124","updated":"2016-05-09 09:10:20.000000000","message":"yes,it seems a little bit complicated.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8dbbe554f7ccbfe3c20623d3ce8dd282c6790d4e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"referring to both Compute and Volume quotas."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* ``access token``: (**Identity**) long-lived OAuth-based token"},{"line_number":73,"context_line":"* ``address scope``: (**Network**) a scope of address"},{"line_number":74,"context_line":"* ``aggregate``: (**Compute**) a grouping of compute hosts"},{"line_number":75,"context_line":"* ``availability zone``: (**Compute**, **Network**, **Volume**) a logical partition of hosts or block storage or network services"},{"line_number":76,"context_line":"* ``backup``: (**Volume**) a volume copy"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_ebb43ff3","line":73,"range":{"start_line":73,"start_character":35,"end_line":73,"end_character":53},"in_reply_to":"dab17558_e95e1e44","updated":"2016-05-09 09:10:20.000000000","message":"I added the details about IP-version.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ff1f1ee87bddb30de96f44a4deaed9dce330bba2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"referring to both Compute and Volume quotas."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* ``access token``: (**Identity**) long-lived OAuth-based token"},{"line_number":73,"context_line":"* ``address scope``: (**Network**) a scope of address"},{"line_number":74,"context_line":"* ``aggregate``: (**Compute**) a grouping of compute hosts"},{"line_number":75,"context_line":"* ``availability zone``: (**Compute**, **Network**, **Volume**) a logical partition of hosts or block storage or network services"},{"line_number":76,"context_line":"* ``backup``: (**Volume**) a volume copy"}],"source_content_type":"text/x-rst","patch_set":2,"id":"dab17558_5869f124","line":73,"range":{"start_line":73,"start_character":35,"end_line":73,"end_character":53},"in_reply_to":"dab17558_e95e1e44","updated":"2016-05-08 05:26:44.000000000","message":"I looked up neutron docs about address scope and i can\u0027t think of a simple way to explain it :)","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e8f0fee54f6099556b8e8898e724cb8fd0ce8dae","unresolved":false,"context_lines":[{"line_number":70,"context_line":"referring to both Compute and Volume quotas."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* ``access token``: (**Identity**) long-lived OAuth-based token"},{"line_number":73,"context_line":"* ``address scope``: (**Network**) a scope of IPv4 or IPv6 address"},{"line_number":74,"context_line":"* ``aggregate``: (**Compute**) a grouping of compute hosts"},{"line_number":75,"context_line":"* ``availability zone``: (**Compute**, **Network**, **Volume**) a logical partition of hosts or block storage or network services"},{"line_number":76,"context_line":"* ``backup``: (**Volume**) a volume copy"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_ebf551cb","line":73,"range":{"start_line":73,"start_character":59,"end_line":73,"end_character":66},"updated":"2016-05-09 14:27:46.000000000","message":"addresses","commit_id":"6cd12845f54d6e590d20d2ba35402715070bb6b9"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"6eb7a4fd9173abfa50c76e774bd4f9bc3796459d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"referring to both Compute and Volume quotas."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* ``access token``: (**Identity**) long-lived OAuth-based token"},{"line_number":73,"context_line":"* ``address scope``: (**Network**) a scope of IPv4 or IPv6 address"},{"line_number":74,"context_line":"* ``aggregate``: (**Compute**) a grouping of compute hosts"},{"line_number":75,"context_line":"* ``availability zone``: (**Compute**, **Network**, **Volume**) a logical partition of hosts or block storage or network services"},{"line_number":76,"context_line":"* ``backup``: (**Volume**) a volume copy"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dab17558_7efb86c1","line":73,"range":{"start_line":73,"start_character":59,"end_line":73,"end_character":66},"in_reply_to":"dab17558_ebf551cb","updated":"2016-05-11 02:09:14.000000000","message":"Done.Thank you.","commit_id":"6cd12845f54d6e590d20d2ba35402715070bb6b9"}],"openstackclient/network/v2/address_scope.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cade4a44ed5a35bc660057c0ba762bc5fc398096","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\"\"\"Address scope action implementations\"\"\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from openstackclient.common import command"},{"line_number":17,"context_line":"from openstackclient.common import utils"},{"line_number":18,"context_line":"from openstackclient.identity import common as identity_common"},{"line_number":19,"context_line":"from openstackclient.common import exceptions"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_eb4ab526","line":16,"updated":"2016-04-22 01:58:51.000000000","message":"Change the order...\n\nfrom openstackclient.common import command\nfrom openstackclient.common import exceptions\nfrom openstackclient.common import utils\nfrom openstackclient.identity import common as identity_common","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c3e4c3210ff69245803117fe1407599cc8c187af","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def _get_attrs(client_manager, parsed_args):"},{"line_number":32,"context_line":"    attrs \u003d {}"},{"line_number":33,"context_line":"    if parsed_args.name is not None:"},{"line_number":34,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":35,"context_line":"    if \u0027ip_version\u0027 in parsed_args and parsed_args.ip_version is not None:"},{"line_number":36,"context_line":"        attrs[\u0027ip_version\u0027] \u003d parsed_args.ip_version"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f1ea0d0e","line":33,"updated":"2016-04-20 10:49:47.000000000","message":"if parsed_args: is sufficient\nparsed_args.name cannot be False or an empty list or dict\nAnd I think the entry in parsed_args would automatically be in string format so you dont need to type cast it","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"87e5cb3f209d6bb0f2c5a41199c28957d4b15c49","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def _get_attrs(client_manager, parsed_args):"},{"line_number":32,"context_line":"    attrs \u003d {}"},{"line_number":33,"context_line":"    if parsed_args.name is not None:"},{"line_number":34,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":35,"context_line":"    if \u0027ip_version\u0027 in parsed_args and parsed_args.ip_version is not None:"},{"line_number":36,"context_line":"        attrs[\u0027ip_version\u0027] \u003d parsed_args.ip_version"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_ab43016b","line":33,"in_reply_to":"1a122d0e_f1ea0d0e","updated":"2016-04-20 12:10:37.000000000","message":"Yes,there are some proprem here,thank you!I will change them right now.","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c3e4c3210ff69245803117fe1407599cc8c187af","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    attrs \u003d {}"},{"line_number":33,"context_line":"    if parsed_args.name is not None:"},{"line_number":34,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":35,"context_line":"    if \u0027ip_version\u0027 in parsed_args and parsed_args.ip_version is not None:"},{"line_number":36,"context_line":"        attrs[\u0027ip_version\u0027] \u003d parsed_args.ip_version"},{"line_number":37,"context_line":"    if \u0027share\u0027 in parsed_args and parsed_args.share:"},{"line_number":38,"context_line":"        attrs[\u0027shared\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b1e53539","line":35,"updated":"2016-04-20 10:49:47.000000000","message":"can ip_version ever be None?\nIt has a default value of 4.\nIt will always be in parsed_args and always have a value \nSo you can just remove the if condition","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"87e5cb3f209d6bb0f2c5a41199c28957d4b15c49","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    attrs \u003d {}"},{"line_number":33,"context_line":"    if parsed_args.name is not None:"},{"line_number":34,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":35,"context_line":"    if \u0027ip_version\u0027 in parsed_args and parsed_args.ip_version is not None:"},{"line_number":36,"context_line":"        attrs[\u0027ip_version\u0027] \u003d parsed_args.ip_version"},{"line_number":37,"context_line":"    if \u0027share\u0027 in parsed_args and parsed_args.share:"},{"line_number":38,"context_line":"        attrs[\u0027shared\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_6e073782","line":35,"in_reply_to":"1a122d0e_b1e53539","updated":"2016-04-20 12:10:37.000000000","message":"Thank you！ip_version can\u0027t None in this patch,but in other command like\"address scope set\",it use this function too and the ip_version is None,so I write the if condition to avoid error in other commands","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c3e4c3210ff69245803117fe1407599cc8c187af","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":35,"context_line":"    if \u0027ip_version\u0027 in parsed_args and parsed_args.ip_version is not None:"},{"line_number":36,"context_line":"        attrs[\u0027ip_version\u0027] \u003d parsed_args.ip_version"},{"line_number":37,"context_line":"    if \u0027share\u0027 in parsed_args and parsed_args.share:"},{"line_number":38,"context_line":"        attrs[\u0027shared\u0027] \u003d True"},{"line_number":39,"context_line":"    if \u0027no_share\u0027 in parsed_args and parsed_args.no_share:"},{"line_number":40,"context_line":"        attrs[\u0027shared\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_516781e8","line":37,"updated":"2016-04-20 10:49:47.000000000","message":"share and no_share would always be in parsed_args\n\nthey would either be  true or false. So you can change the if condition","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"87e5cb3f209d6bb0f2c5a41199c28957d4b15c49","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":35,"context_line":"    if \u0027ip_version\u0027 in parsed_args and parsed_args.ip_version is not None:"},{"line_number":36,"context_line":"        attrs[\u0027ip_version\u0027] \u003d parsed_args.ip_version"},{"line_number":37,"context_line":"    if \u0027share\u0027 in parsed_args and parsed_args.share:"},{"line_number":38,"context_line":"        attrs[\u0027shared\u0027] \u003d True"},{"line_number":39,"context_line":"    if \u0027no_share\u0027 in parsed_args and parsed_args.no_share:"},{"line_number":40,"context_line":"        attrs[\u0027shared\u0027] \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_3162c0d8","line":37,"in_reply_to":"1a122d0e_516781e8","updated":"2016-04-20 12:10:37.000000000","message":"Thank you!But \"share\" or \"no_share\" maybe None in other command like\"address scope set\",so I should write a if condition to aviod error in other commands.And you are right,they would either be true or false,so I will change the if condition and make it look better.Thank you a lot!","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"aa125dbc527d8ed78753f0d2d44e2b5a2fa7d346","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class CreateAddressScope(command.ShowOne):"},{"line_number":54,"context_line":"    \"\"\"Create a new Address Scope\"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def get_parser(self, prog_name):"},{"line_number":57,"context_line":"        parser \u003d super(CreateAddressScope, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_911e220a","line":54,"range":{"start_line":54,"start_character":7,"end_line":54,"end_character":33},"updated":"2016-04-20 16:39:00.000000000","message":"You are missing the new command documentation under doc/source/command-objects/ as well as updating doc/source/commands.rst to include the new object.","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"3ba499df0d26676cc6418f68ffd34b96b9acb38f","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class CreateAddressScope(command.ShowOne):"},{"line_number":54,"context_line":"    \"\"\"Create a new Address Scope\"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def get_parser(self, prog_name):"},{"line_number":57,"context_line":"        parser \u003d super(CreateAddressScope, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_480b0b2c","line":54,"range":{"start_line":54,"start_character":7,"end_line":54,"end_character":33},"in_reply_to":"1a122d0e_911e220a","updated":"2016-04-21 14:39:46.000000000","message":"Thank you for reminding!","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"aa125dbc527d8ed78753f0d2d44e2b5a2fa7d346","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        parser.add_argument("},{"line_number":59,"context_line":"            \u0027name\u0027,"},{"line_number":60,"context_line":"            metavar\u003d\"\u003cname\u003e\","},{"line_number":61,"context_line":"            help\u003d\"New address scope name\","},{"line_number":62,"context_line":"        )"},{"line_number":63,"context_line":"        parser.add_argument("},{"line_number":64,"context_line":"            \u0027--ip-version\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f102f6b2","line":61,"range":{"start_line":61,"start_character":12,"end_line":61,"end_character":41},"updated":"2016-04-20 16:39:00.000000000","message":"Help needs to be wrapped in _() for translation.  Please see other commands for examples.","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"3ba499df0d26676cc6418f68ffd34b96b9acb38f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        parser.add_argument("},{"line_number":59,"context_line":"            \u0027name\u0027,"},{"line_number":60,"context_line":"            metavar\u003d\"\u003cname\u003e\","},{"line_number":61,"context_line":"            help\u003d\"New address scope name\","},{"line_number":62,"context_line":"        )"},{"line_number":63,"context_line":"        parser.add_argument("},{"line_number":64,"context_line":"            \u0027--ip-version\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_3cf41086","line":61,"range":{"start_line":61,"start_character":12,"end_line":61,"end_character":41},"in_reply_to":"1a122d0e_f102f6b2","updated":"2016-04-21 14:39:46.000000000","message":"yes!Thank you!I had seen other commands and I will change them.","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c3e4c3210ff69245803117fe1407599cc8c187af","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        share_group.add_argument("},{"line_number":79,"context_line":"            \u0027--share\u0027,"},{"line_number":80,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":81,"context_line":"            default\u003dNone,"},{"line_number":82,"context_line":"            help\u003d\u0027Share the address scope between projects\u0027,"},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":"        share_group.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b149b562","line":81,"updated":"2016-04-20 10:49:47.000000000","message":"remove the default","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"87e5cb3f209d6bb0f2c5a41199c28957d4b15c49","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        share_group.add_argument("},{"line_number":79,"context_line":"            \u0027--share\u0027,"},{"line_number":80,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":81,"context_line":"            default\u003dNone,"},{"line_number":82,"context_line":"            help\u003d\u0027Share the address scope between projects\u0027,"},{"line_number":83,"context_line":"        )"},{"line_number":84,"context_line":"        share_group.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_31e76041","line":81,"in_reply_to":"1a122d0e_b149b562","updated":"2016-04-20 12:10:37.000000000","message":"Thank you!I will remove it.","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"aa125dbc527d8ed78753f0d2d44e2b5a2fa7d346","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def take_action(self, parsed_args):"},{"line_number":93,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":94,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            obj \u003d client.create_address_scope(**attrs)"},{"line_number":97,"context_line":"        except Exception as e:"},{"line_number":98,"context_line":"            msg \u003d \"Failed to create address scope: %s.\\n%s\" % ("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b1751e65","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":12},"updated":"2016-04-20 16:39:00.000000000","message":"I don\u0027t think this is necessary.","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"65b700c062b1a540f6d9c3243d3e40966a65f318","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def take_action(self, parsed_args):"},{"line_number":93,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":94,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            obj \u003d client.create_address_scope(**attrs)"},{"line_number":97,"context_line":"        except Exception as e:"},{"line_number":98,"context_line":"            msg \u003d \"Failed to create address scope: %s.\\n%s\" % ("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_ffc55d0a","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":12},"in_reply_to":"1a122d0e_52a2959b","updated":"2016-04-21 18:13:15.000000000","message":"In this case, I think it is redundant because the caller should see an error if create fails without this try/except block.  You can see other commands for examples.","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"3ba499df0d26676cc6418f68ffd34b96b9acb38f","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def take_action(self, parsed_args):"},{"line_number":93,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":94,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            obj \u003d client.create_address_scope(**attrs)"},{"line_number":97,"context_line":"        except Exception as e:"},{"line_number":98,"context_line":"            msg \u003d \"Failed to create address scope: %s.\\n%s\" % ("}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_52a2959b","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":12},"in_reply_to":"1a122d0e_b1751e65","updated":"2016-04-21 14:39:46.000000000","message":"The document doc/source/command-errors.rst says that we should catch exception in the code,so I write this.But maybe it is redundant,so I want to ask you whether should I write the catch exception?","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"921d5cb21ca776029bc77cc76820f22301480e71","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            type\u003dint,"},{"line_number":64,"context_line":"            default\u003d4,"},{"line_number":65,"context_line":"            choices\u003d[4, 6],"},{"line_number":66,"context_line":"            help\u003d_(\"Ip version (4 or 6, default: 4)\")"},{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--project\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_c95b5a53","line":66,"range":{"start_line":66,"start_character":20,"end_line":66,"end_character":51},"updated":"2016-05-07 12:19:31.000000000","message":"This needs to match the documentation.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8dbbe554f7ccbfe3c20623d3ce8dd282c6790d4e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            type\u003dint,"},{"line_number":64,"context_line":"            default\u003d4,"},{"line_number":65,"context_line":"            choices\u003d[4, 6],"},{"line_number":66,"context_line":"            help\u003d_(\"Ip version (4 or 6, default: 4)\")"},{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--project\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_2b21274e","line":66,"range":{"start_line":66,"start_character":20,"end_line":66,"end_character":51},"in_reply_to":"dab17558_c95b5a53","updated":"2016-05-09 09:10:20.000000000","message":"Done.Thank you.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"921d5cb21ca776029bc77cc76820f22301480e71","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        share_group.add_argument("},{"line_number":82,"context_line":"            \u0027--no-share\u0027,"},{"line_number":83,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":84,"context_line":"            help\u003d_(\u0027Do not share the address scope between projects (Default)\u0027)"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_2959465b","line":84,"range":{"start_line":84,"start_character":20,"end_line":84,"end_character":77},"updated":"2016-05-07 12:19:31.000000000","message":"The documentation needs to match this.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8dbbe554f7ccbfe3c20623d3ce8dd282c6790d4e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        share_group.add_argument("},{"line_number":82,"context_line":"            \u0027--no-share\u0027,"},{"line_number":83,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":84,"context_line":"            help\u003d_(\u0027Do not share the address scope between projects (Default)\u0027)"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_6b1b2f1c","line":84,"range":{"start_line":84,"start_character":20,"end_line":84,"end_character":77},"in_reply_to":"dab17558_2959465b","updated":"2016-05-09 09:10:20.000000000","message":"Done.Thank you.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e8f0fee54f6099556b8e8898e724cb8fd0ce8dae","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            type\u003dint,"},{"line_number":64,"context_line":"            default\u003d4,"},{"line_number":65,"context_line":"            choices\u003d[4, 6],"},{"line_number":66,"context_line":"            help\u003d_(\"Ip version (default is 4)\")"},{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--project\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_2bee39ec","line":66,"range":{"start_line":66,"start_character":20,"end_line":66,"end_character":22},"updated":"2016-05-09 14:27:46.000000000","message":"IP","commit_id":"6cd12845f54d6e590d20d2ba35402715070bb6b9"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"6eb7a4fd9173abfa50c76e774bd4f9bc3796459d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            type\u003dint,"},{"line_number":64,"context_line":"            default\u003d4,"},{"line_number":65,"context_line":"            choices\u003d[4, 6],"},{"line_number":66,"context_line":"            help\u003d_(\"Ip version (default is 4)\")"},{"line_number":67,"context_line":"        )"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--project\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_de0b92d4","line":66,"range":{"start_line":66,"start_character":20,"end_line":66,"end_character":22},"in_reply_to":"dab17558_2bee39ec","updated":"2016-05-11 02:09:14.000000000","message":"Done.Thank you.","commit_id":"6cd12845f54d6e590d20d2ba35402715070bb6b9"}],"openstackclient/tests/network/v2/test_address_scope.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cade4a44ed5a35bc660057c0ba762bc5fc398096","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#   under the License."},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"import mock"},{"line_number":15,"context_line":"import copy"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from openstackclient.network.v2 import address_scope"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_6b5d05ec","line":14,"updated":"2016-04-22 01:58:51.000000000","message":"pep8 complains, change the order:\n\n import copy\n import mock\n\n from openstackclient.common import exceptions\n from openstackclient.network.v2 import address_scope\n from openstackclient.tests import fakes\n from openstackclient.tests import utils as tests_utils\n from openstackclient.tests.identity.v3 import fakes as identity_fakes_v3\n from openstackclient.tests.network.v2 import fakes as network_fakes","commit_id":"208548c7eae8701e2af79b0dedd42f221776f429"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"921d5cb21ca776029bc77cc76820f22301480e71","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        self.assertEqual(self.data, data)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_create_all_options(self):"},{"line_number":118,"context_line":"        arglist \u003d ["},{"line_number":119,"context_line":"            self.new_address_scope.name,"},{"line_number":120,"context_line":"            \"--share\","},{"line_number":121,"context_line":"            \"--project\", identity_fakes_v3.project_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_e9257ec2","line":118,"range":{"start_line":118,"start_character":8,"end_line":118,"end_character":15},"updated":"2016-05-07 12:19:31.000000000","message":"Missing --ip-version in this test.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8dbbe554f7ccbfe3c20623d3ce8dd282c6790d4e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        self.assertEqual(self.data, data)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_create_all_options(self):"},{"line_number":118,"context_line":"        arglist \u003d ["},{"line_number":119,"context_line":"            self.new_address_scope.name,"},{"line_number":120,"context_line":"            \"--share\","},{"line_number":121,"context_line":"            \"--project\", identity_fakes_v3.project_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_cb121b09","line":118,"range":{"start_line":118,"start_character":8,"end_line":118,"end_character":15},"in_reply_to":"dab17558_e9257ec2","updated":"2016-05-09 09:10:20.000000000","message":"Done.Thank you.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"921d5cb21ca776029bc77cc76820f22301480e71","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_create_all_options(self):"},{"line_number":118,"context_line":"        arglist \u003d ["},{"line_number":119,"context_line":"            self.new_address_scope.name,"},{"line_number":120,"context_line":"            \"--share\","},{"line_number":121,"context_line":"            \"--project\", identity_fakes_v3.project_name,"},{"line_number":122,"context_line":"            \"--project-domain\", identity_fakes_v3.domain_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_89403258","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":39},"updated":"2016-05-07 12:19:31.000000000","message":"Positional parameters are usually after options.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8dbbe554f7ccbfe3c20623d3ce8dd282c6790d4e","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_create_all_options(self):"},{"line_number":118,"context_line":"        arglist \u003d ["},{"line_number":119,"context_line":"            self.new_address_scope.name,"},{"line_number":120,"context_line":"            \"--share\","},{"line_number":121,"context_line":"            \"--project\", identity_fakes_v3.project_name,"},{"line_number":122,"context_line":"            \"--project-domain\", identity_fakes_v3.domain_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_ab2cf74a","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":39},"in_reply_to":"dab17558_89403258","updated":"2016-05-09 09:10:20.000000000","message":"Done.Thank you.","commit_id":"01f61ec60654dd509e96d3b62f459aea54438499"}]}