)]}'
{"openstackclient/common/parseractions.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"54adada6e6b98266037c0fba53c6c6ecf6ad3086","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    \"\"\""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def __call__(self, parser, namespace, values, option_string\u003dNone):"},{"line_number":158,"context_line":"        if int(values) \u003e\u003d 0:"},{"line_number":159,"context_line":"            setattr(namespace, self.dest, values)"},{"line_number":160,"context_line":"        else:"},{"line_number":161,"context_line":"            msg \u003d \"%s expected a non-negative integer\" % (str(option_string))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_d5d07d21","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":28},"updated":"2016-04-28 20:51:12.000000000","message":"won\u0027t this fail if the value is non-int? unless your thinking is that the parser\u0027s int check will already fail that?\n\nthere are 2 instances of NonNegativeAction should should probably specify an int is needed: https://github.com/openstack/python-openstackclient/blob/a0a29df3e67b29880e62e1974dde18a4993f2aa1/openstackclient/network/v2/subnet_pool.py#L93 and lines 99 and 105","commit_id":"0daaa2a42c1663e241179a614bbf54c3f34fe0d3"},{"author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"change_message_id":"c4fe366c5f16f921de5abe00845cffbb36ad02d8","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    \"\"\""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def __call__(self, parser, namespace, values, option_string\u003dNone):"},{"line_number":158,"context_line":"        if int(values) \u003e\u003d 0:"},{"line_number":159,"context_line":"            setattr(namespace, self.dest, values)"},{"line_number":160,"context_line":"        else:"},{"line_number":161,"context_line":"            msg \u003d \"%s expected a non-negative integer\" % (str(option_string))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_cfc2a933","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":28},"in_reply_to":"1a122d0e_d5d07d21","updated":"2016-04-28 23:04:28.000000000","message":"i have to admit that i don\u0027t fully understand the wide usage of this function, but if the input is not sanitized to begin with i could certainly re-add the try/except clause and just remove the assert, if that is a preferable solution?","commit_id":"0daaa2a42c1663e241179a614bbf54c3f34fe0d3"}],"openstackclient/tests/network/v2/test_subnet_pool.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d2fd1e52aa8d78e3f903eeada45de45046039296","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            \u0027--min-prefix-length\u0027, self._subnet_pool.min_prefixlen,"},{"line_number":141,"context_line":"            self._subnet_pool.name,"},{"line_number":142,"context_line":"        ]"},{"line_number":143,"context_line":"        verifylist \u003d ["},{"line_number":144,"context_line":"            (\u0027default_prefix_length\u0027,"},{"line_number":145,"context_line":"                int(self._subnet_pool.default_prefixlen)),"},{"line_number":146,"context_line":"            (\u0027max_prefix_length\u0027, int(self._subnet_pool.max_prefixlen)),"},{"line_number":147,"context_line":"            (\u0027min_prefix_length\u0027, int(self._subnet_pool.min_prefixlen)),"},{"line_number":148,"context_line":"            (\u0027name\u0027, self._subnet_pool.name),"},{"line_number":149,"context_line":"        ]"},{"line_number":150,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        columns, data \u003d (self.cmd.take_action(parsed_args))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        self.network.create_subnet_pool.assert_called_once_with(**{"},{"line_number":155,"context_line":"            \u0027default_prefixlen\u0027: int(self._subnet_pool.default_prefixlen),"},{"line_number":156,"context_line":"            \u0027max_prefixlen\u0027: int(self._subnet_pool.max_prefixlen),"},{"line_number":157,"context_line":"            \u0027min_prefixlen\u0027: int(self._subnet_pool.min_prefixlen),"},{"line_number":158,"context_line":"            \u0027prefixes\u0027: [],"},{"line_number":159,"context_line":"            \u0027name\u0027: self._subnet_pool.name,"},{"line_number":160,"context_line":"        })"},{"line_number":161,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":162,"context_line":"        self.assertEqual(self.data, data)"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_e00cbd94","line":160,"range":{"start_line":143,"start_character":8,"end_line":160,"end_character":10},"updated":"2016-04-29 18:10:38.000000000","message":"i think instead of adding \"int()\" to these, you can change https://github.com/openstack/python-openstackclient/blob/master/openstackclient/tests/network/v2/fakes.py#L679-L685 instead, and just drop the single quotes.","commit_id":"140abfc82344a270b3c06d709bd2aec3f827daae"}]}