)]}'
{"id":"openstack%2Fpython-openstackclient~310891","triplet_id":"openstack%2Fpython-openstackclient~master~I093e7440b8beff4f179e2c4ed81daff82704c40e","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1576375","hashtags":[],"change_id":"I093e7440b8beff4f179e2c4ed81daff82704c40e","subject":"remove assert in favor an if/else","status":"MERGED","created":"2016-04-28 19:17:31.000000000","updated":"2016-05-02 22:21:46.000000000","submitted":"2016-05-02 22:21:46.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ae4b2eac4d456ce7ee3f089142eb821e3c57b91c","_number":310891,"virtual_id_number":310891,"owner":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-05-02 22:21:46.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-05-02 20:19:46.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},{"value":2,"date":"2016-05-02 21:16:15.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},{"value":1,"date":"2016-05-02 21:16:15.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-29 18:13:32.000000000","updated_by":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"reviewer":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"state":"REVIEWER"},{"updated":"2016-05-02 20:19:46.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-05-02 21:16:15.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-05-02 22:21:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f253fbe9706d9a50bc6fced162818ae6feb60009","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2016-04-28 19:17:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3bd5d49eb682f0c2a7214fc16a704408bfc7c14f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-28 20:24:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/91/310891/1/check/gate-python-openstackclient-docs/52beace//doc/build/html/ : SUCCESS in 3m 39s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/91/310891/1/check/gate-python-openstackclient-pep8/47d1ef9/ : SUCCESS in 2m 18s\n- gate-python-openstackclient-python27 http://logs.openstack.org/91/310891/1/check/gate-python-openstackclient-python27/dd7301b/ : SUCCESS in 2m 50s\n- gate-python-openstackclient-python34 http://logs.openstack.org/91/310891/1/check/gate-python-openstackclient-python34/1cb1310/ : SUCCESS in 4m 08s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/91/310891/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/8faa5f4/ : SUCCESS in 1h 06m 13s\n- check-osc-plugins http://logs.openstack.org/91/310891/1/check/check-osc-plugins/d30dbf4/ : SUCCESS in 3m 21s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/91/310891/1/check/gate-osc-dsvm-functional/211130f/ : SUCCESS in 31m 38s","accounts_in_message":[],"_revision_number":1},{"id":"54adada6e6b98266037c0fba53c6c6ecf6ad3086","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-04-28 20:51:12.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c4fe366c5f16f921de5abe00845cffbb36ad02d8","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2016-04-28 23:04:28.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nthanks for the review Steve, i could use a little advice on the best solution to this. in general though, i agree with your assessment.","accounts_in_message":[],"_revision_number":1},{"id":"7d2ff0b0949c4ab5608d196d2128fd744158a999","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-04-29 03:59:50.000000000","message":"Patch Set 1:\n\n@michael, sure, i think if you also add type\u003dint to the sections i mentioned, to sanitize the input, this change should be just fine.","accounts_in_message":[],"_revision_number":1},{"id":"e83265c4f2cb0d4f0c17b7c9440757e6dc147f0c","author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"date":"2016-04-29 06:39:07.000000000","message":"Patch Set 1: Code-Review-1\n\nAgree with steve\u0027s suggestion.\nPlease add type\u003dint as shown below:\n\n    parser.add_argument(\n        \u0027--default-prefix-length\u0027,\n        metavar\u003d\u0027\u003cdefault-prefix-length\u003e\u0027,\n        type\u003dint,     \u003c----------------------\n        action\u003dparseractions.NonNegativeAction,\n        help\u003d_(\"Set subnet pool default prefix length\")\n    )","accounts_in_message":[],"_revision_number":1},{"id":"27db42bde3e6092bdab6c156fc125d52e1ae83b5","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2016-04-29 15:00:20.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b3c5f344722d6d742a3293a494bf372c4b6f773b","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2016-04-29 15:10:51.000000000","message":"Patch Set 2: Workflow-1\n\nSteve and Sheel, thank you for the suggestions.\n\nit looks like adding the type\u003dint to the parsers is causing issues with other tests. i am investigating fixing those tests.","accounts_in_message":[],"_revision_number":2},{"id":"f8d344a2793c33db4d7c5bee331b37e73c876e92","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2016-04-29 15:35:58.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6f52f8a70553e79d3ebb8dededaac75ca817938c","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2016-04-29 15:37:35.000000000","message":"Patch Set 2:\n\nok, fixed the testing issues. thanks again Steve and Sheel!","accounts_in_message":[],"_revision_number":2},{"id":"517259406699c843a7b3fa2da2336a393c2858c4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-29 16:28:14.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/91/310891/3/check/gate-python-openstackclient-docs/bc24cd1//doc/build/html/ : SUCCESS in 2m 16s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/91/310891/3/check/gate-python-openstackclient-pep8/591997a/ : SUCCESS in 1m 47s\n- gate-python-openstackclient-python27 http://logs.openstack.org/91/310891/3/check/gate-python-openstackclient-python27/a1adc48/ : SUCCESS in 2m 28s\n- gate-python-openstackclient-python34 http://logs.openstack.org/91/310891/3/check/gate-python-openstackclient-python34/56cf8ac/ : SUCCESS in 2m 36s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/91/310891/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/692fada/ : SUCCESS in 51m 07s\n- check-osc-plugins http://logs.openstack.org/91/310891/3/check/check-osc-plugins/a4b5314/ : SUCCESS in 4m 21s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/91/310891/3/check/gate-osc-dsvm-functional/1923a7c/ : SUCCESS in 23m 49s","accounts_in_message":[],"_revision_number":3},{"id":"d2fd1e52aa8d78e3f903eeada45de45046039296","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-04-29 18:10:38.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)\n\nthis works, just one suggestion, sorry this is turning into an onion-peeling exercise","accounts_in_message":[],"_revision_number":3},{"id":"3076eb6a8a83502ebf4d03634f30c81cccde98ef","author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"date":"2016-04-29 18:13:32.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"155eac1e2238b8ca40c2ad38c80c7efba8e85f23","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2016-04-29 19:56:17.000000000","message":"Patch Set 3:\n\n@Steve i tried that initially but it created some much deeper issues in the openstackclient.tests.utils module. i tried to deep dive into these issues, but honestly this code base is a little new to these eyes and i had trouble resolving the errors.\n\nwrapping the expected output in \"int()\" seemed the path of least resistance. that being said, i\u0027d be happy to go the other route if someone could help me figure out the parser issues. it has something to do with python\u0027s argparse module receiving strings instead of ints, and i\u0027m not sure if this has to do with the way the openstackclient test utils file handles the interface.","accounts_in_message":[],"_revision_number":3},{"id":"aa73a69e34312f16abc0bac99d5635fedd8dc29d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-02 16:38:37.000000000","message":"Patch Set 3: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"c0fe3c01990b9f8ccf0352ca16a8e934d821b2da","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2016-05-02 19:11:54.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"17064feff8e4eb24d68b0a6e13567dc8b920a631","author":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"date":"2016-05-02 19:13:07.000000000","message":"Patch Set 4:\n\nrebased","accounts_in_message":[],"_revision_number":4},{"id":"215ed2f33d6fc19134f589b4a33a1fcecb097e15","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-02 20:18:43.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/91/310891/4/check/gate-python-openstackclient-docs/6b4992e//doc/build/html/ : SUCCESS in 3m 28s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/91/310891/4/check/gate-python-openstackclient-pep8/c9a45a7/ : SUCCESS in 1m 42s\n- gate-python-openstackclient-python27 http://logs.openstack.org/91/310891/4/check/gate-python-openstackclient-python27/7888404/ : SUCCESS in 2m 26s\n- gate-python-openstackclient-python34 http://logs.openstack.org/91/310891/4/check/gate-python-openstackclient-python34/4e4e50a/ : SUCCESS in 4m 27s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/91/310891/4/check/gate-tempest-dsvm-neutron-src-python-openstackclient/47d5802/ : SUCCESS in 1h 04m 49s\n- check-osc-plugins http://logs.openstack.org/91/310891/4/check/check-osc-plugins/e6a0403/ : SUCCESS in 3m 59s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/91/310891/4/check/gate-osc-dsvm-functional/ee072b9/ : SUCCESS in 36m 23s","accounts_in_message":[],"_revision_number":4},{"id":"d95b4b1ee8f9e48278c1436f1636e5ecfed0a7b3","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-05-02 20:19:46.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"86db1daf017880eacef8b77280dbd3f23d5fcbe2","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-05-02 21:16:15.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"0bcfc1e99eda3e49ab6525d2bc05b7a82a36c860","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-02 21:16:21.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"b9aa84eaec712073fd6db2c0e24f75687c505412","date":"2016-05-02 22:21:46.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":4},{"id":"e2e11df057b3b7f150b9ce48e60bb17be21b4114","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-02 22:21:46.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/91/310891/4/gate/gate-python-openstackclient-docs/1d632ac//doc/build/html/ : SUCCESS in 3m 37s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/91/310891/4/gate/gate-python-openstackclient-pep8/0fffa82/ : SUCCESS in 7m 01s\n- gate-python-openstackclient-python27 http://logs.openstack.org/91/310891/4/gate/gate-python-openstackclient-python27/997ee6d/ : SUCCESS in 3m 08s\n- gate-python-openstackclient-python34 http://logs.openstack.org/91/310891/4/gate/gate-python-openstackclient-python34/06f9247/ : SUCCESS in 10m 01s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/91/310891/4/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/42e20ee/ : SUCCESS in 1h 04m 33s\n- gate-osc-dsvm-functional http://logs.openstack.org/91/310891/4/gate/gate-osc-dsvm-functional/549d4a1/ : SUCCESS in 34m 24s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"b33ee3daf6eebc74fb176b1f2d8018e0e2214377","revisions":{"0daaa2a42c1663e241179a614bbf54c3f34fe0d3":{"kind":"REWORK","_number":1,"created":"2016-04-28 19:17:31.000000000","uploader":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"ref":"refs/changes/91/310891/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/91/310891/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/1"}}},"commit":{"parents":[{"commit":"f1d14de6da5d0f61e34f9e6841e965439c85d629","subject":"Merge \"Doc: Add network resource descriptions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f1d14de6da5d0f61e34f9e6841e965439c85d629"}]}],"author":{"name":"Michael McCune","email":"msm@redhat.com","date":"2016-04-28 19:15:57.000000000","tz":-240},"committer":{"name":"Michael McCune","email":"msm@redhat.com","date":"2016-04-28 19:15:57.000000000","tz":-240},"subject":"remove assert in favor an if/else","message":"remove assert in favor an if/else\n\nthe assert usage in the NonNegativeAction has the potential to allow\nunexpected behavior when the python is byte-compiled with optimization\nturned on.\n\nChange-Id: I093e7440b8beff4f179e2c4ed81daff82704c40e\nCloses-Bug: #1576375\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0daaa2a42c1663e241179a614bbf54c3f34fe0d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0daaa2a42c1663e241179a614bbf54c3f34fe0d3"}]},"branch":"refs/heads/master"},"7aa00c2401b62417648f670308022f0111f2cc42":{"kind":"REWORK","_number":2,"created":"2016-04-29 15:00:20.000000000","uploader":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"ref":"refs/changes/91/310891/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/91/310891/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/2"}}},"commit":{"parents":[{"commit":"f1d14de6da5d0f61e34f9e6841e965439c85d629","subject":"Merge \"Doc: Add network resource descriptions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f1d14de6da5d0f61e34f9e6841e965439c85d629"}]}],"author":{"name":"Michael McCune","email":"msm@redhat.com","date":"2016-04-28 19:15:57.000000000","tz":-240},"committer":{"name":"Michael McCune","email":"msm@redhat.com","date":"2016-04-29 14:59:14.000000000","tz":-240},"subject":"remove assert in favor an if/else","message":"remove assert in favor an if/else\n\nthe assert usage in the NonNegativeAction has the potential to allow\nunexpected behavior when the python is byte-compiled with optimization\nturned on.\n\nChanges\n* remove assert in favor of if/else in NonNegativeAction class\n* add type specifier to parser arguments for non-negative actions\n\nChange-Id: I093e7440b8beff4f179e2c4ed81daff82704c40e\nCloses-Bug: #1576375\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7aa00c2401b62417648f670308022f0111f2cc42"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/7aa00c2401b62417648f670308022f0111f2cc42"}]},"branch":"refs/heads/master"},"140abfc82344a270b3c06d709bd2aec3f827daae":{"kind":"REWORK","_number":3,"created":"2016-04-29 15:35:58.000000000","uploader":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"ref":"refs/changes/91/310891/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/91/310891/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/3"}}},"commit":{"parents":[{"commit":"f1d14de6da5d0f61e34f9e6841e965439c85d629","subject":"Merge \"Doc: Add network resource descriptions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f1d14de6da5d0f61e34f9e6841e965439c85d629"}]}],"author":{"name":"Michael McCune","email":"msm@redhat.com","date":"2016-04-28 19:15:57.000000000","tz":-240},"committer":{"name":"Michael McCune","email":"msm@redhat.com","date":"2016-04-29 15:35:40.000000000","tz":-240},"subject":"remove assert in favor an if/else","message":"remove assert in favor an if/else\n\nthe assert usage in the NonNegativeAction has the potential to allow\nunexpected behavior when the python is byte-compiled with optimization\nturned on.\n\nChanges\n* remove assert in favor of if/else in NonNegativeAction class\n* add type specifier to parser arguments for non-negative actions\n* correct tests for new int based values\n\nChange-Id: I093e7440b8beff4f179e2c4ed81daff82704c40e\nCloses-Bug: #1576375\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/140abfc82344a270b3c06d709bd2aec3f827daae"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/140abfc82344a270b3c06d709bd2aec3f827daae"}]},"branch":"refs/heads/master"},"b33ee3daf6eebc74fb176b1f2d8018e0e2214377":{"kind":"REWORK","_number":4,"created":"2016-05-02 19:11:54.000000000","uploader":{"_account_id":10670,"name":"Michael McCune","email":"elmiko@redhat.com","username":"mimccune"},"ref":"refs/changes/91/310891/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/91/310891/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/91/310891/4"}}},"commit":{"parents":[{"commit":"9d7ccd9385776c8c0edf90094b8ef323ef1890a6","subject":"Merge \"Fixes BadRequest when no --pool-prefix given\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9d7ccd9385776c8c0edf90094b8ef323ef1890a6"}]}],"author":{"name":"Michael McCune","email":"msm@redhat.com","date":"2016-04-28 19:15:57.000000000","tz":-240},"committer":{"name":"Michael McCune","email":"msm@redhat.com","date":"2016-05-02 19:11:45.000000000","tz":-240},"subject":"remove assert in favor an if/else","message":"remove assert in favor an if/else\n\nthe assert usage in the NonNegativeAction has the potential to allow\nunexpected behavior when the python is byte-compiled with optimization\nturned on.\n\nChanges\n* remove assert in favor of if/else in NonNegativeAction class\n* add type specifier to parser arguments for non-negative actions\n* correct tests for new int based values\n\nChange-Id: I093e7440b8beff4f179e2c4ed81daff82704c40e\nCloses-Bug: #1576375\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b33ee3daf6eebc74fb176b1f2d8018e0e2214377"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/b33ee3daf6eebc74fb176b1f2d8018e0e2214377"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}