)]}'
{"id":"openstack%2Fpython-openstackclient~311700","triplet_id":"openstack%2Fpython-openstackclient~master~I4a4ed7b0a2f522ee04d1c3270afcda7064285c39","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1575478","hashtags":[],"change_id":"I4a4ed7b0a2f522ee04d1c3270afcda7064285c39","subject":"Make \"flavor show\" command to show a private flavor properly","status":"MERGED","created":"2016-05-02 09:01:25.000000000","updated":"2016-05-06 14:07:54.000000000","submitted":"2016-05-06 14:07:54.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f86cc047a85d84dfd5f1bf726e420063fb702d72","_number":311700,"virtual_id_number":311700,"owner":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-05-06 14:07:54.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-05-03 06:23:36.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-05-06 10:49:57.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-05-06 10:49:57.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-03 06:23:36.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-05-06 10:49:57.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2016-05-06 14:07:54.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"19d35a1923252c28c31d17f8f519c28f1835c43a","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-05-02 09:01:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9660a503548721eafb294da38b71dd86a9d43b20","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-02 10:02:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/00/311700/1/check/gate-python-openstackclient-docs/3dd2250//doc/build/html/ : SUCCESS in 3m 24s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/00/311700/1/check/gate-python-openstackclient-pep8/dd6a0ae/ : SUCCESS in 2m 18s\n- gate-python-openstackclient-python27 http://logs.openstack.org/00/311700/1/check/gate-python-openstackclient-python27/2b53e69/ : SUCCESS in 2m 44s\n- gate-python-openstackclient-python34 http://logs.openstack.org/00/311700/1/check/gate-python-openstackclient-python34/7672a9f/ : SUCCESS in 2m 36s\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/00/311700/1/check/gate-python-openstackclient-releasenotes/686fe9f//releasenotes/build/html/ : SUCCESS in 2m 46s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/00/311700/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/0dff8d8/ : SUCCESS in 1h 00m 32s\n- check-osc-plugins http://logs.openstack.org/00/311700/1/check/check-osc-plugins/3990aaf/ : SUCCESS in 3m 07s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/00/311700/1/check/gate-osc-dsvm-functional/c6fbe1a/ : SUCCESS in 24m 21s","accounts_in_message":[],"_revision_number":1},{"id":"af16d98ad227e0d2a09bfbb4fe6fd5e4884cbe07","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-05-03 06:23:36.000000000","message":"Patch Set 1: Code-Review+2\n\ncould use a test showing is_public\u003dFalse\n\notherwise, this is a good fix, and shows that sometimes we need to not use find_resource","accounts_in_message":[],"_revision_number":1},{"id":"c2b95f216c1a139ba745001a29ffe5b9606fed85","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-05-06 10:49:57.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e8f5b162b74ccb3698508fdf20b0741685091086","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-06 11:46:01.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"de53f3ada075e731063b6b40d1e4e46822077138","date":"2016-05-06 14:07:54.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"de84aebdd48a617d2017ff3f67d4a67201399de6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-06 14:07:54.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/00/311700/1/gate/gate-python-openstackclient-docs/86296d4//doc/build/html/ : SUCCESS in 4m 09s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/00/311700/1/gate/gate-python-openstackclient-pep8/65eab1c/ : SUCCESS in 3m 12s\n- gate-python-openstackclient-python27 http://logs.openstack.org/00/311700/1/gate/gate-python-openstackclient-python27/486bc8d/ : SUCCESS in 3m 52s\n- gate-python-openstackclient-python34 http://logs.openstack.org/00/311700/1/gate/gate-python-openstackclient-python34/e7d1247/ : SUCCESS in 3m 16s\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/00/311700/1/gate/gate-python-openstackclient-releasenotes/5cb1eb8//releasenotes/build/html/ : SUCCESS in 2m 10s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/00/311700/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/227213b/ : SUCCESS in 53m 27s\n- gate-osc-dsvm-functional http://logs.openstack.org/00/311700/1/gate/gate-osc-dsvm-functional/3788ffa/ : SUCCESS in 32m 28s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"681d6dc2de83ef13b4fb2fb4abe70f3c1ccb0e10","revisions":{"681d6dc2de83ef13b4fb2fb4abe70f3c1ccb0e10":{"kind":"REWORK","_number":1,"created":"2016-05-02 09:01:25.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/00/311700/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/00/311700/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/00/311700/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/00/311700/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/00/311700/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/00/311700/1"}}},"commit":{"parents":[{"commit":"9ec41c0397dbcf818513efd9bc92ad488b66ceca","subject":"Replace tempest-lib with tempest.lib","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9ec41c0397dbcf818513efd9bc92ad488b66ceca"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-05-02 08:30:29.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-05-02 08:47:53.000000000","tz":480},"subject":"Make \"flavor show\" command to show a private flavor properly","message":"Make \"flavor show\" command to show a private flavor properly\n\nThe \"flavor show\" command could not show a\nprivate flavor by flavor name becauce it could\nnot find a private flavor by flavor name.\nIn \"until.find_resource(parsed_args.flavor)\",\nIf parsed_args.falvor is a name of a flavor,\n\"flavors.find(name\u003dparsed_args.flavor)\"will be\ncalled to find a flavor.But the default value of\n\"is_public\" is \"Ture\" in \"flavors.find()\" so that\nwe can only find public flavors.If we want to find\nall flaovrs by flavor name,we should add\n\"is_public\u003dNone\" in \"flavors.find()\".\n\nSo I tried to change\n\"until.find_resource(parsed_args.flavor)\" to\n\"until.find_resource(parsed_args.flavor, is_public\u003dNone)\",\nbut then I could not find any flavor by flavor id\nbecause \"is_public\" is an unexpected argument of\n\"flavors.get()\" in \"until.find_resource()\".\n\nIn this case,I think \"until.find_resource()\"\ncan not find a private flavor properly,and\nwe should combine \"manager.get(flavor.id)\" and\n\"manager.find(name\u003dflavor.name, is_public\u003dNone)\"\nby ourselve to find a flavor.\n\nAlso,this bug affects other flavor commands like\n\"flavor set/unset/delete\",so I fix them in this patch too.\n\nChange-Id: I4a4ed7b0a2f522ee04d1c3270afcda7064285c39\nCloses-Bug: #1575478\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/681d6dc2de83ef13b4fb2fb4abe70f3c1ccb0e10"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/681d6dc2de83ef13b4fb2fb4abe70f3c1ccb0e10"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}