)]}'
{"id":"openstack%2Fpython-openstackclient~313522","triplet_id":"openstack%2Fpython-openstackclient~master~I031395f2c882386c7a708db5cf4eee75393dc639","project":"openstack/python-openstackclient","branch":"master","topic":"trivial-20160506","hashtags":[],"change_id":"I031395f2c882386c7a708db5cf4eee75393dc639","subject":"Trivial: Remove unuseful comments for assertRaise() checking","status":"MERGED","created":"2016-05-06 12:00:06.000000000","updated":"2016-05-07 11:35:05.000000000","submitted":"2016-05-07 11:35:04.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cbdb2cfbf0e5616839197e7dd3a768659d482a36","_number":313522,"virtual_id_number":313522,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-05-07 11:35:04.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-05-06 16:05:46.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-05-06 12:19:46.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":1,"date":"2016-05-07 06:40:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2016-05-06 16:05:46.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-06 12:19:46.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-05-06 16:05:46.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-05-07 06:40:39.000000000","updated_by":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"reviewer":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"state":"REVIEWER"},{"updated":"2016-05-07 11:35:04.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4a38a73881e439113888feec88ca2ea8aa5debb2","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-05-06 12:00:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d6ca6f15d4ac2ad69b28c45cfde6b5305d064b2e","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-05-06 12:19:46.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f77428535f79e54cda53ca2f493e3ecb90e2bc03","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-05-06 16:05:46.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"99ea2a59e876c42c07bb62c18a44b4f80d67b497","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-05-07 06:34:03.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"8dda09d8ca0c73c7af682b92ab2a31429e78e811","author":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"date":"2016-05-07 06:40:39.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"da6ca0cc9eab9355dd39e93161c9a74faea38144","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-07 07:25:24.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/22/313522/1/check/gate-python-openstackclient-docs/79c5d1c//doc/build/html/ : SUCCESS in 2m 05s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/22/313522/1/check/gate-python-openstackclient-pep8/a6c4cd4/ : SUCCESS in 3m 35s\n- gate-python-openstackclient-python27 http://logs.openstack.org/22/313522/1/check/gate-python-openstackclient-python27/6f3e1b1/ : SUCCESS in 2m 28s\n- gate-python-openstackclient-python34 http://logs.openstack.org/22/313522/1/check/gate-python-openstackclient-python34/0932d68/ : SUCCESS in 4m 11s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/22/313522/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/a6c80e2/ : FAILURE in 51m 13s\n- check-osc-plugins http://logs.openstack.org/22/313522/1/check/check-osc-plugins/f4b83f4/ : SUCCESS in 4m 03s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/22/313522/1/check/gate-osc-dsvm-functional/74f29d3/ : SUCCESS in 36m 54s","accounts_in_message":[],"_revision_number":1},{"id":"d20bc6bab4c7bb7959d3c70be66187a613a24afe","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-05-07 07:47:34.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"92ffebed915e3db725a73fbcfad9275d3b06ea5b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-07 08:45:21.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/22/313522/1/check/gate-python-openstackclient-docs/ef84dbd//doc/build/html/ : SUCCESS in 3m 24s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/22/313522/1/check/gate-python-openstackclient-pep8/adc0d2c/ : SUCCESS in 2m 26s\n- gate-python-openstackclient-python27 http://logs.openstack.org/22/313522/1/check/gate-python-openstackclient-python27/053f8e9/ : SUCCESS in 2m 41s\n- gate-python-openstackclient-python34 http://logs.openstack.org/22/313522/1/check/gate-python-openstackclient-python34/be83182/ : SUCCESS in 3m 23s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/22/313522/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/41a370d/ : SUCCESS in 57m 40s\n- check-osc-plugins http://logs.openstack.org/22/313522/1/check/check-osc-plugins/78ccbf7/ : SUCCESS in 3m 12s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/22/313522/1/check/gate-osc-dsvm-functional/15b237a/ : FAILURE in 34m 00s","accounts_in_message":[],"_revision_number":1},{"id":"3cb9ea447acfef884ec346b3478d0dfd40e734d0","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-05-07 09:31:27.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"d336384682c44db64f4e4e7b2f7b66797f41d95c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-07 10:34:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/22/313522/1/check/gate-python-openstackclient-docs/3b264c6//doc/build/html/ : SUCCESS in 3m 05s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/22/313522/1/check/gate-python-openstackclient-pep8/2535290/ : SUCCESS in 2m 14s\n- gate-python-openstackclient-python27 http://logs.openstack.org/22/313522/1/check/gate-python-openstackclient-python27/b204b63/ : SUCCESS in 2m 17s\n- gate-python-openstackclient-python34 http://logs.openstack.org/22/313522/1/check/gate-python-openstackclient-python34/058634f/ : SUCCESS in 3m 10s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/22/313522/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/726785e/ : SUCCESS in 1h 02m 19s\n- check-osc-plugins http://logs.openstack.org/22/313522/1/check/check-osc-plugins/4ad40d1/ : SUCCESS in 2m 51s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/22/313522/1/check/gate-osc-dsvm-functional/3ecc573/ : SUCCESS in 31m 50s","accounts_in_message":[],"_revision_number":1},{"id":"c204467811e13a571b9b96c95f0289ab74254016","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-07 10:35:02.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"5c5ef6587c3a459a8bc8fb5255af8460d53ce6b1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-07 11:35:04.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/22/313522/1/gate/gate-python-openstackclient-docs/6a5c17e//doc/build/html/ : SUCCESS in 3m 15s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/22/313522/1/gate/gate-python-openstackclient-pep8/8faa169/ : SUCCESS in 2m 20s\n- gate-python-openstackclient-python27 http://logs.openstack.org/22/313522/1/gate/gate-python-openstackclient-python27/85255cc/ : SUCCESS in 3m 11s\n- gate-python-openstackclient-python34 http://logs.openstack.org/22/313522/1/gate/gate-python-openstackclient-python34/288a404/ : SUCCESS in 3m 20s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/22/313522/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/d576ed9/ : SUCCESS in 1h 00m 01s\n- gate-osc-dsvm-functional http://logs.openstack.org/22/313522/1/gate/gate-osc-dsvm-functional/8d4e1ae/ : SUCCESS in 33m 18s","accounts_in_message":[],"_revision_number":1},{"id":"f9fe05e2aced3f7e9b1257862f98a0513af7d567","date":"2016-05-07 11:35:05.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"15c9576817c5925ebf89835a2c35b7b7524d4e57","revisions":{"15c9576817c5925ebf89835a2c35b7b7524d4e57":{"kind":"REWORK","_number":1,"created":"2016-05-06 12:00:06.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/22/313522/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/22/313522/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/313522/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/313522/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/22/313522/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/22/313522/1"}}},"commit":{"parents":[{"commit":"5df18843b7aeb2f9254f55e4127c44d6fbf66efb","subject":"Merge \"Ignore domain related config when using with keystone v2\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5df18843b7aeb2f9254f55e4127c44d6fbf66efb"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-05-06 11:55:50.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-05-06 11:55:50.000000000","tz":480},"subject":"Trivial: Remove unuseful comments for assertRaise() checking","message":"Trivial: Remove unuseful comments for assertRaise() checking\n\n\"Missing required args should bail here\" is not understandable\nand not necessary. The code is obvious enough. And some of the\ncomments are misused because of code copy. So remove them.\n\nChange-Id: I031395f2c882386c7a708db5cf4eee75393dc639\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/15c9576817c5925ebf89835a2c35b7b7524d4e57"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/15c9576817c5925ebf89835a2c35b7b7524d4e57"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}