)]}'
{"id":"openstack%2Fpython-openstackclient~313997","triplet_id":"openstack%2Fpython-openstackclient~master~I8d79afc5f341fb5caf771d905506b7f1c7a41ae8","project":"openstack/python-openstackclient","branch":"master","topic":"no-findall-20160509","hashtags":[],"change_id":"I8d79afc5f341fb5caf771d905506b7f1c7a41ae8","subject":"Use find_resource() instead of get() in _prep_server_detail()","status":"MERGED","created":"2016-05-09 07:03:17.000000000","updated":"2016-05-11 13:26:30.000000000","submitted":"2016-05-11 13:26:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4d779b417b9ad8c2705eda019ec543499b0eff15","_number":313997,"virtual_id_number":313997,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-05-11 13:26:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-05-11 06:32:19.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-05-11 12:21:17.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-05-11 12:21:19.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-11 06:32:19.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-05-11 12:21:19.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-05-11 13:26:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a766af2380f479cfce6695290b4f5cde775aad5b","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-05-09 07:03:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"31fbce450dac4fed665dfe093a28f36e9d06c1a3","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-05-09 07:28:30.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a919902cbcf661d8baf60e41a60edf8e1d2818a7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-09 08:25:23.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/97/313997/2/check/gate-python-openstackclient-docs/e7aea94//doc/build/html/ : SUCCESS in 3m 21s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/97/313997/2/check/gate-python-openstackclient-pep8/bcae9de/ : SUCCESS in 2m 41s\n- gate-python-openstackclient-python27 http://logs.openstack.org/97/313997/2/check/gate-python-openstackclient-python27/9b7d9b7/ : SUCCESS in 2m 29s\n- gate-python-openstackclient-python34 http://logs.openstack.org/97/313997/2/check/gate-python-openstackclient-python34/2cdef02/ : SUCCESS in 3m 21s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/97/313997/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/5aea487/ : SUCCESS in 56m 46s\n- check-osc-plugins http://logs.openstack.org/97/313997/2/check/check-osc-plugins/1407451/ : SUCCESS in 3m 05s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/97/313997/2/check/gate-osc-dsvm-functional/7b0583c/ : SUCCESS in 33m 02s","accounts_in_message":[],"_revision_number":2},{"id":"0c6688e87628dd10366e76d8b14c39087833c550","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-05-09 12:29:47.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b348698f7cb7c9e255beeca14ab61f30b038505f","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-05-10 02:50:06.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"762de564c889525fd97c02896e2172f888dbbc91","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-05-10 11:28:44.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e15c58e076e968925bb5b1998a5e58415834a1ce","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-05-11 02:47:15.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"aebec78321963d47f9c2bc963fc1259edc3f5103","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-05-11 06:32:19.000000000","message":"Patch Set 2: Code-Review+2\n\n++ for using find_resources when applicable","accounts_in_message":[],"_revision_number":2},{"id":"c5e5343c92c939b9b780ab5def69e47ebda3e7ae","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-05-11 12:21:17.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks Tang.","accounts_in_message":[],"_revision_number":2},{"id":"159b4c9bbcaa0b906c9d8f079540a294d25ea1b9","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-05-11 12:21:19.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"9a9dcf83bd62b8b6c593583bdb44e9a3fbcdf701","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-11 12:26:24.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"06e47d6d68b7a6916f95686d25cbab625ad67ce9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-11 13:26:29.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/97/313997/2/gate/gate-python-openstackclient-docs/caab999//doc/build/html/ : SUCCESS in 5m 29s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/97/313997/2/gate/gate-python-openstackclient-pep8/649e6b0/ : SUCCESS in 2m 26s\n- gate-python-openstackclient-python27 http://logs.openstack.org/97/313997/2/gate/gate-python-openstackclient-python27/e470143/ : SUCCESS in 2m 26s\n- gate-python-openstackclient-python34 http://logs.openstack.org/97/313997/2/gate/gate-python-openstackclient-python34/ef150bd/ : SUCCESS in 2m 33s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/97/313997/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/d8033f1/ : SUCCESS in 58m 51s\n- gate-osc-dsvm-functional http://logs.openstack.org/97/313997/2/gate/gate-osc-dsvm-functional/8b02a0c/ : SUCCESS in 27m 51s","accounts_in_message":[],"_revision_number":2},{"id":"bd2c61d5aee5f58aded9582a138b0d89314c5349","date":"2016-05-11 13:26:30.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d58280a27989ab781cbf2598a6f7c263cb2275e8","revisions":{"84f7c2165c411445506ebc1db8182b31eeafea6c":{"kind":"REWORK","_number":1,"created":"2016-05-09 07:03:17.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/97/313997/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/97/313997/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/97/313997/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/97/313997/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/97/313997/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/97/313997/1"}}},"commit":{"parents":[{"commit":"4cd702c3610e4e6b40695ff9ea8eecf7c0735c68","subject":"Merge \"Fix functional test failures\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4cd702c3610e4e6b40695ff9ea8eecf7c0735c68"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-05-09 06:59:39.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-05-09 06:59:39.000000000","tz":480},"subject":"Use find_resource() instead of get() in _prep_server_detail()","message":"Use find_resource() instead of get() in _prep_server_detail()\n\nThere is such a comment in test_server.py:\n\n    # Call .get() to retrieve all of the server information\n    # as findall(name\u003dblah) and REST /details are not the same\n    # and do not return flavor and image information.\n\nThis is an out of date comment. There is no function named\nfindall() in OSC now. So use find_resource() instead of get(),\nand remove this comment.\n\nChange-Id: I8d79afc5f341fb5caf771d905506b7f1c7a41ae8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/84f7c2165c411445506ebc1db8182b31eeafea6c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/84f7c2165c411445506ebc1db8182b31eeafea6c"}]},"branch":"refs/heads/master"},"d58280a27989ab781cbf2598a6f7c263cb2275e8":{"kind":"REWORK","_number":2,"created":"2016-05-09 07:28:30.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/97/313997/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/97/313997/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/97/313997/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/97/313997/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/97/313997/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/97/313997/2"}}},"commit":{"parents":[{"commit":"4cd702c3610e4e6b40695ff9ea8eecf7c0735c68","subject":"Merge \"Fix functional test failures\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/4cd702c3610e4e6b40695ff9ea8eecf7c0735c68"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-05-09 06:59:39.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-05-09 06:59:39.000000000","tz":480},"subject":"Use find_resource() instead of get() in _prep_server_detail()","message":"Use find_resource() instead of get() in _prep_server_detail()\n\nThere is such a comment in test_server.py:\n\n    # Call .get() to retrieve all of the server information\n    # as findall(name\u003dblah) and REST /details are not the same\n    # and do not return flavor and image information.\n\nThis is an out of date comment. There is no function named\nfindall() in OSC now. So use find_resource() instead of get(),\nand remove this comment.\n\nChange-Id: I8d79afc5f341fb5caf771d905506b7f1c7a41ae8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d58280a27989ab781cbf2598a6f7c263cb2275e8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d58280a27989ab781cbf2598a6f7c263cb2275e8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}