)]}'
{"id":"openstack%2Fpython-openstackclient~315344","triplet_id":"openstack%2Fpython-openstackclient~master~I98ad520f32afd529fda77a4592f645130282537f","project":"openstack/python-openstackclient","branch":"master","topic":"bp/improve-volume-unittest-framework","hashtags":[],"change_id":"I98ad520f32afd529fda77a4592f645130282537f","subject":"Refactor TestVolumeShow with FakeVolume","status":"MERGED","created":"2016-05-12 04:46:54.000000000","updated":"2016-05-24 23:30:56.000000000","submitted":"2016-05-24 23:30:56.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e723ca280bafe81ee8d64e23cce386134fdfbf80","_number":315344,"virtual_id_number":315344,"owner":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":2,"date":"2016-05-24 23:30:56.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"recommended":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"all":[{"value":1,"date":"2016-05-20 11:52:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-05-24 02:40:08.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":2,"date":"2016-05-24 22:40:44.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":1,"date":"2016-05-24 22:40:44.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-20 11:52:07.000000000","updated_by":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"reviewer":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"state":"REVIEWER"},{"updated":"2016-05-24 02:40:08.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2016-05-24 22:40:44.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-05-24 23:30:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"841af293f9ff3d5b27c314b415653f04a13f64b1","author":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"date":"2016-05-12 04:46:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"723635c1384124f45dcaacf341668918fd289e58","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-12 05:38:53.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/44/315344/1/check/gate-python-openstackclient-docs/7ef5c9c//doc/build/html/ : SUCCESS in 2m 04s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/44/315344/1/check/gate-python-openstackclient-pep8/c029702/ : SUCCESS in 2m 56s\n- gate-python-openstackclient-python27 http://logs.openstack.org/44/315344/1/check/gate-python-openstackclient-python27/f8f1dc7/ : SUCCESS in 2m 24s\n- gate-python-openstackclient-python34 http://logs.openstack.org/44/315344/1/check/gate-python-openstackclient-python34/72bc1b0/ : SUCCESS in 3m 43s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/44/315344/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/2f91885/ : FAILURE in 51m 49s\n- check-osc-plugins http://logs.openstack.org/44/315344/1/check/check-osc-plugins/a9cb232/ : SUCCESS in 7m 20s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/44/315344/1/check/gate-osc-dsvm-functional/19ad0f8/ : SUCCESS in 34m 24s","accounts_in_message":[],"_revision_number":1},{"id":"0c99d0553abab1616334ef2f36aee68727861830","author":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"date":"2016-05-12 05:41:23.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"150cda495045a85be051c2ad4cdccf3617c06e62","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-12 06:49:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/44/315344/1/check/gate-python-openstackclient-docs/80ea4f8//doc/build/html/ : SUCCESS in 3m 24s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/44/315344/1/check/gate-python-openstackclient-pep8/7b9c889/ : SUCCESS in 2m 24s\n- gate-python-openstackclient-python27 http://logs.openstack.org/44/315344/1/check/gate-python-openstackclient-python27/5aec2f3/ : SUCCESS in 2m 33s\n- gate-python-openstackclient-python34 http://logs.openstack.org/44/315344/1/check/gate-python-openstackclient-python34/e2a45e1/ : SUCCESS in 3m 40s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/44/315344/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/4bead7a/ : SUCCESS in 1h 03m 45s\n- check-osc-plugins http://logs.openstack.org/44/315344/1/check/check-osc-plugins/bade3a5/ : SUCCESS in 3m 05s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/44/315344/1/check/gate-osc-dsvm-functional/e9db8f9/ : SUCCESS in 36m 26s","accounts_in_message":[],"_revision_number":1},{"id":"e38e94130d309672d885d648e1ed80edf105fd4f","author":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"date":"2016-05-17 12:22:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"557932a3ea8a757fa2a6ffe1c063ae4265a4b943","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-17 15:16:36.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/44/315344/2/check/gate-python-openstackclient-docs/9626bd6//doc/build/html/ : SUCCESS in 4m 37s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/44/315344/2/check/gate-python-openstackclient-pep8/d186cb7/ : SUCCESS in 3m 19s\n- gate-python-openstackclient-python27 http://logs.openstack.org/44/315344/2/check/gate-python-openstackclient-python27/937ef71/ : SUCCESS in 2m 23s\n- gate-python-openstackclient-python34 http://logs.openstack.org/44/315344/2/check/gate-python-openstackclient-python34/7d8be0f/ : SUCCESS in 4m 17s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/44/315344/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/f4f7703/ : SUCCESS in 1h 03m 20s\n- check-osc-plugins http://logs.openstack.org/44/315344/2/check/check-osc-plugins/a6306cb/ : SUCCESS in 2m 48s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/44/315344/2/check/gate-osc-dsvm-functional/298d8de/ : SUCCESS in 37m 10s","accounts_in_message":[],"_revision_number":2},{"id":"cc942382029928924842371a50068d95d02afc67","author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"date":"2016-05-20 11:52:07.000000000","message":"Patch Set 2: Code-Review+1\n\nHi, wang,\nThanks for your nice patch, LGTM.","accounts_in_message":[],"_revision_number":2},{"id":"908436b3aed0cd35146dae14c55e7f7b0a48248a","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-05-24 02:40:08.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"63c19ee1e567c2923d76f60091ec0e0581e97f4f","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-05-24 22:40:44.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"a7441018f9b9f99945d9c76cf452f1ae6ff07a3e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-24 22:40:50.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"3b3990bc5e4565c1c2e595aaa56e9a5b806f977d","date":"2016-05-24 23:30:56.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"08c0c60164c530d7b6fa3f51762a5e4a0258dd9e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-24 23:30:56.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/44/315344/2/gate/gate-python-openstackclient-docs/aebaae6//doc/build/html/ : SUCCESS in 5m 08s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/44/315344/2/gate/gate-python-openstackclient-pep8/f7e4fef/ : SUCCESS in 3m 01s\n- gate-python-openstackclient-python27 http://logs.openstack.org/44/315344/2/gate/gate-python-openstackclient-python27/e2be491/ : SUCCESS in 3m 20s\n- gate-python-openstackclient-python34 http://logs.openstack.org/44/315344/2/gate/gate-python-openstackclient-python34/5bce458/ : SUCCESS in 4m 33s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/44/315344/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/fd586e9/ : SUCCESS in 47m 19s\n- gate-osc-dsvm-functional http://logs.openstack.org/44/315344/2/gate/gate-osc-dsvm-functional/881bbf9/ : SUCCESS in 31m 29s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"0fa2e8df92986bf7cbbba131042c1d3196b54365","revisions":{"c11d69443e6d0779a2d1ed05361347de2f048374":{"kind":"REWORK","_number":1,"created":"2016-05-12 04:46:54.000000000","uploader":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"ref":"refs/changes/44/315344/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/44/315344/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/44/315344/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/44/315344/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/44/315344/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/44/315344/1"}}},"commit":{"parents":[{"commit":"553e154960c6a9da8481c4602c0a7a0d1147d2ad","subject":"Refactor TestVolumeList with FakeVolume","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/553e154960c6a9da8481c4602c0a7a0d1147d2ad"}]}],"author":{"name":"ting.wang","email":"ting.wang@easystack.cn","date":"2016-05-12 02:13:13.000000000","tz":480},"committer":{"name":"ting.wang","email":"ting.wang@easystack.cn","date":"2016-05-12 03:47:12.000000000","tz":480},"subject":"Refactor TestVolumeShow with FakeVolume","message":"Refactor TestVolumeShow with FakeVolume\n\nIn the meantime, add some static methods in FakeVolume for ease of use.\nChange-Id: I98ad520f32afd529fda77a4592f645130282537f\nCo-Authored-By: xiexs \u003cxiexs@cn.fujitsu.com\u003e\nImplements: blueprint improve-volume-unittest-framework\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c11d69443e6d0779a2d1ed05361347de2f048374"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c11d69443e6d0779a2d1ed05361347de2f048374"}]},"branch":"refs/heads/master"},"0fa2e8df92986bf7cbbba131042c1d3196b54365":{"kind":"REWORK","_number":2,"created":"2016-05-17 12:22:16.000000000","uploader":{"_account_id":19132,"name":"ting wang","email":"bx_wang@outlook.com","username":"binean"},"ref":"refs/changes/44/315344/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/44/315344/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/44/315344/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/44/315344/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/44/315344/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/44/315344/2"}}},"commit":{"parents":[{"commit":"553e154960c6a9da8481c4602c0a7a0d1147d2ad","subject":"Refactor TestVolumeList with FakeVolume","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/553e154960c6a9da8481c4602c0a7a0d1147d2ad"}]}],"author":{"name":"ting.wang","email":"ting.wang@easystack.cn","date":"2016-05-12 02:13:13.000000000","tz":480},"committer":{"name":"ting wang","email":"bx_wang@outlook.com","date":"2016-05-17 12:14:18.000000000","tz":480},"subject":"Refactor TestVolumeShow with FakeVolume","message":"Refactor TestVolumeShow with FakeVolume\n\nIn the meantime, add some static methods in FakeVolume for ease of use\nand add info() method with \"property\" decorator in FakeResource to allow\nthose static methods to get fake information.\n\nChange-Id: I98ad520f32afd529fda77a4592f645130282537f\nCo-Authored-By: xiexs \u003cxiexs@cn.fujitsu.com\u003e\nImplements: blueprint improve-volume-unittest-framework\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0fa2e8df92986bf7cbbba131042c1d3196b54365"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0fa2e8df92986bf7cbbba131042c1d3196b54365"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}