)]}'
{"openstackclient/api/auth.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"86eac0492e94aea8eab9bb1bae94dd8e4a68706e","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    :param required_scope: indicate whether a scoped token is required"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    \"\"\""},{"line_number":137,"context_line":"    auth_plugin_cls \u003d base.get_plugin_class(auth_plugin_name)"},{"line_number":138,"context_line":"    plugin_opts \u003d {opt.dest: opt for opt in auth_plugin_cls.get_options()}"},{"line_number":139,"context_line":"    scope_opts \u003d [\u0027project_id\u0027, \u0027domain_id\u0027, \u0027domain_name\u0027, \u0027project_name\u0027,"},{"line_number":140,"context_line":"                  \u0027tenant_id\u0027, \u0027tenant_name\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_eb17b4a0","line":137,"range":{"start_line":137,"start_character":27,"end_line":137,"end_character":43},"updated":"2016-06-14 04:48:04.000000000","message":"looks like this is causing the tests to fail","commit_id":"6bee2a71672e01648cf4074ab31d2295e13df34b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"0c13fbc355fde9f23212b76b32debd15346225db","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    :param required_scope: indicate whether a scoped token is required"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    \"\"\""},{"line_number":137,"context_line":"    plugin_opts \u003d base.get_plugin_options(auth_plugin_name)"},{"line_number":138,"context_line":"    plugin_opts \u003d {opt.dest: opt for opt in plugin_opts}"},{"line_number":139,"context_line":"    scope_opts \u003d [\u0027project_id\u0027, \u0027domain_id\u0027, \u0027domain_name\u0027, \u0027project_name\u0027,"},{"line_number":140,"context_line":"                  \u0027tenant_id\u0027, \u0027tenant_name\u0027]"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    # NOTE(aloga): this is an horrible hack. We need a way to specify the"},{"line_number":143,"context_line":"    # required options in the plugins. Using the \"required\" argument for"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_c35fffe2","line":140,"range":{"start_line":137,"start_character":4,"end_line":140,"end_character":45},"updated":"2016-06-15 04:18:59.000000000","message":"consider adding a comment above this block explaining why you are doing this, as it may not be immediate obvious","commit_id":"479b5bc5ad8303770d91f33fcf554d5f69dcc787"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"c75c8c9835134be77c2734c866252b8b6270e0db","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    :param required_scope: indicate whether a scoped token is required"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    \"\"\""},{"line_number":137,"context_line":"    plugin_opts \u003d base.get_plugin_options(auth_plugin_name)"},{"line_number":138,"context_line":"    plugin_opts \u003d {opt.dest: opt for opt in plugin_opts}"},{"line_number":139,"context_line":"    scope_opts \u003d [\u0027project_id\u0027, \u0027domain_id\u0027, \u0027domain_name\u0027, \u0027project_name\u0027,"},{"line_number":140,"context_line":"                  \u0027tenant_id\u0027, \u0027tenant_name\u0027]"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    # NOTE(aloga): this is an horrible hack. We need a way to specify the"},{"line_number":143,"context_line":"    # required options in the plugins. Using the \"required\" argument for"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_51463650","line":140,"range":{"start_line":137,"start_character":4,"end_line":140,"end_character":45},"in_reply_to":"7aa08908_c35fffe2","updated":"2016-06-15 07:20:25.000000000","message":"Done. I\u0027ve moved it closer to where it\u0027s being used, and added a verbose explanation","commit_id":"479b5bc5ad8303770d91f33fcf554d5f69dcc787"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"78eba817381a9a5bcb31d62740e2997d23c95755","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    if \u0027url\u0027 in plugin_opts and not options.auth.get(\u0027url\u0027):"},{"line_number":167,"context_line":"        msgs.append(_(\u0027Set a service URL, with --os-url, \u0027"},{"line_number":168,"context_line":"                      \u0027OS_URL or auth.url\u0027))"},{"line_number":169,"context_line":"    if \u0027token\u0027 in plugin_opts:"},{"line_number":170,"context_line":"        if not options.auth.get(\u0027token\u0027):"},{"line_number":171,"context_line":"            msgs.append(_(\u0027Set a token with --os-token, \u0027"},{"line_number":172,"context_line":"                          \u0027OS_TOKEN or auth.token\u0027))"},{"line_number":173,"context_line":"    if msgs:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a9d85d2_6e734b81","line":170,"range":{"start_line":169,"start_character":4,"end_line":170,"end_character":41},"updated":"2016-06-21 03:29:42.000000000","message":"why not continue the pattern above with:\n\n  if \u0027token\u0027 in plugin_opts and not options.auth.get(\u0027token\u0027):\n    msgs.append(...)","commit_id":"6b3f075c9b5da2732a8d1c7dfe4851bb737ac18b"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"a0eba62eb58ab8042bc4dad37fa74fb9afd4eeaf","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    if \u0027url\u0027 in plugin_opts and not options.auth.get(\u0027url\u0027):"},{"line_number":167,"context_line":"        msgs.append(_(\u0027Set a service URL, with --os-url, \u0027"},{"line_number":168,"context_line":"                      \u0027OS_URL or auth.url\u0027))"},{"line_number":169,"context_line":"    if \u0027token\u0027 in plugin_opts:"},{"line_number":170,"context_line":"        if not options.auth.get(\u0027token\u0027):"},{"line_number":171,"context_line":"            msgs.append(_(\u0027Set a token with --os-token, \u0027"},{"line_number":172,"context_line":"                          \u0027OS_TOKEN or auth.token\u0027))"},{"line_number":173,"context_line":"    if msgs:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a9d85d2_8e8af2bd","line":170,"range":{"start_line":169,"start_character":4,"end_line":170,"end_character":41},"in_reply_to":"5a9d85d2_6e734b81","updated":"2016-06-21 06:53:36.000000000","message":"Done","commit_id":"6b3f075c9b5da2732a8d1c7dfe4851bb737ac18b"}]}
