)]}'
{"id":"openstack%2Fpython-openstackclient~322412","triplet_id":"openstack%2Fpython-openstackclient~master~I38b00c2321014757970183205f95f026e20a8090","project":"openstack/python-openstackclient","branch":"master","topic":"new-line-20160528","hashtags":[],"change_id":"I38b00c2321014757970183205f95f026e20a8090","subject":"Fix output and error log in server.py","status":"MERGED","created":"2016-05-28 08:14:09.000000000","updated":"2016-05-31 13:42:14.000000000","submitted":"2016-05-31 13:42:14.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2129aa6b5a1e84fe87f9e1b01e4869243569b9ad","_number":322412,"virtual_id_number":322412,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-05-31 13:42:14.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-05-28 16:49:26.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-05-31 12:42:54.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-05-31 12:42:54.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-28 16:49:26.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-05-31 12:42:54.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-05-31 13:42:14.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6c6dea5123537f0f6b24d3e5c9f2254b40bfe313","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-05-28 08:14:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"31e49d88223d92c73e6a333e8352c30f686bbf74","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-28 09:14:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/12/322412/1/check/gate-python-openstackclient-docs/b233c5e//doc/build/html/ : SUCCESS in 2m 46s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/12/322412/1/check/gate-python-openstackclient-pep8/27f0689/ : SUCCESS in 1m 54s\n- gate-python-openstackclient-python27 http://logs.openstack.org/12/322412/1/check/gate-python-openstackclient-python27/7264ba2/ : SUCCESS in 1m 53s\n- gate-python-openstackclient-python34 http://logs.openstack.org/12/322412/1/check/gate-python-openstackclient-python34/e40fdf2/ : SUCCESS in 2m 53s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/12/322412/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/17a9507/ : SUCCESS in 57m 37s\n- check-osc-plugins http://logs.openstack.org/12/322412/1/check/check-osc-plugins/54c8b23/ : FAILURE in 3m 54s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/12/322412/1/check/gate-osc-dsvm-functional/4433294/ : SUCCESS in 36m 29s","accounts_in_message":[],"_revision_number":1},{"id":"9d5118b891b9a9172a6843ce25e1d826b5c3a8a0","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-05-28 16:49:26.000000000","message":"Patch Set 1: Code-Review+2\n\nlove the consistency!","accounts_in_message":[],"_revision_number":1},{"id":"d7b38dc45bfcdf590806d81f315f780ee92e24a5","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-05-31 12:42:54.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"47dd3a01997b521e8785044ad0e4f2e61ea37b51","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-31 12:42:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e0bd8d6e586e6f6eac2d1d4a640bcb705a4cef48","date":"2016-05-31 13:42:14.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"6cae87402117ac1fae419e09ad8cd2a2e955fc76","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-31 13:42:14.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/12/322412/1/gate/gate-python-openstackclient-docs/0560ade//doc/build/html/ : SUCCESS in 3m 25s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/12/322412/1/gate/gate-python-openstackclient-pep8/1cfaa62/ : SUCCESS in 1m 41s\n- gate-python-openstackclient-python27 http://logs.openstack.org/12/322412/1/gate/gate-python-openstackclient-python27/ad8307d/ : SUCCESS in 2m 15s\n- gate-python-openstackclient-python34 http://logs.openstack.org/12/322412/1/gate/gate-python-openstackclient-python34/68051c2/ : SUCCESS in 3m 14s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/12/322412/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/10055fa/ : SUCCESS in 58m 45s\n- gate-osc-dsvm-functional http://logs.openstack.org/12/322412/1/gate/gate-osc-dsvm-functional/16afd89/ : SUCCESS in 37m 17s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"97162ecd2277a3b50bbe3c7d672438d75b23b43b","revisions":{"97162ecd2277a3b50bbe3c7d672438d75b23b43b":{"kind":"REWORK","_number":1,"created":"2016-05-28 08:14:09.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/12/322412/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/12/322412/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/12/322412/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/12/322412/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/12/322412/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/12/322412/1"}}},"commit":{"parents":[{"commit":"9da02d14eadc39da6f97b3df095af8b0c452a5b4","subject":"Merge \"fix endpoint show help\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9da02d14eadc39da6f97b3df095af8b0c452a5b4"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-05-28 07:46:32.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-05-28 07:46:32.000000000","tz":480},"subject":"Fix output and error log in server.py","message":"Fix output and error log in server.py\n\nThis patch fixes 2 problems:\n\n1. The \u0027\\n\u0027 should be in the end of a message,\n   not the beginning.\n\ni.e.:\n   The original code was:\n       sys.stdout.write(_(\u0027\\nError deleting server\u0027))\n   It will make the output look like this:\n\n   [root@tangchen /]# openstack server delete aaa bbb\n\n   Error deleting server\n   Error deleting server[root@tangchen /]#\n\n   We change it to:\n       sys.stdout.write(_(\u0027Error deleting server\\n\u0027))\n   Then the output will become:\n\n   [root@tangchen /]# openstack server delete aaa bbb\n   Error deleting server\n   Error deleting server\n   [root@tangchen /]#\n\n   which is much better.\n\n2. Record the error in log for those who didn\u0027t.\n\nChange-Id: I38b00c2321014757970183205f95f026e20a8090\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/97162ecd2277a3b50bbe3c7d672438d75b23b43b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/97162ecd2277a3b50bbe3c7d672438d75b23b43b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}