)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"98143ee6a0a97918b79ccbda225ffe943a1c4204","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sunyajing \u003cyajing.sun@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-08 09:57:41 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix compute service set cammand"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"add ``Binary name`` to help msg of compute service set command."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7aa08908_e5053c7a","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":31},"updated":"2016-06-08 03:05:33.000000000","message":"command*","commit_id":"6979346357f91f6f570d20959e68026bb97110de"}],"openstackclient/compute/v2/service.py":[{"author":{"_account_id":21808,"name":"sunyajing","email":"yajing.sun@easystack.cn","username":"sunyajing"},"change_message_id":"607fc47970ebbf5b37465b3d9c7e0f135ed15cda","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \"--service\","},{"line_number":53,"context_line":"            metavar\u003d\"\u003cservice\u003e\","},{"line_number":54,"context_line":"            help\u003d_(\"List only specified service (name only)\")"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \"--long\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_e985b907","line":54,"range":{"start_line":54,"start_character":19,"end_line":54,"end_character":61},"updated":"2016-06-02 09:32:51.000000000","message":"like this, novaclient uses \u0027binary\u0027 , but it actually means service name.","commit_id":"2a2f1bc21e65a4ae15cebc6c362c42bbfe53b131"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"e1fa51cdd748562e0721c0c33aeaaf14f076875a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def take_action(self, parsed_args):"},{"line_number":65,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":66,"context_line":"        if parsed_args.long:"},{"line_number":67,"context_line":"            COLUMNS \u003d ("},{"line_number":68,"context_line":"                \"ID\","},{"line_number":69,"context_line":"                \"Name\","},{"line_number":70,"context_line":"                \"Host\","},{"line_number":71,"context_line":"                \"Zone\","},{"line_number":72,"context_line":"                \"Status\","},{"line_number":73,"context_line":"                \"State\","},{"line_number":74,"context_line":"                \"Update At\","},{"line_number":75,"context_line":"                \"Disabled Reason\""},{"line_number":76,"context_line":"            )"},{"line_number":77,"context_line":"            columns \u003d ("},{"line_number":78,"context_line":"                \"ID\","},{"line_number":79,"context_line":"                \"Binary\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_1e695126","line":76,"range":{"start_line":67,"start_character":0,"end_line":76,"end_character":13},"updated":"2016-06-02 09:21:49.000000000","message":"Why add this ?","commit_id":"2a2f1bc21e65a4ae15cebc6c362c42bbfe53b131"},{"author":{"_account_id":21808,"name":"sunyajing","email":"yajing.sun@easystack.cn","username":"sunyajing"},"change_message_id":"23aeea0c0a9eb4440622ef581089539bee9dcb77","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def take_action(self, parsed_args):"},{"line_number":65,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":66,"context_line":"        if parsed_args.long:"},{"line_number":67,"context_line":"            COLUMNS \u003d ("},{"line_number":68,"context_line":"                \"ID\","},{"line_number":69,"context_line":"                \"Name\","},{"line_number":70,"context_line":"                \"Host\","},{"line_number":71,"context_line":"                \"Zone\","},{"line_number":72,"context_line":"                \"Status\","},{"line_number":73,"context_line":"                \"State\","},{"line_number":74,"context_line":"                \"Update At\","},{"line_number":75,"context_line":"                \"Disabled Reason\""},{"line_number":76,"context_line":"            )"},{"line_number":77,"context_line":"            columns \u003d ("},{"line_number":78,"context_line":"                \"ID\","},{"line_number":79,"context_line":"                \"Binary\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_c93555a9","line":76,"range":{"start_line":67,"start_character":0,"end_line":76,"end_character":13},"in_reply_to":"9abb7d3a_1e695126","updated":"2016-06-02 09:28:49.000000000","message":"Done","commit_id":"2a2f1bc21e65a4ae15cebc6c362c42bbfe53b131"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"e1fa51cdd748562e0721c0c33aeaaf14f076875a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                \"Disabled Reason\""},{"line_number":86,"context_line":"            )"},{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            COLUMNS \u003d ("},{"line_number":89,"context_line":"                \"ID\","},{"line_number":90,"context_line":"                \"Name\","},{"line_number":91,"context_line":"                \"Host\","},{"line_number":92,"context_line":"                \"Zone\","},{"line_number":93,"context_line":"                \"Status\","},{"line_number":94,"context_line":"                \"State\","},{"line_number":95,"context_line":"                \"Update At\""},{"line_number":96,"context_line":"            )"},{"line_number":97,"context_line":"            columns \u003d ("},{"line_number":98,"context_line":"                \"ID\","},{"line_number":99,"context_line":"                \"Binary\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_5e73d915","line":96,"range":{"start_line":88,"start_character":0,"end_line":96,"end_character":13},"updated":"2016-06-02 09:21:49.000000000","message":"ditto","commit_id":"2a2f1bc21e65a4ae15cebc6c362c42bbfe53b131"},{"author":{"_account_id":21808,"name":"sunyajing","email":"yajing.sun@easystack.cn","username":"sunyajing"},"change_message_id":"23aeea0c0a9eb4440622ef581089539bee9dcb77","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                \"Disabled Reason\""},{"line_number":86,"context_line":"            )"},{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            COLUMNS \u003d ("},{"line_number":89,"context_line":"                \"ID\","},{"line_number":90,"context_line":"                \"Name\","},{"line_number":91,"context_line":"                \"Host\","},{"line_number":92,"context_line":"                \"Zone\","},{"line_number":93,"context_line":"                \"Status\","},{"line_number":94,"context_line":"                \"State\","},{"line_number":95,"context_line":"                \"Update At\""},{"line_number":96,"context_line":"            )"},{"line_number":97,"context_line":"            columns \u003d ("},{"line_number":98,"context_line":"                \"ID\","},{"line_number":99,"context_line":"                \"Binary\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_69ba690c","line":96,"range":{"start_line":88,"start_character":0,"end_line":96,"end_character":13},"in_reply_to":"9abb7d3a_5e73d915","updated":"2016-06-02 09:28:49.000000000","message":"utils._get_item_properties function still need to use \u0027binary\u0027 to get item from compute.service object, but when it is displayed to users ,it means \u0027name\u0027.","commit_id":"2a2f1bc21e65a4ae15cebc6c362c42bbfe53b131"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"7ae81d1cd57bd0d8dccae1d84e5be1f9ef56b141","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def take_action(self, parsed_args):"},{"line_number":65,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":66,"context_line":"        if parsed_args.long:"},{"line_number":67,"context_line":"            COLUMNS \u003d ("},{"line_number":68,"context_line":"                \"ID\","},{"line_number":69,"context_line":"                \"Name\","},{"line_number":70,"context_line":"                \"Host\","}],"source_content_type":"text/x-python","patch_set":4,"id":"9abb7d3a_e375c332","line":67,"range":{"start_line":67,"start_character":12,"end_line":67,"end_character":19},"updated":"2016-06-02 15:03:31.000000000","message":"we usually use \"column_headers\" if we are overriding the default column name","commit_id":"6e236a6fb5778208a3a761c4d927278c3607eb29"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b7b01378bbf33f605f061d1357209f442ff80c6a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        if parsed_args.long:"},{"line_number":67,"context_line":"            column_headers \u003d ("},{"line_number":68,"context_line":"                \"ID\","},{"line_number":69,"context_line":"                \"Name\","},{"line_number":70,"context_line":"                \"Host\","},{"line_number":71,"context_line":"                \"Zone\","},{"line_number":72,"context_line":"                \"Status\","}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_5c539739","line":69,"updated":"2016-06-03 11:22:25.000000000","message":"This change is not backwards compatible since output filtering can be done on column name.  Why is it necessary to change Binary to Name?","commit_id":"ad162b6dde8081c3f71e432256e5a61f11b81f3e"},{"author":{"_account_id":21808,"name":"sunyajing","email":"yajing.sun@easystack.cn","username":"sunyajing"},"change_message_id":"12c721471fc54c646263e04643630e371d7ae316","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        if parsed_args.long:"},{"line_number":67,"context_line":"            column_headers \u003d ("},{"line_number":68,"context_line":"                \"ID\","},{"line_number":69,"context_line":"                \"Name\","},{"line_number":70,"context_line":"                \"Host\","},{"line_number":71,"context_line":"                \"Zone\","},{"line_number":72,"context_line":"                \"Status\","}],"source_content_type":"text/x-python","patch_set":6,"id":"9abb7d3a_e243c611","line":69,"in_reply_to":"9abb7d3a_5c539739","updated":"2016-06-03 11:48:36.000000000","message":"Yes,output filtering uses item \u0027Binary\u0027.\nBut when it is displayed to users, it\u0027s necessary to change Binary to Name.\nSuch as the help msg of ``service set``command :``help\u003d_(\"Name of service\")``,it tells users to input service name which actually equals to Bianry here.\nfor clarity, i think we should hide Binary for users and use Name instead .","commit_id":"ad162b6dde8081c3f71e432256e5a61f11b81f3e"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f298247274b1c0199dd56985ff11d9b7e7301791","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        if parsed_args.long:"},{"line_number":67,"context_line":"            column_headers \u003d ("},{"line_number":68,"context_line":"                \"ID\","},{"line_number":69,"context_line":"                \"Name\","},{"line_number":70,"context_line":"                \"Host\","},{"line_number":71,"context_line":"                \"Zone\","},{"line_number":72,"context_line":"                \"Status\","}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_83c4cc40","line":69,"in_reply_to":"9abb7d3a_e243c611","updated":"2016-06-04 10:17:13.000000000","message":"You could just change the help text to clarify that the binary name is expected.  If you feel strongly that this needs to change, then let\u0027s wait for the OSC 3.0 release for this change to merge.","commit_id":"ad162b6dde8081c3f71e432256e5a61f11b81f3e"}]}