)]}'
{"openstackclient/compute/v2/service.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f52552527c1d555077c48af23fc5720e5132ca2b","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                    else:"},{"line_number":169,"context_line":"                        cs.disable(parsed_args.host, parsed_args.service)"},{"line_number":170,"context_line":"        except Exception:"},{"line_number":171,"context_line":"            self.log.error(_(\"Service status set failed\"))"},{"line_number":172,"context_line":"            result +\u003d 1"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_d48f5b21","line":171,"range":{"start_line":171,"start_character":30,"end_line":171,"end_character":55},"updated":"2016-06-07 04:42:44.000000000","message":"maybe say something like ... \"Failed to set service to $enabled\" ?","commit_id":"8be869e183288d64bdc5b9761c7dd4511e8132e1"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"9f5ae9daafdcd2f4c39c206aecd0cbfeecbdb244","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                    else:"},{"line_number":169,"context_line":"                        cs.disable(parsed_args.host, parsed_args.service)"},{"line_number":170,"context_line":"        except Exception:"},{"line_number":171,"context_line":"            self.log.error(_(\"Service status set failed\"))"},{"line_number":172,"context_line":"            result +\u003d 1"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_e5ae1f97","line":171,"range":{"start_line":171,"start_character":30,"end_line":171,"end_character":55},"in_reply_to":"7aa08908_d48f5b21","updated":"2016-06-07 06:36:51.000000000","message":"Done","commit_id":"8be869e183288d64bdc5b9761c7dd4511e8132e1"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f52552527c1d555077c48af23fc5720e5132ca2b","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                cs.force_down(parsed_args.host, parsed_args.service,"},{"line_number":182,"context_line":"                              force_down\u003dforce_down)"},{"line_number":183,"context_line":"        except Exception:"},{"line_number":184,"context_line":"            self.log.error(_(\"Service state set failed\"))"},{"line_number":185,"context_line":"            result +\u003d 1"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        if result \u003e 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_94ae7383","line":184,"range":{"start_line":184,"start_character":30,"end_line":184,"end_character":54},"updated":"2016-06-07 04:42:44.000000000","message":"Same thing... \"Failed to force the service $force_down\"","commit_id":"8be869e183288d64bdc5b9761c7dd4511e8132e1"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"9f5ae9daafdcd2f4c39c206aecd0cbfeecbdb244","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                cs.force_down(parsed_args.host, parsed_args.service,"},{"line_number":182,"context_line":"                              force_down\u003dforce_down)"},{"line_number":183,"context_line":"        except Exception:"},{"line_number":184,"context_line":"            self.log.error(_(\"Service state set failed\"))"},{"line_number":185,"context_line":"            result +\u003d 1"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        if result \u003e 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_4596134d","line":184,"range":{"start_line":184,"start_character":30,"end_line":184,"end_character":54},"in_reply_to":"7aa08908_94ae7383","updated":"2016-06-07 06:36:51.000000000","message":"Done","commit_id":"8be869e183288d64bdc5b9761c7dd4511e8132e1"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"c21735b1583285bc1f9240ca777e23ceffaf8f19","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            if parsed_args.up:"},{"line_number":182,"context_line":"                force_down \u003d False"},{"line_number":183,"context_line":"            if force_down is not None:"},{"line_number":184,"context_line":"                cs.force_down(parsed_args.host, parsed_args.service,"},{"line_number":185,"context_line":"                              force_down\u003dforce_down)"},{"line_number":186,"context_line":"        except Exception:"},{"line_number":187,"context_line":"            state \u003d \"down\" if force_down else \"up\""},{"line_number":188,"context_line":"            self.log.error(_LE(\"Failed to set service state to %s\"), state)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_a21adb7a","line":185,"range":{"start_line":184,"start_character":0,"end_line":185,"end_character":52},"updated":"2016-06-14 11:59:23.000000000","message":"Please correct me if I didn\u0027t understand this correctly. :)\n\nI greped nova code, and I don\u0027t think we have a concept of \"force up\". Usually, only \"force down\" makes sense, which often means that sometimes we cannot shutdown the service normally and we force it down. But what dose \"force up\" actually mean ?\n\nAnd also, does \"force_down\u003dFalse\" mean \"force up\" ?","commit_id":"eccd943acc9526311fcfc318280b4be51c42a566"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"fe77940b9fdbebfa7599cd489aaab687493da3ff","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            if parsed_args.up:"},{"line_number":182,"context_line":"                force_down \u003d False"},{"line_number":183,"context_line":"            if force_down is not None:"},{"line_number":184,"context_line":"                cs.force_down(parsed_args.host, parsed_args.service,"},{"line_number":185,"context_line":"                              force_down\u003dforce_down)"},{"line_number":186,"context_line":"        except Exception:"},{"line_number":187,"context_line":"            state \u003d \"down\" if force_down else \"up\""},{"line_number":188,"context_line":"            self.log.error(_LE(\"Failed to set service state to %s\"), state)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_883236f0","line":185,"range":{"start_line":184,"start_character":0,"end_line":185,"end_character":52},"in_reply_to":"7aa08908_050d8fe7","updated":"2016-06-15 03:03:07.000000000","message":"OK, thanks for the info.\n\nJust the word \"force up\" confuses me. And it will appear in help message. Any other better description ?\n\nAnd the code LGTM.\n\nThanks.","commit_id":"eccd943acc9526311fcfc318280b4be51c42a566"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"33b8873ab6e1a2d4096857a79fa4c0c845161972","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            if parsed_args.up:"},{"line_number":182,"context_line":"                force_down \u003d False"},{"line_number":183,"context_line":"            if force_down is not None:"},{"line_number":184,"context_line":"                cs.force_down(parsed_args.host, parsed_args.service,"},{"line_number":185,"context_line":"                              force_down\u003dforce_down)"},{"line_number":186,"context_line":"        except Exception:"},{"line_number":187,"context_line":"            state \u003d \"down\" if force_down else \"up\""},{"line_number":188,"context_line":"            self.log.error(_LE(\"Failed to set service state to %s\"), state)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_f7a2b2fb","line":185,"range":{"start_line":184,"start_character":0,"end_line":185,"end_character":52},"in_reply_to":"7aa08908_883236f0","updated":"2016-06-15 08:10:12.000000000","message":"Nova force_down API actually have two behavior \"force down\" and \"force up\" according to the boolean API argument, for OSC command should be two options(--up \u0026 --down), I want to keep the consistent of help message, so \"Force up service\" is present, I think it\u0027s exact in the case :-)","commit_id":"eccd943acc9526311fcfc318280b4be51c42a566"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"4767b09ac3d90edc502d16494eb8aed0c7cee808","unresolved":false,"context_lines":[{"line_number":181,"context_line":"            if parsed_args.up:"},{"line_number":182,"context_line":"                force_down \u003d False"},{"line_number":183,"context_line":"            if force_down is not None:"},{"line_number":184,"context_line":"                cs.force_down(parsed_args.host, parsed_args.service,"},{"line_number":185,"context_line":"                              force_down\u003dforce_down)"},{"line_number":186,"context_line":"        except Exception:"},{"line_number":187,"context_line":"            state \u003d \"down\" if force_down else \"up\""},{"line_number":188,"context_line":"            self.log.error(_LE(\"Failed to set service state to %s\"), state)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_050d8fe7","line":185,"range":{"start_line":184,"start_character":0,"end_line":185,"end_character":52},"in_reply_to":"7aa08908_a21adb7a","updated":"2016-06-15 02:26:17.000000000","message":"Yes, \"force_down\u003dFalse\" mean that the compute service would be set to \"up\", [1] is nova \"force_down\" specification, more details you can found :-)\n\n[1]: http://specs.openstack.org/openstack/nova-specs/specs/liberty/implemented/mark-host-down.html","commit_id":"eccd943acc9526311fcfc318280b4be51c42a566"}],"openstackclient/tests/compute/v2/test_service.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"c4f122d00b670ddd4416772109cbddc947cab760","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        ]"},{"line_number":269,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":270,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":271,"context_line":"        self.service_mock.force_down.assert_called_once_with("},{"line_number":272,"context_line":"            self.service.host, self.service.binary, force_down\u003dFalse)"},{"line_number":273,"context_line":"        self.assertIsNone(result)"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_fcfc99b9","line":271,"range":{"start_line":271,"start_character":37,"end_line":271,"end_character":60},"updated":"2016-06-08 12:15:29.000000000","message":"It would be good to assert that enable and disable methods aren\u0027t called.","commit_id":"98163aef046c97db4c348d536c19e5e4a509d7bf"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"d74409e15a2117c28b9d97db2c60b383146b00bc","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        ]"},{"line_number":269,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":270,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":271,"context_line":"        self.service_mock.force_down.assert_called_once_with("},{"line_number":272,"context_line":"            self.service.host, self.service.binary, force_down\u003dFalse)"},{"line_number":273,"context_line":"        self.assertIsNone(result)"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_32e03a96","line":271,"range":{"start_line":271,"start_character":37,"end_line":271,"end_character":60},"in_reply_to":"7aa08908_fcfc99b9","updated":"2016-06-13 10:12:08.000000000","message":"Done","commit_id":"98163aef046c97db4c348d536c19e5e4a509d7bf"}]}