)]}'
{"id":"openstack%2Fpython-openstackclient~326257","triplet_id":"openstack%2Fpython-openstackclient~master~I248861a38a4de0412a080046aa7a6f6473c3e082","project":"openstack/python-openstackclient","branch":"master","topic":"bp/log-usage","hashtags":[],"change_id":"I248861a38a4de0412a080046aa7a6f6473c3e082","subject":"Standardize logger usage in volume","status":"MERGED","created":"2016-06-07 06:53:58.000000000","updated":"2016-06-15 01:44:27.000000000","submitted":"2016-06-15 00:09:15.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1666862e206b2553ea0f725b14031821ff8a1627","_number":326257,"virtual_id_number":326257,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-06-15 00:09:15.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"date":"2016-06-15 01:44:27.000000000","post_submit":true,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":11676,"name":"wuyuting","email":"wytdahu@gmail.com","username":"wuyuting"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-06-14 22:35:40.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":2,"date":"2016-06-14 23:09:55.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":11676,"name":"wuyuting","email":"wytdahu@gmail.com","username":"wuyuting"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":1,"date":"2016-06-14 23:09:55.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":11676,"name":"wuyuting","email":"wytdahu@gmail.com","username":"wuyuting"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":11676,"name":"wuyuting","email":"wytdahu@gmail.com","username":"wuyuting"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-07 12:34:59.000000000","updated_by":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"reviewer":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"state":"REVIEWER"},{"updated":"2016-06-07 15:27:46.000000000","updated_by":{"_account_id":11676,"name":"wuyuting","email":"wytdahu@gmail.com","username":"wuyuting"},"reviewer":{"_account_id":11676,"name":"wuyuting","email":"wytdahu@gmail.com","username":"wuyuting"},"state":"REVIEWER"},{"updated":"2016-06-08 12:21:14.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-06-14 22:35:40.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-06-14 23:09:55.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-06-15 00:09:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e433f163e2672d0fed5bff08e6d8ef407e77a5e1","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-06-07 06:53:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"34bd598a6e5e0f774571ad0fd9eab66d2c85900b","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-06-07 06:55:52.000000000","message":"Patch Set 1:\n\nHi all,\n\nDean and Richard has discussed in the weekly meeting about this BP:\nhttps://blueprints.launchpad.net/python-openstackclient/+spec/log-usage\n\nThis patch is the first one. I saw Nova uses logger like this. We can discuss more about how to setup rule of logger usage. Maybe give a doc for it. :)","accounts_in_message":[],"_revision_number":1},{"id":"7a54c97737f9d51a464e9297fb9d37cadc6c1a88","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-07 07:47:40.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/57/326257/1/check/gate-python-openstackclient-docs/0c069af//doc/build/html/ : SUCCESS in 2m 32s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/57/326257/1/check/gate-python-openstackclient-pep8/c9d4db9/ : FAILURE in 2m 42s\n- gate-python-openstackclient-python27 http://logs.openstack.org/57/326257/1/check/gate-python-openstackclient-python27/f3b3c98/ : FAILURE in 2m 47s\n- gate-python-openstackclient-python34 http://logs.openstack.org/57/326257/1/check/gate-python-openstackclient-python34/639ceb4/ : FAILURE in 5m 51s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/57/326257/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/60fa251/ : SUCCESS in 50m 52s\n- check-osc-plugins http://logs.openstack.org/57/326257/1/check/check-osc-plugins/7b0f569/ : SUCCESS in 3m 34s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/57/326257/1/check/gate-osc-dsvm-functional/1de6bcb/ : SUCCESS in 40m 21s","accounts_in_message":[],"_revision_number":1},{"id":"79f072211931bfbe46edcee2b28baaa55f93cb82","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-06-07 09:18:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b1410f3a5d2d20b7ec978b6c0f7c2f5c84f6093b","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-06-07 09:33:27.000000000","message":"Patch Set 2: Code-Review+1\n\nThis is how we log in keystone projects too. Not sure why we did it differently in in the first place. I would support this standardization.","accounts_in_message":[],"_revision_number":2},{"id":"66122f020235d77e0c6a10e86707dd17000f4e22","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-07 10:45:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/57/326257/2/check/gate-python-openstackclient-docs/ab0223c//doc/build/html/ : SUCCESS in 3m 56s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/57/326257/2/check/gate-python-openstackclient-pep8/064867b/ : SUCCESS in 2m 28s\n- gate-python-openstackclient-python27 http://logs.openstack.org/57/326257/2/check/gate-python-openstackclient-python27/5b0c446/ : SUCCESS in 3m 32s\n- gate-python-openstackclient-python34 http://logs.openstack.org/57/326257/2/check/gate-python-openstackclient-python34/9a62440/ : SUCCESS in 3m 46s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/57/326257/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/0738ded/ : SUCCESS in 1h 08m 35s\n- check-osc-plugins http://logs.openstack.org/57/326257/2/check/check-osc-plugins/ed67ebb/ : SUCCESS in 3m 24s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/57/326257/2/check/gate-osc-dsvm-functional/2d43bb3/ : SUCCESS in 34m 21s","accounts_in_message":[],"_revision_number":2},{"id":"940d75a99333ce93f9969e01450123b419d7c96b","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2016-06-07 12:34:59.000000000","message":"Patch Set 2:\n\n+1 for standardize logger usage\n\nI would like a log usage document is drafted and merged into devref, then start to change code.\n\nAnd I think we can define self.log as standard log usage in take_action() method, because that way had been supported in CommandMeta class[1], gracefully and the log message also contain the command info, like this: \n\n\"2016-06-07 20:07:59.089 487 DEBUG openstackclient.compute.v2.service.ListService [devstack-admin admin admin] run(Namespace(columns\u003d[], formatter\u003d\u0027table\u0027, host\u003dNone, long\u003dFalse, max_width\u003d0, noindent\u003dFalse, quote_mode\u003d\u0027nonnumeric\u0027, service\u003dNone))\n\"\n\n[1]: http://git.openstack.org/cgit/openstack/python-openstackclient/tree/openstackclient/common/command.py#n29","accounts_in_message":[],"_revision_number":2},{"id":"a20c5e168cebc68da7e61dc9bc8335dc3319a507","author":{"_account_id":11676,"name":"wuyuting","email":"wytdahu@gmail.com","username":"wuyuting"},"date":"2016-06-07 15:27:46.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM. So far， logger used in opc are not uniformly, It is necessary to standardize。","accounts_in_message":[],"_revision_number":2},{"id":"e72c51a3e8a020a833f52d6662ce5bbe2eeae855","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-06-08 12:21:14.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1052eae34d50a1715120557266d52d13182bd850","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-13 19:33:38.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"94b51a41d08a2df4bdd8c57430bbf8011b384b6a","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-06-14 21:38:41.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ecd1b17e38b3857e9ea61baf3b5b6b54485ee2c0","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-06-14 21:38:59.000000000","message":"Patch Set 3:\n\nrebased after osc-lib changes","accounts_in_message":[],"_revision_number":3},{"id":"c0876f16d73540a89e55275efe23f3666506297d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-14 22:35:12.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/57/326257/3/check/gate-python-openstackclient-docs/68808fb//doc/build/html/ : SUCCESS in 3m 46s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/57/326257/3/check/gate-python-openstackclient-pep8/4308eaa/ : SUCCESS in 1m 48s\n- gate-python-openstackclient-python27 http://logs.openstack.org/57/326257/3/check/gate-python-openstackclient-python27/79043cb/ : SUCCESS in 1m 51s\n- gate-python-openstackclient-python34 http://logs.openstack.org/57/326257/3/check/gate-python-openstackclient-python34/768f412/ : SUCCESS in 5m 08s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/57/326257/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/1914a42/ : SUCCESS in 54m 09s\n- check-osc-plugins http://logs.openstack.org/57/326257/3/check/check-osc-plugins/b3869be/ : SUCCESS in 4m 38s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/57/326257/3/check/gate-osc-dsvm-functional/2635732/ : SUCCESS in 48m 07s","accounts_in_message":[],"_revision_number":3},{"id":"63cb64f8d6eae98bf79a820b116fdaf2b56ca710","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-06-14 22:35:40.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"43b43cba43f1763e01c20abdc6926b2d1b4ef014","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-06-14 23:09:55.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"2ea56517f8ea4d53fe50a3bd6a87e72ebcaf9f11","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-14 23:10:08.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"5874a6b16dfe1115bfec3d650a521791b102211d","date":"2016-06-15 00:09:15.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"33e28ff764f549203a16c2e3ef7caee938eab4d3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-15 00:09:15.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/57/326257/3/gate/gate-python-openstackclient-docs/b119e2a//doc/build/html/ : SUCCESS in 3m 17s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/57/326257/3/gate/gate-python-openstackclient-pep8/9d44840/ : SUCCESS in 4m 59s\n- gate-python-openstackclient-python27 http://logs.openstack.org/57/326257/3/gate/gate-python-openstackclient-python27/482afac/ : SUCCESS in 3m 08s\n- gate-python-openstackclient-python34 http://logs.openstack.org/57/326257/3/gate/gate-python-openstackclient-python34/355be14/ : SUCCESS in 3m 21s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/57/326257/3/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/4403bbd/ : SUCCESS in 58m 11s\n- gate-osc-dsvm-functional http://logs.openstack.org/57/326257/3/gate/gate-osc-dsvm-functional/b7fb749/ : SUCCESS in 25m 55s","accounts_in_message":[],"_revision_number":3},{"id":"2716a345e593baa8e0ed90f095568c2bf3c48ff6","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-06-15 01:44:27.000000000","message":"Patch Set 3:\n\nHi Dean, Steve,\n\nThanks for rebasing the patch. Will add a devref doc for it in another patch.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"0e9862be7af9a88c9c0e6a9ef4e11e48a1192727","revisions":{"57e9c9e2cb2974feab55b733e4e66c7ad909a5b0":{"kind":"REWORK","_number":1,"created":"2016-06-07 06:53:58.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/57/326257/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/57/326257/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/326257/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/326257/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/326257/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/57/326257/1"}}},"commit":{"parents":[{"commit":"dd0fe3d94ee6967c42c48be5181a2901b691a40c","subject":"Merge \"Fix errors for \"volume type unset\" command\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/dd0fe3d94ee6967c42c48be5181a2901b691a40c"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-06-07 06:29:41.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-06-07 06:29:41.000000000","tz":480},"subject":"Standardize logger usage in volume","message":"Standardize logger usage in volume\n\nself.app.log is the logger in class OpenStackShell,\nwhich should be used to record logs that have nothing\nto do with any specific command.\n\nSo, use the file logger instead.\n\nThis patch also fixes some usage that doesn\u0027t follow\nrules in:\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html\n1. add variables to logger as an argument\n2. do not wrap variables with str()\n\nChange-Id: I248861a38a4de0412a080046aa7a6f6473c3e082\nImplements: blueprint log-usage\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/57e9c9e2cb2974feab55b733e4e66c7ad909a5b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/57e9c9e2cb2974feab55b733e4e66c7ad909a5b0"}]},"branch":"refs/heads/master"},"247a15deb4555023301c108046290951705e7811":{"kind":"REWORK","_number":2,"created":"2016-06-07 09:18:27.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/57/326257/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/57/326257/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/326257/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/326257/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/326257/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/57/326257/2"}}},"commit":{"parents":[{"commit":"5293bb103e75542d9defb9d0d5ed3c144f0657fe","subject":"Fix i18n support problems in identity","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5293bb103e75542d9defb9d0d5ed3c144f0657fe"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-06-07 06:29:41.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-06-07 08:15:22.000000000","tz":480},"subject":"Standardize logger usage in volume","message":"Standardize logger usage in volume\n\nself.app.log is the logger in class OpenStackShell,\nwhich should be used to record logs that have nothing\nto do with any specific command.\n\nSo, use the file logger instead.\n\nThis patch also fixes some usage that doesn\u0027t follow\nrules in:\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html\n1. add variables to logger as an argument\n2. do not wrap variables with str()\n\nChange-Id: I248861a38a4de0412a080046aa7a6f6473c3e082\nImplements: blueprint log-usage\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/247a15deb4555023301c108046290951705e7811"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/247a15deb4555023301c108046290951705e7811"}]},"branch":"refs/heads/master"},"0e9862be7af9a88c9c0e6a9ef4e11e48a1192727":{"kind":"REWORK","_number":3,"created":"2016-06-14 21:38:41.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/57/326257/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/57/326257/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/326257/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/326257/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/57/326257/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/57/326257/3"}}},"commit":{"parents":[{"commit":"769baf329e6aa619e7d9a5e48a5230bcf4399228","subject":"Merge \"Ensure endpoint type is used for network commands\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/769baf329e6aa619e7d9a5e48a5230bcf4399228"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-06-07 06:29:41.000000000","tz":480},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2016-06-14 21:37:57.000000000","tz":-300},"subject":"Standardize logger usage in volume","message":"Standardize logger usage in volume\n\nself.app.log is the logger in class OpenStackShell,\nwhich should be used to record logs that have nothing\nto do with any specific command.\n\nSo, use the file logger instead.\n\nThis patch also fixes some usage that doesn\u0027t follow\nrules in:\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html\n1. add variables to logger as an argument\n2. do not wrap variables with str()\n\nChange-Id: I248861a38a4de0412a080046aa7a6f6473c3e082\nImplements: blueprint log-usage\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0e9862be7af9a88c9c0e6a9ef4e11e48a1192727"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/0e9862be7af9a88c9c0e6a9ef4e11e48a1192727"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}