)]}'
{"id":"openstack%2Fpython-openstackclient~326397","triplet_id":"openstack%2Fpython-openstackclient~master~I14e64922faa7e083bc8b5e7e1cac41ef8117c224","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1589935","hashtags":[],"change_id":"I14e64922faa7e083bc8b5e7e1cac41ef8117c224","subject":"Error handling for KeyValueAction class.","status":"MERGED","created":"2016-06-07 11:43:18.000000000","updated":"2016-06-08 04:30:58.000000000","submitted":"2016-06-08 04:30:57.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"51b07259c7970038a5651f75cc9118d77c570d55","_number":326397,"virtual_id_number":326397,"owner":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-06-08 04:30:57.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-06-08 03:01:03.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-06-08 03:18:38.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-06-08 03:18:38.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"value":0,"date":"2016-06-08 03:01:07.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-08 03:01:03.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-06-08 03:01:07.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2016-06-08 03:18:38.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2016-06-08 04:30:57.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"37ac797b3d2f1183ff8cf45c270e9f843dd2c3c6","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-06-07 11:43:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b5b778879134e6544e4c01da808f87382ac84057","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-06-07 12:03:10.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nI think you need also update the unit tests.","accounts_in_message":[],"_revision_number":1},{"id":"e0b8c75156fcc3586d30527b37e4f539ad7d5e74","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-07 12:59:31.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/97/326397/1/check/gate-python-openstackclient-docs/6ee7925//doc/build/html/ : SUCCESS in 3m 22s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/97/326397/1/check/gate-python-openstackclient-pep8/3c7dcc6/ : SUCCESS in 2m 38s\n- gate-python-openstackclient-python27 http://logs.openstack.org/97/326397/1/check/gate-python-openstackclient-python27/315f135/ : FAILURE in 2m 38s\n- gate-python-openstackclient-python34 http://logs.openstack.org/97/326397/1/check/gate-python-openstackclient-python34/196f029/ : FAILURE in 2m 40s\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/97/326397/1/check/gate-python-openstackclient-releasenotes/46458c3//releasenotes/build/html/ : SUCCESS in 2m 35s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/97/326397/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/e373015/ : SUCCESS in 57m 40s\n- check-osc-plugins http://logs.openstack.org/97/326397/1/check/check-osc-plugins/0728f33/ : SUCCESS in 2m 51s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/97/326397/1/check/gate-osc-dsvm-functional/68e9806/ : SUCCESS in 25m 57s","accounts_in_message":[],"_revision_number":1},{"id":"b3d2cbef1c95f0ae0af8de1991a25bc7edf9ae36","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-06-07 16:07:40.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"316c382d6658951374a0e7a6d104513917621304","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-06-07 16:08:04.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"a039e04ab954136c19234b82018d7db891201e98","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-06-07 17:02:07.000000000","message":"Patch Set 2:\n\nlooks like the tests still need to be updated","accounts_in_message":[],"_revision_number":2},{"id":"f2b10ef3a11d632a404306b145bc689230afbde5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-07 18:56:44.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/97/326397/2/check/gate-python-openstackclient-docs/8b05ada//doc/build/html/ : SUCCESS in 3m 48s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/97/326397/2/check/gate-python-openstackclient-pep8/f2f9f74/ : SUCCESS in 4m 51s\n- gate-python-openstackclient-python27 http://logs.openstack.org/97/326397/2/check/gate-python-openstackclient-python27/08a1615/ : FAILURE in 3m 56s\n- gate-python-openstackclient-python34 http://logs.openstack.org/97/326397/2/check/gate-python-openstackclient-python34/2c19679/ : FAILURE in 3m 42s\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/97/326397/2/check/gate-python-openstackclient-releasenotes/7779c83//releasenotes/build/html/ : SUCCESS in 2m 51s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/97/326397/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/21d2f91/ : SUCCESS in 1h 39m 56s\n- check-osc-plugins http://logs.openstack.org/97/326397/2/check/check-osc-plugins/f8425a4/ : SUCCESS in 5m 55s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/97/326397/2/check/gate-osc-dsvm-functional/b8a4e61/ : SUCCESS in 41m 10s","accounts_in_message":[],"_revision_number":2},{"id":"4739aea27de1d56cb87bf49078d81b6c54a2998d","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-06-08 01:53:02.000000000","message":"Patch Set 2:\n\n\u003e looks like the tests still need to be updated\n\nThank you, Steve. I will update the unit tests.","accounts_in_message":[],"_revision_number":2},{"id":"b2e3052f39644ee96552a96287220778af19f784","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-06-08 02:16:22.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e6040e5f969e6d0727f0ed008d113c664f8a39b4","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-06-08 03:01:03.000000000","message":"Patch Set 3: Code-Review+2\n\ncan you also do the same change here: https://github.com/openstack/osc-lib/blob/master/osc_lib/cli/parseractions.py","accounts_in_message":[],"_revision_number":3},{"id":"2dd0ca9d83e47d825b7c70b71b876c96d37a7b0e","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-06-08 03:18:38.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"beca43f47d21ecee5a581eeb4101c96d8785dbd8","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-06-08 03:23:58.000000000","message":"Patch Set 3:\n\n\u003e can you also do the same change here: https://github.com/openstack/osc-lib/blob/master/osc_lib/cli/parseractions.py\n\nOK, I will :)","accounts_in_message":[],"_revision_number":3},{"id":"95bcb123502754e3685ccf02af262b91a3582ef9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-08 03:26:24.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/97/326397/3/check/gate-python-openstackclient-docs/cef9eb4//doc/build/html/ : SUCCESS in 5m 00s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/97/326397/3/check/gate-python-openstackclient-pep8/aecf82b/ : SUCCESS in 4m 53s\n- gate-python-openstackclient-python27 http://logs.openstack.org/97/326397/3/check/gate-python-openstackclient-python27/32a00b1/ : SUCCESS in 3m 47s\n- gate-python-openstackclient-python34 http://logs.openstack.org/97/326397/3/check/gate-python-openstackclient-python34/fad96ad/ : SUCCESS in 4m 17s\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/97/326397/3/check/gate-python-openstackclient-releasenotes/49a2e1d//releasenotes/build/html/ : SUCCESS in 3m 24s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/97/326397/3/check/gate-tempest-dsvm-neutron-src-python-openstackclient/15a9165/ : SUCCESS in 1h 07m 30s\n- check-osc-plugins http://logs.openstack.org/97/326397/3/check/check-osc-plugins/e3ff00d/ : SUCCESS in 4m 09s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/97/326397/3/check/gate-osc-dsvm-functional/dc08179/ : SUCCESS in 37m 49s","accounts_in_message":[],"_revision_number":3},{"id":"4b0d56361ec4eeabaa9286e1b7db3b868bd24ad3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-08 03:26:30.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"d4d1d94f227ca89511b74d7f814a31dc91f8264a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-08 04:30:57.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/97/326397/3/gate/gate-python-openstackclient-docs/9b33135//doc/build/html/ : SUCCESS in 4m 15s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/97/326397/3/gate/gate-python-openstackclient-pep8/d750544/ : SUCCESS in 3m 41s\n- gate-python-openstackclient-python27 http://logs.openstack.org/97/326397/3/gate/gate-python-openstackclient-python27/41a319a/ : SUCCESS in 3m 22s\n- gate-python-openstackclient-python34 http://logs.openstack.org/97/326397/3/gate/gate-python-openstackclient-python34/8ee7540/ : SUCCESS in 4m 25s\n- gate-python-openstackclient-releasenotes http://docs-draft.openstack.org/97/326397/3/gate/gate-python-openstackclient-releasenotes/ee2af8b//releasenotes/build/html/ : SUCCESS in 4m 18s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/97/326397/3/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/22e4544/ : SUCCESS in 1h 03m 38s\n- gate-osc-dsvm-functional http://logs.openstack.org/97/326397/3/gate/gate-osc-dsvm-functional/1bd208b/ : SUCCESS in 34m 34s","accounts_in_message":[],"_revision_number":3},{"id":"8c4d705be6ae2ea3db605fc5e4c60932c9204fe3","date":"2016-06-08 04:30:58.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"cf122397733b8795530577b7824aeae305719658","revisions":{"d97114ba0bc87c1c234bdcba066d34756570f542":{"kind":"REWORK","_number":1,"created":"2016-06-07 11:43:18.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/97/326397/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/97/326397/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/97/326397/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/97/326397/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/97/326397/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/97/326397/1"}}},"commit":{"parents":[{"commit":"5293bb103e75542d9defb9d0d5ed3c144f0657fe","subject":"Fix i18n support problems in identity","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5293bb103e75542d9defb9d0d5ed3c144f0657fe"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-06-07 08:41:21.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-06-07 11:41:54.000000000","tz":480},"subject":"Error handling for KeyValueAction class.","message":"Error handling for KeyValueAction class.\n\nThe set --property command requires that the input match\nthe \"key\u003dvalue\" type, but if the type don\u0027t match, the return\nvalue will be None, and the command still can be implemented\nsuccessfully, this may confuse the users. I think we should\nraise exception if the argument type don\u0027t match \"key\u003dvalue\".\nSo I make some changes in KeyValueAction class in this patch.\n\nChange-Id: I14e64922faa7e083bc8b5e7e1cac41ef8117c224\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d97114ba0bc87c1c234bdcba066d34756570f542"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/d97114ba0bc87c1c234bdcba066d34756570f542"}]},"branch":"refs/heads/master"},"a6cc38973f03cf95d8b30f52ebc98aed7418e894":{"kind":"REWORK","_number":2,"created":"2016-06-07 16:08:04.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/97/326397/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/97/326397/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/97/326397/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/97/326397/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/97/326397/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/97/326397/2"}}},"commit":{"parents":[{"commit":"5293bb103e75542d9defb9d0d5ed3c144f0657fe","subject":"Fix i18n support problems in identity","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5293bb103e75542d9defb9d0d5ed3c144f0657fe"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-06-07 08:41:21.000000000","tz":480},"committer":{"name":"Steve Martinelli","email":"s.martinelli@gmail.com","date":"2016-06-07 16:08:02.000000000","tz":0},"subject":"Error handling for KeyValueAction class.","message":"Error handling for KeyValueAction class.\n\nThe set --property command requires that the input match\nthe \"key\u003dvalue\" type, but if the type don\u0027t match, the return\nvalue will be None, and the command still can be implemented\nsuccessfully, this may confuse the users. I think we should\nraise exception if the argument type don\u0027t match \"key\u003dvalue\".\nSo I make some changes in KeyValueAction class in this patch.\n\nChange-Id: I14e64922faa7e083bc8b5e7e1cac41ef8117c224\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a6cc38973f03cf95d8b30f52ebc98aed7418e894"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a6cc38973f03cf95d8b30f52ebc98aed7418e894"}]},"branch":"refs/heads/master"},"cf122397733b8795530577b7824aeae305719658":{"kind":"REWORK","_number":3,"created":"2016-06-08 02:16:22.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/97/326397/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/97/326397/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/97/326397/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/97/326397/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/97/326397/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/97/326397/3"}}},"commit":{"parents":[{"commit":"5293bb103e75542d9defb9d0d5ed3c144f0657fe","subject":"Fix i18n support problems in identity","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5293bb103e75542d9defb9d0d5ed3c144f0657fe"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-06-07 08:41:21.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-06-08 02:15:19.000000000","tz":480},"subject":"Error handling for KeyValueAction class.","message":"Error handling for KeyValueAction class.\n\nThe set --property command requires that the input match\nthe \"key\u003dvalue\" type, but if the type don\u0027t match, the return\nvalue will be None, and the command still can be implemented\nsuccessfully, this may confuse the users. I think we should\nraise exception if the argument type don\u0027t match \"key\u003dvalue\".\nSo I make some changes in KeyValueAction class in this patch.\n\nChange-Id: I14e64922faa7e083bc8b5e7e1cac41ef8117c224\nCloses-Bug: #1589935\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cf122397733b8795530577b7824aeae305719658"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/cf122397733b8795530577b7824aeae305719658"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}