)]}'
{"id":"openstack%2Fpython-openstackclient~329293","triplet_id":"openstack%2Fpython-openstackclient~master~Ifd33c72d5b7581aaabffb09e9b5e38ecc67e18c0","project":"openstack/python-openstackclient","branch":"master","topic":"set-flavor-test-20160614","hashtags":[],"change_id":"Ifd33c72d5b7581aaabffb09e9b5e38ecc67e18c0","subject":"Fix errors in ``set/unset flavor`` unit tests","status":"MERGED","created":"2016-06-14 07:07:14.000000000","updated":"2016-06-14 19:18:21.000000000","submitted":"2016-06-14 19:18:21.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c52ad0d5a4d45b9a4a2478e1296179c980ff91d0","_number":329293,"virtual_id_number":329293,"owner":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-06-14 19:18:21.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"recommended":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"all":[{"value":1,"date":"2016-06-14 08:38:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":2,"date":"2016-06-14 17:55:50.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-06-14 11:37:56.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":0,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":1,"date":"2016-06-14 17:55:50.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-14 08:38:24.000000000","updated_by":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"reviewer":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"state":"REVIEWER"},{"updated":"2016-06-14 11:37:56.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-06-14 17:55:50.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-06-14 19:18:21.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5be385f4428583fc55ccafc9e4cc93d521409f1a","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-06-14 07:07:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"59915cb8fba7a269e9b1f5cbfe340795f48db5bc","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-06-14 07:32:46.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"45f6ee1b787c69f239c890e2f9a211e3ea8c9083","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-14 08:31:51.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/93/329293/2/check/gate-python-openstackclient-docs/794aef0//doc/build/html/ : SUCCESS in 4m 20s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/93/329293/2/check/gate-python-openstackclient-pep8/2754875/ : SUCCESS in 1m 45s\n- gate-python-openstackclient-python27 http://logs.openstack.org/93/329293/2/check/gate-python-openstackclient-python27/f61feff/ : SUCCESS in 3m 38s\n- gate-python-openstackclient-python34 http://logs.openstack.org/93/329293/2/check/gate-python-openstackclient-python34/6b69afb/ : SUCCESS in 3m 11s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/93/329293/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/2b40d02/ : SUCCESS in 56m 23s\n- check-osc-plugins http://logs.openstack.org/93/329293/2/check/check-osc-plugins/ec4e898/ : SUCCESS in 3m 43s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/93/329293/2/check/gate-osc-dsvm-functional/36fcc6b/ : SUCCESS in 38m 06s","accounts_in_message":[],"_revision_number":2},{"id":"0abf75e903b4599fa4c72cb69f46f2b1cd76df96","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-06-14 08:38:24.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"a14cccfd1e47a32b540e2c7558a05f17c66e16d9","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-06-14 11:37:56.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"aa0c0b07e49be64033d7d5254f23e45ea1e291bd","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-06-14 17:55:50.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"26477e6211d768a77d483aa80994d3408d957183","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-14 17:56:03.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"df399ad5139fd534eae3eda3e7ca05cabaecd085","date":"2016-06-14 19:18:21.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"87709efb6862358392d3cf0a0f351603fae38f33","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-14 19:18:21.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/93/329293/2/gate/gate-python-openstackclient-docs/b11e521//doc/build/html/ : SUCCESS in 4m 55s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/93/329293/2/gate/gate-python-openstackclient-pep8/3797a90/ : SUCCESS in 2m 34s\n- gate-python-openstackclient-python27 http://logs.openstack.org/93/329293/2/gate/gate-python-openstackclient-python27/ab2cf02/ : SUCCESS in 1m 43s\n- gate-python-openstackclient-python34 http://logs.openstack.org/93/329293/2/gate/gate-python-openstackclient-python34/46184ea/ : SUCCESS in 4m 54s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/93/329293/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/c6babe4/ : SUCCESS in 1h 09m 04s\n- gate-osc-dsvm-functional http://logs.openstack.org/93/329293/2/gate/gate-osc-dsvm-functional/b47fbc9/ : SUCCESS in 31m 41s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c4b590748a059f760beb74509efbf5a825e24d0f","revisions":{"a9235c7a79bd7cd511b752fad9f93aa2c7dadefc":{"kind":"REWORK","_number":1,"created":"2016-06-14 07:07:14.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/93/329293/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/93/329293/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/329293/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/329293/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/329293/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/93/329293/1"}}},"commit":{"parents":[{"commit":"287fe3610af6297b654dc30ee587aa0f7eecaeaa","subject":"Merge \"osc-lib: parseractions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/287fe3610af6297b654dc30ee587aa0f7eecaeaa"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-06-14 06:51:37.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-06-14 06:51:37.000000000","tz":480},"subject":"Fix errors in ``set/unset flavor`` unit tests","message":"Fix errors in ``set/unset flavor`` unit tests\n\n1. We should assert flavor.set_keys() is called correctly\n   or not called in ``set flavor`` unit tests.\n\n2. Commit c7e6973ff50ff84af9ad55f7bdaeeea83ae40f0b from me\n   removed test_flavor_unset_no_project which used to test\n   if --project was specified as \u0027\u0027, and assert CommandError\n   was raised, which is incorrect. So I removed it. But after\n   looking into the code, I think we should not remove it,\n   but specify nothing after --project, and assert\n   ParserException was raised. So in this patch, we fix it\n   as so.\n\n   (\u0027--project\u0027, \u0027\u0027) --\u003e (\u0027--project\u0027)\n   assert CommandError --\u003e assert ParserException\n\nChange-Id: Ifd33c72d5b7581aaabffb09e9b5e38ecc67e18c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a9235c7a79bd7cd511b752fad9f93aa2c7dadefc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a9235c7a79bd7cd511b752fad9f93aa2c7dadefc"}]},"branch":"refs/heads/master"},"c4b590748a059f760beb74509efbf5a825e24d0f":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2016-06-14 07:32:46.000000000","uploader":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"ref":"refs/changes/93/329293/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/93/329293/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/329293/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/329293/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/93/329293/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/93/329293/2"}}},"commit":{"parents":[{"commit":"2c92b60f457a16c315b6286592e9fee534bd4b3d","subject":"Merge \"osc-lib: command\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/2c92b60f457a16c315b6286592e9fee534bd4b3d"}]}],"author":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-06-14 06:51:37.000000000","tz":480},"committer":{"name":"Tang Chen","email":"chen.tang@easystack.cn","date":"2016-06-14 07:32:33.000000000","tz":480},"subject":"Fix errors in ``set/unset flavor`` unit tests","message":"Fix errors in ``set/unset flavor`` unit tests\n\n1. We should assert flavor.set_keys() is called correctly\n   or not called in ``set flavor`` unit tests.\n\n2. Commit c7e6973ff50ff84af9ad55f7bdaeeea83ae40f0b from me\n   removed test_flavor_unset_no_project which used to test\n   if --project was specified as \u0027\u0027, and assert CommandError\n   was raised, which is incorrect. So I removed it. But after\n   looking into the code, I think we should not remove it,\n   but specify nothing after --project, and assert\n   ParserException was raised. So in this patch, we fix it\n   as so.\n\n   (\u0027--project\u0027, \u0027\u0027) --\u003e (\u0027--project\u0027)\n   assert CommandError --\u003e assert ParserException\n\nChange-Id: Ifd33c72d5b7581aaabffb09e9b5e38ecc67e18c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c4b590748a059f760beb74509efbf5a825e24d0f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/c4b590748a059f760beb74509efbf5a825e24d0f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}