)]}'
{"openstackclient/compute/v2/flavor.py":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"6da2a518aac1c91dba81b0830760efe3012d899a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Flavor action implementations\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import logging"},{"line_number":19,"context_line":"from osc_lib.cli import parseractions"},{"line_number":20,"context_line":"from osc_lib.command import command"},{"line_number":21,"context_line":"from osc_lib import exceptions"},{"line_number":22,"context_line":"from osc_lib import utils"},{"line_number":23,"context_line":"import six"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from openstackclient.i18n import _"},{"line_number":26,"context_line":"from openstackclient.identity import common as identity_common"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_6b9a5670","line":23,"range":{"start_line":18,"start_character":0,"end_line":23,"end_character":10},"updated":"2016-06-15 11:14:53.000000000","message":"These should be like this:\n\nimport logging\nimport six\n\nfrom osc_lib.cli import parseractions\nfrom osc_lib.command import command\nfrom osc_lib import exceptions\nfrom osc_lib import utils","commit_id":"5bbaa130f4c912e3c540c5264728e745ce70db22"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a3ba75760e4df9b751451a5b94ab4c630afc5b5e","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"Flavor action implementations\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import logging"},{"line_number":19,"context_line":"from osc_lib.cli import parseractions"},{"line_number":20,"context_line":"from osc_lib.command import command"},{"line_number":21,"context_line":"from osc_lib import exceptions"},{"line_number":22,"context_line":"from osc_lib import utils"},{"line_number":23,"context_line":"import six"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from openstackclient.i18n import _"},{"line_number":26,"context_line":"from openstackclient.identity import common as identity_common"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_64c28388","line":23,"range":{"start_line":18,"start_character":0,"end_line":23,"end_character":10},"in_reply_to":"7aa08908_6b9a5670","updated":"2016-06-15 11:38:57.000000000","message":"Done.Thank you.","commit_id":"5bbaa130f4c912e3c540c5264728e745ce70db22"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"6da2a518aac1c91dba81b0830760efe3012d899a","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            except Exception as e:"},{"line_number":166,"context_line":"                msg \u003d _(\"Fail to add this new flavor access to project \""},{"line_number":167,"context_line":"                        \"\u0027%(project)s\u0027: %(e)s\")"},{"line_number":168,"context_line":"                LOG.error(msg % {\u0027project\u0027: parsed_args.project, \u0027e\u0027: e})"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        return zip(*sorted(six.iteritems(flavor)))"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_09b75af6","line":168,"range":{"start_line":168,"start_character":16,"end_line":168,"end_character":73},"updated":"2016-06-15 11:14:53.000000000","message":"I think this will only record the error in log, but not the stdout or stderr. So there won\u0027t be any output to the user, and the user may think the command just succeeded. So please also print this msg in stderr.","commit_id":"5bbaa130f4c912e3c540c5264728e745ce70db22"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a3ba75760e4df9b751451a5b94ab4c630afc5b5e","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            except Exception as e:"},{"line_number":166,"context_line":"                msg \u003d _(\"Fail to add this new flavor access to project \""},{"line_number":167,"context_line":"                        \"\u0027%(project)s\u0027: %(e)s\")"},{"line_number":168,"context_line":"                LOG.error(msg % {\u0027project\u0027: parsed_args.project, \u0027e\u0027: e})"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"        return zip(*sorted(six.iteritems(flavor)))"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_a453cbe1","line":168,"range":{"start_line":168,"start_character":16,"end_line":168,"end_character":73},"in_reply_to":"7aa08908_09b75af6","updated":"2016-06-15 11:38:57.000000000","message":"I have tested it and fond the error message will be printed to the user. May we needn\u0027t print it again.","commit_id":"5bbaa130f4c912e3c540c5264728e745ce70db22"}],"releasenotes/notes/flavor-create-with-project-19d41bfa93e3c6d0.yaml":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"81099fd9675769e81258e9c1983b430a8d54600b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add ``--project`` and ``--project-domain`` options to the ``flavor create``"},{"line_number":4,"context_line":"    command. We can use these options to add the flavor access to a givin project"},{"line_number":5,"context_line":"    when we create the flavor."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3aaa91ec_cfeba1af","line":4,"range":{"start_line":4,"start_character":68,"end_line":4,"end_character":73},"updated":"2016-06-21 16:28:03.000000000","message":"given*","commit_id":"876fcfa6674dc758361f966789bdb758cad35d95"}]}