)]}'
{"doc/source/command-objects/host.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d4bf45b672cd0fe0920fa4641689b84125fb7c40","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":".. describe:: \u003chost\u003e"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    Name of the host to modify"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"host show"},{"line_number":60,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5a9d85d2_46d81454","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":30},"updated":"2016-06-20 15:34:59.000000000","message":"refer to comment in host.py","commit_id":"2d83cac746954371e6300d21f1d12e5718077188"}],"openstackclient/compute/v2/host.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d4bf45b672cd0fe0920fa4641689b84125fb7c40","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \"host\","},{"line_number":56,"context_line":"            metavar\u003d\"\u003chost\u003e\","},{"line_number":57,"context_line":"            help\u003d_(\"Name of the host to modify\")"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":"        status \u003d parser.add_mutually_exclusive_group()"},{"line_number":60,"context_line":"        status.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_463134a2","line":57,"range":{"start_line":57,"start_character":20,"end_line":57,"end_character":46},"updated":"2016-06-20 15:34:59.000000000","message":"\"Host to modify (name only)\" may be better","commit_id":"2d83cac746954371e6300d21f1d12e5718077188"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"5ad8c59bbc9edf8fc543dc4a0c9ed2ea17ebb2fe","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            kwargs[\u0027maintenance_mode\u0027] \u003d False"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":96,"context_line":"        foundhost \u003d utils.find_resource("},{"line_number":97,"context_line":"            compute_client.hosts,"},{"line_number":98,"context_line":"            parsed_args.host"},{"line_number":99,"context_line":"        )"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        compute_client.hosts.update("},{"line_number":102,"context_line":"            foundhost.id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_b604607e","side":"PARENT","line":99,"range":{"start_line":96,"start_character":8,"end_line":99,"end_character":9},"updated":"2016-06-21 09:53:41.000000000","message":"I think you should not remove the existence check, that keep the exception consistent when the host is\u0027t exist, if the host is exist, you can use parsed_args.host in the following logic just like you do in new patch.","commit_id":"ba825a4d5c04e2e6fd8a82ebbfb2f71a85e683aa"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"d696667d6f0918e81f28c497c4b601c74e8762d0","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            kwargs[\u0027maintenance_mode\u0027] \u003d False"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":96,"context_line":"        foundhost \u003d utils.find_resource("},{"line_number":97,"context_line":"            compute_client.hosts,"},{"line_number":98,"context_line":"            parsed_args.host"},{"line_number":99,"context_line":"        )"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        compute_client.hosts.update("},{"line_number":102,"context_line":"            foundhost.id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_598f2dcc","side":"PARENT","line":99,"range":{"start_line":96,"start_character":8,"end_line":99,"end_character":9},"in_reply_to":"5a9d85d2_b604607e","updated":"2016-06-21 10:14:26.000000000","message":"Actually, the update() method will also check the existence of the host. But for the consistent of exception, we\u0027d better don\u0027t remove the check here like you said. I will follow your sugustions, thank you for reviewing.","commit_id":"ba825a4d5c04e2e6fd8a82ebbfb2f71a85e683aa"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c8e858475afbc9aa8448c44a79bafe05a77e4def","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            kwargs[\u0027maintenance_mode\u0027] \u003d \u0027disable\u0027"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":96,"context_line":"        utils.find_resource(compute_client.hosts, parsed_args.host)"},{"line_number":97,"context_line":"        compute_client.hosts.update("},{"line_number":98,"context_line":"            parsed_args.host,"},{"line_number":99,"context_line":"            kwargs"},{"line_number":100,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_d504797f","line":97,"range":{"start_line":96,"start_character":8,"end_line":97,"end_character":36},"updated":"2016-06-21 12:50:48.000000000","message":"this part is a little weird, since normally we retrieve the resource and pass that along, but in this case we are just checking to make sure it exists. if you end up doing another change for this patch then feel free to add a comment here explaining why do you this","commit_id":"d54d09c40e1fb3dc4849a9557f790bee76d60472"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"2edcc02d196100dc6079fb272e8d0ebc9bd2cbc8","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            kwargs[\u0027maintenance_mode\u0027] \u003d \u0027disable\u0027"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":96,"context_line":"        utils.find_resource(compute_client.hosts, parsed_args.host)"},{"line_number":97,"context_line":"        compute_client.hosts.update("},{"line_number":98,"context_line":"            parsed_args.host,"},{"line_number":99,"context_line":"            kwargs"},{"line_number":100,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_34ec1bc7","line":97,"range":{"start_line":96,"start_character":8,"end_line":97,"end_character":36},"in_reply_to":"5a9d85d2_d504797f","updated":"2016-06-22 02:27:25.000000000","message":"Thank you for your suggestion. I added a explanation here, but I am not sure whether this is enough. I am open to modify it if necessary.","commit_id":"d54d09c40e1fb3dc4849a9557f790bee76d60472"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"b250887c15a7b37530ddd10a826f29c42927762a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":96,"context_line":"        # More than one hosts will be returned by using find_resource()"},{"line_number":97,"context_line":"        # so that the return value cannot be used in host update() method."},{"line_number":98,"context_line":"        # find_resource() is just used for checking existence of host here."},{"line_number":99,"context_line":"        utils.find_resource(compute_client.hosts, parsed_args.host)"},{"line_number":100,"context_line":"        compute_client.hosts.update("},{"line_number":101,"context_line":"            parsed_args.host,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_f931e7ed","line":98,"range":{"start_line":98,"start_character":7,"end_line":98,"end_character":75},"updated":"2016-06-22 06:06:46.000000000","message":"I think the comment could be more detailed here. Why should we check the existence of the host ? What if we just pass the host name to update() ?","commit_id":"db942ee6523d851f94c490e3388281ff002f53a8"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"aa67a0f038814d006d537688fd8071e9410997b9","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        compute_client \u003d self.app.client_manager.compute"},{"line_number":96,"context_line":"        # More than one hosts will be returned by using find_resource()"},{"line_number":97,"context_line":"        # so that the return value cannot be used in host update() method."},{"line_number":98,"context_line":"        # find_resource() is just used for checking existence of host here."},{"line_number":99,"context_line":"        utils.find_resource(compute_client.hosts, parsed_args.host)"},{"line_number":100,"context_line":"        compute_client.hosts.update("},{"line_number":101,"context_line":"            parsed_args.host,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_397ecfe4","line":98,"range":{"start_line":98,"start_character":7,"end_line":98,"end_character":75},"in_reply_to":"3aaa91ec_f931e7ed","updated":"2016-06-22 06:23:08.000000000","message":"Done.Thank you.","commit_id":"db942ee6523d851f94c490e3388281ff002f53a8"}]}