)]}'
{"openstackclient/compute/v2/flavor.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"05f6aad1ded58d35cf8447dffbf5d349889a001d","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                LOG.error(msg % {\u0027project\u0027: parsed_args.project, \u0027e\u0027: e})"},{"line_number":175,"context_line":"        if parsed_args.property:"},{"line_number":176,"context_line":"            try:"},{"line_number":177,"context_line":"                flavor.set_keys(parsed_args.property)"},{"line_number":178,"context_line":"            except Exception as e:"},{"line_number":179,"context_line":"                LOG.error(_(\"Failed to set flavor property: %s\"), e)"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_d9eb2711","line":177,"range":{"start_line":177,"start_character":32,"end_line":177,"end_character":52},"updated":"2016-06-28 13:28:46.000000000","message":"set_keys takes a list of props? \n\ni think this has to be transformed into a dict of dicts:\n\nhttp://developer.openstack.org/api-ref-compute-v2.1.html#createFlavorExtraSpec\n\nand \n\nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/v2/flavors.py#L55-L65","commit_id":"0b226ad3c432f8f391fe4c7fdae3958e9f6d0be3"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"a5a608dc6f6cd11f45fe43d77352cec8216915a0","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        flavor_info \u003d flavor._info.copy()"},{"line_number":182,"context_line":"        flavor_info.pop(\"links\")"},{"line_number":183,"context_line":"        flavor_info[\u0027properties\u0027] \u003d utils.format_dict(flavor.get_keys())"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        return zip(*sorted(six.iteritems(flavor_info)))"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_0e4c196f","line":183,"range":{"start_line":183,"start_character":42,"end_line":183,"end_character":54},"updated":"2016-06-29 09:18:31.000000000","message":"Doug try to resolve the dict format issue in cliff, we shouldn\u0027t format dict data by ourselves.\n\nhttps://review.openstack.org/#/c/330223/","commit_id":"0b226ad3c432f8f391fe4c7fdae3958e9f6d0be3"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"2354d48220dab62335f60896583fcbf37462d2de","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        flavor_info \u003d flavor._info.copy()"},{"line_number":182,"context_line":"        flavor_info.pop(\"links\")"},{"line_number":183,"context_line":"        flavor_info[\u0027properties\u0027] \u003d utils.format_dict(flavor.get_keys())"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        return zip(*sorted(six.iteritems(flavor_info)))"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_d553b537","line":183,"range":{"start_line":183,"start_character":42,"end_line":183,"end_character":54},"in_reply_to":"3aaa91ec_0e4c196f","updated":"2016-06-29 11:16:27.000000000","message":"Yea, but before that patch being merged, we may still format the data, so I think we need not modify it in this patch.","commit_id":"0b226ad3c432f8f391fe4c7fdae3958e9f6d0be3"}],"openstackclient/tests/compute/v2/test_flavor.py":[{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"a5a608dc6f6cd11f45fe43d77352cec8216915a0","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            \u0027--vcpus\u0027, str(self.flavor.vcpus),"},{"line_number":127,"context_line":"            \u0027--rxtx-factor\u0027, str(self.flavor.rxtx_factor),"},{"line_number":128,"context_line":"            \u0027--public\u0027,"},{"line_number":129,"context_line":"            \u0027--property\u0027, \u0027property\u003d\"value\"\u0027,"},{"line_number":130,"context_line":"            self.flavor.name,"},{"line_number":131,"context_line":"        ]"},{"line_number":132,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_3485e258","line":129,"range":{"start_line":129,"start_character":36,"end_line":129,"end_character":37},"updated":"2016-06-29 09:18:31.000000000","message":"all the double quotation marks isn\u0027t necessary.\n\nI would like you can add a test case with multiple \"--property\" options, like this:\n\n    flavor create --property key1\u003dvalue1 --property key2\u003dvalue2 test_flavor","commit_id":"0b226ad3c432f8f391fe4c7fdae3958e9f6d0be3"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"2354d48220dab62335f60896583fcbf37462d2de","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            \u0027--vcpus\u0027, str(self.flavor.vcpus),"},{"line_number":127,"context_line":"            \u0027--rxtx-factor\u0027, str(self.flavor.rxtx_factor),"},{"line_number":128,"context_line":"            \u0027--public\u0027,"},{"line_number":129,"context_line":"            \u0027--property\u0027, \u0027property\u003d\"value\"\u0027,"},{"line_number":130,"context_line":"            self.flavor.name,"},{"line_number":131,"context_line":"        ]"},{"line_number":132,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_151b7d81","line":129,"range":{"start_line":129,"start_character":36,"end_line":129,"end_character":37},"in_reply_to":"3aaa91ec_3485e258","updated":"2016-06-29 11:16:27.000000000","message":"Done. I added both functional test and unit test for multi properties :)","commit_id":"0b226ad3c432f8f391fe4c7fdae3958e9f6d0be3"}]}