)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"033899c224e3a24187dedf923a75576b8305dc19","unresolved":false,"context_lines":[{"line_number":14,"context_line":"to avoid this."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ide640e2cab3936d419ca62105304ff5d4a8a2074"},{"line_number":17,"context_line":"Related-Bug: #1602588"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_d0bacd22","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":21},"updated":"2016-07-19 08:19:55.000000000","message":"Can this bug be closed?","commit_id":"1217fdcc85b28f590a240e156273b0f9850fcdec"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"da49e369bee1dc4e47861a253161911b7938fbda","unresolved":false,"context_lines":[{"line_number":14,"context_line":"to avoid this."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ide640e2cab3936d419ca62105304ff5d4a8a2074"},{"line_number":17,"context_line":"Related-Bug: #1602588"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_1090e542","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":21},"in_reply_to":"dada55a8_d0bacd22","updated":"2016-07-19 08:26:08.000000000","message":"The bug status is still new now.\nI think this bug can be closed after this fix merged.","commit_id":"1217fdcc85b28f590a240e156273b0f9850fcdec"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"a513f274f499a5e82062895eadbcd715081e00fa","unresolved":false,"context_lines":[{"line_number":14,"context_line":"to avoid this."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ide640e2cab3936d419ca62105304ff5d4a8a2074"},{"line_number":17,"context_line":"Related-Bug: #1602588"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dada55a8_d04acdc4","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":21},"updated":"2016-07-19 08:30:23.000000000","message":"If this bug can be closed after this patch, you can write like this\n\"Closes-Bug: #1602588\"\nThank you for contribution in OpenStackClient :)","commit_id":"95feee3fc631d4015a0506c0a14f89c0ca3bc9cc"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"8fba282521736f6a499cdd4b847b9453eb16d582","unresolved":false,"context_lines":[{"line_number":14,"context_line":"to avoid this."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ide640e2cab3936d419ca62105304ff5d4a8a2074"},{"line_number":17,"context_line":"Related-Bug: #1602588"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dada55a8_c94504b4","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":21},"in_reply_to":"dada55a8_d04acdc4","updated":"2016-07-19 09:12:55.000000000","message":"Thanks for your comments :)","commit_id":"95feee3fc631d4015a0506c0a14f89c0ca3bc9cc"}],"openstackclient/network/v2/subnet.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"60c555c722ea33989ddff5361444d8a2b1fbf937","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        attrs[\u0027allocation_pools\u0027] \u003d parsed_args.allocation_pools"},{"line_number":169,"context_line":"    if parsed_args.dhcp:"},{"line_number":170,"context_line":"        attrs[\u0027enable_dhcp\u0027] \u003d True"},{"line_number":171,"context_line":"    elif parsed_args.no_dhcp:"},{"line_number":172,"context_line":"        attrs[\u0027enable_dhcp\u0027] \u003d False"},{"line_number":173,"context_line":"    if (\u0027dns_nameservers\u0027 in parsed_args and"},{"line_number":174,"context_line":"       parsed_args.dns_nameservers is not None):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_795b3c55","side":"PARENT","line":171,"range":{"start_line":171,"start_character":4,"end_line":171,"end_character":8},"updated":"2016-07-18 12:18:21.000000000","message":"let\u0027s just change this to:\n\n  if parsed_args.no_dhcp:\n    ...\n\n?\n\nit\u0027s the more commonly used convention: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/network/v2/address_scope.py#L42-L45","commit_id":"5a21eb25558c4820bdf1eec3f0d25fca00e7fd24"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"935831c05939306b560812d7df7516ac1ae05437","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        attrs[\u0027allocation_pools\u0027] \u003d parsed_args.allocation_pools"},{"line_number":169,"context_line":"    if parsed_args.dhcp:"},{"line_number":170,"context_line":"        attrs[\u0027enable_dhcp\u0027] \u003d True"},{"line_number":171,"context_line":"    elif parsed_args.no_dhcp:"},{"line_number":172,"context_line":"        attrs[\u0027enable_dhcp\u0027] \u003d False"},{"line_number":173,"context_line":"    if (\u0027dns_nameservers\u0027 in parsed_args and"},{"line_number":174,"context_line":"       parsed_args.dns_nameservers is not None):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_2804c713","side":"PARENT","line":171,"range":{"start_line":171,"start_character":4,"end_line":171,"end_character":8},"in_reply_to":"dada55a8_795b3c55","updated":"2016-07-18 13:58:13.000000000","message":"I agree with steve","commit_id":"5a21eb25558c4820bdf1eec3f0d25fca00e7fd24"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"935831c05939306b560812d7df7516ac1ae05437","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        dhcp_enable_group.add_argument("},{"line_number":224,"context_line":"            \u0027--dhcp\u0027,"},{"line_number":225,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":226,"context_line":"            default\u003dTrue,"},{"line_number":227,"context_line":"            help\u003d_(\"Enable DHCP (default)\")"},{"line_number":228,"context_line":"        )"},{"line_number":229,"context_line":"        dhcp_enable_group.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_25c192e5","side":"PARENT","line":226,"range":{"start_line":226,"start_character":12,"end_line":226,"end_character":25},"updated":"2016-07-18 13:58:13.000000000","message":"I think the main cause of this bug is here.\nwhen we use \"--dncp\" option. the \"dhcp\" is \"True\"\nand the \"no_dhcp\" is \"False\". It is OK.\nBut when we use \"--no-dhcp\" option, the \"no_dhcp\"\nis \"True\" and the \"dhcp\" also is \"True\" because\nthe default value is \"Ture\".\nI think we should delete the \"default\u003dTrue\" here.\nAfter deleting, \"dhcp\" and \"no_dhcp\" can be both\n\"False\" so that the \u0027enable_dhcp\u0027 in \"attrs\" may\nnot exist, and then it will create by default.","commit_id":"5a21eb25558c4820bdf1eec3f0d25fca00e7fd24"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"74d72547027c5babd7a49d7e4b757bf727e1b6af","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        dhcp_enable_group.add_argument("},{"line_number":224,"context_line":"            \u0027--dhcp\u0027,"},{"line_number":225,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":226,"context_line":"            default\u003dTrue,"},{"line_number":227,"context_line":"            help\u003d_(\"Enable DHCP (default)\")"},{"line_number":228,"context_line":"        )"},{"line_number":229,"context_line":"        dhcp_enable_group.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_b492d255","side":"PARENT","line":226,"range":{"start_line":226,"start_character":12,"end_line":226,"end_character":25},"in_reply_to":"dada55a8_25c192e5","updated":"2016-07-18 15:08:57.000000000","message":"that also matches this: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/network/v2/address_scope.py#L82-L92","commit_id":"5a21eb25558c4820bdf1eec3f0d25fca00e7fd24"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"033899c224e3a24187dedf923a75576b8305dc19","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            \u0027--dhcp\u0027,"},{"line_number":225,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":226,"context_line":"            default\u003dTrue,"},{"line_number":227,"context_line":"            help\u003d_(\"Enable DHCP (default)\")"},{"line_number":228,"context_line":"        )"},{"line_number":229,"context_line":"        dhcp_enable_group.add_argument("},{"line_number":230,"context_line":"            \u0027--no-dhcp\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_b05e3910","side":"PARENT","line":227,"range":{"start_line":227,"start_character":31,"end_line":227,"end_character":41},"updated":"2016-07-19 08:19:55.000000000","message":"\"(default)\" can not be removed here because dhcp still will be enabled by default without any options.","commit_id":"60639d76a742852e18f9e2889c480be95596c268"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"a26a0392ae4940ab492dc0010fa28a51a780135c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            \u0027--dhcp\u0027,"},{"line_number":225,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":226,"context_line":"            default\u003dTrue,"},{"line_number":227,"context_line":"            help\u003d_(\"Enable DHCP (default)\")"},{"line_number":228,"context_line":"        )"},{"line_number":229,"context_line":"        dhcp_enable_group.add_argument("},{"line_number":230,"context_line":"            \u0027--no-dhcp\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_3013690f","side":"PARENT","line":227,"range":{"start_line":227,"start_character":31,"end_line":227,"end_character":41},"in_reply_to":"dada55a8_b05e3910","updated":"2016-07-19 08:23:13.000000000","message":"Done in patch set 4","commit_id":"60639d76a742852e18f9e2889c480be95596c268"}]}