)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e3c2f5b6e5c7adf91841275ff88cdf53a016529f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Subnet service-types."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I215d83e4d4cf53e03fa35041c5e41a328641b3a9"},{"line_number":13,"context_line":"Partially-implements: blueprint service-subnets"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_c78ae3be","line":13,"updated":"2016-07-19 23:43:17.000000000","message":"Do you think we should have a depends-on here?","commit_id":"e21b4afb91bf2ed7c3d4cb0c0525bb6fd96098eb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"400324f28009cdf3115c563e9e22699d0de897ce","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Subnet service-types."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I215d83e4d4cf53e03fa35041c5e41a328641b3a9"},{"line_number":13,"context_line":"Partially-implements: blueprint service-subnets"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_5de5e9a1","line":13,"in_reply_to":"dada55a8_c78ae3be","updated":"2016-07-26 21:14:38.000000000","message":"Done","commit_id":"e21b4afb91bf2ed7c3d4cb0c0525bb6fd96098eb"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e77976c70393694bf7f662292756e20ae3beca57","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add Subnet service-types to subnets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027--service-type\u0027 to subnet arguments to support"},{"line_number":10,"context_line":"Subnet service-types."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I215d83e4d4cf53e03fa35041c5e41a328641b3a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_95243e60","line":9,"updated":"2016-07-27 11:29:17.000000000","message":"Please include a release note for this as well.","commit_id":"37b885849113b18fcded1a9d570f28685c4ab54d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"46643e2a4a6e58d3fab29e134d9c9fdd9528864c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add Subnet service-types to subnets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add \u0027--service-type\u0027 to subnet arguments to support"},{"line_number":10,"context_line":"Subnet service-types."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I215d83e4d4cf53e03fa35041c5e41a328641b3a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_c309a5df","line":9,"in_reply_to":"dada55a8_95243e60","updated":"2016-07-27 19:12:35.000000000","message":"Done","commit_id":"37b885849113b18fcded1a9d570f28685c4ab54d"}],"doc/source/command-objects/subnet.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"bbfdcb7b4c44f555d123eb6ad3fcf1bb91862cbc","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"     Service Type for this subnet e.g.:"},{"line_number":123,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":124,"context_line":"     Must be a valid device_owner value for a Neutron port"},{"line_number":125,"context_line":"     (repeat option to set multiple Service Types)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":".. option:: --network \u003cnetwork\u003e"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bacf61ea_a1e60d14","line":124,"range":{"start_line":124,"start_character":46,"end_line":124,"end_character":53},"updated":"2016-08-03 04:21:31.000000000","message":"can we write \"network\" instead of the project name?","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c31116405cc8bd465d2ec6d00ef24096b7e03d69","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"     Service Type for this subnet e.g.:"},{"line_number":123,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":124,"context_line":"     Must be a valid device_owner value for a Neutron port"},{"line_number":125,"context_line":"     (repeat option to set multiple Service Types)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":".. option:: --network \u003cnetwork\u003e"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bacf61ea_ec872e10","line":124,"range":{"start_line":124,"start_character":46,"end_line":124,"end_character":53},"in_reply_to":"bacf61ea_a1e60d14","updated":"2016-08-03 19:51:06.000000000","message":"Done","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"bbfdcb7b4c44f555d123eb6ad3fcf1bb91862cbc","unresolved":false,"context_lines":[{"line_number":122,"context_line":"     Service Type for this subnet e.g.:"},{"line_number":123,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":124,"context_line":"     Must be a valid device_owner value for a Neutron port"},{"line_number":125,"context_line":"     (repeat option to set multiple Service Types)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":".. option:: --network \u003cnetwork\u003e"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bacf61ea_41b8f1e5","line":125,"range":{"start_line":125,"start_character":36,"end_line":125,"end_character":49},"updated":"2016-08-03 04:21:31.000000000","message":"this should be lower case unless starting a sentence","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c31116405cc8bd465d2ec6d00ef24096b7e03d69","unresolved":false,"context_lines":[{"line_number":122,"context_line":"     Service Type for this subnet e.g.:"},{"line_number":123,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":124,"context_line":"     Must be a valid device_owner value for a Neutron port"},{"line_number":125,"context_line":"     (repeat option to set multiple Service Types)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":".. option:: --network \u003cnetwork\u003e"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bacf61ea_cc8a2a1a","line":125,"range":{"start_line":125,"start_character":36,"end_line":125,"end_character":49},"in_reply_to":"bacf61ea_41b8f1e5","updated":"2016-08-03 19:51:06.000000000","message":"Done","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"bbfdcb7b4c44f555d123eb6ad3fcf1bb91862cbc","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"     Service Type for this subnet e.g.:"},{"line_number":226,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":227,"context_line":"     Must be a valid device_owner value for a Neutron port"},{"line_number":228,"context_line":"     (repeat option to set multiple Service Types)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":".. option:: --name"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bacf61ea_e1f005cc","line":227,"range":{"start_line":227,"start_character":46,"end_line":227,"end_character":53},"updated":"2016-08-03 04:21:31.000000000","message":"same","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c31116405cc8bd465d2ec6d00ef24096b7e03d69","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"     Service Type for this subnet e.g.:"},{"line_number":226,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":227,"context_line":"     Must be a valid device_owner value for a Neutron port"},{"line_number":228,"context_line":"     (repeat option to set multiple Service Types)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":".. option:: --name"}],"source_content_type":"text/x-rst","patch_set":6,"id":"bacf61ea_4c775a3b","line":227,"range":{"start_line":227,"start_character":46,"end_line":227,"end_character":53},"in_reply_to":"bacf61ea_e1f005cc","updated":"2016-08-03 19:51:06.000000000","message":"Done","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"bbfdcb7b4c44f555d123eb6ad3fcf1bb91862cbc","unresolved":false,"context_lines":[{"line_number":225,"context_line":"     Service Type for this subnet e.g.:"},{"line_number":226,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":227,"context_line":"     Must be a valid device_owner value for a Neutron port"},{"line_number":228,"context_line":"     (repeat option to set multiple Service Types)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":".. option:: --name"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bacf61ea_a1cd6d88","line":228,"range":{"start_line":228,"start_character":36,"end_line":228,"end_character":49},"updated":"2016-08-03 04:21:31.000000000","message":"same","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c31116405cc8bd465d2ec6d00ef24096b7e03d69","unresolved":false,"context_lines":[{"line_number":225,"context_line":"     Service Type for this subnet e.g.:"},{"line_number":226,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":227,"context_line":"     Must be a valid device_owner value for a Neutron port"},{"line_number":228,"context_line":"     (repeat option to set multiple Service Types)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":".. option:: --name"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bacf61ea_ac76d63b","line":228,"range":{"start_line":228,"start_character":36,"end_line":228,"end_character":49},"in_reply_to":"bacf61ea_a1cd6d88","updated":"2016-08-03 19:51:06.000000000","message":"Done","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"34905d66774cec3aa65130174be84d1da0a05052","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"     Service type for this subnet e.g.:"},{"line_number":123,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":124,"context_line":"     Must be a valid device_owner value for a network port"},{"line_number":125,"context_line":"     (repeat option to set multiple service types)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":".. option:: --network \u003cnetwork\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_de2e258b","line":124,"range":{"start_line":124,"start_character":27,"end_line":124,"end_character":28},"updated":"2016-08-04 13:21:42.000000000","message":"You can drop the underscore here.","commit_id":"2a9bb9f2a8014f887ab7c95f8b2bf22c989d865a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8cb53420dcfef3826bd0eea1705533726bb072a4","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"     Service type for this subnet e.g.:"},{"line_number":123,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":124,"context_line":"     Must be a valid device_owner value for a network port"},{"line_number":125,"context_line":"     (repeat option to set multiple service types)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":".. option:: --network \u003cnetwork\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_55ea0b10","line":124,"range":{"start_line":124,"start_character":27,"end_line":124,"end_character":28},"in_reply_to":"bacf61ea_de2e258b","updated":"2016-08-04 15:36:04.000000000","message":"Yeah, was just trying to be specific where the values were coming from, but _ not necessary.","commit_id":"2a9bb9f2a8014f887ab7c95f8b2bf22c989d865a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"34905d66774cec3aa65130174be84d1da0a05052","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"     Service type for this subnet e.g.:"},{"line_number":226,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":227,"context_line":"     Must be a valid device_owner value for a network port"},{"line_number":228,"context_line":"     (repeat option to set multiple service types)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":".. option:: --name"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_be42513c","line":227,"range":{"start_line":227,"start_character":27,"end_line":227,"end_character":28},"updated":"2016-08-04 13:21:42.000000000","message":"same as above","commit_id":"2a9bb9f2a8014f887ab7c95f8b2bf22c989d865a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8cb53420dcfef3826bd0eea1705533726bb072a4","unresolved":false,"context_lines":[{"line_number":224,"context_line":""},{"line_number":225,"context_line":"     Service type for this subnet e.g.:"},{"line_number":226,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":227,"context_line":"     Must be a valid device_owner value for a network port"},{"line_number":228,"context_line":"     (repeat option to set multiple service types)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":".. option:: --name"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_554e8b6f","line":227,"range":{"start_line":227,"start_character":27,"end_line":227,"end_character":28},"in_reply_to":"bacf61ea_be42513c","updated":"2016-08-04 15:36:04.000000000","message":"Done","commit_id":"2a9bb9f2a8014f887ab7c95f8b2bf22c989d865a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8cb53420dcfef3826bd0eea1705533726bb072a4","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":".. option:: --service-type \u003cservice-type\u003e"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"     Service type for this subnet e.g.:"},{"line_number":293,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":294,"context_line":"     Must be a valid device_owner value for a network port"},{"line_number":295,"context_line":"     (repeat option to set multiple service types)"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_35a157f9","line":292,"updated":"2016-08-04 15:36:04.000000000","message":"I\u0027ll add a \"to be removed\" here as well.","commit_id":"2a9bb9f2a8014f887ab7c95f8b2bf22c989d865a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"34905d66774cec3aa65130174be84d1da0a05052","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"     Service type for this subnet e.g.:"},{"line_number":293,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":294,"context_line":"     Must be a valid device_owner value for a network port"},{"line_number":295,"context_line":"     (repeat option to set multiple service types)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":".. _subnet_unset-subnet:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_9e666deb","line":294,"range":{"start_line":294,"start_character":27,"end_line":294,"end_character":28},"updated":"2016-08-04 13:21:42.000000000","message":"same as above","commit_id":"2a9bb9f2a8014f887ab7c95f8b2bf22c989d865a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8cb53420dcfef3826bd0eea1705533726bb072a4","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":"     Service type for this subnet e.g.:"},{"line_number":293,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":294,"context_line":"     Must be a valid device_owner value for a network port"},{"line_number":295,"context_line":"     (repeat option to set multiple service types)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":".. _subnet_unset-subnet:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_75590f35","line":294,"range":{"start_line":294,"start_character":27,"end_line":294,"end_character":28},"in_reply_to":"bacf61ea_9e666deb","updated":"2016-08-04 15:36:04.000000000","message":"Done","commit_id":"2a9bb9f2a8014f887ab7c95f8b2bf22c989d865a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"34905d66774cec3aa65130174be84d1da0a05052","unresolved":false,"context_lines":[{"line_number":292,"context_line":"     Service type for this subnet e.g.:"},{"line_number":293,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":294,"context_line":"     Must be a valid device_owner value for a network port"},{"line_number":295,"context_line":"     (repeat option to set multiple service types)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":".. _subnet_unset-subnet:"},{"line_number":298,"context_line":".. describe:: \u003csubnet\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_de5c651b","line":295,"range":{"start_line":295,"start_character":23,"end_line":295,"end_character":26},"updated":"2016-08-04 13:21:42.000000000","message":"unset","commit_id":"2a9bb9f2a8014f887ab7c95f8b2bf22c989d865a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8cb53420dcfef3826bd0eea1705533726bb072a4","unresolved":false,"context_lines":[{"line_number":292,"context_line":"     Service type for this subnet e.g.:"},{"line_number":293,"context_line":"     ``network:floatingip_agent_gateway``"},{"line_number":294,"context_line":"     Must be a valid device_owner value for a network port"},{"line_number":295,"context_line":"     (repeat option to set multiple service types)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":".. _subnet_unset-subnet:"},{"line_number":298,"context_line":".. describe:: \u003csubnet\u003e"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_d5427b3d","line":295,"range":{"start_line":295,"start_character":23,"end_line":295,"end_character":26},"in_reply_to":"bacf61ea_de5c651b","updated":"2016-08-04 15:36:04.000000000","message":"Done","commit_id":"2a9bb9f2a8014f887ab7c95f8b2bf22c989d865a"}],"openstackclient/network/v2/subnet.py":[{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"1515e8f3054c3e7e62d7c4371affb6fecfb69dee","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        metavar\u003d\u0027\u003cservice-type\u003e\u0027,"},{"line_number":89,"context_line":"        action\u003d\u0027append\u0027,"},{"line_number":90,"context_line":"        dest\u003d\u0027service_types\u0027,"},{"line_number":91,"context_line":"        help\u003d_(\"Service Type for this subnet \""},{"line_number":92,"context_line":"               \"(repeat option to set multiple Service Types)\")"},{"line_number":93,"context_line":"    )"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_b9c12b83","line":91,"updated":"2016-07-18 14:52:59.000000000","message":"Perhaps a note here to mention that a service type must be a valid device owner?","commit_id":"e21b4afb91bf2ed7c3d4cb0c0525bb6fd96098eb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"400324f28009cdf3115c563e9e22699d0de897ce","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        metavar\u003d\u0027\u003cservice-type\u003e\u0027,"},{"line_number":89,"context_line":"        action\u003d\u0027append\u0027,"},{"line_number":90,"context_line":"        dest\u003d\u0027service_types\u0027,"},{"line_number":91,"context_line":"        help\u003d_(\"Service Type for this subnet \""},{"line_number":92,"context_line":"               \"(repeat option to set multiple Service Types)\")"},{"line_number":93,"context_line":"    )"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_49a7ef0a","line":91,"in_reply_to":"dada55a8_b9c12b83","updated":"2016-07-26 21:14:38.000000000","message":"I added a couple of sentences, let me know if it\u0027s clear","commit_id":"e21b4afb91bf2ed7c3d4cb0c0525bb6fd96098eb"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e77976c70393694bf7f662292756e20ae3beca57","unresolved":false,"context_lines":[{"line_number":84,"context_line":"               \"(repeat option to add multiple routes)\")"},{"line_number":85,"context_line":"    )"},{"line_number":86,"context_line":"    parser.add_argument("},{"line_number":87,"context_line":"        \u0027--service-type\u0027,"},{"line_number":88,"context_line":"        metavar\u003d\u0027\u003cservice-type\u003e\u0027,"},{"line_number":89,"context_line":"        action\u003d\u0027append\u0027,"},{"line_number":90,"context_line":"        dest\u003d\u0027service_types\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_353c7292","line":87,"updated":"2016-07-27 11:29:17.000000000","message":"OSC has documentation for each command that needs to be updated for interface changes such as new options.  Please update doc/source/command-objects/subnet.rst","commit_id":"37b885849113b18fcded1a9d570f28685c4ab54d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"46643e2a4a6e58d3fab29e134d9c9fdd9528864c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"               \"(repeat option to add multiple routes)\")"},{"line_number":85,"context_line":"    )"},{"line_number":86,"context_line":"    parser.add_argument("},{"line_number":87,"context_line":"        \u0027--service-type\u0027,"},{"line_number":88,"context_line":"        metavar\u003d\u0027\u003cservice-type\u003e\u0027,"},{"line_number":89,"context_line":"        action\u003d\u0027append\u0027,"},{"line_number":90,"context_line":"        dest\u003d\u0027service_types\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_7d969195","line":87,"in_reply_to":"dada55a8_353c7292","updated":"2016-07-27 19:12:35.000000000","message":"Done","commit_id":"37b885849113b18fcded1a9d570f28685c4ab54d"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"bbfdcb7b4c44f555d123eb6ad3fcf1bb91862cbc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"               \"(repeat option to add multiple routes)\")"},{"line_number":85,"context_line":"    )"},{"line_number":86,"context_line":"    parser.add_argument("},{"line_number":87,"context_line":"        \u0027--service-type\u0027,"},{"line_number":88,"context_line":"        metavar\u003d\u0027\u003cservice-type\u003e\u0027,"},{"line_number":89,"context_line":"        action\u003d\u0027append\u0027,"},{"line_number":90,"context_line":"        dest\u003d\u0027service_types\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_018c3934","line":87,"range":{"start_line":87,"start_character":11,"end_line":87,"end_character":23},"updated":"2016-08-03 04:21:31.000000000","message":"are there a list of valid types the user can pick from? if so, we can use choices\u003d[\u0027a\u0027, \u0027b\u0027, ... ]","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"490737254a6d2db62b8ba45aa143e7dedb1e9850","unresolved":false,"context_lines":[{"line_number":84,"context_line":"               \"(repeat option to add multiple routes)\")"},{"line_number":85,"context_line":"    )"},{"line_number":86,"context_line":"    parser.add_argument("},{"line_number":87,"context_line":"        \u0027--service-type\u0027,"},{"line_number":88,"context_line":"        metavar\u003d\u0027\u003cservice-type\u003e\u0027,"},{"line_number":89,"context_line":"        action\u003d\u0027append\u0027,"},{"line_number":90,"context_line":"        dest\u003d\u0027service_types\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_0d88ce21","line":87,"range":{"start_line":87,"start_character":11,"end_line":87,"end_character":23},"in_reply_to":"bacf61ea_018c3934","updated":"2016-08-03 15:12:18.000000000","message":"The list is plugin-dependent, so this probably isn\u0027t practical.","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c31116405cc8bd465d2ec6d00ef24096b7e03d69","unresolved":false,"context_lines":[{"line_number":84,"context_line":"               \"(repeat option to add multiple routes)\")"},{"line_number":85,"context_line":"    )"},{"line_number":86,"context_line":"    parser.add_argument("},{"line_number":87,"context_line":"        \u0027--service-type\u0027,"},{"line_number":88,"context_line":"        metavar\u003d\u0027\u003cservice-type\u003e\u0027,"},{"line_number":89,"context_line":"        action\u003d\u0027append\u0027,"},{"line_number":90,"context_line":"        dest\u003d\u0027service_types\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_0c0f2289","line":87,"range":{"start_line":87,"start_character":11,"end_line":87,"end_character":23},"in_reply_to":"bacf61ea_0d88ce21","updated":"2016-08-03 19:51:06.000000000","message":"We have to leave this intentionally open so we don\u0027t have to come and update it whenever a new port type is added, any validation is done in the server.","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"490737254a6d2db62b8ba45aa143e7dedb1e9850","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        dest\u003d\u0027service_types\u0027,"},{"line_number":91,"context_line":"        help\u003d_(\"Service Type for this subnet \""},{"line_number":92,"context_line":"               \"e.g.: network:floatingip_agent_gateway \""},{"line_number":93,"context_line":"               \"Must be a valid device_owner value for a Neutron port \""},{"line_number":94,"context_line":"               \"(repeat option to set multiple Service Types)\")"},{"line_number":95,"context_line":"    )"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_8d267e14","line":93,"range":{"start_line":93,"start_character":57,"end_line":93,"end_character":64},"updated":"2016-08-03 15:12:18.000000000","message":"This should be changed in line with Steve\u0027s comments in doc/source/command-objects/subnet.rst for consistency.","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c31116405cc8bd465d2ec6d00ef24096b7e03d69","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        dest\u003d\u0027service_types\u0027,"},{"line_number":91,"context_line":"        help\u003d_(\"Service Type for this subnet \""},{"line_number":92,"context_line":"               \"e.g.: network:floatingip_agent_gateway \""},{"line_number":93,"context_line":"               \"Must be a valid device_owner value for a Neutron port \""},{"line_number":94,"context_line":"               \"(repeat option to set multiple Service Types)\")"},{"line_number":95,"context_line":"    )"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_2cfe666b","line":93,"range":{"start_line":93,"start_character":57,"end_line":93,"end_character":64},"in_reply_to":"bacf61ea_8d267e14","updated":"2016-08-03 19:51:06.000000000","message":"Done","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"490737254a6d2db62b8ba45aa143e7dedb1e9850","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        help\u003d_(\"Service Type for this subnet \""},{"line_number":92,"context_line":"               \"e.g.: network:floatingip_agent_gateway \""},{"line_number":93,"context_line":"               \"Must be a valid device_owner value for a Neutron port \""},{"line_number":94,"context_line":"               \"(repeat option to set multiple Service Types)\")"},{"line_number":95,"context_line":"    )"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_ad1b82c9","line":94,"range":{"start_line":94,"start_character":47,"end_line":94,"end_character":60},"updated":"2016-08-03 15:12:18.000000000","message":"ditto","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c31116405cc8bd465d2ec6d00ef24096b7e03d69","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        help\u003d_(\"Service Type for this subnet \""},{"line_number":92,"context_line":"               \"e.g.: network:floatingip_agent_gateway \""},{"line_number":93,"context_line":"               \"Must be a valid device_owner value for a Neutron port \""},{"line_number":94,"context_line":"               \"(repeat option to set multiple Service Types)\")"},{"line_number":95,"context_line":"    )"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_0c01e26a","line":94,"range":{"start_line":94,"start_character":47,"end_line":94,"end_character":60},"in_reply_to":"bacf61ea_ad1b82c9","updated":"2016-08-03 19:51:06.000000000","message":"Done","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"bbfdcb7b4c44f555d123eb6ad3fcf1bb91862cbc","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        headers \u003d (\u0027ID\u0027, \u0027Name\u0027, \u0027Network\u0027, \u0027Subnet\u0027)"},{"line_number":368,"context_line":"        columns \u003d (\u0027id\u0027, \u0027name\u0027, \u0027network_id\u0027, \u0027cidr\u0027)"},{"line_number":369,"context_line":"        if parsed_args.long:"},{"line_number":370,"context_line":"            headers +\u003d (\u0027Project\u0027, \u0027DHCP\u0027, \u0027Name Servers\u0027,"},{"line_number":371,"context_line":"                        \u0027Allocation Pools\u0027, \u0027Host Routes\u0027, \u0027IP Version\u0027,"},{"line_number":372,"context_line":"                        \u0027Gateway\u0027)"},{"line_number":373,"context_line":"            columns +\u003d (\u0027tenant_id\u0027, \u0027enable_dhcp\u0027, \u0027dns_nameservers\u0027,"},{"line_number":374,"context_line":"                        \u0027allocation_pools\u0027, \u0027host_routes\u0027, \u0027ip_version\u0027,"},{"line_number":375,"context_line":"                        \u0027gateway_ip\u0027, \u0027service_types\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_01a559b4","line":372,"range":{"start_line":370,"start_character":12,"end_line":372,"end_character":34},"updated":"2016-08-03 04:21:31.000000000","message":"you need to add the the headers here \"Service Types\"","commit_id":"b6da3356686d30ea96b193ba3982bcd37ffc282e"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"34905d66774cec3aa65130174be84d1da0a05052","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                        \u0027Gateway\u0027)"},{"line_number":373,"context_line":"            columns +\u003d (\u0027tenant_id\u0027, \u0027enable_dhcp\u0027, \u0027dns_nameservers\u0027,"},{"line_number":374,"context_line":"                        \u0027allocation_pools\u0027, \u0027host_routes\u0027, \u0027ip_version\u0027,"},{"line_number":375,"context_line":"                        \u0027gateway_ip\u0027, \u0027service_types\u0027)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        return (headers,"},{"line_number":378,"context_line":"                (utils.get_item_properties("}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_beded16a","line":375,"updated":"2016-08-04 13:21:42.000000000","message":"You\u0027ll need a column header for this.","commit_id":"2a9bb9f2a8014f887ab7c95f8b2bf22c989d865a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8cb53420dcfef3826bd0eea1705533726bb072a4","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                        \u0027Gateway\u0027)"},{"line_number":373,"context_line":"            columns +\u003d (\u0027tenant_id\u0027, \u0027enable_dhcp\u0027, \u0027dns_nameservers\u0027,"},{"line_number":374,"context_line":"                        \u0027allocation_pools\u0027, \u0027host_routes\u0027, \u0027ip_version\u0027,"},{"line_number":375,"context_line":"                        \u0027gateway_ip\u0027, \u0027service_types\u0027)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"        return (headers,"},{"line_number":378,"context_line":"                (utils.get_item_properties("}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_15fa5343","line":375,"in_reply_to":"bacf61ea_beded16a","updated":"2016-08-04 15:36:04.000000000","message":"Done","commit_id":"2a9bb9f2a8014f887ab7c95f8b2bf22c989d865a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"34905d66774cec3aa65130174be84d1da0a05052","unresolved":false,"context_lines":[{"line_number":496,"context_line":"            metavar\u003d\u0027\u003cservice-type\u003e\u0027,"},{"line_number":497,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":498,"context_line":"            dest\u003d\u0027service_types\u0027,"},{"line_number":499,"context_line":"            help\u003d_(\u0027Service type to be removed from this subnet \u0027"},{"line_number":500,"context_line":"                   \u0027(repeat option to unset multiple service types)\u0027)"},{"line_number":501,"context_line":"        )"},{"line_number":502,"context_line":"        parser.add_argument("},{"line_number":503,"context_line":"            \u0027subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_febb290d","line":500,"range":{"start_line":499,"start_character":20,"end_line":500,"end_character":67},"updated":"2016-08-04 13:21:42.000000000","message":"This should match the documentation or vice versa.","commit_id":"2a9bb9f2a8014f887ab7c95f8b2bf22c989d865a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8cb53420dcfef3826bd0eea1705533726bb072a4","unresolved":false,"context_lines":[{"line_number":496,"context_line":"            metavar\u003d\u0027\u003cservice-type\u003e\u0027,"},{"line_number":497,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":498,"context_line":"            dest\u003d\u0027service_types\u0027,"},{"line_number":499,"context_line":"            help\u003d_(\u0027Service type to be removed from this subnet \u0027"},{"line_number":500,"context_line":"                   \u0027(repeat option to unset multiple service types)\u0027)"},{"line_number":501,"context_line":"        )"},{"line_number":502,"context_line":"        parser.add_argument("},{"line_number":503,"context_line":"            \u0027subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_3564b7b7","line":500,"range":{"start_line":499,"start_character":20,"end_line":500,"end_character":67},"in_reply_to":"bacf61ea_febb290d","updated":"2016-08-04 15:36:04.000000000","message":"Done","commit_id":"2a9bb9f2a8014f887ab7c95f8b2bf22c989d865a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fd37b9c24ffa3edd5326dd2c80437a74fc8b72aa","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        action\u003d\u0027append\u0027,"},{"line_number":90,"context_line":"        dest\u003d\u0027service_types\u0027,"},{"line_number":91,"context_line":"        help\u003d_(\"Service type for this subnet \""},{"line_number":92,"context_line":"               \"e.g.: network:floatingip_agent_gateway \""},{"line_number":93,"context_line":"               \"Must be a valid device owner value for a network port \""},{"line_number":94,"context_line":"               \"(repeat option to set multiple service types)\")"},{"line_number":95,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_74d6f64f","line":92,"range":{"start_line":92,"start_character":54,"end_line":92,"end_character":56},"updated":"2016-08-11 12:18:34.000000000","message":"Nit for next patch:\nPlease add a fullstop here","commit_id":"da9791f3196cb637c4c1edb793e7a6f3f3cf4825"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e74b3244690f834370241dd944d51d8ac07b8327","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        action\u003d\u0027append\u0027,"},{"line_number":90,"context_line":"        dest\u003d\u0027service_types\u0027,"},{"line_number":91,"context_line":"        help\u003d_(\"Service type for this subnet \""},{"line_number":92,"context_line":"               \"e.g.: network:floatingip_agent_gateway \""},{"line_number":93,"context_line":"               \"Must be a valid device owner value for a network port \""},{"line_number":94,"context_line":"               \"(repeat option to set multiple service types)\")"},{"line_number":95,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ac371cc_0b259e5b","line":92,"range":{"start_line":92,"start_character":54,"end_line":92,"end_character":56},"in_reply_to":"9ad45d7e_74d6f64f","updated":"2016-08-18 19:38:55.000000000","message":"Done","commit_id":"da9791f3196cb637c4c1edb793e7a6f3f3cf4825"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fd37b9c24ffa3edd5326dd2c80437a74fc8b72aa","unresolved":false,"context_lines":[{"line_number":497,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":498,"context_line":"            dest\u003d\u0027service_types\u0027,"},{"line_number":499,"context_line":"            help\u003d_(\u0027Service type to be removed from this subnet \u0027"},{"line_number":500,"context_line":"                   \u0027e.g.: network:floatingip_agent_gateway \u0027"},{"line_number":501,"context_line":"                   \u0027Must be a valid device owner value for a network port \u0027"},{"line_number":502,"context_line":"                   \u0027(repeat option to unset multiple service types)\u0027)"},{"line_number":503,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_144fba37","line":500,"updated":"2016-08-11 12:18:34.000000000","message":"Same here","commit_id":"da9791f3196cb637c4c1edb793e7a6f3f3cf4825"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e74b3244690f834370241dd944d51d8ac07b8327","unresolved":false,"context_lines":[{"line_number":497,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":498,"context_line":"            dest\u003d\u0027service_types\u0027,"},{"line_number":499,"context_line":"            help\u003d_(\u0027Service type to be removed from this subnet \u0027"},{"line_number":500,"context_line":"                   \u0027e.g.: network:floatingip_agent_gateway \u0027"},{"line_number":501,"context_line":"                   \u0027Must be a valid device owner value for a network port \u0027"},{"line_number":502,"context_line":"                   \u0027(repeat option to unset multiple service types)\u0027)"},{"line_number":503,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ac371cc_eb292239","line":500,"in_reply_to":"9ad45d7e_144fba37","updated":"2016-08-18 19:38:55.000000000","message":"Done","commit_id":"da9791f3196cb637c4c1edb793e7a6f3f3cf4825"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"567be78393a9474a878efd38b1381406d5db935f","unresolved":false,"context_lines":[{"line_number":367,"context_line":"            help\u003d_(\"List subnets which have DHCP disabled\")"},{"line_number":368,"context_line":"        )"},{"line_number":369,"context_line":"        parser.add_argument("},{"line_number":370,"context_line":"            \u0027--service-type\u0027,"},{"line_number":371,"context_line":"            metavar\u003d\u0027\u003cservice-type\u003e\u0027,"},{"line_number":372,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":373,"context_line":"            dest\u003d\u0027service_types\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_bd474f1c","line":370,"updated":"2016-08-19 09:10:08.000000000","message":"This is missing from the docs.","commit_id":"c052662b499e30bb3012c090ade2d976a5e8c131"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"80ebabc468134766604ab9a4d5855e8751574dad","unresolved":false,"context_lines":[{"line_number":367,"context_line":"            help\u003d_(\"List subnets which have DHCP disabled\")"},{"line_number":368,"context_line":"        )"},{"line_number":369,"context_line":"        parser.add_argument("},{"line_number":370,"context_line":"            \u0027--service-type\u0027,"},{"line_number":371,"context_line":"            metavar\u003d\u0027\u003cservice-type\u003e\u0027,"},{"line_number":372,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":373,"context_line":"            dest\u003d\u0027service_types\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_849cd26a","line":370,"in_reply_to":"3ac371cc_bd474f1c","updated":"2016-08-19 15:05:22.000000000","message":"Will add it.","commit_id":"c052662b499e30bb3012c090ade2d976a5e8c131"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"567be78393a9474a878efd38b1381406d5db935f","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                _update_arguments(tmp_obj.service_types,"},{"line_number":572,"context_line":"                                  parsed_args.service_types)"},{"line_number":573,"context_line":"            except ValueError as error:"},{"line_number":574,"context_line":"                msg \u003d (_(\"%s not in service-types\") % str(error))"},{"line_number":575,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":576,"context_line":"            attrs[\u0027service_types\u0027] \u003d tmp_obj.service_types"},{"line_number":577,"context_line":"        if attrs:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_1d0303ba","line":574,"range":{"start_line":574,"start_character":54,"end_line":574,"end_character":64},"updated":"2016-08-19 09:10:08.000000000","message":"This isn\u0027t the missing service type.","commit_id":"c052662b499e30bb3012c090ade2d976a5e8c131"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ba277de21a0f4746992b38c17ad32bfea74c1777","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                _update_arguments(tmp_obj.service_types,"},{"line_number":572,"context_line":"                                  parsed_args.service_types)"},{"line_number":573,"context_line":"            except ValueError as error:"},{"line_number":574,"context_line":"                msg \u003d (_(\"%s not in service-types\") % str(error))"},{"line_number":575,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":576,"context_line":"            attrs[\u0027service_types\u0027] \u003d tmp_obj.service_types"},{"line_number":577,"context_line":"        if attrs:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_6ac4fd91","line":574,"range":{"start_line":574,"start_character":54,"end_line":574,"end_character":64},"in_reply_to":"1ac06dbe_c416caa6","updated":"2016-08-19 15:18:39.000000000","message":"That sounds good to me.","commit_id":"c052662b499e30bb3012c090ade2d976a5e8c131"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ebe9ae6a713b6bb2309bcb775abe6ce31fb4d8e6","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                _update_arguments(tmp_obj.service_types,"},{"line_number":572,"context_line":"                                  parsed_args.service_types)"},{"line_number":573,"context_line":"            except ValueError as error:"},{"line_number":574,"context_line":"                msg \u003d (_(\"%s not in service-types\") % str(error))"},{"line_number":575,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":576,"context_line":"            attrs[\u0027service_types\u0027] \u003d tmp_obj.service_types"},{"line_number":577,"context_line":"        if attrs:"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_b2d019f9","line":574,"range":{"start_line":574,"start_character":54,"end_line":574,"end_character":64},"in_reply_to":"3ac371cc_1d0303ba","updated":"2016-08-19 09:42:17.000000000","message":"I have a fix here: https://review.openstack.org/357721","commit_id":"c052662b499e30bb3012c090ade2d976a5e8c131"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"80ebabc468134766604ab9a4d5855e8751574dad","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                _update_arguments(tmp_obj.service_types,"},{"line_number":572,"context_line":"                                  parsed_args.service_types)"},{"line_number":573,"context_line":"            except ValueError as error:"},{"line_number":574,"context_line":"                msg \u003d (_(\"%s not in service-types\") % str(error))"},{"line_number":575,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":576,"context_line":"            attrs[\u0027service_types\u0027] \u003d tmp_obj.service_types"},{"line_number":577,"context_line":"        if attrs:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1ac06dbe_c416caa6","line":574,"range":{"start_line":574,"start_character":54,"end_line":574,"end_character":64},"in_reply_to":"3ac371cc_b2d019f9","updated":"2016-08-19 15:05:22.000000000","message":"Thanks, I just figured the existing code was correct :)\n\nFor now I\u0027ll just leave this, and will either rebase on the fix if it merges first, or rebase that to fix this in that.","commit_id":"c052662b499e30bb3012c090ade2d976a5e8c131"}],"openstackclient/tests/network/v2/test_subnet.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fd37b9c24ffa3edd5326dd2c80437a74fc8b72aa","unresolved":false,"context_lines":[{"line_number":818,"context_line":"            \u0027--dns-nameserver\u0027, \u00278.8.8.8\u0027,"},{"line_number":819,"context_line":"            \u0027--host-route\u0027, \u0027destination\u003d10.30.30.30/24,gateway\u003d10.30.30.1\u0027,"},{"line_number":820,"context_line":"            \u0027--allocation-pool\u0027, \u0027start\u003d8.8.8.100,end\u003d8.8.8.150\u0027,"},{"line_number":821,"context_line":"            \u0027--service-type\u0027, \u0027network:router_gateway\u0027,"},{"line_number":822,"context_line":"            self._testsubnet.name,"},{"line_number":823,"context_line":"        ]"},{"line_number":824,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_34bf5eab","line":821,"updated":"2016-08-11 12:18:34.000000000","message":"You donot need to add it to all the CLIs if this option is  \"optional\"","commit_id":"da9791f3196cb637c4c1edb793e7a6f3f3cf4825"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e74b3244690f834370241dd944d51d8ac07b8327","unresolved":false,"context_lines":[{"line_number":818,"context_line":"            \u0027--dns-nameserver\u0027, \u00278.8.8.8\u0027,"},{"line_number":819,"context_line":"            \u0027--host-route\u0027, \u0027destination\u003d10.30.30.30/24,gateway\u003d10.30.30.1\u0027,"},{"line_number":820,"context_line":"            \u0027--allocation-pool\u0027, \u0027start\u003d8.8.8.100,end\u003d8.8.8.150\u0027,"},{"line_number":821,"context_line":"            \u0027--service-type\u0027, \u0027network:router_gateway\u0027,"},{"line_number":822,"context_line":"            self._testsubnet.name,"},{"line_number":823,"context_line":"        ]"},{"line_number":824,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"3ac371cc_ebe002fd","line":821,"in_reply_to":"9ad45d7e_34bf5eab","updated":"2016-08-18 19:38:55.000000000","message":"Right.  I left this one but removed from the other tests I had modified.","commit_id":"da9791f3196cb637c4c1edb793e7a6f3f3cf4825"}],"releasenotes/notes/subnet-service-type-8d9c414732e474a4.yaml":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"34905d66774cec3aa65130174be84d1da0a05052","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``--service-type`` option to the ``subnet create`` command."},{"line_number":5,"context_line":"    [ Blueprint `service-subnets \u003chttps://blueprints.launchpad.net/neutron/+spec/service-subnets\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bacf61ea_9ef78dd2","line":4,"range":{"start_line":4,"start_character":43,"end_line":4,"end_character":56},"updated":"2016-08-04 13:21:42.000000000","message":"The option was also added to subnet set and subnet unset.","commit_id":"2a9bb9f2a8014f887ab7c95f8b2bf22c989d865a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8cb53420dcfef3826bd0eea1705533726bb072a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``--service-type`` option to the ``subnet create`` command."},{"line_number":5,"context_line":"    [ Blueprint `service-subnets \u003chttps://blueprints.launchpad.net/neutron/+spec/service-subnets\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bacf61ea_356957fa","line":4,"range":{"start_line":4,"start_character":43,"end_line":4,"end_character":56},"in_reply_to":"bacf61ea_9ef78dd2","updated":"2016-08-04 15:36:04.000000000","message":"Done","commit_id":"2a9bb9f2a8014f887ab7c95f8b2bf22c989d865a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fd37b9c24ffa3edd5326dd2c80437a74fc8b72aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``--service-type`` option to the ``subnet create``,"},{"line_number":5,"context_line":"    ``subnet set``, and ``subnet unset`` commands."},{"line_number":6,"context_line":"    [ Blueprint `service-subnets \u003chttps://blueprints.launchpad.net/neutron/+spec/service-subnets\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9ad45d7e_54dbf21a","line":4,"updated":"2016-08-11 12:18:34.000000000","message":"Should we add a filter option in subnet list for type of service???","commit_id":"da9791f3196cb637c4c1edb793e7a6f3f3cf4825"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e74b3244690f834370241dd944d51d8ac07b8327","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add ``--service-type`` option to the ``subnet create``,"},{"line_number":5,"context_line":"    ``subnet set``, and ``subnet unset`` commands."},{"line_number":6,"context_line":"    [ Blueprint `service-subnets \u003chttps://blueprints.launchpad.net/neutron/+spec/service-subnets\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3ac371cc_ae15789c","line":4,"in_reply_to":"9ad45d7e_54dbf21a","updated":"2016-08-18 19:38:55.000000000","message":"Done","commit_id":"da9791f3196cb637c4c1edb793e7a6f3f3cf4825"}]}