)]}'
{"openstackclient/volume/v2/volume_type.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"efa2b8b69ae1bd088c28fb6d41b8498c9bc15082","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            column_headers \u003d columns"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        is_public \u003d None if parsed_args.all else parsed_args.public"},{"line_number":168,"context_line":"        data \u003d self.app.client_manager.volume.volume_types.list("},{"line_number":169,"context_line":"            is_public\u003dis_public)"},{"line_number":170,"context_line":"        return (column_headers,"},{"line_number":171,"context_line":"                (utils.get_item_properties("}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_8af0d968","line":168,"updated":"2016-07-20 11:26:33.000000000","message":"Doesn\u0027t this change behavior since is_public\u003dNone before?","commit_id":"58672250b21c48aa2e0a240ebc4e3b4539230bf3"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4ad365e38e6c44101da8251dcbffefc3310568ba","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            column_headers \u003d columns"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        is_public \u003d None if parsed_args.all else parsed_args.public"},{"line_number":168,"context_line":"        data \u003d self.app.client_manager.volume.volume_types.list("},{"line_number":169,"context_line":"            is_public\u003dis_public)"},{"line_number":170,"context_line":"        return (column_headers,"},{"line_number":171,"context_line":"                (utils.get_item_properties("}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_9a6d35cf","line":168,"in_reply_to":"dada55a8_4afeaaae","updated":"2016-07-22 18:35:07.000000000","message":"If --private and --all are admin only, that needs to be documented.\n\nIf the behaviour changes, which may be acceptable given we are approaching a major release, then it also needs to be properly documented.  However, consider that admin users may not appreciate the change in default behaviour.\n\nIf specifying --all for non-admin users is an error (passing is_public\u003dNone) then changing the default behaviour is OK, otherwise why make the change?","commit_id":"58672250b21c48aa2e0a240ebc4e3b4539230bf3"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"790c87efe27d9a0e3cc47be1c8775f4891f2bb23","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            column_headers \u003d columns"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        is_public \u003d None if parsed_args.all else parsed_args.public"},{"line_number":168,"context_line":"        data \u003d self.app.client_manager.volume.volume_types.list("},{"line_number":169,"context_line":"            is_public\u003dis_public)"},{"line_number":170,"context_line":"        return (column_headers,"},{"line_number":171,"context_line":"                (utils.get_item_properties("}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_bba371ff","line":168,"in_reply_to":"dada55a8_8af0d968","updated":"2016-07-20 12:17:06.000000000","message":"is_public \u003d None or False or True can be controlled by options \"--all/private/public\"","commit_id":"58672250b21c48aa2e0a240ebc4e3b4539230bf3"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"fe41640b414812c92b4b3e893c1b89e235e38f98","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            column_headers \u003d columns"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        is_public \u003d None if parsed_args.all else parsed_args.public"},{"line_number":168,"context_line":"        data \u003d self.app.client_manager.volume.volume_types.list("},{"line_number":169,"context_line":"            is_public\u003dis_public)"},{"line_number":170,"context_line":"        return (column_headers,"},{"line_number":171,"context_line":"                (utils.get_item_properties("}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_4afeaaae","line":168,"in_reply_to":"dada55a8_969c845e","updated":"2016-07-21 10:46:19.000000000","message":"Yea, before this change, is_public is None by default but non-admin users just can list public types and types from their own projects only, \"--all\" is the same as \"--public\" for a non-admin user. I think default\u003dpublic will be better here, not ever users were allowed to see all types, \"--all\" and \"--private\" should be admin-only options, only admin users can use these option to list more types.","commit_id":"58672250b21c48aa2e0a240ebc4e3b4539230bf3"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"2020792e13d8405e6076fa19e1b2ab16b7fdc378","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            column_headers \u003d columns"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        is_public \u003d None if parsed_args.all else parsed_args.public"},{"line_number":168,"context_line":"        data \u003d self.app.client_manager.volume.volume_types.list("},{"line_number":169,"context_line":"            is_public\u003dis_public)"},{"line_number":170,"context_line":"        return (column_headers,"},{"line_number":171,"context_line":"                (utils.get_item_properties("}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_c70ea8e4","line":168,"in_reply_to":"dada55a8_9a6d35cf","updated":"2016-07-23 03:01:44.000000000","message":"Hi, Dean.\nThanks for your reviewing, I thought for a moment about this, maybe admin user will not like the change in default like you said, and I has tested that non-admin user will not get an error with \"--all\" option, so I think keeping the default \"is_public\u003dNone (--all option)\" is the right way. I will commit a new patch set to modiy it, Thanks again :)","commit_id":"58672250b21c48aa2e0a240ebc4e3b4539230bf3"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"52332d64036be15d54ba640ec9bbdd99d1d09ddf","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            column_headers \u003d columns"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        is_public \u003d None if parsed_args.all else parsed_args.public"},{"line_number":168,"context_line":"        data \u003d self.app.client_manager.volume.volume_types.list("},{"line_number":169,"context_line":"            is_public\u003dis_public)"},{"line_number":170,"context_line":"        return (column_headers,"},{"line_number":171,"context_line":"                (utils.get_item_properties("}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_969c845e","line":168,"in_reply_to":"dada55a8_bba371ff","updated":"2016-07-20 12:31:13.000000000","message":"I understand, but before this change the default was is_public\u003dNone which is --all.","commit_id":"58672250b21c48aa2e0a240ebc4e3b4539230bf3"}]}