)]}'
{"doc/source/command-objects/console-url.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"67190ad0779279e79a440efdfb52e6ea5d148c51","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Show serial console URL"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":".. option:: --mks"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    Show WebMKS console URL"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_72b8c075","line":41,"updated":"2016-07-21 11:57:15.000000000","message":"Should this option be --webmks to align with the help text?","commit_id":"cf20225347766240a2ebb155e6e46b85f84a3ddc"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"086b9d05ff75ef29cf18ecfb636f44984d4f56a5","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Show serial console URL"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":".. option:: --mks"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    Show WebMKS console URL"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_8f0879db","line":41,"in_reply_to":"dada55a8_72b8c075","updated":"2016-07-22 07:44:29.000000000","message":"\"mks\" is consistent with current nova command \"nova get-mks-console\", I think the name \"mks\" help users swithing to osc smoothly, and the shorter option always be popular :-)\n\nI use the more exact word \"WebMKS\" in help message, it come from nova specification.\n\nhttp://specs.openstack.org/openstack/nova-specs/specs/liberty/implemented/vmware-webmks-console.html","commit_id":"cf20225347766240a2ebb155e6e46b85f84a3ddc"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"408591a9c21e45cba33937fbe043afc8b68c93e2","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Show serial console URL"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":".. option:: --mks"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    Show WebMKS console URL"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dada55a8_fc856807","line":41,"in_reply_to":"dada55a8_8f0879db","updated":"2016-07-22 11:23:13.000000000","message":"Thanks","commit_id":"cf20225347766240a2ebb155e6e46b85f84a3ddc"}],"openstackclient/compute/v2/console.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ac278226765139a5bd73b385b198361704a0d635","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        if parsed_args.url_type in [\u0027serial\u0027]:"},{"line_number":137,"context_line":"            data \u003d server.get_serial_console(parsed_args.url_type)"},{"line_number":138,"context_line":"        if parsed_args.url_type in [\u0027webmks\u0027]:"},{"line_number":139,"context_line":"            data \u003d server.get_mks_console()"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        if not data:"},{"line_number":142,"context_line":"            return ({}, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_2cb9b7cc","line":139,"range":{"start_line":139,"start_character":26,"end_line":139,"end_character":41},"updated":"2016-07-21 17:01:36.000000000","message":"no need to send in url type?","commit_id":"cf20225347766240a2ebb155e6e46b85f84a3ddc"},{"author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"change_message_id":"086b9d05ff75ef29cf18ecfb636f44984d4f56a5","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        if parsed_args.url_type in [\u0027serial\u0027]:"},{"line_number":137,"context_line":"            data \u003d server.get_serial_console(parsed_args.url_type)"},{"line_number":138,"context_line":"        if parsed_args.url_type in [\u0027webmks\u0027]:"},{"line_number":139,"context_line":"            data \u003d server.get_mks_console()"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        if not data:"},{"line_number":142,"context_line":"            return ({}, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_ef249561","line":139,"range":{"start_line":139,"start_character":26,"end_line":139,"end_character":41},"in_reply_to":"dada55a8_2cb9b7cc","updated":"2016-07-22 07:44:29.000000000","message":"Yes, mks url type is fulfilled in related novaclient logic.\n\nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L1004-L1005","commit_id":"cf20225347766240a2ebb155e6e46b85f84a3ddc"}]}
