)]}'
{"id":"openstack%2Fpython-openstackclient~346469","triplet_id":"openstack%2Fpython-openstackclient~master~I587a34187f7fa277fb25de647e6a03e972cb4e4c","project":"openstack/python-openstackclient","branch":"master","topic":"osc-lib-clientmanager2","hashtags":[],"change_id":"I587a34187f7fa277fb25de647e6a03e972cb4e4c","subject":"Revert \"Rework clientmanager\"","status":"ABANDONED","created":"2016-07-23 21:36:05.000000000","updated":"2016-07-25 14:51:26.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8e5c3285f443ee41602e8fa8f818ddfce4430de9","_number":346469,"virtual_id_number":346469,"owner":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-07-23 21:36:54.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":-1,"date":"2016-07-23 22:04:58.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"date":"2016-07-24 01:15:28.000000000","_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"date":"2016-07-25 10:50:29.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"recommended":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-07-25 06:46:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":2,"date":"2016-07-25 10:52:03.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":-1,"date":"2016-07-25 13:55:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-07-23 21:36:17.000000000","_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-07-23 21:36:17.000000000","updated_by":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"reviewer":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"state":"REVIEWER"},{"updated":"2016-07-23 22:04:58.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-07-24 01:15:28.000000000","updated_by":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"reviewer":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"state":"REVIEWER"},{"updated":"2016-07-25 10:50:29.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2016-07-25 13:55:00.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"}],"messages":[{"id":"926b4f24b9711d870ccb6c0055ce452056d5ec16","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-07-23 21:36:54.000000000","message":"Patch Set 1:\n\ni don\u0027t know the immediate solution, so we could revert so tripleo can continue to work.","accounts_in_message":[],"_revision_number":1},{"id":"40b560fc2cb84c254d98431dcb0aedfad6a026bd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-23 22:04:58.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs http://docs-draft.openstack.org/69/346469/1/check/gate-python-openstackclient-docs/9a53e7e//doc/build/html/ : SUCCESS in 3m 23s\n- gate-python-openstackclient-pep8 http://logs.openstack.org/69/346469/1/check/gate-python-openstackclient-pep8/7843b39/ : SUCCESS in 3m 43s\n- gate-python-openstackclient-python27 http://logs.openstack.org/69/346469/1/check/gate-python-openstackclient-python27/6724f9a/ : SUCCESS in 3m 59s\n- gate-python-openstackclient-python34 http://logs.openstack.org/69/346469/1/check/gate-python-openstackclient-python34/db6db4e/ : SUCCESS in 3m 32s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/69/346469/1/check/gate-python-openstackclient-python35-nv/61fa7ba/ : SUCCESS in 4m 51s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/69/346469/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/e1e4805/ : FAILURE in 28m 39s\n- check-osc-plugins http://logs.openstack.org/69/346469/1/check/check-osc-plugins/b528f74/ : SUCCESS in 4m 13s\n- gate-osc-dsvm-functional http://logs.openstack.org/69/346469/1/check/gate-osc-dsvm-functional/5342606/ : FAILURE in 24m 23s","accounts_in_message":[],"_revision_number":1},{"id":"1e1d1e3cd1cc4ec944450c10dc00cd9d3e2c7424","author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"date":"2016-07-24 01:15:28.000000000","message":"Patch Set 1:\n\nfor reference, the bug is https://bugs.launchpad.net/tripleo/+bug/1605876","accounts_in_message":[],"_revision_number":1},{"id":"c4fe6e9513d4e1077f6dded189538e0f793bfd8f","author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"date":"2016-07-25 06:45:12.000000000","message":"Patch Set 1:\n\nnoop change failed in check too: https://review.openstack.org/346550","accounts_in_message":[],"_revision_number":1},{"id":"f54fa547203bcca2ba587f9eb2ba5346e87cd133","author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"date":"2016-07-25 06:46:55.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"aa070de955f5d963d0cbcc6432b154535634b5cc","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-07-25 10:50:29.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"9d5ad8cf65bdbf015c130639816f2a856288a859","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-07-25 10:52:03.000000000","message":"Patch Set 1: Code-Review+2\n\nI\u0027m OK with the revert. And let\u0027s migrate to osc-lib when we find why.","accounts_in_message":[],"_revision_number":1},{"id":"b9e30add268f6576cf47b3ec9d7febab74015c04","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-07-25 12:18:34.000000000","message":"Patch Set 1:\n\nlooks related to setuptools release and devstack: https://review.openstack.org/#/c/346545/3","accounts_in_message":[],"_revision_number":1},{"id":"40d19c1902a8df7e39d97d6028cf04c9dbf6f9c2","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-07-25 13:55:00.000000000","message":"Patch Set 1: Code-Review-1\n\nSo you want to revert rather than fix?At the very least put in a compat attribute, which we\u0027ve done for a handful of other attributes, rather than set 3.0 back at least another week.  Move this forward...","accounts_in_message":[],"_revision_number":1},{"id":"cd9de0dbe0daeb1f027779e82781575504549cff","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-07-25 14:04:29.000000000","message":"Patch Set 1:\n\n@dean, reverts are cheap since they are just a click away. But given the OSC gate is broken right now (see previous devstack / setuptools comment), then we should probably fix this one instead.","accounts_in_message":[],"_revision_number":1},{"id":"33c66280c4dff2d227af8f05f021cc0c7c98b9e6","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-07-25 14:29:37.000000000","message":"Patch Set 1:\n\nIt looks like these clients are using private data they never should have.  Yes I am well aware that \u0027private\u0027 has not really been enforced until now, that is why a bunch of attributes are no longer private.\n\nBut the base plugins have never used _auth_params and nobody needs to.  Those are cli args before auth has happened.  The change to using only os-client-config to handle the options removed our ability to even have that data available in the same form.  Besides, anything anyone could possible want aut-related should come directly from the actual auth plugin in ClientManager.auth.  Even better yet, plugins should be using ClientManager.session and they should never need to think about auth again.","accounts_in_message":[],"_revision_number":1},{"id":"d9a31aa951bbf675e9249541d38db3f7844e92be","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-07-25 14:51:26.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5a9bfab7b5821c359fd55bb1f4684cab5e24ca59","revisions":{"5a9bfab7b5821c359fd55bb1f4684cab5e24ca59":{"kind":"REWORK","_number":1,"created":"2016-07-23 21:36:05.000000000","uploader":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"ref":"refs/changes/69/346469/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/69/346469/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/69/346469/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/69/346469/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/69/346469/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/69/346469/1"}}},"commit":{"parents":[{"commit":"f38c51c1b90576e6b13ac6086386884c09f5813a","subject":"Rework clientmanager","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f38c51c1b90576e6b13ac6086386884c09f5813a"}]}],"author":{"name":"Steve Martinelli","email":"s.martinelli@gmail.com","date":"2016-07-23 21:36:05.000000000","tz":0},"committer":{"name":"Steve Martinelli","email":"s.martinelli@gmail.com","date":"2016-07-23 21:36:05.000000000","tz":0},"subject":"Revert \"Rework clientmanager\"","message":"Revert \"Rework clientmanager\"\n\nThis reverts commit f38c51c1b90576e6b13ac6086386884c09f5813a.\n\nChange-Id: I587a34187f7fa277fb25de647e6a03e972cb4e4c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5a9bfab7b5821c359fd55bb1f4684cab5e24ca59"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/5a9bfab7b5821c359fd55bb1f4684cab5e24ca59"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}