)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8490647e9dfe5cbe50a30310c6d0fac61d603980","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add network support for \"qos policies\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added following commands:"},{"line_number":10,"context_line":"  - qos policy create"},{"line_number":11,"context_line":"  - qos policy delete"},{"line_number":12,"context_line":"  - qos policy update"},{"line_number":13,"context_line":"  - qos policy show"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9a89bdaa_c6f90650","line":10,"updated":"2016-09-13 10:55:29.000000000","message":"It would be better also add \"network\" prefix in commit message.","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb31077dab337a65618fa09a9e4b766d12634ec8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add network support for \"qos policies\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added following commands:"},{"line_number":10,"context_line":"  - qos policy create"},{"line_number":11,"context_line":"  - qos policy delete"},{"line_number":12,"context_line":"  - qos policy update"},{"line_number":13,"context_line":"  - qos policy show"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9a89bdaa_30b8112a","line":10,"in_reply_to":"9a89bdaa_c6f90650","updated":"2016-09-13 15:13:29.000000000","message":"Done","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"}],"doc/source/command-objects/network-qos-policy.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6cbe6ac0c88d19e98119c97925685d063acef614","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"network qos policy"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **Network QoS policy** groups a number of Network QoS rules, applied to a"}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_9d022d6e","line":2,"updated":"2016-09-15 14:13:03.000000000","message":"Please add this object to the commands.rst documentation.","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd27ae0354b63031a86ee073a4e4178e0602b11c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"network qos policy"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **Network QoS policy** groups a number of Network QoS rules, applied to a"}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_2532db10","line":2,"in_reply_to":"7a8ec9b2_9d022d6e","updated":"2016-09-15 15:48:30.000000000","message":"Done","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6cbe6ac0c88d19e98119c97925685d063acef614","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    Description of the QoS policy."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --shared"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_3d64b920","line":25,"range":{"start_line":25,"start_character":33,"end_line":25,"end_character":34},"updated":"2016-09-15 14:13:03.000000000","message":"The help text generally avoids periods when there\u0027s only one sentence.","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd27ae0354b63031a86ee073a4e4178e0602b11c","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    Description of the QoS policy."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --shared"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_68211a9f","line":25,"range":{"start_line":25,"start_character":33,"end_line":25,"end_character":34},"in_reply_to":"7a8ec9b2_3d64b920","updated":"2016-09-15 15:48:30.000000000","message":"Done","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6cbe6ac0c88d19e98119c97925685d063acef614","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    Description of the QoS policy."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --shared"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    Make the QoS policy accessible by other projects."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_bddc49e5","line":27,"range":{"start_line":27,"start_character":12,"end_line":27,"end_character":20},"updated":"2016-09-15 14:13:03.000000000","message":"The network commands are using \"--share | --no-share\" for similar options.  Should we support --no-share here?","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd27ae0354b63031a86ee073a4e4178e0602b11c","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    Description of the QoS policy."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. option:: --shared"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    Make the QoS policy accessible by other projects."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_68de7a40","line":27,"range":{"start_line":27,"start_character":12,"end_line":27,"end_character":20},"in_reply_to":"7a8ec9b2_bddc49e5","updated":"2016-09-15 15:48:30.000000000","message":"By default is \"not-shared\", that\u0027s why I didn\u0027t add this option in the creation function.\n\nBut I\u0027ve seen other commands (address-scope, for example) and I\u0027ll add it.","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6cbe6ac0c88d19e98119c97925685d063acef614","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. option:: --project-domain \u003cproject-domain\u003e]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    Domain the project belongs to (name or ID)."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":".. describe:: \u003cname\u003e"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_1df9bd4d","line":37,"updated":"2016-09-15 14:13:03.000000000","message":"You are missing \"This can be used in case collisions between project names exist.\" See other commands.","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd27ae0354b63031a86ee073a4e4178e0602b11c","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":".. option:: --project-domain \u003cproject-domain\u003e]"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    Domain the project belongs to (name or ID)."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":".. describe:: \u003cname\u003e"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_2890f242","line":37,"in_reply_to":"7a8ec9b2_1df9bd4d","updated":"2016-09-15 15:48:30.000000000","message":"Done","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6cbe6ac0c88d19e98119c97925685d063acef614","unresolved":false,"context_lines":[{"line_number":74,"context_line":".. code:: bash"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    os network qos policy set"},{"line_number":77,"context_line":"        [--name \u003cname\u003e] [--description DESCRIPTION]"},{"line_number":78,"context_line":"        [--shared | --not-shared]"},{"line_number":79,"context_line":"        \u003cqos-policy\u003e"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_9d714de3","line":77,"range":{"start_line":77,"start_character":39,"end_line":77,"end_character":50},"updated":"2016-09-15 14:13:03.000000000","message":"\u003cdescription\u003e","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd27ae0354b63031a86ee073a4e4178e0602b11c","unresolved":false,"context_lines":[{"line_number":74,"context_line":".. code:: bash"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    os network qos policy set"},{"line_number":77,"context_line":"        [--name \u003cname\u003e] [--description DESCRIPTION]"},{"line_number":78,"context_line":"        [--shared | --not-shared]"},{"line_number":79,"context_line":"        \u003cqos-policy\u003e"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_a30d0340","line":77,"range":{"start_line":77,"start_character":39,"end_line":77,"end_character":50},"in_reply_to":"7a8ec9b2_9d714de3","updated":"2016-09-15 15:48:30.000000000","message":"Done","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6cbe6ac0c88d19e98119c97925685d063acef614","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    os network qos policy set"},{"line_number":77,"context_line":"        [--name \u003cname\u003e] [--description DESCRIPTION]"},{"line_number":78,"context_line":"        [--shared | --not-shared]"},{"line_number":79,"context_line":"        \u003cqos-policy\u003e"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_fd825193","line":78,"updated":"2016-09-15 14:13:03.000000000","message":"See comment above","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd27ae0354b63031a86ee073a4e4178e0602b11c","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    os network qos policy set"},{"line_number":77,"context_line":"        [--name \u003cname\u003e] [--description DESCRIPTION]"},{"line_number":78,"context_line":"        [--shared | --not-shared]"},{"line_number":79,"context_line":"        \u003cqos-policy\u003e"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_3e03cc0e","line":78,"in_reply_to":"7a8ec9b2_fd825193","updated":"2016-09-15 15:48:30.000000000","message":"Done","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6cbe6ac0c88d19e98119c97925685d063acef614","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. option:: --name \u003cname\u003e"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    Name of the Network QoS policy."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_7d13a166","line":83,"range":{"start_line":83,"start_character":16,"end_line":83,"end_character":34},"updated":"2016-09-15 14:13:03.000000000","message":"Let\u0027s be consistent here and use \"QoS policy\" in the option help.","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd27ae0354b63031a86ee073a4e4178e0602b11c","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":".. option:: --name \u003cname\u003e"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    Name of the Network QoS policy."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_9e3b00d1","line":83,"range":{"start_line":83,"start_character":16,"end_line":83,"end_character":34},"in_reply_to":"7a8ec9b2_7d13a166","updated":"2016-09-15 15:48:30.000000000","message":"Done","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6cbe6ac0c88d19e98119c97925685d063acef614","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    Network QoS policy(s) to delete (name or ID)."}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_dd083530","line":114,"range":{"start_line":114,"start_character":29,"end_line":114,"end_character":35},"updated":"2016-09-15 14:13:03.000000000","message":"show","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd27ae0354b63031a86ee073a4e4178e0602b11c","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    Network QoS policy(s) to delete (name or ID)."}],"source_content_type":"text/x-rst","patch_set":19,"id":"7a8ec9b2_de3588da","line":114,"range":{"start_line":114,"start_character":29,"end_line":114,"end_character":35},"in_reply_to":"7a8ec9b2_dd083530","updated":"2016-09-15 15:48:30.000000000","message":"Done","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"d48dcb3a45675bd523aa1c28dec13a9ee2dea75f","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":".. option:: --no-share"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    Make the QoS policy not accessible by other projects (default)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"7a8ec9b2_72bff560","line":100,"updated":"2016-09-17 02:41:44.000000000","message":"This is not the default on set.","commit_id":"b3753361d4823848a9fcffb311128961e3cbba0e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"59960ba19432bb83782366dbdc4156ebf8ade45d","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":".. option:: --no-share"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    Make the QoS policy not accessible by other projects (default)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"7a8ec9b2_32c9b85b","line":100,"in_reply_to":"7a8ec9b2_72bff560","updated":"2016-09-19 13:27:38.000000000","message":"That\u0027s right","commit_id":"b3753361d4823848a9fcffb311128961e3cbba0e"}],"functional/tests/network/v2/test_network_qos_policy.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8490647e9dfe5cbe50a30310c6d0fac61d603980","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9a89bdaa_31558ac1","updated":"2016-09-13 10:55:29.000000000","message":"move this file to openstackclient/test/functional/network/v2","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb31077dab337a65618fa09a9e4b766d12634ec8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9a89bdaa_50b3d54c","in_reply_to":"9a89bdaa_31558ac1","updated":"2016-09-13 15:13:29.000000000","message":"Done","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8490647e9dfe5cbe50a30310c6d0fac61d603980","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.assertEqual(self.NAME + \"\\n\", raw_output)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_qos_policy_update(self):"},{"line_number":49,"context_line":"        self.openstack(\u0027qos policy update --shared \u0027 + self.NAME)"},{"line_number":50,"context_line":"        opts \u003d self.get_opts([\u0027shared\u0027])"},{"line_number":51,"context_line":"        raw_output \u003d self.openstack(\u0027qos policy show \u0027 + self.NAME + opts)"},{"line_number":52,"context_line":"        self.assertEqual(\"True\\n\", raw_output)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_71971290","line":49,"range":{"start_line":49,"start_character":35,"end_line":49,"end_character":41},"updated":"2016-09-13 10:55:29.000000000","message":"this command should be named \"set\"","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb31077dab337a65618fa09a9e4b766d12634ec8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.assertEqual(self.NAME + \"\\n\", raw_output)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_qos_policy_update(self):"},{"line_number":49,"context_line":"        self.openstack(\u0027qos policy update --shared \u0027 + self.NAME)"},{"line_number":50,"context_line":"        opts \u003d self.get_opts([\u0027shared\u0027])"},{"line_number":51,"context_line":"        raw_output \u003d self.openstack(\u0027qos policy show \u0027 + self.NAME + opts)"},{"line_number":52,"context_line":"        self.assertEqual(\"True\\n\", raw_output)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_b0f18103","line":49,"range":{"start_line":49,"start_character":35,"end_line":49,"end_character":41},"in_reply_to":"9a89bdaa_71971290","updated":"2016-09-13 15:13:29.000000000","message":"Done","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"}],"openstackclient/network/v2/network_qos_policy.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8490647e9dfe5cbe50a30310c6d0fac61d603980","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def get_parser(self, prog_name):"},{"line_number":66,"context_line":"        parser \u003d super(CreateQosPolicy, self).get_parser(prog_name)"},{"line_number":67,"context_line":"        parser.add_argument("},{"line_number":68,"context_line":"            \u0027name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":69,"context_line":"            help\u003d_(\"Name of QoS policy to create.\")"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_2632b2a7","line":68,"range":{"start_line":68,"start_character":28,"end_line":68,"end_character":34},"updated":"2016-09-13 10:55:29.000000000","message":"we usually use \u0027\u003cname\u003e\u0027 here","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb31077dab337a65618fa09a9e4b766d12634ec8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def get_parser(self, prog_name):"},{"line_number":66,"context_line":"        parser \u003d super(CreateQosPolicy, self).get_parser(prog_name)"},{"line_number":67,"context_line":"        parser.add_argument("},{"line_number":68,"context_line":"            \u0027name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":69,"context_line":"            help\u003d_(\"Name of QoS policy to create.\")"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_1b57b326","line":68,"range":{"start_line":68,"start_character":28,"end_line":68,"end_character":34},"in_reply_to":"9a89bdaa_2632b2a7","updated":"2016-09-13 15:13:29.000000000","message":"Done","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8490647e9dfe5cbe50a30310c6d0fac61d603980","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            help\u003d_(\"Name of QoS policy to create.\")"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        parser.add_argument("},{"line_number":72,"context_line":"            \u0027--description\u0027,"},{"line_number":73,"context_line":"            help\u003d_(\"Description of the QoS policy.\")"},{"line_number":74,"context_line":"        )"},{"line_number":75,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_669bda66","line":72,"updated":"2016-09-13 10:55:29.000000000","message":"You need add \"metavar\u003d\u0027\u003cdescription\u003e\u0027\"","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb31077dab337a65618fa09a9e4b766d12634ec8","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            help\u003d_(\"Name of QoS policy to create.\")"},{"line_number":70,"context_line":"        )"},{"line_number":71,"context_line":"        parser.add_argument("},{"line_number":72,"context_line":"            \u0027--description\u0027,"},{"line_number":73,"context_line":"            help\u003d_(\"Description of the QoS policy.\")"},{"line_number":74,"context_line":"        )"},{"line_number":75,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_bb3c07e2","line":72,"in_reply_to":"9a89bdaa_669bda66","updated":"2016-09-13 15:13:29.000000000","message":"Done","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8490647e9dfe5cbe50a30310c6d0fac61d603980","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        parser \u003d super(DeleteQosPolicy, self).get_parser(prog_name)"},{"line_number":103,"context_line":"        parser.add_argument("},{"line_number":104,"context_line":"            \u0027policy\u0027,"},{"line_number":105,"context_line":"            metavar\u003d\"\u003cqos_policy\u003e\","},{"line_number":106,"context_line":"            nargs\u003d\"+\","},{"line_number":107,"context_line":"            help\u003d_(\"QoS policy(s) to delete (name or ID)\")"},{"line_number":108,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_f126c2b8","line":105,"range":{"start_line":105,"start_character":22,"end_line":105,"end_character":32},"updated":"2016-09-13 10:55:29.000000000","message":"qos-policy","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb31077dab337a65618fa09a9e4b766d12634ec8","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        parser \u003d super(DeleteQosPolicy, self).get_parser(prog_name)"},{"line_number":103,"context_line":"        parser.add_argument("},{"line_number":104,"context_line":"            \u0027policy\u0027,"},{"line_number":105,"context_line":"            metavar\u003d\"\u003cqos_policy\u003e\","},{"line_number":106,"context_line":"            nargs\u003d\"+\","},{"line_number":107,"context_line":"            help\u003d_(\"QoS policy(s) to delete (name or ID)\")"},{"line_number":108,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_1b2ed3a4","line":105,"range":{"start_line":105,"start_character":22,"end_line":105,"end_character":32},"in_reply_to":"9a89bdaa_f126c2b8","updated":"2016-09-13 15:13:29.000000000","message":"Done","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8490647e9dfe5cbe50a30310c6d0fac61d603980","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        parser \u003d super(SetQosPolicy, self).get_parser(prog_name)"},{"line_number":162,"context_line":"        parser.add_argument("},{"line_number":163,"context_line":"            \u0027policy\u0027,"},{"line_number":164,"context_line":"            metavar\u003d\"\u003cqos_policy\u003e\","},{"line_number":165,"context_line":"            help\u003d_(\"QoS policy to modify (name or ID)\")"},{"line_number":166,"context_line":"        )"},{"line_number":167,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_e6ec4abd","line":164,"range":{"start_line":164,"start_character":22,"end_line":164,"end_character":32},"updated":"2016-09-13 10:55:29.000000000","message":"qos-policy","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb31077dab337a65618fa09a9e4b766d12634ec8","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        parser \u003d super(SetQosPolicy, self).get_parser(prog_name)"},{"line_number":162,"context_line":"        parser.add_argument("},{"line_number":163,"context_line":"            \u0027policy\u0027,"},{"line_number":164,"context_line":"            metavar\u003d\"\u003cqos_policy\u003e\","},{"line_number":165,"context_line":"            help\u003d_(\"QoS policy to modify (name or ID)\")"},{"line_number":166,"context_line":"        )"},{"line_number":167,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_7b1d1f72","line":164,"range":{"start_line":164,"start_character":22,"end_line":164,"end_character":32},"in_reply_to":"9a89bdaa_e6ec4abd","updated":"2016-09-13 15:13:29.000000000","message":"Done","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8490647e9dfe5cbe50a30310c6d0fac61d603980","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            help\u003d_(\u0027Set QoS policy name\u0027)"},{"line_number":171,"context_line":"        )"},{"line_number":172,"context_line":"        parser.add_argument("},{"line_number":173,"context_line":"            \u0027--description\u0027,"},{"line_number":174,"context_line":"            help\u003d_(\"Description of the QoS policy.\")"},{"line_number":175,"context_line":"        )"},{"line_number":176,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_067a0ef1","line":173,"updated":"2016-09-13 10:55:29.000000000","message":"You need add a \"metavar\u003d\u0027\u003cdescription\u003e\u0027\"","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb31077dab337a65618fa09a9e4b766d12634ec8","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            help\u003d_(\u0027Set QoS policy name\u0027)"},{"line_number":171,"context_line":"        )"},{"line_number":172,"context_line":"        parser.add_argument("},{"line_number":173,"context_line":"            \u0027--description\u0027,"},{"line_number":174,"context_line":"            help\u003d_(\"Description of the QoS policy.\")"},{"line_number":175,"context_line":"        )"},{"line_number":176,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_f6106650","line":173,"in_reply_to":"9a89bdaa_067a0ef1","updated":"2016-09-13 15:13:29.000000000","message":"Done","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8490647e9dfe5cbe50a30310c6d0fac61d603980","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        parser \u003d super(ShowQosPolicy, self).get_parser(prog_name)"},{"line_number":202,"context_line":"        parser.add_argument("},{"line_number":203,"context_line":"            \u0027policy\u0027,"},{"line_number":204,"context_line":"            metavar\u003d\"\u003cqos_policy\u003e\","},{"line_number":205,"context_line":"            help\u003d_(\"QoS policy to display (name or ID)\")"},{"line_number":206,"context_line":"        )"},{"line_number":207,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_c674a6ff","line":204,"range":{"start_line":204,"start_character":22,"end_line":204,"end_character":32},"updated":"2016-09-13 10:55:29.000000000","message":"qos-policy","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb31077dab337a65618fa09a9e4b766d12634ec8","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        parser \u003d super(ShowQosPolicy, self).get_parser(prog_name)"},{"line_number":202,"context_line":"        parser.add_argument("},{"line_number":203,"context_line":"            \u0027policy\u0027,"},{"line_number":204,"context_line":"            metavar\u003d\"\u003cqos_policy\u003e\","},{"line_number":205,"context_line":"            help\u003d_(\"QoS policy to display (name or ID)\")"},{"line_number":206,"context_line":"        )"},{"line_number":207,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_36172e46","line":204,"range":{"start_line":204,"start_character":22,"end_line":204,"end_character":32},"in_reply_to":"9a89bdaa_c674a6ff","updated":"2016-09-13 15:13:29.000000000","message":"Done","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"08895b5b0c27a796b5f40b7d9ec4920234f9954c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    return tuple(sorted(columns))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def _get_attrs(client_manager, parsed_args, is_create\u003dTrue):"},{"line_number":38,"context_line":"    attrs \u003d {}"},{"line_number":39,"context_line":"    if \u0027name\u0027 in parsed_args and parsed_args.name is not None:"},{"line_number":40,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a8ec9b2_2b7f65ab","line":37,"updated":"2016-09-14 09:43:08.000000000","message":"Dose this function work only for create command? If it is, then I think the \"is_create\" argument is not necessary.","commit_id":"8296fa477e8e3c407d6853a541c2f30e8e286e22"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"358a215970dc637007e8f261bcfb773f4b2a3438","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    return tuple(sorted(columns))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def _get_attrs(client_manager, parsed_args, is_create\u003dTrue):"},{"line_number":38,"context_line":"    attrs \u003d {}"},{"line_number":39,"context_line":"    if \u0027name\u0027 in parsed_args and parsed_args.name is not None:"},{"line_number":40,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a8ec9b2_114c9a6f","line":37,"in_reply_to":"7a8ec9b2_2b7f65ab","updated":"2016-09-14 10:12:14.000000000","message":"Done","commit_id":"8296fa477e8e3c407d6853a541c2f30e8e286e22"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"08895b5b0c27a796b5f40b7d9ec4920234f9954c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            attrs[\u0027shared\u0027] \u003d False"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    if \u0027project\u0027 in parsed_args and parsed_args.project is not None:"},{"line_number":51,"context_line":"        identity_client \u003d client_manager.identity"},{"line_number":52,"context_line":"        project_id \u003d identity_common.find_project("},{"line_number":53,"context_line":"            identity_client,"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a8ec9b2_0bf3899f","line":50,"range":{"start_line":50,"start_character":7,"end_line":50,"end_character":31},"updated":"2016-09-14 09:43:08.000000000","message":"\u0027project\u0027 is always in parsed_args I think.","commit_id":"8296fa477e8e3c407d6853a541c2f30e8e286e22"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"358a215970dc637007e8f261bcfb773f4b2a3438","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            attrs[\u0027shared\u0027] \u003d False"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    if \u0027project\u0027 in parsed_args and parsed_args.project is not None:"},{"line_number":51,"context_line":"        identity_client \u003d client_manager.identity"},{"line_number":52,"context_line":"        project_id \u003d identity_common.find_project("},{"line_number":53,"context_line":"            identity_client,"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a8ec9b2_b12be62f","line":50,"range":{"start_line":50,"start_character":7,"end_line":50,"end_character":31},"in_reply_to":"7a8ec9b2_0bf3899f","updated":"2016-09-14 10:12:14.000000000","message":"Yes, it\u0027s always there","commit_id":"8296fa477e8e3c407d6853a541c2f30e8e286e22"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"08895b5b0c27a796b5f40b7d9ec4920234f9954c","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            \u0027--shared\u0027,"},{"line_number":181,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":182,"context_line":"            help\u003d_(\u0027Make the QoS policy accessible by other \u0027"},{"line_number":183,"context_line":"                   \u0027projects (defaults to False).\u0027)"},{"line_number":184,"context_line":"        )"},{"line_number":185,"context_line":"        return parser"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"7a8ec9b2_6b3c0d94","line":183,"range":{"start_line":183,"start_character":30,"end_line":183,"end_character":48},"updated":"2016-09-14 09:43:08.000000000","message":"There is not default value in set command. Can we set no-shared by a \"--no-chared\" option?","commit_id":"8296fa477e8e3c407d6853a541c2f30e8e286e22"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"358a215970dc637007e8f261bcfb773f4b2a3438","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            \u0027--shared\u0027,"},{"line_number":181,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":182,"context_line":"            help\u003d_(\u0027Make the QoS policy accessible by other \u0027"},{"line_number":183,"context_line":"                   \u0027projects (defaults to False).\u0027)"},{"line_number":184,"context_line":"        )"},{"line_number":185,"context_line":"        return parser"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"7a8ec9b2_71095e95","line":183,"range":{"start_line":183,"start_character":30,"end_line":183,"end_character":48},"in_reply_to":"7a8ec9b2_6b3c0d94","updated":"2016-09-14 10:12:14.000000000","message":"That\u0027s correct. I\u0027ll remove this from the message. By default the QoS policy is not shared and you can force it with this parameter.","commit_id":"8296fa477e8e3c407d6853a541c2f30e8e286e22"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"08895b5b0c27a796b5f40b7d9ec4920234f9954c","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        if parsed_args.name is not None:"},{"line_number":194,"context_line":"            attrs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":195,"context_line":"        if parsed_args.shared:"},{"line_number":196,"context_line":"            attrs[\u0027shared\u0027] \u003d True"},{"line_number":197,"context_line":"        client.update_qos_policy(obj, **attrs)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"7a8ec9b2_8b9f9902","line":196,"updated":"2016-09-14 09:43:08.000000000","message":"Missing \"description\" here.","commit_id":"8296fa477e8e3c407d6853a541c2f30e8e286e22"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"358a215970dc637007e8f261bcfb773f4b2a3438","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        if parsed_args.name is not None:"},{"line_number":194,"context_line":"            attrs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":195,"context_line":"        if parsed_args.shared:"},{"line_number":196,"context_line":"            attrs[\u0027shared\u0027] \u003d True"},{"line_number":197,"context_line":"        client.update_qos_policy(obj, **attrs)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"7a8ec9b2_91feea69","line":196,"in_reply_to":"7a8ec9b2_8b9f9902","updated":"2016-09-14 10:12:14.000000000","message":"Done","commit_id":"8296fa477e8e3c407d6853a541c2f30e8e286e22"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"401e87814d1bd9120b013c76ad9f07a228675e69","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def _get_attrs(client_manager, parsed_args):"},{"line_number":38,"context_line":"    attrs \u003d {}"},{"line_number":39,"context_line":"    if \u0027name\u0027 in parsed_args and parsed_args.name is not None:"},{"line_number":40,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":41,"context_line":"    if parsed_args.description:"},{"line_number":42,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_6c350045","line":39,"updated":"2016-09-14 11:16:29.000000000","message":"Also, \"name\" will always in parsed_args and \"name\" not be None in create command, you can remove the if condition","commit_id":"f6afe5c6f7ddf4dde850ab1d859458d537a92276"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1357b87f71d2c35cc5863d5f1e434c4d4a89b54e","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"def _get_attrs(client_manager, parsed_args):"},{"line_number":38,"context_line":"    attrs \u003d {}"},{"line_number":39,"context_line":"    if \u0027name\u0027 in parsed_args and parsed_args.name is not None:"},{"line_number":40,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":41,"context_line":"    if parsed_args.description:"},{"line_number":42,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_65c26635","line":39,"in_reply_to":"7a8ec9b2_6c350045","updated":"2016-09-14 15:22:26.000000000","message":"Thanks!","commit_id":"f6afe5c6f7ddf4dde850ab1d859458d537a92276"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"401e87814d1bd9120b013c76ad9f07a228675e69","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            help\u003d_(\"Description of the QoS policy.\")"},{"line_number":174,"context_line":"        )"},{"line_number":175,"context_line":"        parser.add_argument("},{"line_number":176,"context_line":"            \u0027--shared\u0027,"},{"line_number":177,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":178,"context_line":"            help\u003d_(\u0027Make the QoS policy accessible by other projects.\u0027)"},{"line_number":179,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_0c7f1cab","line":176,"updated":"2016-09-14 11:16:29.000000000","message":"If a QoS policy is shared, can we set it to no-shared by this set command?","commit_id":"f6afe5c6f7ddf4dde850ab1d859458d537a92276"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1357b87f71d2c35cc5863d5f1e434c4d4a89b54e","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            help\u003d_(\"Description of the QoS policy.\")"},{"line_number":174,"context_line":"        )"},{"line_number":175,"context_line":"        parser.add_argument("},{"line_number":176,"context_line":"            \u0027--shared\u0027,"},{"line_number":177,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":178,"context_line":"            help\u003d_(\u0027Make the QoS policy accessible by other projects.\u0027)"},{"line_number":179,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":18,"id":"7a8ec9b2_e503d671","line":176,"in_reply_to":"7a8ec9b2_0c7f1cab","updated":"2016-09-14 15:22:26.000000000","message":"Done","commit_id":"f6afe5c6f7ddf4dde850ab1d859458d537a92276"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6cbe6ac0c88d19e98119c97925685d063acef614","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    attrs \u003d {}"},{"line_number":39,"context_line":"    if parsed_args.name is not None:"},{"line_number":40,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":41,"context_line":"    if parsed_args.description:"},{"line_number":42,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":43,"context_line":"    if parsed_args.shared:"},{"line_number":44,"context_line":"        attrs[\u0027shared\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_4f51c80d","line":41,"updated":"2016-09-15 14:13:03.000000000","message":"Check \"is not None\" to allow an empty description.","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd27ae0354b63031a86ee073a4e4178e0602b11c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    attrs \u003d {}"},{"line_number":39,"context_line":"    if parsed_args.name is not None:"},{"line_number":40,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":41,"context_line":"    if parsed_args.description:"},{"line_number":42,"context_line":"        attrs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":43,"context_line":"    if parsed_args.shared:"},{"line_number":44,"context_line":"        attrs[\u0027shared\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_fe5164d9","line":41,"in_reply_to":"7a8ec9b2_4f51c80d","updated":"2016-09-15 15:48:30.000000000","message":"Done","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6cbe6ac0c88d19e98119c97925685d063acef614","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        obj \u003d client.find_qos_policy(parsed_args.policy,"},{"line_number":218,"context_line":"                                     ignore_missing\u003dFalse)"},{"line_number":219,"context_line":"        columns \u003d _get_columns(obj)"},{"line_number":220,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d{})"},{"line_number":221,"context_line":"        return columns, data"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_cfcdd85e","line":220,"range":{"start_line":220,"start_character":55,"end_line":220,"end_character":68},"updated":"2016-09-15 14:13:03.000000000","message":"Do the rules need special formatting? There are list, dict and list of dict formatters that could be applied.  This comment applies to create as well.","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd27ae0354b63031a86ee073a4e4178e0602b11c","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        obj \u003d client.find_qos_policy(parsed_args.policy,"},{"line_number":218,"context_line":"                                     ignore_missing\u003dFalse)"},{"line_number":219,"context_line":"        columns \u003d _get_columns(obj)"},{"line_number":220,"context_line":"        data \u003d utils.get_item_properties(obj, columns, formatters\u003d{})"},{"line_number":221,"context_line":"        return columns, data"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_de7828f5","line":220,"range":{"start_line":220,"start_character":55,"end_line":220,"end_character":68},"in_reply_to":"7a8ec9b2_cfcdd85e","updated":"2016-09-15 15:48:30.000000000","message":"No, they don\u0027t. So I\u0027ll remove this optional parameter in the function call.","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"d48dcb3a45675bd523aa1c28dec13a9ee2dea75f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        share_group.add_argument("},{"line_number":82,"context_line":"            \u0027--no-share\u0027,"},{"line_number":83,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":84,"context_line":"            help\u003d_(\"Make the QoS policy not accessible by other projects\")"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        parser.add_argument("},{"line_number":87,"context_line":"            \u0027--project\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_d2b8c977","line":84,"updated":"2016-09-17 02:41:44.000000000","message":"Please make this help match the documentation.","commit_id":"b3753361d4823848a9fcffb311128961e3cbba0e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"59960ba19432bb83782366dbdc4156ebf8ade45d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        share_group.add_argument("},{"line_number":82,"context_line":"            \u0027--no-share\u0027,"},{"line_number":83,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":84,"context_line":"            help\u003d_(\"Make the QoS policy not accessible by other projects\")"},{"line_number":85,"context_line":"        )"},{"line_number":86,"context_line":"        parser.add_argument("},{"line_number":87,"context_line":"            \u0027--project\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7a8ec9b2_52c6444a","line":84,"in_reply_to":"7a8ec9b2_d2b8c977","updated":"2016-09-19 13:27:38.000000000","message":"Done","commit_id":"b3753361d4823848a9fcffb311128961e3cbba0e"}],"openstackclient/network/v2/qos.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"72ae081ed9798499b5219b817ad5774bbb4a4049","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9a89bdaa_1d95593f","updated":"2016-09-11 04:27:34.000000000","message":"just a note about the wording for this command, if i didn\u0027t know any better i would have no idea it was a \"network\" command. another reason we should consider prefixing it with \"network\"","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e16c3fa2ebff029a44f7655ecb72b34fbe1f5e32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9a89bdaa_02d24800","in_reply_to":"9a89bdaa_1d95593f","updated":"2016-09-12 07:50:06.000000000","message":"Done, but I don\u0027t agree with that. This command is under the network directory. I think that\u0027s enough to identify it.","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"72ae081ed9798499b5219b817ad5774bbb4a4049","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        parser.add_argument("},{"line_number":76,"context_line":"            \u0027--shared\u0027,"},{"line_number":77,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":78,"context_line":"            help\u003d_(\u0027Accessible by other tenants. \u0027"},{"line_number":79,"context_line":"                   \u0027Set shared to True (default is False).\u0027)"},{"line_number":80,"context_line":"        )"},{"line_number":81,"context_line":"        parser.add_argument("},{"line_number":82,"context_line":"            \u0027--project\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_ddaa1185","line":79,"range":{"start_line":78,"start_character":20,"end_line":79,"end_character":60},"updated":"2016-09-11 04:27:34.000000000","message":"see comment below","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e16c3fa2ebff029a44f7655ecb72b34fbe1f5e32","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        parser.add_argument("},{"line_number":76,"context_line":"            \u0027--shared\u0027,"},{"line_number":77,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":78,"context_line":"            help\u003d_(\u0027Accessible by other tenants. \u0027"},{"line_number":79,"context_line":"                   \u0027Set shared to True (default is False).\u0027)"},{"line_number":80,"context_line":"        )"},{"line_number":81,"context_line":"        parser.add_argument("},{"line_number":82,"context_line":"            \u0027--project\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_62c4f45e","line":79,"range":{"start_line":78,"start_character":20,"end_line":79,"end_character":60},"in_reply_to":"9a89bdaa_ddaa1185","updated":"2016-09-12 07:50:06.000000000","message":"Done","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"72ae081ed9798499b5219b817ad5774bbb4a4049","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        parser.add_argument("},{"line_number":152,"context_line":"            \u0027--shared\u0027,"},{"line_number":153,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":154,"context_line":"            help\u003d_(\u0027Accessible by other tenants. \u0027"},{"line_number":155,"context_line":"                   \u0027Set shared to True (default is False).\u0027)"},{"line_number":156,"context_line":"        )"},{"line_number":157,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_fdb6f5f7","line":154,"range":{"start_line":154,"start_character":40,"end_line":154,"end_character":47},"updated":"2016-09-11 04:27:34.000000000","message":"use the term projects","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e16c3fa2ebff029a44f7655ecb72b34fbe1f5e32","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        parser.add_argument("},{"line_number":152,"context_line":"            \u0027--shared\u0027,"},{"line_number":153,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":154,"context_line":"            help\u003d_(\u0027Accessible by other tenants. \u0027"},{"line_number":155,"context_line":"                   \u0027Set shared to True (default is False).\u0027)"},{"line_number":156,"context_line":"        )"},{"line_number":157,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_82a1f8ab","line":154,"range":{"start_line":154,"start_character":40,"end_line":154,"end_character":47},"in_reply_to":"9a89bdaa_fdb6f5f7","updated":"2016-09-12 07:50:06.000000000","message":"Done","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"72ae081ed9798499b5219b817ad5774bbb4a4049","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            \u0027--shared\u0027,"},{"line_number":153,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":154,"context_line":"            help\u003d_(\u0027Accessible by other tenants. \u0027"},{"line_number":155,"context_line":"                   \u0027Set shared to True (default is False).\u0027)"},{"line_number":156,"context_line":"        )"},{"line_number":157,"context_line":"        return parser"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_7dc3c557","line":155,"range":{"start_line":155,"start_character":20,"end_line":155,"end_character":23},"updated":"2016-09-11 04:27:34.000000000","message":"there\u0027s no \u0027setting\u0027 here, it\u0027s a flag, how about:\n\n  \"Make the QoS policy accessible by other projects (defaults to False)\"","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e16c3fa2ebff029a44f7655ecb72b34fbe1f5e32","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            \u0027--shared\u0027,"},{"line_number":153,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":154,"context_line":"            help\u003d_(\u0027Accessible by other tenants. \u0027"},{"line_number":155,"context_line":"                   \u0027Set shared to True (default is False).\u0027)"},{"line_number":156,"context_line":"        )"},{"line_number":157,"context_line":"        return parser"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_22e3cc06","line":155,"range":{"start_line":155,"start_character":20,"end_line":155,"end_character":23},"in_reply_to":"9a89bdaa_7dc3c557","updated":"2016-09-12 07:50:06.000000000","message":"Done","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"72ae081ed9798499b5219b817ad5774bbb4a4049","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        client.update_qos_policy(obj, **attrs)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class ListQosPolicy(command.Lister):"},{"line_number":173,"context_line":"    \"\"\"List QoS policies\"\"\""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_9db969ef","line":172,"range":{"start_line":172,"start_character":6,"end_line":172,"end_character":19},"updated":"2016-09-11 04:27:34.000000000","message":"these class names should be in alphabetical order","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e16c3fa2ebff029a44f7655ecb72b34fbe1f5e32","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        client.update_qos_policy(obj, **attrs)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"class ListQosPolicy(command.Lister):"},{"line_number":173,"context_line":"    \"\"\"List QoS policies\"\"\""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_22910c53","line":172,"range":{"start_line":172,"start_character":6,"end_line":172,"end_character":19},"in_reply_to":"9a89bdaa_9db969ef","updated":"2016-09-12 07:50:06.000000000","message":"Done","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"72ae081ed9798499b5219b817ad5774bbb4a4049","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"class ShowQosPolicy(command.ShowOne):"},{"line_number":198,"context_line":"    \"\"\"Display address scope details\"\"\""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def get_parser(self, prog_name):"},{"line_number":201,"context_line":"        parser \u003d super(ShowQosPolicy, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_3de21d02","line":198,"range":{"start_line":198,"start_character":15,"end_line":198,"end_character":28},"updated":"2016-09-11 04:27:34.000000000","message":"QoS policy","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e16c3fa2ebff029a44f7655ecb72b34fbe1f5e32","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"class ShowQosPolicy(command.ShowOne):"},{"line_number":198,"context_line":"    \"\"\"Display address scope details\"\"\""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def get_parser(self, prog_name):"},{"line_number":201,"context_line":"        parser \u003d super(ShowQosPolicy, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_82dd7816","line":198,"range":{"start_line":198,"start_character":15,"end_line":198,"end_character":28},"in_reply_to":"9a89bdaa_3de21d02","updated":"2016-09-12 07:50:06.000000000","message":"Done","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"72ae081ed9798499b5219b817ad5774bbb4a4049","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        parser.add_argument("},{"line_number":203,"context_line":"            \u0027policy\u0027,"},{"line_number":204,"context_line":"            metavar\u003d\"\u003cqos_policy\u003e\","},{"line_number":205,"context_line":"            help\u003d_(\"QoS policy to modify (name or ID)\")"},{"line_number":206,"context_line":"        )"},{"line_number":207,"context_line":"        return parser"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_5df1a1cc","line":205,"range":{"start_line":205,"start_character":34,"end_line":205,"end_character":40},"updated":"2016-09-11 04:27:34.000000000","message":"display","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e16c3fa2ebff029a44f7655ecb72b34fbe1f5e32","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        parser.add_argument("},{"line_number":203,"context_line":"            \u0027policy\u0027,"},{"line_number":204,"context_line":"            metavar\u003d\"\u003cqos_policy\u003e\","},{"line_number":205,"context_line":"            help\u003d_(\"QoS policy to modify (name or ID)\")"},{"line_number":206,"context_line":"        )"},{"line_number":207,"context_line":"        return parser"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_62c0742b","line":205,"range":{"start_line":205,"start_character":34,"end_line":205,"end_character":40},"in_reply_to":"9a89bdaa_5df1a1cc","updated":"2016-09-12 07:50:06.000000000","message":"Done","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"}],"openstackclient/shell.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"72ae081ed9798499b5219b817ad5774bbb4a4049","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9a89bdaa_3d1bfd1d","updated":"2016-09-11 04:27:34.000000000","message":"the permission on the file has changed, change it back please :)","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e16c3fa2ebff029a44f7655ecb72b34fbe1f5e32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9a89bdaa_c2fea06a","in_reply_to":"9a89bdaa_3d1bfd1d","updated":"2016-09-12 07:50:06.000000000","message":"Done","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"}],"openstackclient/tests/network/v2/test_network_qos_policy.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8490647e9dfe5cbe50a30310c6d0fac61d603980","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9a89bdaa_71fab2be","updated":"2016-09-13 10:55:29.000000000","message":"Move this file to openstackclient/test/unit/network/v2","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb31077dab337a65618fa09a9e4b766d12634ec8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9a89bdaa_d0f445f2","in_reply_to":"9a89bdaa_71fab2be","updated":"2016-09-13 15:13:29.000000000","message":"Done","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"}],"openstackclient/tests/network/v2/test_qos.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"72ae081ed9798499b5219b817ad5774bbb4a4049","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        self.assertIsNone(result)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"class TestListQosPolicy(TestQosPolicy):"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    # The QoS policies to list up."},{"line_number":286,"context_line":"    qos_policies \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_5d9fe15e","line":283,"range":{"start_line":283,"start_character":6,"end_line":283,"end_character":23},"updated":"2016-09-11 04:27:34.000000000","message":"move this above set","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e16c3fa2ebff029a44f7655ecb72b34fbe1f5e32","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        self.assertIsNone(result)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"class TestListQosPolicy(TestQosPolicy):"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    # The QoS policies to list up."},{"line_number":286,"context_line":"    qos_policies \u003d ("}],"source_content_type":"text/x-python","patch_set":13,"id":"9a89bdaa_6d5ea513","line":283,"range":{"start_line":283,"start_character":6,"end_line":283,"end_character":23},"in_reply_to":"9a89bdaa_5d9fe15e","updated":"2016-09-12 07:50:06.000000000","message":"Done","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"}],"openstackclient/tests/unit/network/v2/fakes.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8490647e9dfe5cbe50a30310c6d0fac61d603980","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        :param Dictionary attrs:"},{"line_number":639,"context_line":"            A dictionary with all attributes"},{"line_number":640,"context_line":"        :return:"},{"line_number":641,"context_line":"            A FakeResource object with name, id, etc."},{"line_number":642,"context_line":"        \"\"\""},{"line_number":643,"context_line":"        attrs \u003d attrs or {}"},{"line_number":644,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_a6db227b","line":641,"range":{"start_line":641,"start_character":39,"end_line":641,"end_character":43},"updated":"2016-09-13 10:55:29.000000000","message":"no \"name\" here.","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb31077dab337a65618fa09a9e4b766d12634ec8","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        :param Dictionary attrs:"},{"line_number":639,"context_line":"            A dictionary with all attributes"},{"line_number":640,"context_line":"        :return:"},{"line_number":641,"context_line":"            A FakeResource object with name, id, etc."},{"line_number":642,"context_line":"        \"\"\""},{"line_number":643,"context_line":"        attrs \u003d attrs or {}"},{"line_number":644,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_506675bb","line":641,"range":{"start_line":641,"start_character":39,"end_line":641,"end_character":43},"in_reply_to":"9a89bdaa_a6db227b","updated":"2016-09-13 15:13:29.000000000","message":"Done","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8490647e9dfe5cbe50a30310c6d0fac61d603980","unresolved":false,"context_lines":[{"line_number":690,"context_line":"            The number of QoS bandwidth limit rules to fake"},{"line_number":691,"context_line":"        :return:"},{"line_number":692,"context_line":"            An iterable Mock object with side_effect set to a list of faked"},{"line_number":693,"context_line":"            qos policies"},{"line_number":694,"context_line":"        \"\"\""},{"line_number":695,"context_line":"        if qos_rules is None:"},{"line_number":696,"context_line":"            qos_rules \u003d (FakeQosBandwidthLimitRule."}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_064bee87","line":693,"range":{"start_line":693,"start_character":12,"end_line":693,"end_character":24},"updated":"2016-09-13 10:55:29.000000000","message":"Qos bandwidth limit rules","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb31077dab337a65618fa09a9e4b766d12634ec8","unresolved":false,"context_lines":[{"line_number":690,"context_line":"            The number of QoS bandwidth limit rules to fake"},{"line_number":691,"context_line":"        :return:"},{"line_number":692,"context_line":"            An iterable Mock object with side_effect set to a list of faked"},{"line_number":693,"context_line":"            qos policies"},{"line_number":694,"context_line":"        \"\"\""},{"line_number":695,"context_line":"        if qos_rules is None:"},{"line_number":696,"context_line":"            qos_rules \u003d (FakeQosBandwidthLimitRule."}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_f0fb09bf","line":693,"range":{"start_line":693,"start_character":12,"end_line":693,"end_character":24},"in_reply_to":"9a89bdaa_064bee87","updated":"2016-09-13 15:13:29.000000000","message":"Done","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6cbe6ac0c88d19e98119c97925685d063acef614","unresolved":false,"context_lines":[{"line_number":696,"context_line":"        if qos_rules is None:"},{"line_number":697,"context_line":"            qos_rules \u003d (FakeQosBandwidthLimitRule."},{"line_number":698,"context_line":"                         create_qos_bandwidth_limit_rules(count))"},{"line_number":699,"context_line":"        return mock.MagicMock(side_effect\u003dqos_rules)"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"class FakeQosPolicy(object):"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_cf915854","line":699,"range":{"start_line":699,"start_character":20,"end_line":699,"end_character":29},"updated":"2016-09-15 14:13:03.000000000","message":"Please use Mock","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd27ae0354b63031a86ee073a4e4178e0602b11c","unresolved":false,"context_lines":[{"line_number":696,"context_line":"        if qos_rules is None:"},{"line_number":697,"context_line":"            qos_rules \u003d (FakeQosBandwidthLimitRule."},{"line_number":698,"context_line":"                         create_qos_bandwidth_limit_rules(count))"},{"line_number":699,"context_line":"        return mock.MagicMock(side_effect\u003dqos_rules)"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"class FakeQosPolicy(object):"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_1ec8d021","line":699,"range":{"start_line":699,"start_character":20,"end_line":699,"end_character":29},"in_reply_to":"7a8ec9b2_cf915854","updated":"2016-09-15 15:48:30.000000000","message":"Done","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6cbe6ac0c88d19e98119c97925685d063acef614","unresolved":false,"context_lines":[{"line_number":775,"context_line":"        \"\"\""},{"line_number":776,"context_line":"        if qos_policies is None:"},{"line_number":777,"context_line":"            qos_policies \u003d FakeQosPolicy.create_qos_policies(count)"},{"line_number":778,"context_line":"        return mock.MagicMock(side_effect\u003dqos_policies)"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"class FakeRouter(object):"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_0f9c2068","line":778,"updated":"2016-09-15 14:13:03.000000000","message":"Please use Mock","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd27ae0354b63031a86ee073a4e4178e0602b11c","unresolved":false,"context_lines":[{"line_number":775,"context_line":"        \"\"\""},{"line_number":776,"context_line":"        if qos_policies is None:"},{"line_number":777,"context_line":"            qos_policies \u003d FakeQosPolicy.create_qos_policies(count)"},{"line_number":778,"context_line":"        return mock.MagicMock(side_effect\u003dqos_policies)"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"class FakeRouter(object):"}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_fe7de4b1","line":778,"in_reply_to":"7a8ec9b2_0f9c2068","updated":"2016-09-15 15:48:30.000000000","message":"Done","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"}],"openstackclient/tests/unit/network/v2/test_network_qos_policy.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6cbe6ac0c88d19e98119c97925685d063acef614","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        # Get the command object to test"},{"line_number":237,"context_line":"        self.cmd \u003d network_qos_policy.ListQosPolicy(self.app, self.namespace)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def test_address_scope_list(self):"},{"line_number":240,"context_line":"        arglist \u003d []"},{"line_number":241,"context_line":"        verifylist \u003d []"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_0f69808b","line":239,"updated":"2016-09-15 14:13:03.000000000","message":"This is not an address scope list.","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd27ae0354b63031a86ee073a4e4178e0602b11c","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        # Get the command object to test"},{"line_number":237,"context_line":"        self.cmd \u003d network_qos_policy.ListQosPolicy(self.app, self.namespace)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def test_address_scope_list(self):"},{"line_number":240,"context_line":"        arglist \u003d []"},{"line_number":241,"context_line":"        verifylist \u003d []"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7a8ec9b2_998a3abe","line":239,"in_reply_to":"7a8ec9b2_0f69808b","updated":"2016-09-15 15:48:30.000000000","message":"Sorry....","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"}],"releasenotes/notes/add-network-qos-policy-b8ad1e408d73c279.yaml":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"29bcba4249b8ba99f082e48882936f714a469f6b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for Network QoS policies commands:"},{"line_number":4,"context_line":"    ``network qos policy create``, ``network qos policy delete``,"},{"line_number":5,"context_line":"    ``network qos policy list``, ``network qos policy show`` and"},{"line_number":6,"context_line":"    ``network qos policy set``"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7a8ec9b2_bb9035ee","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":15},"updated":"2016-09-14 03:50:46.000000000","message":"you\u0027ll want to add a pipe \"|\" here, or the release notes job won\u0027t pass:\n\n\n---\nfeatures:\n  - |","commit_id":"9c0d2e809dde117e8aa8b45aefcf97a47482a657"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c6d6c050ba221a3d77d7341f99492e11b552007f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add support for Network QoS policies commands:"},{"line_number":4,"context_line":"    ``network qos policy create``, ``network qos policy delete``,"},{"line_number":5,"context_line":"    ``network qos policy list``, ``network qos policy show`` and"},{"line_number":6,"context_line":"    ``network qos policy set``"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7a8ec9b2_76815f4a","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":15},"in_reply_to":"7a8ec9b2_bb9035ee","updated":"2016-09-14 06:16:34.000000000","message":"Thanks!","commit_id":"9c0d2e809dde117e8aa8b45aefcf97a47482a657"}],"setup.cfg":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"72ae081ed9798499b5219b817ad5774bbb4a4049","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    subnet_pool_show \u003d openstackclient.network.v2.subnet_pool:ShowSubnetPool"},{"line_number":419,"context_line":"    subnet_pool_unset \u003d openstackclient.network.v2.subnet_pool:UnsetSubnetPool"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    qos_policy_create \u003d openstackclient.network.v2.qos:CreateQosPolicy"},{"line_number":422,"context_line":"    qos_policy_delete \u003d openstackclient.network.v2.qos:DeleteQosPolicy"},{"line_number":423,"context_line":"    qos_policy_list \u003d openstackclient.network.v2.qos:ListQosPolicy"},{"line_number":424,"context_line":"    qos_policy_show \u003d openstackclient.network.v2.qos:ShowQosPolicy"}],"source_content_type":"text/x-ttcn-cfg","patch_set":13,"id":"9a89bdaa_dd25b15c","line":421,"range":{"start_line":421,"start_character":4,"end_line":421,"end_character":21},"updated":"2016-09-11 04:27:34.000000000","message":"since QoS is generic we probably need to prefix it here, like we did with volume: http://docs.openstack.org/developer/python-openstackclient/command-objects/volume-qos.html\n\n  `volume_qos_create`\n\nCan we use `network_qos_create`? do we need the word \"policy\"?","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e16c3fa2ebff029a44f7655ecb72b34fbe1f5e32","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    subnet_pool_show \u003d openstackclient.network.v2.subnet_pool:ShowSubnetPool"},{"line_number":419,"context_line":"    subnet_pool_unset \u003d openstackclient.network.v2.subnet_pool:UnsetSubnetPool"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    qos_policy_create \u003d openstackclient.network.v2.qos:CreateQosPolicy"},{"line_number":422,"context_line":"    qos_policy_delete \u003d openstackclient.network.v2.qos:DeleteQosPolicy"},{"line_number":423,"context_line":"    qos_policy_list \u003d openstackclient.network.v2.qos:ListQosPolicy"},{"line_number":424,"context_line":"    qos_policy_show \u003d openstackclient.network.v2.qos:ShowQosPolicy"}],"source_content_type":"text/x-ttcn-cfg","patch_set":13,"id":"9a89bdaa_0d42793e","line":421,"range":{"start_line":421,"start_character":4,"end_line":421,"end_character":21},"in_reply_to":"9a89bdaa_dd25b15c","updated":"2016-09-12 07:50:06.000000000","message":"Now we have only two QoS rules, one for volume and this one for network. The first one is using \"volume\" as prefix. This one will have:\n- QoS policy for policies.\n- QoS and the name of the rule (max, min, dscp, etc.) for the rules.\n\n\u003e do we need the word \"policy\"\nYes, we need it. There are QoS policies and QoS rules and it\u0027s important to keep it.\n\nI don\u0027t think we need to change it.","commit_id":"c5bc4f8cee2fef709f21ac5e65d42c0afaf08319"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"8490647e9dfe5cbe50a30310c6d0fac61d603980","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    qos_policy_delete \u003d openstackclient.network.v2.qos:DeleteQosPolicy"},{"line_number":423,"context_line":"    qos_policy_list \u003d openstackclient.network.v2.qos:ListQosPolicy"},{"line_number":424,"context_line":"    qos_policy_show \u003d openstackclient.network.v2.qos:ShowQosPolicy"},{"line_number":425,"context_line":"    qos_policy_update \u003d openstackclient.network.v2.qos:SetQosPolicy"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"openstack.object_store.v1 \u003d"},{"line_number":428,"context_line":"    object_store_account_set \u003d openstackclient.object.v1.account:SetAccount"}],"source_content_type":"text/x-ttcn-cfg","patch_set":14,"id":"9a89bdaa_0683ee56","line":425,"range":{"start_line":425,"start_character":15,"end_line":425,"end_character":21},"updated":"2016-09-13 10:55:29.000000000","message":"set","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bb31077dab337a65618fa09a9e4b766d12634ec8","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    qos_policy_delete \u003d openstackclient.network.v2.qos:DeleteQosPolicy"},{"line_number":423,"context_line":"    qos_policy_list \u003d openstackclient.network.v2.qos:ListQosPolicy"},{"line_number":424,"context_line":"    qos_policy_show \u003d openstackclient.network.v2.qos:ShowQosPolicy"},{"line_number":425,"context_line":"    qos_policy_update \u003d openstackclient.network.v2.qos:SetQosPolicy"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"openstack.object_store.v1 \u003d"},{"line_number":428,"context_line":"    object_store_account_set \u003d openstackclient.object.v1.account:SetAccount"}],"source_content_type":"text/x-ttcn-cfg","patch_set":14,"id":"9a89bdaa_702e1944","line":425,"range":{"start_line":425,"start_character":15,"end_line":425,"end_character":21},"in_reply_to":"9a89bdaa_0683ee56","updated":"2016-09-13 15:13:29.000000000","message":"Done","commit_id":"0555fce2b81a0a832563a3c93cf42fe0297d4a4e"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c527d2ce4f274446968aa3575d0b3391d43247e1","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    subnet_pool_show \u003d openstackclient.network.v2.subnet_pool:ShowSubnetPool"},{"line_number":419,"context_line":"    subnet_pool_unset \u003d openstackclient.network.v2.subnet_pool:UnsetSubnetPool"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    network_qos_policy_create \u003d openstackclient.network.v2.qos:CreateQosPolicy"},{"line_number":422,"context_line":"    network_qos_policy_delete \u003d openstackclient.network.v2.qos:DeleteQosPolicy"},{"line_number":423,"context_line":"    network_qos_policy_list \u003d openstackclient.network.v2.qos:ListQosPolicy"},{"line_number":424,"context_line":"    network_qos_policy_show \u003d openstackclient.network.v2.qos:ShowQosPolicy"}],"source_content_type":"text/x-ttcn-cfg","patch_set":15,"id":"7a8ec9b2_7badcd30","line":421,"range":{"start_line":421,"start_character":59,"end_line":421,"end_character":62},"updated":"2016-09-14 03:51:29.000000000","message":"these now need to be renamed to \"network_qos_policy\"","commit_id":"9c0d2e809dde117e8aa8b45aefcf97a47482a657"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c6d6c050ba221a3d77d7341f99492e11b552007f","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    subnet_pool_show \u003d openstackclient.network.v2.subnet_pool:ShowSubnetPool"},{"line_number":419,"context_line":"    subnet_pool_unset \u003d openstackclient.network.v2.subnet_pool:UnsetSubnetPool"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    network_qos_policy_create \u003d openstackclient.network.v2.qos:CreateQosPolicy"},{"line_number":422,"context_line":"    network_qos_policy_delete \u003d openstackclient.network.v2.qos:DeleteQosPolicy"},{"line_number":423,"context_line":"    network_qos_policy_list \u003d openstackclient.network.v2.qos:ListQosPolicy"},{"line_number":424,"context_line":"    network_qos_policy_show \u003d openstackclient.network.v2.qos:ShowQosPolicy"}],"source_content_type":"text/x-ttcn-cfg","patch_set":15,"id":"7a8ec9b2_d6907398","line":421,"range":{"start_line":421,"start_character":59,"end_line":421,"end_character":62},"in_reply_to":"7a8ec9b2_7badcd30","updated":"2016-09-14 06:16:34.000000000","message":"Done","commit_id":"9c0d2e809dde117e8aa8b45aefcf97a47482a657"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6cbe6ac0c88d19e98119c97925685d063acef614","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    subnet_pool_show \u003d openstackclient.network.v2.subnet_pool:ShowSubnetPool"},{"line_number":419,"context_line":"    subnet_pool_unset \u003d openstackclient.network.v2.subnet_pool:UnsetSubnetPool"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    network_qos_policy_create \u003d openstackclient.network.v2.network_qos_policy:CreateQosPolicy"},{"line_number":422,"context_line":"    network_qos_policy_delete \u003d openstackclient.network.v2.network_qos_policy:DeleteQosPolicy"},{"line_number":423,"context_line":"    network_qos_policy_list \u003d openstackclient.network.v2.network_qos_policy:ListQosPolicy"},{"line_number":424,"context_line":"    network_qos_policy_show \u003d openstackclient.network.v2.network_qos_policy:ShowQosPolicy"}],"source_content_type":"text/x-ttcn-cfg","patch_set":19,"id":"7a8ec9b2_7db561ec","line":421,"updated":"2016-09-15 14:13:03.000000000","message":"Please place commands in alphabetical order.  Also the class name usually reflects the command name which would make these classes *NetworkQosPolicy.","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd27ae0354b63031a86ee073a4e4178e0602b11c","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    subnet_pool_show \u003d openstackclient.network.v2.subnet_pool:ShowSubnetPool"},{"line_number":419,"context_line":"    subnet_pool_unset \u003d openstackclient.network.v2.subnet_pool:UnsetSubnetPool"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    network_qos_policy_create \u003d openstackclient.network.v2.network_qos_policy:CreateQosPolicy"},{"line_number":422,"context_line":"    network_qos_policy_delete \u003d openstackclient.network.v2.network_qos_policy:DeleteQosPolicy"},{"line_number":423,"context_line":"    network_qos_policy_list \u003d openstackclient.network.v2.network_qos_policy:ListQosPolicy"},{"line_number":424,"context_line":"    network_qos_policy_show \u003d openstackclient.network.v2.network_qos_policy:ShowQosPolicy"}],"source_content_type":"text/x-ttcn-cfg","patch_set":19,"id":"7a8ec9b2_19270ab7","line":421,"in_reply_to":"7a8ec9b2_7db561ec","updated":"2016-09-15 15:48:30.000000000","message":"Done","commit_id":"65b3840e41fcb818f376f2de5866ad156b314790"}]}