)]}'
{"doc/source/command-objects/network.rst":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"bd4bc3884ec42240f83416765cd6ec7ec13b6df6","unresolved":false,"context_lines":[{"line_number":181,"context_line":".. code:: bash"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    os network list"},{"line_number":184,"context_line":"        [--external]"},{"line_number":185,"context_line":"        [--internal]"},{"line_number":186,"context_line":"        [--long]"},{"line_number":187,"context_line":"        [--name]"},{"line_number":188,"context_line":"        [--enable]"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_52bcf66b","line":185,"range":{"start_line":184,"start_character":0,"end_line":185,"end_character":20},"updated":"2016-08-04 09:22:59.000000000","message":"Please add these tow options in one line","commit_id":"b0742f4dbd88f4f6c831eed4e847bc463d065a4a"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"2d5fde775fff2a4d4d9ca41d626e433593495b93","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":".. option:: --internal"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    List internal networks"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":".. option:: --long"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_ddc8a4aa","line":199,"updated":"2016-08-05 16:33:45.000000000","message":"Which of these is assumed behaviour when neither --internal nor --external is present on the command line?  Please mark that one as the default here and in the help text.","commit_id":"f204e65ecb385b0c1ec411bea091d4e6dd617bb4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"67716e6b92acaf3437ab2b40884cfe365a43c3c3","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":".. option:: --internal"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    List internal networks"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":".. option:: --long"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"bacf61ea_fd0c5d94","line":199,"in_reply_to":"bacf61ea_ddc8a4aa","updated":"2016-08-08 03:53:35.000000000","message":"+1","commit_id":"f204e65ecb385b0c1ec411bea091d4e6dd617bb4"},{"author":{"_account_id":20079,"name":"Ha Van Tu","email":"tuhv@vn.fujitsu.com","username":"tuhv"},"change_message_id":"7f1677ff1cdb7b9dc315eafdf4021b1abfd64c84","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":".. option:: --internal"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    List internal networks"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":".. option:: --long"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3ac371cc_bf6c799d","line":199,"in_reply_to":"bacf61ea_fd0c5d94","updated":"2016-08-15 06:50:11.000000000","message":"@Dean Troyer, Reedip:\nActually, in my understanding, when neither --internal nor --external is presented on the command line, both internal and external networks are listed. So no \u0027--internal\u0027 and \u0027--external\u0027 is default value.","commit_id":"f204e65ecb385b0c1ec411bea091d4e6dd617bb4"}],"openstackclient/network/v2/network.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"bd4bc3884ec42240f83416765cd6ec7ec13b6df6","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        router_ext_group.add_argument("},{"line_number":300,"context_line":"            \u0027--external\u0027,"},{"line_number":301,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":302,"context_line":"            default\u003dFalse,"},{"line_number":303,"context_line":"            help\u003d_(\"List external networks\")"},{"line_number":304,"context_line":"        )"},{"line_number":305,"context_line":"        router_ext_group.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_adaa37d0","line":302,"range":{"start_line":302,"start_character":12,"end_line":302,"end_character":26},"updated":"2016-08-04 09:22:59.000000000","message":"Remove the default","commit_id":"b0742f4dbd88f4f6c831eed4e847bc463d065a4a"},{"author":{"_account_id":20079,"name":"Ha Van Tu","email":"tuhv@vn.fujitsu.com","username":"tuhv"},"change_message_id":"d5aa00f618c8fd61ebee6b744ecb3cc3c607833d","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        router_ext_group.add_argument("},{"line_number":300,"context_line":"            \u0027--external\u0027,"},{"line_number":301,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":302,"context_line":"            default\u003dFalse,"},{"line_number":303,"context_line":"            help\u003d_(\"List external networks\")"},{"line_number":304,"context_line":"        )"},{"line_number":305,"context_line":"        router_ext_group.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_6d479f77","line":302,"range":{"start_line":302,"start_character":12,"end_line":302,"end_character":26},"in_reply_to":"bacf61ea_adaa37d0","updated":"2016-08-04 09:36:04.000000000","message":"@Huanxuan Ao: I just follow as existed argument: \u0027--external\u0027 and \u0027--long\u0027. Maybe it make easier to understand the argument we add.","commit_id":"b0742f4dbd88f4f6c831eed4e847bc463d065a4a"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"bd4bc3884ec42240f83416765cd6ec7ec13b6df6","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        router_ext_group.add_argument("},{"line_number":306,"context_line":"            \u0027--internal\u0027,"},{"line_number":307,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":308,"context_line":"            default\u003dFalse,"},{"line_number":309,"context_line":"            help\u003d_(\"List internal networks\")"},{"line_number":310,"context_line":"        )"},{"line_number":311,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_edb42f36","line":308,"range":{"start_line":308,"start_character":12,"end_line":308,"end_character":26},"updated":"2016-08-04 09:22:59.000000000","message":"ditto","commit_id":"b0742f4dbd88f4f6c831eed4e847bc463d065a4a"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"ed1400fced48d844029c9fd04abb7bd0221a09f7","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        router_ext_group.add_argument("},{"line_number":306,"context_line":"            \u0027--internal\u0027,"},{"line_number":307,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":308,"context_line":"            default\u003dFalse,"},{"line_number":309,"context_line":"            help\u003d_(\"List internal networks\")"},{"line_number":310,"context_line":"        )"},{"line_number":311,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_8723c057","line":308,"updated":"2016-08-04 14:12:15.000000000","message":"I don\u0027t think a default is required here or for --external.","commit_id":"f204e65ecb385b0c1ec411bea091d4e6dd617bb4"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"2d5fde775fff2a4d4d9ca41d626e433593495b93","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        router_ext_group.add_argument("},{"line_number":306,"context_line":"            \u0027--internal\u0027,"},{"line_number":307,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":308,"context_line":"            default\u003dFalse,"},{"line_number":309,"context_line":"            help\u003d_(\"List internal networks\")"},{"line_number":310,"context_line":"        )"},{"line_number":311,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_bdf4d0f0","line":308,"in_reply_to":"bacf61ea_8723c057","updated":"2016-08-05 16:33:45.000000000","message":"While not an issue in this case, normally I would say there should be no default for mutex boolean options like this (http://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options).  Sometimes we need to know when neither option is present, setting a default breaks that.  Again, not an issue here, but it is inconsistent and someone will eventually copy-paste it...","commit_id":"f204e65ecb385b0c1ec411bea091d4e6dd617bb4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"67716e6b92acaf3437ab2b40884cfe365a43c3c3","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        router_ext_group.add_argument("},{"line_number":306,"context_line":"            \u0027--internal\u0027,"},{"line_number":307,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":308,"context_line":"            default\u003dFalse,"},{"line_number":309,"context_line":"            help\u003d_(\"List internal networks\")"},{"line_number":310,"context_line":"        )"},{"line_number":311,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_bd7dc5e8","line":308,"in_reply_to":"bacf61ea_bdf4d0f0","updated":"2016-08-08 03:53:35.000000000","message":"I agree with both the above comments, but yes, the default is False, so theoretically it matches your expectations that if neither option is present, none of the options would be default.( as both are false)\n\nHowever, as stated by Dean in the current and several of my previous patches, it is better to know which is the default option if neither of these options is present.","commit_id":"f204e65ecb385b0c1ec411bea091d4e6dd617bb4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"67716e6b92acaf3437ab2b40884cfe365a43c3c3","unresolved":false,"context_lines":[{"line_number":395,"context_line":"        if parsed_args.external:"},{"line_number":396,"context_line":"            args[\u0027router:external\u0027] \u003d True"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        if parsed_args.internal:"},{"line_number":399,"context_line":"            args[\u0027router:external\u0027] \u003d False"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        if parsed_args.name:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9d7561fb","line":398,"updated":"2016-08-08 03:53:35.000000000","message":"considering that external and internal are Mutex, there would not be any condition when both of them can be specified. \n\nTherefore , I would suggest you make this condition as elsif/else .","commit_id":"f204e65ecb385b0c1ec411bea091d4e6dd617bb4"}]}