)]}'
{"openstackclient/network/v2/router.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"bbfc2cde9ea85bffd1a594dc4e2fea4c231f2cfa","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        parser.add_argument("},{"line_number":183,"context_line":"            \u0027--ha\u0027,"},{"line_number":184,"context_line":"            dest\u003d\u0027ha\u0027,"},{"line_number":185,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":186,"context_line":"            default\u003dFalse,"},{"line_number":187,"context_line":"            help\u003d_(\"Create a highly available router\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_ad73c9b3","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":22},"updated":"2016-08-08 09:29:03.000000000","message":"Dest name is the same as option name by default, so this is not necessary here.","commit_id":"0bf556895d44450a791e960aff2d83b53720beb6"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"bd699f18ed618cc62b7a312b86625fb1dfe8d6aa","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        parser.add_argument("},{"line_number":183,"context_line":"            \u0027--ha\u0027,"},{"line_number":184,"context_line":"            dest\u003d\u0027ha\u0027,"},{"line_number":185,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":186,"context_line":"            default\u003dFalse,"},{"line_number":187,"context_line":"            help\u003d_(\"Create a highly available router\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_966252ac","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":22},"in_reply_to":"9ad45d7e_96789291","updated":"2016-08-08 10:18:31.000000000","message":"Thanks for your comment. I got it :)","commit_id":"0bf556895d44450a791e960aff2d83b53720beb6"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"41fe440b7af56593dc912a3aa0b57a2dce1e4df8","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        parser.add_argument("},{"line_number":183,"context_line":"            \u0027--ha\u0027,"},{"line_number":184,"context_line":"            dest\u003d\u0027ha\u0027,"},{"line_number":185,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":186,"context_line":"            default\u003dFalse,"},{"line_number":187,"context_line":"            help\u003d_(\"Create a highly available router\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_fb6d77cd","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":22},"in_reply_to":"9ad45d7e_ad73c9b3","updated":"2016-08-08 09:54:46.000000000","message":"You are right, but how do you think about the --distributed option.\n\nFor --distributed option, I see the value of dest is \"distributed\" which is the same name of the option.","commit_id":"0bf556895d44450a791e960aff2d83b53720beb6"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"e063e5c2f577b3dead7c500497bbd2a2df48e5d6","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        parser.add_argument("},{"line_number":183,"context_line":"            \u0027--ha\u0027,"},{"line_number":184,"context_line":"            dest\u003d\u0027ha\u0027,"},{"line_number":185,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":186,"context_line":"            default\u003dFalse,"},{"line_number":187,"context_line":"            help\u003d_(\"Create a highly available router\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_96789291","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":22},"in_reply_to":"9ad45d7e_fb6d77cd","updated":"2016-08-08 10:14:31.000000000","message":"I think you can also remove the \"dest\u003ddistributed\" if you like.","commit_id":"0bf556895d44450a791e960aff2d83b53720beb6"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"bbfc2cde9ea85bffd1a594dc4e2fea4c231f2cfa","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            \u0027--ha\u0027,"},{"line_number":184,"context_line":"            dest\u003d\u0027ha\u0027,"},{"line_number":185,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":186,"context_line":"            default\u003dFalse,"},{"line_number":187,"context_line":"            help\u003d_(\"Create a highly available router\")"},{"line_number":188,"context_line":"        )"},{"line_number":189,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_adcf49b2","line":186,"range":{"start_line":186,"start_character":12,"end_line":186,"end_character":26},"updated":"2016-08-08 09:29:03.000000000","message":"Need not set the default here since the default is \"False\" by default","commit_id":"0bf556895d44450a791e960aff2d83b53720beb6"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"bbfc2cde9ea85bffd1a594dc4e2fea4c231f2cfa","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        return parser"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def take_action(self, parsed_args):"},{"line_number":208,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_ed0e61e4","line":207,"updated":"2016-08-08 09:29:03.000000000","message":"I do not see there is a action for option \"--ha\"","commit_id":"0bf556895d44450a791e960aff2d83b53720beb6"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"02dbc42a253bfc2f2cca066b8103bc8637063ccc","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        attrs[\u0027distributed\u0027] \u003d False"},{"line_number":80,"context_line":"    if parsed_args.distributed:"},{"line_number":81,"context_line":"        attrs[\u0027distributed\u0027] \u003d True"},{"line_number":82,"context_line":"    if parsed_args.ha:"},{"line_number":83,"context_line":"        attrs[\u0027ha\u0027] \u003d False"},{"line_number":84,"context_line":"    if (\u0027availability_zone_hints\u0027 in parsed_args"},{"line_number":85,"context_line":"            and parsed_args.availability_zone_hints is not None):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_30c1e981","line":82,"range":{"start_line":82,"start_character":4,"end_line":82,"end_character":21},"updated":"2016-08-08 11:28:56.000000000","message":"\"_get_attrs()\" is also used for set command, but set command has no \"--ha\" option now, so I think here will be a error when we use set command.","commit_id":"cb5ca20f6fb9d1013cffaa6e34777d6806839a6e"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"02dbc42a253bfc2f2cca066b8103bc8637063ccc","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    if parsed_args.distributed:"},{"line_number":81,"context_line":"        attrs[\u0027distributed\u0027] \u003d True"},{"line_number":82,"context_line":"    if parsed_args.ha:"},{"line_number":83,"context_line":"        attrs[\u0027ha\u0027] \u003d False"},{"line_number":84,"context_line":"    if (\u0027availability_zone_hints\u0027 in parsed_args"},{"line_number":85,"context_line":"            and parsed_args.availability_zone_hints is not None):"},{"line_number":86,"context_line":"        attrs[\u0027availability_zone_hints\u0027] \u003d parsed_args.availability_zone_hints"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_50a3bd9e","line":83,"updated":"2016-08-08 11:28:56.000000000","message":"You can follow this docs here:\nhttp://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options","commit_id":"cb5ca20f6fb9d1013cffaa6e34777d6806839a6e"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0f7148ed7a50234a7deff24bd99fcf4f1017bcc2","unresolved":false,"context_lines":[{"line_number":417,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":418,"context_line":"        )"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        # TODO(tangchen): Support setting \u0027ha\u0027 property in \u0027router set\u0027"},{"line_number":421,"context_line":"        # command. It appears that changing the ha state is supported by"},{"line_number":422,"context_line":"        # neutron under certain conditions."},{"line_number":423,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_1e02b96f","line":420,"updated":"2016-08-09 11:28:47.000000000","message":"I think we should add --ha and --no-ha to the set command as well in this patch.","commit_id":"dd208c95324f2aa52a0549386fa6b264f864a6f0"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"bf9ceadb3be0f50003afa9c9f1cd13e587b85dc8","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        parser.add_argument("},{"line_number":182,"context_line":"            \u0027--ha\u0027,"},{"line_number":183,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":184,"context_line":"            default\u003dFalse,"},{"line_number":185,"context_line":"            help\u003d_(\"Create a highly available router\")"},{"line_number":186,"context_line":"        )"},{"line_number":187,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_fe6640eb","line":184,"updated":"2016-08-11 12:53:09.000000000","message":"You don\u0027t need to set a default.  The default will be None.","commit_id":"70adb972c445b7fb9836e25c834639fc23c76dbd"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"46d273cc5a72cae1bf7896ae0bed154b2d5b96a3","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":214,"context_line":"        if parsed_args.ha:"},{"line_number":215,"context_line":"            attrs[\u0027ha\u0027] \u003d parsed_args.ha"},{"line_number":216,"context_line":"        obj \u003d client.create_router(**attrs)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        columns \u003d _get_columns(obj)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_04e96814","line":215,"range":{"start_line":214,"start_character":0,"end_line":215,"end_character":40},"updated":"2016-09-30 08:10:10.000000000","message":"I think we should move this block to _get_attrs(). The the set command will be able to reuse it.","commit_id":"e2fc436d53f53d0993fc0b9dd29f402e6c7f8bc1"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"4cdcaf7af45247b6676b7ea0ed8929f044e6eae1","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        client \u003d self.app.client_manager.network"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        attrs \u003d _get_attrs(self.app.client_manager, parsed_args)"},{"line_number":214,"context_line":"        if parsed_args.ha:"},{"line_number":215,"context_line":"            attrs[\u0027ha\u0027] \u003d parsed_args.ha"},{"line_number":216,"context_line":"        obj \u003d client.create_router(**attrs)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        columns \u003d _get_columns(obj)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_740d778f","line":215,"range":{"start_line":214,"start_character":0,"end_line":215,"end_character":40},"in_reply_to":"3a98d1f4_04e96814","updated":"2016-09-30 09:11:20.000000000","message":"Er...OK, my mistake. The ha property cannot be updated according to the Neutron API doc.","commit_id":"e2fc436d53f53d0993fc0b9dd29f402e6c7f8bc1"}],"openstackclient/tests/network/v2/test_router.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"bf9ceadb3be0f50003afa9c9f1cd13e587b85dc8","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            (\u0027name\u0027, self.new_router.name),"},{"line_number":166,"context_line":"            (\u0027enable\u0027, True),"},{"line_number":167,"context_line":"            (\u0027distributed\u0027, False),"},{"line_number":168,"context_line":"            (\u0027ha\u0027, False),"},{"line_number":169,"context_line":"        ]"},{"line_number":170,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_fec2c083","line":168,"updated":"2016-08-11 12:53:09.000000000","message":"Please add a unit test to set --ha.","commit_id":"70adb972c445b7fb9836e25c834639fc23c76dbd"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"1099e154f4a93e0eba44e87b912a68175a874592","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def test_create_with_ha_option(self):"},{"line_number":182,"context_line":"        arglist \u003d ["},{"line_number":183,"context_line":"            self.new_router.name,"},{"line_number":184,"context_line":"            \u0027--ha\u0027,"},{"line_number":185,"context_line":"        ]"},{"line_number":186,"context_line":"        verifylist \u003d ["},{"line_number":187,"context_line":"            (\u0027name\u0027, self.new_router.name),"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_1f5f8d73","line":184,"range":{"start_line":183,"start_character":0,"end_line":184,"end_character":19},"updated":"2016-08-15 07:06:03.000000000","message":"positional parameter often in the end of the list:\n    \u0027--ha\u0027,\n    self.new_router.name,","commit_id":"bb1126749ea6f810434eb4ede89047443c52b801"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"db4b2adce13c200073a84a1b646b7dcaebc09a23","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def test_create_with_ha_option(self):"},{"line_number":182,"context_line":"        arglist \u003d ["},{"line_number":183,"context_line":"            self.new_router.name,"},{"line_number":184,"context_line":"            \u0027--ha\u0027,"},{"line_number":185,"context_line":"        ]"},{"line_number":186,"context_line":"        verifylist \u003d ["},{"line_number":187,"context_line":"            (\u0027name\u0027, self.new_router.name),"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_453c962f","line":184,"range":{"start_line":183,"start_character":0,"end_line":184,"end_character":19},"in_reply_to":"3ac371cc_1f5f8d73","updated":"2016-08-15 07:56:21.000000000","message":"Thanks for your comment :)","commit_id":"bb1126749ea6f810434eb4ede89047443c52b801"}]}