)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14640ef43422a0e97b025254ed4c149ba0c05aad","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  - network qos rule delete"},{"line_number":14,"context_line":"  - network qos rule list"},{"line_number":15,"context_line":"  - network qos rule set"},{"line_number":16,"context_line":"  - network qos rule show"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: 1609472"},{"line_number":19,"context_line":"Depends-On: I2e8869750024a8ccbc7777b95fe8ef6e26ec0885"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"7a77a97e_5c78b12a","line":16,"range":{"start_line":16,"start_character":3,"end_line":16,"end_character":25},"updated":"2016-11-16 16:15:51.000000000","message":"We can have a new command\n\n  network qos rule unset\n\nThe usecase for that would be clearing DSCP rule markings etc.","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a21527642abf98127d85606f9e44e2990275b22b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  - network qos rule delete"},{"line_number":14,"context_line":"  - network qos rule list"},{"line_number":15,"context_line":"  - network qos rule set"},{"line_number":16,"context_line":"  - network qos rule show"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: 1609472"},{"line_number":19,"context_line":"Depends-On: I2e8869750024a8ccbc7777b95fe8ef6e26ec0885"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"7a77a97e_fde59b08","line":16,"range":{"start_line":16,"start_character":3,"end_line":16,"end_character":25},"in_reply_to":"7a77a97e_5c78b12a","updated":"2016-11-18 09:15:51.000000000","message":"Thanks for the tip. This command is not needed in qos rule.","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73d4c787e9c82042287ccd4d3b7eb60f20925d8e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  - network qos rule delete"},{"line_number":14,"context_line":"  - network qos rule list"},{"line_number":15,"context_line":"  - network qos rule set"},{"line_number":16,"context_line":"  - network qos rule show"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: 1609472"},{"line_number":19,"context_line":"Depends-On: I2e8869750024a8ccbc7777b95fe8ef6e26ec0885"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"7a77a97e_ce3372f5","line":16,"range":{"start_line":16,"start_character":3,"end_line":16,"end_character":25},"in_reply_to":"7a77a97e_b4a30eb1","updated":"2016-11-21 16:06:51.000000000","message":"The only way to clear DSCP rule markings is to delete the rule.","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6c098dccb25ee0fc90d31f275cb10f7437120869","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  - network qos rule delete"},{"line_number":14,"context_line":"  - network qos rule list"},{"line_number":15,"context_line":"  - network qos rule set"},{"line_number":16,"context_line":"  - network qos rule show"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: 1609472"},{"line_number":19,"context_line":"Depends-On: I2e8869750024a8ccbc7777b95fe8ef6e26ec0885"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"7a77a97e_b4a30eb1","line":16,"range":{"start_line":16,"start_character":3,"end_line":16,"end_character":25},"in_reply_to":"7a77a97e_fde59b08","updated":"2016-11-20 07:51:46.000000000","message":"I think we can use it to clear DSCP rule markings.","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"}],"doc/source/command-objects/network-qos-minimum-bandwidth-rule.rst":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0096e83979ade30c467451d0690bebd8a08ff16a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"network qos minimum-bandwidth-rule"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"da6895a0_a663aab0","line":1,"updated":"2016-10-21 23:30:42.000000000","message":"We started documenting OSC commands under:\n\ndoc/source/usage/osc/v2\n\nwhere is this path you\u0027re proposing coming from?","commit_id":"f074fdb4f59588f3768ad9c3869941ff76bc2a96"}],"doc/source/command-objects/network-qos-rule.rst":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"f27322d4a76e72060ce3b1f34124f1407b9b5997","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. option:: --type \u003ctype\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    QoS rule type (minimum_bandwidth)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":".. option:: --min-kbps \u003cmin-kbps\u003e"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a629dbe_7df16194","line":26,"updated":"2016-11-11 22:01:18.000000000","message":"Use dashes not underscores; what is the default?","commit_id":"63c1fce6b612208f5e50444bf04c82e70a8a7645"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ba34f9cb2c62fbf7ddbc8bd5ee3e0ea7bc795ff","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. option:: --type \u003ctype\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    QoS rule type (minimum_bandwidth)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":".. option:: --min-kbps \u003cmin-kbps\u003e"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a629dbe_cf02930b","line":26,"in_reply_to":"9a629dbe_7df16194","updated":"2016-11-14 16:14:03.000000000","message":"I\u0027ll change underscores.\n\nThere shouldn\u0027t be a default option in \"type\". I think setting a default option for \"type\" is dangerous and we should coerce the user to set the type.","commit_id":"63c1fce6b612208f5e50444bf04c82e70a8a7645"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"f27322d4a76e72060ce3b1f34124f1407b9b5997","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":".. option:: --direction \u003cdirection\u003e"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Traffic direction from the tenant point of view"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a629dbe_dd30ad58","line":34,"updated":"2016-11-11 22:01:18.000000000","message":"What values?  ingress/egress?  what is the default?\n\nAlso, use project in place of tenant","commit_id":"63c1fce6b612208f5e50444bf04c82e70a8a7645"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ba34f9cb2c62fbf7ddbc8bd5ee3e0ea7bc795ff","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":".. option:: --direction \u003cdirection\u003e"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Traffic direction from the tenant point of view"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a629dbe_72aecce8","line":34,"in_reply_to":"9a629dbe_dd30ad58","updated":"2016-11-14 16:14:03.000000000","message":"Done","commit_id":"63c1fce6b612208f5e50444bf04c82e70a8a7645"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"f27322d4a76e72060ce3b1f34124f1407b9b5997","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    ID or name of the QoS policy which owns the rule"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"network qos rule delete"},{"line_number":41,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a629dbe_036d68cb","line":38,"updated":"2016-11-11 22:01:18.000000000","message":"QoS policy that contains the rule (name or ID)\n\nWe use the trailing \u0027(name or ID)\u0027 form when either is allowed","commit_id":"63c1fce6b612208f5e50444bf04c82e70a8a7645"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ba34f9cb2c62fbf7ddbc8bd5ee3e0ea7bc795ff","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    ID or name of the QoS policy which owns the rule"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"network qos rule delete"},{"line_number":41,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a629dbe_520d4836","line":38,"in_reply_to":"9a629dbe_036d68cb","updated":"2016-11-14 16:14:03.000000000","message":"Done","commit_id":"63c1fce6b612208f5e50444bf04c82e70a8a7645"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"f27322d4a76e72060ce3b1f34124f1407b9b5997","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    os network qos rule delete"},{"line_number":49,"context_line":"         \u003crule-id\u003e"},{"line_number":50,"context_line":"         \u003cqos-policy\u003e"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":".. describe:: \u003crule-id\u003e"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a629dbe_5d3d7d29","line":50,"updated":"2016-11-11 22:01:18.000000000","message":"I may have asked this before, but rule-id is not globally unique?","commit_id":"63c1fce6b612208f5e50444bf04c82e70a8a7645"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ba34f9cb2c62fbf7ddbc8bd5ee3e0ea7bc795ff","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    os network qos rule delete"},{"line_number":49,"context_line":"         \u003crule-id\u003e"},{"line_number":50,"context_line":"         \u003cqos-policy\u003e"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":".. describe:: \u003crule-id\u003e"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"9a629dbe_d25eb811","line":50,"in_reply_to":"9a629dbe_5d3d7d29","updated":"2016-11-14 16:14:03.000000000","message":"Yes, we talk about this. \"rule-id\" is unique, but it\u0027s not possible to retreive the QoS rule without the QoS policy ID/name. This is an \"issue\" in the API. To avoid this, we should first modify neutron API but, for now, this is not a priority.","commit_id":"63c1fce6b612208f5e50444bf04c82e70a8a7645"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14640ef43422a0e97b025254ed4c149ba0c05aad","unresolved":false,"context_lines":[{"line_number":2,"context_line":"network qos rule"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **Network QoS rule** is a specific Network QoS rule; its type is defined by"},{"line_number":6,"context_line":"the parameter \u0027type\u0027. Can be assigned to a port or a network."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Network v2"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_bc9f05b3","line":5,"range":{"start_line":5,"start_character":1,"end_line":5,"end_character":54},"updated":"2016-11-16 16:15:51.000000000","message":"A network QoS rule is a specific Network QoS rule (??)\nI am a bit confused with the statement","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a21527642abf98127d85606f9e44e2990275b22b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"network qos rule"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **Network QoS rule** is a specific Network QoS rule; its type is defined by"},{"line_number":6,"context_line":"the parameter \u0027type\u0027. Can be assigned to a port or a network."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Network v2"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_6850e70b","line":5,"range":{"start_line":5,"start_character":1,"end_line":5,"end_character":54},"in_reply_to":"7a77a97e_bc9f05b3","updated":"2016-11-18 09:15:51.000000000","message":"Done","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14640ef43422a0e97b025254ed4c149ba0c05aad","unresolved":false,"context_lines":[{"line_number":5,"context_line":"A **Network QoS rule** is a specific Network QoS rule; its type is defined by"},{"line_number":6,"context_line":"the parameter \u0027type\u0027. Can be assigned to a port or a network."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Network v2"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"network qos rule create"},{"line_number":11,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_5c57d1cd","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":10},"updated":"2016-11-16 16:15:51.000000000","message":"DO we need to mention Network v2 here?","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a21527642abf98127d85606f9e44e2990275b22b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"A **Network QoS rule** is a specific Network QoS rule; its type is defined by"},{"line_number":6,"context_line":"the parameter \u0027type\u0027. Can be assigned to a port or a network."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Network v2"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"network qos rule create"},{"line_number":11,"context_line":"-----------------------"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_dd70df0d","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":10},"in_reply_to":"7a77a97e_5c57d1cd","updated":"2016-11-18 09:15:51.000000000","message":"Like in the rest of the commands, to dafine the version of the API. Just take a look at network commands like addess-scope, floating-ip, ip-*, network-*, etc.","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14640ef43422a0e97b025254ed4c149ba0c05aad","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    Maximum burst bandwidth in kbps"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":".. option:: --dscp-mark \u003cdscp-mark\u003e"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    DSCP mark: value can be 0, even numbers from 8-56, excluding 42, 44, 50, 52, and 54"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_5c0511ba","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":35},"updated":"2016-11-16 16:15:51.000000000","message":"Is there a possibility to remove dscp marks?\nIf so, then we need to add the option in a new command \"openstack network qos rule unset\"","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a21527642abf98127d85606f9e44e2990275b22b","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    Maximum burst bandwidth in kbps"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":".. option:: --dscp-mark \u003cdscp-mark\u003e"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    DSCP mark: value can be 0, even numbers from 8-56, excluding 42, 44, 50, 52, and 54"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_9db5877f","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":35},"in_reply_to":"7a77a97e_5c0511ba","updated":"2016-11-18 09:15:51.000000000","message":"No, there isn\u0027t. A rule, type\u003ddscp-markings must have a \"dscp-mark\" parameter. If no DSCP marking is needed, the rule must be removed from the policy.","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6c098dccb25ee0fc90d31f275cb10f7437120869","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    Maximum burst bandwidth in kbps"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":".. option:: --dscp-mark \u003cdscp-mark\u003e"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    DSCP mark: value can be 0, even numbers from 8-56, excluding 42, 44, 50, 52, and 54"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_14ada29a","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":35},"in_reply_to":"7a77a97e_9db5877f","updated":"2016-11-20 07:51:46.000000000","message":"Can we have multiple DSCP marking?","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14640ef43422a0e97b025254ed4c149ba0c05aad","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. option:: --direction \u003cdirection\u003e"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Traffic direction from the project point of view (egress, ingress. Default: egress)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_fc5edd74","line":49,"updated":"2016-11-16 16:15:51.000000000","message":"Lets put it in the next line, shall we?","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a21527642abf98127d85606f9e44e2990275b22b","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. option:: --direction \u003cdirection\u003e"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Traffic direction from the project point of view (egress, ingress. Default: egress)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_fd5cbb4c","line":49,"in_reply_to":"7a77a97e_fc5edd74","updated":"2016-11-18 09:15:51.000000000","message":"Done","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14640ef43422a0e97b025254ed4c149ba0c05aad","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. describe:: \u003crule-id\u003e"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    Network QoS rule to delete (ID)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_cc9dec5a","line":69,"range":{"start_line":69,"start_character":32,"end_line":69,"end_character":34},"updated":"2016-11-16 16:15:51.000000000","message":"why cant we use QoS rule name?","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73d4c787e9c82042287ccd4d3b7eb60f20925d8e","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. describe:: \u003crule-id\u003e"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    Network QoS rule to delete (ID)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_0e73aab5","line":69,"range":{"start_line":69,"start_character":32,"end_line":69,"end_character":34},"in_reply_to":"7a77a97e_749ed663","updated":"2016-11-21 16:06:51.000000000","message":"Could be, but the Neutron database/object was not designed in this way","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6c098dccb25ee0fc90d31f275cb10f7437120869","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. describe:: \u003crule-id\u003e"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    Network QoS rule to delete (ID)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_749ed663","line":69,"range":{"start_line":69,"start_character":32,"end_line":69,"end_character":34},"in_reply_to":"7a77a97e_7d37cbfe","updated":"2016-11-20 07:51:46.000000000","message":"Oh right...\nNow, I am wondering why is there no name... wont a rule name be more useful to a user?","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a21527642abf98127d85606f9e44e2990275b22b","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. describe:: \u003crule-id\u003e"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    Network QoS rule to delete (ID)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_7d37cbfe","line":69,"range":{"start_line":69,"start_character":32,"end_line":69,"end_character":34},"in_reply_to":"7a77a97e_cc9dec5a","updated":"2016-11-18 09:15:51.000000000","message":"There is no rule name","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14640ef43422a0e97b025254ed4c149ba0c05aad","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    os network qos rule set"},{"line_number":99,"context_line":"        [--max-kbps \u003cmax-kbps\u003e]"},{"line_number":100,"context_line":"        [--max-burst-kbps \u003cmax-burst-kbps\u003e]"},{"line_number":101,"context_line":"        [--dscp-marks \u003cdscp-marks\u003e]"},{"line_number":102,"context_line":"        [--min-kbps \u003cmin-kbps\u003e]"},{"line_number":103,"context_line":"        [--direction \u003cdirection\u003e]"},{"line_number":104,"context_line":"        \u003crule-id\u003e"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_2cdd800e","line":101,"range":{"start_line":101,"start_character":7,"end_line":101,"end_character":35},"updated":"2016-11-16 16:15:51.000000000","message":"dscp marks is an optional argument.\nSo it means the user can Set/Clear the values of dscp marking.\nIf so, the user should be given an option \"--no-dscp-marking\"","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6c098dccb25ee0fc90d31f275cb10f7437120869","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    os network qos rule set"},{"line_number":99,"context_line":"        [--max-kbps \u003cmax-kbps\u003e]"},{"line_number":100,"context_line":"        [--max-burst-kbps \u003cmax-burst-kbps\u003e]"},{"line_number":101,"context_line":"        [--dscp-marks \u003cdscp-marks\u003e]"},{"line_number":102,"context_line":"        [--min-kbps \u003cmin-kbps\u003e]"},{"line_number":103,"context_line":"        [--direction \u003cdirection\u003e]"},{"line_number":104,"context_line":"        \u003crule-id\u003e"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_b48a2e19","line":101,"range":{"start_line":101,"start_character":7,"end_line":101,"end_character":35},"in_reply_to":"7a77a97e_281d0f66","updated":"2016-11-20 07:51:46.000000000","message":"ok","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a21527642abf98127d85606f9e44e2990275b22b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    os network qos rule set"},{"line_number":99,"context_line":"        [--max-kbps \u003cmax-kbps\u003e]"},{"line_number":100,"context_line":"        [--max-burst-kbps \u003cmax-burst-kbps\u003e]"},{"line_number":101,"context_line":"        [--dscp-marks \u003cdscp-marks\u003e]"},{"line_number":102,"context_line":"        [--min-kbps \u003cmin-kbps\u003e]"},{"line_number":103,"context_line":"        [--direction \u003cdirection\u003e]"},{"line_number":104,"context_line":"        \u003crule-id\u003e"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_281d0f66","line":101,"range":{"start_line":101,"start_character":7,"end_line":101,"end_character":35},"in_reply_to":"7a77a97e_2cdd800e","updated":"2016-11-18 09:15:51.000000000","message":"dscp-marks is now an optional argument, like max-burst-kbps, max-kbps, min-kbps, and direction. Depending on the rule type, the presence of this arguments will be enforced or not. But, in this case, if dscp-mark is needed, a value must be set.\n\n\"--no-dscp-marking\" has no sense in this command.","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14640ef43422a0e97b025254ed4c149ba0c05aad","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":".. describe:: \u003crule-id\u003e"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    Network QoS rule to delete (ID)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_8c085493","line":129,"range":{"start_line":129,"start_character":32,"end_line":129,"end_character":34},"updated":"2016-11-16 16:15:51.000000000","message":"name or ID","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a21527642abf98127d85606f9e44e2990275b22b","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":".. describe:: \u003crule-id\u003e"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    Network QoS rule to delete (ID)"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a77a97e_6829c789","line":129,"range":{"start_line":129,"start_character":32,"end_line":129,"end_character":34},"in_reply_to":"7a77a97e_8c085493","updated":"2016-11-18 09:15:51.000000000","message":"Rules have no name.","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"3fbdbf0e16ba7b2582a04c0ef321c1a72eb19879","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    Minimum guaranteed bandwidth in kbps"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. option:: --direction \u003cdirection\u003e"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    Traffic direction from the project point of view (egress, ingress)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"3a71b18c_5a5a7150","line":50,"updated":"2016-12-02 20:24:58.000000000","message":"Make this like the security group rule command with --egress and --ingress options","commit_id":"7b83521a68ebd2b4cd6274bd26b510445d18e34b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"14d6adee451128f7cf83a051b0458fc951cc295e","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    Minimum guaranteed bandwidth in kbps"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. option:: --direction \u003cdirection\u003e"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    Traffic direction from the project point of view (egress, ingress)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"3a71b18c_960afa77","line":50,"in_reply_to":"3a71b18c_5a5a7150","updated":"2016-12-05 10:36:54.000000000","message":"Done","commit_id":"7b83521a68ebd2b4cd6274bd26b510445d18e34b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"594c93633d9da10d1c48c07210e0637ac6b4e3e4","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    Maximum bandwidth in kbps"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":".. option:: --max-burst-kbps \u003cmax-burst-kbps\u003e"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Maximum burst bandwidth in kbps"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"1a6eadb0_21c39b8a","line":37,"updated":"2016-12-21 13:58:38.000000000","message":"I believe we should hide our error in the API by exposing here the right cmdline option (eventually we will transparently change the API)\n--max-burst-kbits\n\n\nWhat do you think?","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"606b3b51c6d54ea195082b9aaa60bc4f2349be7c","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    Maximum bandwidth in kbps"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":".. option:: --max-burst-kbps \u003cmax-burst-kbps\u003e"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Maximum burst bandwidth in kbps"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"da4df55a_4b44c673","line":37,"in_reply_to":"1a6eadb0_21c39b8a","updated":"2016-12-22 12:19:00.000000000","message":"I agree and this is something we need to solve.","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"594c93633d9da10d1c48c07210e0637ac6b4e3e4","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":".. option:: --max-burst-kbps \u003cmax-burst-kbps\u003e"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Maximum burst bandwidth in kbps"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":".. option:: --dscp-mark \u003cdscp-mark\u003e"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"1a6eadb0_8138efa1","line":39,"updated":"2016-12-21 13:58:38.000000000","message":"Maximum burst in kilobits, 0 means automatic.\n\n(This is the size of the toke bucket used for policing), which is replenished at \"max-kbps\" rate.","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"606b3b51c6d54ea195082b9aaa60bc4f2349be7c","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":".. option:: --max-burst-kbps \u003cmax-burst-kbps\u003e"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    Maximum burst bandwidth in kbps"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":".. option:: --dscp-mark \u003cdscp-mark\u003e"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"da4df55a_4141070b","line":39,"in_reply_to":"1a6eadb0_8138efa1","updated":"2016-12-22 12:19:00.000000000","message":"Done","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"594c93633d9da10d1c48c07210e0637ac6b4e3e4","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. option:: --ingress"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    Ingress traffic direction from the project point of view"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":".. option:: --egress"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"1a6eadb0_81d46f20","line":52,"updated":"2016-12-21 13:58:38.000000000","message":"project-\u003einstance?","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"606b3b51c6d54ea195082b9aaa60bc4f2349be7c","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. option:: --ingress"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    Ingress traffic direction from the project point of view"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":".. option:: --egress"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"da4df55a_41b027de","line":52,"in_reply_to":"1a6eadb0_81d46f20","updated":"2016-12-22 12:19:00.000000000","message":"I changed this because of this recommendation made by Dean Troyer:\nhttps://review.openstack.org/#/c/352477/21/doc/source/command-objects/network-qos-rule.rst","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"594c93633d9da10d1c48c07210e0637ac6b4e3e4","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":".. option:: --egress"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    Egress traffic direction from the project point of view"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"1a6eadb0_a1d96b59","line":56,"updated":"2016-12-21 13:58:38.000000000","message":"project -\u003e instance?","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"606b3b51c6d54ea195082b9aaa60bc4f2349be7c","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":".. option:: --egress"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    Egress traffic direction from the project point of view"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"da4df55a_e1c11b30","line":56,"in_reply_to":"1a6eadb0_a1d96b59","updated":"2016-12-22 12:19:00.000000000","message":"I changed this because of this recommendation made by Dean Troyer:\nhttps://review.openstack.org/#/c/352477/21/doc/source/command-objects/network-qos-rule.rst","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"594c93633d9da10d1c48c07210e0637ac6b4e3e4","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    Maximum bandwidth in kbps"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":".. option:: --max-burst-kbps \u003cmax-burst-kbps\u003e"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    Maximum burst bandwidth in kbps"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"1a6eadb0_61c3d357","line":118,"updated":"2016-12-21 13:58:38.000000000","message":"same comments as for  for create.","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"606b3b51c6d54ea195082b9aaa60bc4f2349be7c","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    Maximum bandwidth in kbps"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":".. option:: --max-burst-kbps \u003cmax-burst-kbps\u003e"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    Maximum burst bandwidth in kbps"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"da4df55a_01dd3f14","line":118,"in_reply_to":"1a6eadb0_61c3d357","updated":"2016-12-22 12:19:00.000000000","message":"Done","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"594c93633d9da10d1c48c07210e0637ac6b4e3e4","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":".. option:: --max-burst-kbps \u003cmax-burst-kbps\u003e"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    Maximum burst bandwidth in kbps"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":".. option:: --dscp-mark \u003cdscp-mark\u003e"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"1a6eadb0_e1ad239c","line":120,"updated":"2016-12-21 13:58:38.000000000","message":"same comments as for create.","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"606b3b51c6d54ea195082b9aaa60bc4f2349be7c","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":".. option:: --max-burst-kbps \u003cmax-burst-kbps\u003e"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    Maximum burst bandwidth in kbps"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":".. option:: --dscp-mark \u003cdscp-mark\u003e"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"da4df55a_81d12ffe","line":120,"in_reply_to":"1a6eadb0_e1ad239c","updated":"2016-12-22 12:19:00.000000000","message":"Done","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"594c93633d9da10d1c48c07210e0637ac6b4e3e4","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":".. option:: --ingress"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    Ingress traffic direction from the project point of view"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":".. option:: --egress"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"1a6eadb0_21947b41","line":133,"updated":"2016-12-21 13:58:38.000000000","message":"project-\u003einstance","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"606b3b51c6d54ea195082b9aaa60bc4f2349be7c","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":".. option:: --ingress"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    Ingress traffic direction from the project point of view"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":".. option:: --egress"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"da4df55a_c1db371a","line":133,"in_reply_to":"1a6eadb0_21947b41","updated":"2016-12-22 12:19:00.000000000","message":"ditto","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"594c93633d9da10d1c48c07210e0637ac6b4e3e4","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":".. option:: --egress"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    Egress traffic direction from the project point of view"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"1a6eadb0_419df764","line":137,"updated":"2016-12-21 13:58:38.000000000","message":"project-\u003einstance","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"606b3b51c6d54ea195082b9aaa60bc4f2349be7c","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":".. option:: --egress"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    Egress traffic direction from the project point of view"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":".. describe:: \u003cqos-policy\u003e"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-rst","patch_set":28,"id":"da4df55a_61036b74","line":137,"in_reply_to":"1a6eadb0_419df764","updated":"2016-12-22 12:19:00.000000000","message":"ditto","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"f4d81713d4c0ae8ae166fbee13c7e487cc8630ce","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. option:: --type \u003ctype\u003e"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    QoS rule type (minimum-bandwidth)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. option:: --max-kbps \u003cmin-kbps\u003e"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":31,"id":"ba5201f7_efa8ebdd","line":31,"updated":"2017-01-03 21:36:44.000000000","message":"All valid types should be listed here, ie the first line of these doc sections should match the help output.\n\nAlso, recalling an earlier comment, since there is no default for type, this should be a required option.","commit_id":"2cc845e406cfc2c6c784a33171760c86b7dce945"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a8cad9c9eeec9b161dc90f63f1e26094ecc59926","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. option:: --type \u003ctype\u003e"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    QoS rule type (minimum-bandwidth)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. option:: --max-kbps \u003cmin-kbps\u003e"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":31,"id":"ba5201f7_1ce76bad","line":31,"in_reply_to":"ba5201f7_efa8ebdd","updated":"2017-01-09 18:01:23.000000000","message":"Done.\n\nThis parameter is mandatory in the creation process. An exception is thrown is this parameter is missing. I\u0027ll remove the brackets.","commit_id":"2cc845e406cfc2c6c784a33171760c86b7dce945"}],"openstackclient/network/v2/network_qos_rule.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14640ef43422a0e97b025254ed4c149ba0c05aad","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            type\u003dint,"},{"line_number":172,"context_line":"            help\u003d_(\u0027Minimum guaranteed bandwidth in kbps\u0027)"},{"line_number":173,"context_line":"        )"},{"line_number":174,"context_line":"        parser.add_argument("},{"line_number":175,"context_line":"            \u0027--direction\u0027,"},{"line_number":176,"context_line":"            dest\u003d\u0027direction\u0027,"},{"line_number":177,"context_line":"            metavar\u003d\u0027\u003cdirection\u003e\u0027,"},{"line_number":178,"context_line":"            choices\u003d[DIRECTION_EGRESS, DIRECTION_INGRESS],"},{"line_number":179,"context_line":"            help\u003d_(\u0027Traffic direction from the project point of view (egress, \u0027"},{"line_number":180,"context_line":"                   \u0027ingress)\u0027))"},{"line_number":181,"context_line":"        return parser"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_cca32c4e","line":180,"range":{"start_line":174,"start_character":0,"end_line":180,"end_character":31},"updated":"2016-11-16 16:15:51.000000000","message":"Missing the default value, I guess","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6c098dccb25ee0fc90d31f275cb10f7437120869","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            type\u003dint,"},{"line_number":172,"context_line":"            help\u003d_(\u0027Minimum guaranteed bandwidth in kbps\u0027)"},{"line_number":173,"context_line":"        )"},{"line_number":174,"context_line":"        parser.add_argument("},{"line_number":175,"context_line":"            \u0027--direction\u0027,"},{"line_number":176,"context_line":"            dest\u003d\u0027direction\u0027,"},{"line_number":177,"context_line":"            metavar\u003d\u0027\u003cdirection\u003e\u0027,"},{"line_number":178,"context_line":"            choices\u003d[DIRECTION_EGRESS, DIRECTION_INGRESS],"},{"line_number":179,"context_line":"            help\u003d_(\u0027Traffic direction from the project point of view (egress, \u0027"},{"line_number":180,"context_line":"                   \u0027ingress)\u0027))"},{"line_number":181,"context_line":"        return parser"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_f4974637","line":180,"range":{"start_line":174,"start_character":0,"end_line":180,"end_character":31},"in_reply_to":"7a77a97e_28342fdc","updated":"2016-11-20 07:51:46.000000000","message":"Agreed, but in https://review.openstack.org/#/c/352477/22/doc/source/command-objects/network-qos-rule.rst , you have mentioned in the description of \"Direction\" that default is egress.\nSo you can either remove it from there or add it here...\nThats what I meant by my earlier comment, which now I understand was not completely understandable :)","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a21527642abf98127d85606f9e44e2990275b22b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            type\u003dint,"},{"line_number":172,"context_line":"            help\u003d_(\u0027Minimum guaranteed bandwidth in kbps\u0027)"},{"line_number":173,"context_line":"        )"},{"line_number":174,"context_line":"        parser.add_argument("},{"line_number":175,"context_line":"            \u0027--direction\u0027,"},{"line_number":176,"context_line":"            dest\u003d\u0027direction\u0027,"},{"line_number":177,"context_line":"            metavar\u003d\u0027\u003cdirection\u003e\u0027,"},{"line_number":178,"context_line":"            choices\u003d[DIRECTION_EGRESS, DIRECTION_INGRESS],"},{"line_number":179,"context_line":"            help\u003d_(\u0027Traffic direction from the project point of view (egress, \u0027"},{"line_number":180,"context_line":"                   \u0027ingress)\u0027))"},{"line_number":181,"context_line":"        return parser"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_28342fdc","line":180,"range":{"start_line":174,"start_character":0,"end_line":180,"end_character":31},"in_reply_to":"7a77a97e_cca32c4e","updated":"2016-11-18 09:15:51.000000000","message":"Direction is an optional argument. If a default value is set, the argument will be present in the attributes parsing (_get_attrs). Depending on the rule type, if \"direction\" is present, the parsing will fail.\n\nIf an argument is optional, no default value must be set.","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73d4c787e9c82042287ccd4d3b7eb60f20925d8e","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            type\u003dint,"},{"line_number":172,"context_line":"            help\u003d_(\u0027Minimum guaranteed bandwidth in kbps\u0027)"},{"line_number":173,"context_line":"        )"},{"line_number":174,"context_line":"        parser.add_argument("},{"line_number":175,"context_line":"            \u0027--direction\u0027,"},{"line_number":176,"context_line":"            dest\u003d\u0027direction\u0027,"},{"line_number":177,"context_line":"            metavar\u003d\u0027\u003cdirection\u003e\u0027,"},{"line_number":178,"context_line":"            choices\u003d[DIRECTION_EGRESS, DIRECTION_INGRESS],"},{"line_number":179,"context_line":"            help\u003d_(\u0027Traffic direction from the project point of view (egress, \u0027"},{"line_number":180,"context_line":"                   \u0027ingress)\u0027))"},{"line_number":181,"context_line":"        return parser"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_0e2baa34","line":180,"range":{"start_line":174,"start_character":0,"end_line":180,"end_character":31},"in_reply_to":"7a77a97e_f4974637","updated":"2016-11-21 16:06:51.000000000","message":"You are right. I\u0027ll remove the comment in the doc section.","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14640ef43422a0e97b025254ed4c149ba0c05aad","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                                                 ignore_missing\u003dFalse)"},{"line_number":221,"context_line":"            rule_type \u003d _find_rule_type(qos, rule_id)"},{"line_number":222,"context_line":"            if not rule_type:"},{"line_number":223,"context_line":"                raise Exception(\u0027Rule not found\u0027)"},{"line_number":224,"context_line":"            _rule_action_call(network_client, ACTION_DELETE, rule_type)("},{"line_number":225,"context_line":"                rule_id, qos.id)"},{"line_number":226,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_df3bd0cf","line":223,"range":{"start_line":223,"start_character":33,"end_line":223,"end_character":41},"updated":"2016-11-16 16:15:51.000000000","message":"_(\"%(rule)s not found\" %{\"rule\" : rule_type})","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6c098dccb25ee0fc90d31f275cb10f7437120869","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                                                 ignore_missing\u003dFalse)"},{"line_number":221,"context_line":"            rule_type \u003d _find_rule_type(qos, rule_id)"},{"line_number":222,"context_line":"            if not rule_type:"},{"line_number":223,"context_line":"                raise Exception(\u0027Rule not found\u0027)"},{"line_number":224,"context_line":"            _rule_action_call(network_client, ACTION_DELETE, rule_type)("},{"line_number":225,"context_line":"                rule_id, qos.id)"},{"line_number":226,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_94a7f2a5","line":223,"range":{"start_line":223,"start_character":33,"end_line":223,"end_character":41},"in_reply_to":"7a77a97e_0895b385","updated":"2016-11-20 07:51:46.000000000","message":"Umm, ok ...\nBut I meant that we can show the Rule ID in the exception","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73d4c787e9c82042287ccd4d3b7eb60f20925d8e","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                                                 ignore_missing\u003dFalse)"},{"line_number":221,"context_line":"            rule_type \u003d _find_rule_type(qos, rule_id)"},{"line_number":222,"context_line":"            if not rule_type:"},{"line_number":223,"context_line":"                raise Exception(\u0027Rule not found\u0027)"},{"line_number":224,"context_line":"            _rule_action_call(network_client, ACTION_DELETE, rule_type)("},{"line_number":225,"context_line":"                rule_id, qos.id)"},{"line_number":226,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_4e7be27b","line":223,"range":{"start_line":223,"start_character":33,"end_line":223,"end_character":41},"in_reply_to":"7a77a97e_94a7f2a5","updated":"2016-11-21 16:06:51.000000000","message":"Ok, I\u0027ll put the ID of the rule","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a21527642abf98127d85606f9e44e2990275b22b","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                                                 ignore_missing\u003dFalse)"},{"line_number":221,"context_line":"            rule_type \u003d _find_rule_type(qos, rule_id)"},{"line_number":222,"context_line":"            if not rule_type:"},{"line_number":223,"context_line":"                raise Exception(\u0027Rule not found\u0027)"},{"line_number":224,"context_line":"            _rule_action_call(network_client, ACTION_DELETE, rule_type)("},{"line_number":225,"context_line":"                rule_id, qos.id)"},{"line_number":226,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_0895b385","line":223,"range":{"start_line":223,"start_character":33,"end_line":223,"end_character":41},"in_reply_to":"7a77a97e_df3bd0cf","updated":"2016-11-18 09:15:51.000000000","message":"Only one. To delete a rule you must specify the QoS policy and the rule ID. Only one could be found/deleted.","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14640ef43422a0e97b025254ed4c149ba0c05aad","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            type\u003dint,"},{"line_number":315,"context_line":"            help\u003d_(\u0027Minimum guaranteed bandwidth in kbps\u0027)"},{"line_number":316,"context_line":"        )"},{"line_number":317,"context_line":"        parser.add_argument("},{"line_number":318,"context_line":"            \u0027--direction\u0027,"},{"line_number":319,"context_line":"            metavar\u003d\u0027\u003cdirection\u003e\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Traffic direction from the project point of view (egress, \u0027"},{"line_number":321,"context_line":"                   \u0027ingress. Default: egress)\u0027))"},{"line_number":322,"context_line":"        return parser"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_3f8da47b","line":321,"range":{"start_line":317,"start_character":2,"end_line":321,"end_character":48},"updated":"2016-11-16 16:15:51.000000000","message":"Can you add the default value?","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a21527642abf98127d85606f9e44e2990275b22b","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            type\u003dint,"},{"line_number":315,"context_line":"            help\u003d_(\u0027Minimum guaranteed bandwidth in kbps\u0027)"},{"line_number":316,"context_line":"        )"},{"line_number":317,"context_line":"        parser.add_argument("},{"line_number":318,"context_line":"            \u0027--direction\u0027,"},{"line_number":319,"context_line":"            metavar\u003d\u0027\u003cdirection\u003e\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Traffic direction from the project point of view (egress, \u0027"},{"line_number":321,"context_line":"                   \u0027ingress. Default: egress)\u0027))"},{"line_number":322,"context_line":"        return parser"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_2890af94","line":321,"range":{"start_line":317,"start_character":2,"end_line":321,"end_character":48},"in_reply_to":"7a77a97e_3f8da47b","updated":"2016-11-18 09:15:51.000000000","message":"ditto","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"3fbdbf0e16ba7b2582a04c0ef321c1a72eb19879","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class CreateNetworkQosRule(command.ShowOne):"},{"line_number":126,"context_line":"    \"\"\"Create a Network QoS rule\"\"\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def get_parser(self, prog_name):"},{"line_number":129,"context_line":"        parser \u003d super(CreateNetworkQosRule, self).get_parser("}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_9575ba99","line":126,"updated":"2016-12-02 20:24:58.000000000","message":"I realize this changed after this review was submitted, but would you please change these to the new translatable format:\n\n  _description \u003d _(\"Create a Network QoS rule\")","commit_id":"7b83521a68ebd2b4cd6274bd26b510445d18e34b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"14d6adee451128f7cf83a051b0458fc951cc295e","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"class CreateNetworkQosRule(command.ShowOne):"},{"line_number":126,"context_line":"    \"\"\"Create a Network QoS rule\"\"\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def get_parser(self, prog_name):"},{"line_number":129,"context_line":"        parser \u003d super(CreateNetworkQosRule, self).get_parser("}],"source_content_type":"text/x-python","patch_set":25,"id":"3a71b18c_36c0462a","line":126,"in_reply_to":"3a71b18c_9575ba99","updated":"2016-12-05 10:36:54.000000000","message":"Done","commit_id":"7b83521a68ebd2b4cd6274bd26b510445d18e34b"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"4db96776757444775c6caedb9ff9895f25d65028","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        columns.append(\u0027project_id\u0027)"},{"line_number":53,"context_line":"    if \u0027headers\u0027 in columns:"},{"line_number":54,"context_line":"        columns.remove(\u0027headers\u0027)"},{"line_number":55,"context_line":"    return tuple(sorted(columns))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def _check_type_parameters(attrs, type, is_create):"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a6eadb0_fbf3be70","line":55,"updated":"2016-12-16 17:01:09.000000000","message":"rebase with sdk changes.\nhttps://etherpad.openstack.org/p/osc-network-command-sdk-support\n\nExample https://review.openstack.org/#/c/401033/","commit_id":"f5a2357b34d73938dae98b369796d3ae0f287c7e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d8d1837508aa9b1b2d0b51fd69fbbc219ea5a887","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        columns.append(\u0027project_id\u0027)"},{"line_number":53,"context_line":"    if \u0027headers\u0027 in columns:"},{"line_number":54,"context_line":"        columns.remove(\u0027headers\u0027)"},{"line_number":55,"context_line":"    return tuple(sorted(columns))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def _check_type_parameters(attrs, type, is_create):"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a6eadb0_d88adfbe","line":55,"in_reply_to":"1a6eadb0_fbf3be70","updated":"2016-12-21 11:26:30.000000000","message":"Done","commit_id":"f5a2357b34d73938dae98b369796d3ae0f287c7e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"594c93633d9da10d1c48c07210e0637ac6b4e3e4","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        )"},{"line_number":152,"context_line":"        parser.add_argument("},{"line_number":153,"context_line":"            \u0027--max-burst-kbps\u0027,"},{"line_number":154,"context_line":"            dest\u003d\u0027max_burst_kbps\u0027,"},{"line_number":155,"context_line":"            metavar\u003d\u0027\u003cmax-burst-kbps\u003e\u0027,"},{"line_number":156,"context_line":"            type\u003dint,"},{"line_number":157,"context_line":"            help\u003d_(\u0027Maximum burst bandwidth in kbps\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_a1bc0bbc","line":154,"updated":"2016-12-21 13:58:38.000000000","message":"max_burst_kbits","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"606b3b51c6d54ea195082b9aaa60bc4f2349be7c","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        )"},{"line_number":152,"context_line":"        parser.add_argument("},{"line_number":153,"context_line":"            \u0027--max-burst-kbps\u0027,"},{"line_number":154,"context_line":"            dest\u003d\u0027max_burst_kbps\u0027,"},{"line_number":155,"context_line":"            metavar\u003d\u0027\u003cmax-burst-kbps\u003e\u0027,"},{"line_number":156,"context_line":"            type\u003dint,"},{"line_number":157,"context_line":"            help\u003d_(\u0027Maximum burst bandwidth in kbps\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"da4df55a_a18633b7","line":154,"in_reply_to":"1a6eadb0_a1bc0bbc","updated":"2016-12-22 12:19:00.000000000","message":"Done","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"594c93633d9da10d1c48c07210e0637ac6b4e3e4","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            metavar\u003d\u0027\u003cqos-policy\u003e\u0027,"},{"line_number":285,"context_line":"            help\u003d_(\u0027QoS policy that contains the rule (name or ID)\u0027)"},{"line_number":286,"context_line":"        )"},{"line_number":287,"context_line":"        parser.add_argument("},{"line_number":288,"context_line":"            \u0027id\u0027,"},{"line_number":289,"context_line":"            metavar\u003d\u0027\u003crule-id\u003e\u0027,"},{"line_number":290,"context_line":"            help\u003d_(\u0027Network QoS rule to delete (ID)\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_411ed7bb","line":287,"updated":"2016-12-21 13:58:38.000000000","message":"Is it possible to refactor this together with L145-L180 into a function?\n\nIs there any way to make the parameters dependent on the type of rule? It was easier when all rules had their separate action, but as far as I understood we don\u0027t want hyphened commands here.","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"606b3b51c6d54ea195082b9aaa60bc4f2349be7c","unresolved":false,"context_lines":[{"line_number":284,"context_line":"            metavar\u003d\u0027\u003cqos-policy\u003e\u0027,"},{"line_number":285,"context_line":"            help\u003d_(\u0027QoS policy that contains the rule (name or ID)\u0027)"},{"line_number":286,"context_line":"        )"},{"line_number":287,"context_line":"        parser.add_argument("},{"line_number":288,"context_line":"            \u0027id\u0027,"},{"line_number":289,"context_line":"            metavar\u003d\u0027\u003crule-id\u003e\u0027,"},{"line_number":290,"context_line":"            help\u003d_(\u0027Network QoS rule to delete (ID)\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"da4df55a_30d0ca53","line":287,"in_reply_to":"1a6eadb0_411ed7bb","updated":"2016-12-22 12:19:00.000000000","message":"I can make a function to add the arguments.\n\nIt\u0027s not possible to make parameters dependent on the rule, because when \"get_parser\" is called, OSclient doesn\u0027t know which type of rule is creating/modifying.","commit_id":"bf322ee74864ba6e441c800061fd48a0aceecb03"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e14f1eb56e0633a3b8155d00abbe88b94c19ba1d","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"class CreateNetworkQosRule(command.ShowOne):"},{"line_number":169,"context_line":"    _description \u003d _(\"Create a Network QoS rule\")"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def get_parser(self, prog_name):"},{"line_number":172,"context_line":"        parser \u003d super(CreateNetworkQosRule, self).get_parser("}],"source_content_type":"text/x-python","patch_set":31,"id":"ba5201f7_a4e1a59c","line":169,"range":{"start_line":169,"start_character":22,"end_line":169,"end_character":47},"updated":"2017-01-03 22:51:10.000000000","message":"Create new Network QoS rule","commit_id":"2cc845e406cfc2c6c784a33171760c86b7dce945"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a8cad9c9eeec9b161dc90f63f1e26094ecc59926","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"class CreateNetworkQosRule(command.ShowOne):"},{"line_number":169,"context_line":"    _description \u003d _(\"Create a Network QoS rule\")"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def get_parser(self, prog_name):"},{"line_number":172,"context_line":"        parser \u003d super(CreateNetworkQosRule, self).get_parser("}],"source_content_type":"text/x-python","patch_set":31,"id":"ba5201f7_c9bd2404","line":169,"range":{"start_line":169,"start_character":22,"end_line":169,"end_character":47},"in_reply_to":"ba5201f7_a4e1a59c","updated":"2017-01-09 18:01:23.000000000","message":"Done","commit_id":"2cc845e406cfc2c6c784a33171760c86b7dce945"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e14f1eb56e0633a3b8155d00abbe88b94c19ba1d","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"class DeleteNetworkQosRule(command.Command):"},{"line_number":207,"context_line":"    _description \u003d _(\"Delete Network Qos rule\")"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def get_parser(self, prog_name):"},{"line_number":210,"context_line":"        parser \u003d super(DeleteNetworkQosRule, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":31,"id":"ba5201f7_a4736514","line":207,"range":{"start_line":207,"start_character":37,"end_line":207,"end_character":40},"updated":"2017-01-03 22:51:10.000000000","message":"QoS*","commit_id":"2cc845e406cfc2c6c784a33171760c86b7dce945"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a8cad9c9eeec9b161dc90f63f1e26094ecc59926","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"class DeleteNetworkQosRule(command.Command):"},{"line_number":207,"context_line":"    _description \u003d _(\"Delete Network Qos rule\")"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def get_parser(self, prog_name):"},{"line_number":210,"context_line":"        parser \u003d super(DeleteNetworkQosRule, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":31,"id":"ba5201f7_e9bae809","line":207,"range":{"start_line":207,"start_character":37,"end_line":207,"end_character":40},"in_reply_to":"ba5201f7_a4736514","updated":"2017-01-09 18:01:23.000000000","message":"Done","commit_id":"2cc845e406cfc2c6c784a33171760c86b7dce945"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e14f1eb56e0633a3b8155d00abbe88b94c19ba1d","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"class ListNetworkQosRule(command.Lister):"},{"line_number":241,"context_line":"    _description \u003d _(\"List Network Qos rules\")"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def get_parser(self, prog_name):"},{"line_number":244,"context_line":"        parser \u003d super(ListNetworkQosRule, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":31,"id":"ba5201f7_c4606938","line":241,"range":{"start_line":241,"start_character":35,"end_line":241,"end_character":38},"updated":"2017-01-03 22:51:10.000000000","message":"QoS*","commit_id":"2cc845e406cfc2c6c784a33171760c86b7dce945"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a8cad9c9eeec9b161dc90f63f1e26094ecc59926","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"class ListNetworkQosRule(command.Lister):"},{"line_number":241,"context_line":"    _description \u003d _(\"List Network Qos rules\")"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def get_parser(self, prog_name):"},{"line_number":244,"context_line":"        parser \u003d super(ListNetworkQosRule, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":31,"id":"ba5201f7_09364cb4","line":241,"range":{"start_line":241,"start_character":35,"end_line":241,"end_character":38},"in_reply_to":"ba5201f7_c4606938","updated":"2017-01-09 18:01:23.000000000","message":"Done","commit_id":"2cc845e406cfc2c6c784a33171760c86b7dce945"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e14f1eb56e0633a3b8155d00abbe88b94c19ba1d","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"class SetNetworkQosRule(command.Command):"},{"line_number":282,"context_line":"    _description \u003d _(\"Set Network Qos rule\")"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def get_parser(self, prog_name):"},{"line_number":285,"context_line":"        parser \u003d super(SetNetworkQosRule, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":31,"id":"ba5201f7_04d271d2","line":282,"range":{"start_line":282,"start_character":22,"end_line":282,"end_character":42},"updated":"2017-01-03 22:51:10.000000000","message":"Set Network QoS rule properties","commit_id":"2cc845e406cfc2c6c784a33171760c86b7dce945"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a8cad9c9eeec9b161dc90f63f1e26094ecc59926","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"class SetNetworkQosRule(command.Command):"},{"line_number":282,"context_line":"    _description \u003d _(\"Set Network Qos rule\")"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def get_parser(self, prog_name):"},{"line_number":285,"context_line":"        parser \u003d super(SetNetworkQosRule, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":31,"id":"ba5201f7_293b109e","line":282,"range":{"start_line":282,"start_character":22,"end_line":282,"end_character":42},"in_reply_to":"ba5201f7_04d271d2","updated":"2017-01-09 18:01:23.000000000","message":"Done","commit_id":"2cc845e406cfc2c6c784a33171760c86b7dce945"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e14f1eb56e0633a3b8155d00abbe88b94c19ba1d","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"class ShowNetworkQosRule(command.ShowOne):"},{"line_number":318,"context_line":"    _description \u003d _(\"Display Network Qos rule\")"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    def get_parser(self, prog_name):"},{"line_number":321,"context_line":"        parser \u003d super(ShowNetworkQosRule, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":31,"id":"ba5201f7_245e9576","line":318,"range":{"start_line":318,"start_character":38,"end_line":318,"end_character":41},"updated":"2017-01-03 22:51:10.000000000","message":"QoS*\n\nDisplay Network QoS rule details","commit_id":"2cc845e406cfc2c6c784a33171760c86b7dce945"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a8cad9c9eeec9b161dc90f63f1e26094ecc59926","unresolved":false,"context_lines":[{"line_number":315,"context_line":""},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"class ShowNetworkQosRule(command.ShowOne):"},{"line_number":318,"context_line":"    _description \u003d _(\"Display Network Qos rule\")"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    def get_parser(self, prog_name):"},{"line_number":321,"context_line":"        parser \u003d super(ShowNetworkQosRule, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":31,"id":"ba5201f7_49405408","line":318,"range":{"start_line":318,"start_character":38,"end_line":318,"end_character":41},"in_reply_to":"ba5201f7_245e9576","updated":"2017-01-09 18:01:23.000000000","message":"Done","commit_id":"2cc845e406cfc2c6c784a33171760c86b7dce945"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"4f2160df26bcb0a7a889747a7eab872e98f39bf2","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            metavar\u003d\u0027\u003cqos-policy\u003e\u0027,"},{"line_number":180,"context_line":"            help\u003d_(\u0027QoS policy that contains the rule (name or ID)\u0027)"},{"line_number":181,"context_line":"        )"},{"line_number":182,"context_line":"        parser.add_argument("},{"line_number":183,"context_line":"            \u0027--type\u0027,"},{"line_number":184,"context_line":"            metavar\u003d\u0027\u003ctype\u003e\u0027,"},{"line_number":185,"context_line":"            choices\u003d[RULE_TYPE_MINIMUM_BANDWIDTH,"}],"source_content_type":"text/x-python","patch_set":34,"id":"ba5201f7_ef2e61a4","line":182,"updated":"2017-01-09 21:59:54.000000000","message":"This needs to be required","commit_id":"6b114cd98f4a1bc95cb8702db02eeb625be6b3e7"}],"openstackclient/tests/functional/base.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14640ef43422a0e97b025254ed4c149ba0c05aad","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def assertsOutputNotNone(cls, observed):"},{"line_number":82,"context_line":"        if observed is None:"},{"line_number":83,"context_line":"            raise Exception(observed + \u0027 is None\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def assert_table_structure(self, items, field_names):"},{"line_number":86,"context_line":"        \"\"\"Verify that all items have keys listed in field_names.\"\"\""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_3f5204de","line":83,"range":{"start_line":83,"start_character":44,"end_line":83,"end_character":48},"updated":"2016-11-16 16:15:51.000000000","message":"From a user point of view, would \"None\" be of value ?\nCan we rewrite it ?","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a21527642abf98127d85606f9e44e2990275b22b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def assertsOutputNotNone(cls, observed):"},{"line_number":82,"context_line":"        if observed is None:"},{"line_number":83,"context_line":"            raise Exception(observed + \u0027 is None\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def assert_table_structure(self, items, field_names):"},{"line_number":86,"context_line":"        \"\"\"Verify that all items have keys listed in field_names.\"\"\""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_e84eb739","line":83,"range":{"start_line":83,"start_character":44,"end_line":83,"end_character":48},"in_reply_to":"7a77a97e_3f5204de","updated":"2016-11-18 09:15:51.000000000","message":"That\u0027s why I wrote None, instead of \"None\". If we are using Python, we understand (Python) None is like C++ null or Pascal nil.","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6c098dccb25ee0fc90d31f275cb10f7437120869","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def assertsOutputNotNone(cls, observed):"},{"line_number":82,"context_line":"        if observed is None:"},{"line_number":83,"context_line":"            raise Exception(observed + \u0027 is None\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def assert_table_structure(self, items, field_names):"},{"line_number":86,"context_line":"        \"\"\"Verify that all items have keys listed in field_names.\"\"\""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_f4ae667f","line":83,"range":{"start_line":83,"start_character":44,"end_line":83,"end_character":48},"in_reply_to":"7a77a97e_e84eb739","updated":"2016-11-20 07:51:46.000000000","message":"No, I understand that in Python None means null.\n\nI meant that instead of None, can we right \n\n  No output observed\n\ninstead of \n\n  None is None\n\nBecause if observed is None, then the exception raised would be \"None is None\"\n\n\nBesides I tried a small test\n\u003e\u003e\u003e p\u003dNone\n\u003e\u003e\u003e if p is None:\n...     raise Exception( p + \u0027is None\u0027)\n... \nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 2, in \u003cmodule\u003e\nTypeError: unsupported operand type(s) for +: \u0027NoneType\u0027 and \u0027str\u0027\n\nCan you confirm if the assert works?","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"73d4c787e9c82042287ccd4d3b7eb60f20925d8e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    @classmethod"},{"line_number":81,"context_line":"    def assertsOutputNotNone(cls, observed):"},{"line_number":82,"context_line":"        if observed is None:"},{"line_number":83,"context_line":"            raise Exception(observed + \u0027 is None\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def assert_table_structure(self, items, field_names):"},{"line_number":86,"context_line":"        \"\"\"Verify that all items have keys listed in field_names.\"\"\""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a77a97e_4ec922ac","line":83,"range":{"start_line":83,"start_character":44,"end_line":83,"end_character":48},"in_reply_to":"7a77a97e_f4ae667f","updated":"2016-11-21 16:06:51.000000000","message":"You are right. Something like \"None is None\" is not useful.","commit_id":"452876710e932c7e4527aa4fd36f0f0b7b54f6c9"}]}