)]}'
{"doc/source/command-objects/subnet.rst":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"29576ba209c243c1bcbdce07d6051b6a7662d828","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        [--long]"},{"line_number":154,"context_line":"        [--ip-version {4,6}]"},{"line_number":155,"context_line":"        [--dhcp | --no-dhcp]"},{"line_number":156,"context_line":"        [--project]"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":".. option:: --long"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_bc26e2cb","line":156,"range":{"start_line":156,"start_character":9,"end_line":156,"end_character":18},"updated":"2016-08-10 08:15:30.000000000","message":"--project \u003cproject\u003e","commit_id":"0fec6b33d72077404be24d7c83914d5fe2bf7377"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"697107d74ccb8d66f57e5032996c939a3610a7bf","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        [--long]"},{"line_number":154,"context_line":"        [--ip-version {4,6}]"},{"line_number":155,"context_line":"        [--dhcp | --no-dhcp]"},{"line_number":156,"context_line":"        [--project]"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":".. option:: --long"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_fff32c9c","line":156,"range":{"start_line":156,"start_character":9,"end_line":156,"end_character":18},"in_reply_to":"9ad45d7e_bc26e2cb","updated":"2016-08-10 08:32:01.000000000","message":"Good catch! Revision patch will be as your expected.","commit_id":"0fec6b33d72077404be24d7c83914d5fe2bf7377"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"29576ba209c243c1bcbdce07d6051b6a7662d828","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    List subnets which have DHCP disabled"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":".. option:: --project"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    List subnets according to their project (name or id)"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_fc305a03","line":175,"range":{"start_line":175,"start_character":12,"end_line":175,"end_character":21},"updated":"2016-08-10 08:15:30.000000000","message":"ditto","commit_id":"0fec6b33d72077404be24d7c83914d5fe2bf7377"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"697107d74ccb8d66f57e5032996c939a3610a7bf","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    List subnets which have DHCP disabled"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":".. option:: --project"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    List subnets according to their project (name or id)"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_1f2f20f7","line":175,"range":{"start_line":175,"start_character":12,"end_line":175,"end_character":21},"in_reply_to":"9ad45d7e_fc305a03","updated":"2016-08-10 08:32:01.000000000","message":"Done","commit_id":"0fec6b33d72077404be24d7c83914d5fe2bf7377"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"29576ba209c243c1bcbdce07d6051b6a7662d828","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":".. option:: --project"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    List subnets according to their project (name or id)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"subnet set"},{"line_number":180,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_7c13ca66","line":177,"range":{"start_line":177,"start_character":53,"end_line":177,"end_character":55},"updated":"2016-08-10 08:15:30.000000000","message":"ID","commit_id":"0fec6b33d72077404be24d7c83914d5fe2bf7377"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"697107d74ccb8d66f57e5032996c939a3610a7bf","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":".. option:: --project"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    List subnets according to their project (name or id)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"subnet set"},{"line_number":180,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9ad45d7e_9f3b1038","line":177,"range":{"start_line":177,"start_character":53,"end_line":177,"end_character":55},"in_reply_to":"9ad45d7e_7c13ca66","updated":"2016-08-10 08:32:01.000000000","message":"Got it.","commit_id":"0fec6b33d72077404be24d7c83914d5fe2bf7377"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"f0bb42472ad00a20908fff99589f7eef4e0e6358","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":".. option:: --project-domain \u003cproject-domain\u003e"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    List subnets according to their project domain (name or ID)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"subnet set"},{"line_number":184,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9ad45d7e_d4f09493","line":181,"updated":"2016-08-11 06:52:10.000000000","message":"Doc should match the help message. You can find the message from:\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/identity/common.py#L194","commit_id":"00b1ca826c8b5e51d51bca77cd64db6ac7eec32c"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"5589db5bca424fd9a0cf7c0a502d55c59c428b8f","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":".. option:: --project-domain \u003cproject-domain\u003e"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    List subnets according to their project domain (name or ID)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"subnet set"},{"line_number":184,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9ad45d7e_d4a89422","line":181,"in_reply_to":"9ad45d7e_d4f09493","updated":"2016-08-11 07:43:57.000000000","message":"Done","commit_id":"00b1ca826c8b5e51d51bca77cd64db6ac7eec32c"}],"openstackclient/network/v2/subnet.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"29576ba209c243c1bcbdce07d6051b6a7662d828","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        parser.add_argument("},{"line_number":356,"context_line":"            \u0027--project\u0027,"},{"line_number":357,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":358,"context_line":"            help\u003d_(\"List subnets according to their project (name or id)\")"},{"line_number":359,"context_line":"        )"},{"line_number":360,"context_line":"        return parser"},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_5c71a6df","line":358,"range":{"start_line":358,"start_character":69,"end_line":358,"end_character":71},"updated":"2016-08-10 08:15:30.000000000","message":"ID","commit_id":"0fec6b33d72077404be24d7c83914d5fe2bf7377"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"697107d74ccb8d66f57e5032996c939a3610a7bf","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        parser.add_argument("},{"line_number":356,"context_line":"            \u0027--project\u0027,"},{"line_number":357,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":358,"context_line":"            help\u003d_(\"List subnets according to their project (name or id)\")"},{"line_number":359,"context_line":"        )"},{"line_number":360,"context_line":"        return parser"},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_ff4a0cc4","line":358,"range":{"start_line":358,"start_character":69,"end_line":358,"end_character":71},"in_reply_to":"9ad45d7e_5c71a6df","updated":"2016-08-10 08:32:01.000000000","message":"Done","commit_id":"0fec6b33d72077404be24d7c83914d5fe2bf7377"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"29576ba209c243c1bcbdce07d6051b6a7662d828","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            \u0027--project\u0027,"},{"line_number":357,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":358,"context_line":"            help\u003d_(\"List subnets according to their project (name or id)\")"},{"line_number":359,"context_line":"        )"},{"line_number":360,"context_line":"        return parser"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_1c356ef6","line":359,"updated":"2016-08-10 08:15:30.000000000","message":"Should we also add \"--project-domain\" option here?","commit_id":"0fec6b33d72077404be24d7c83914d5fe2bf7377"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"697107d74ccb8d66f57e5032996c939a3610a7bf","unresolved":false,"context_lines":[{"line_number":356,"context_line":"            \u0027--project\u0027,"},{"line_number":357,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":358,"context_line":"            help\u003d_(\"List subnets according to their project (name or id)\")"},{"line_number":359,"context_line":"        )"},{"line_number":360,"context_line":"        return parser"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_ffe68cb2","line":359,"in_reply_to":"9ad45d7e_1c356ef6","updated":"2016-08-10 08:32:01.000000000","message":"Please check the bug report. It is OK to add \"--project-domain\" option to the command but I think it isn\u0027t on this patch.","commit_id":"0fec6b33d72077404be24d7c83914d5fe2bf7377"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"d8d94645b2960c08e2deae861296de3f1eb379a4","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            help\u003d_(\"List subnets which have DHCP disabled\")"},{"line_number":354,"context_line":"        )"},{"line_number":355,"context_line":"        parser.add_argument("},{"line_number":356,"context_line":"            \u0027--project\u0027,"},{"line_number":357,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":358,"context_line":"            help\u003d_(\"List subnets according to their project (name or ID)\")"},{"line_number":359,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_d55e0911","line":356,"updated":"2016-08-10 08:57:40.000000000","message":"\"--project-domain\" option is usually used with \"project\" option, please add it as well in this patch.","commit_id":"ebca18e760b4617f5641896abb9950c58c8b09da"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"71a312b10d7d565d36a76a8686bc9705da859996","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            help\u003d_(\"List subnets which have DHCP disabled\")"},{"line_number":354,"context_line":"        )"},{"line_number":355,"context_line":"        parser.add_argument("},{"line_number":356,"context_line":"            \u0027--project\u0027,"},{"line_number":357,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":358,"context_line":"            help\u003d_(\"List subnets according to their project (name or ID)\")"},{"line_number":359,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_f0fd1b3b","line":356,"in_reply_to":"9ad45d7e_d55e0911","updated":"2016-08-10 09:49:18.000000000","message":"OK!","commit_id":"ebca18e760b4617f5641896abb9950c58c8b09da"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"9eba7ab107dca9010a4b9c65ef92537f4141264c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":126,"context_line":"                identity_client,"},{"line_number":127,"context_line":"                parsed_args.project,"},{"line_number":128,"context_line":"                parsed_args.project_domain,"},{"line_number":129,"context_line":"            ).id"},{"line_number":130,"context_line":"            attrs[\u0027tenant_id\u0027] \u003d project_id"},{"line_number":131,"context_line":"        client \u003d client_manager.network"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_dd53cb37","line":128,"updated":"2016-08-10 10:34:54.000000000","message":"This is a example for using \"project_domain\".","commit_id":"c6acf764092ba9c296d095ef2fd381b1a6fbfa3f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"e8fd4a81f7b16e9d1754807dfc7b98c221608f0f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":126,"context_line":"                identity_client,"},{"line_number":127,"context_line":"                parsed_args.project,"},{"line_number":128,"context_line":"                parsed_args.project_domain,"},{"line_number":129,"context_line":"            ).id"},{"line_number":130,"context_line":"            attrs[\u0027tenant_id\u0027] \u003d project_id"},{"line_number":131,"context_line":"        client \u003d client_manager.network"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_8ba27f97","line":128,"in_reply_to":"9ad45d7e_dd53cb37","updated":"2016-08-11 04:17:37.000000000","message":"Thanks :-)","commit_id":"c6acf764092ba9c296d095ef2fd381b1a6fbfa3f"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"9eba7ab107dca9010a4b9c65ef92537f4141264c","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":195,"context_line":"            help\u003d_(\"Owner\u0027s project (name or ID)\")"},{"line_number":196,"context_line":"        )"},{"line_number":197,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":198,"context_line":"        subnet_pool_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":199,"context_line":"        subnet_pool_group.add_argument("},{"line_number":200,"context_line":"            \u0027--subnet-pool\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_9d7673d5","line":197,"updated":"2016-08-10 10:34:54.000000000","message":"This is a example for adding \"--project-domain\" option","commit_id":"c6acf764092ba9c296d095ef2fd381b1a6fbfa3f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"e8fd4a81f7b16e9d1754807dfc7b98c221608f0f","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            metavar\u003d\u0027\u003cproject\u003e\u0027,"},{"line_number":195,"context_line":"            help\u003d_(\"Owner\u0027s project (name or ID)\")"},{"line_number":196,"context_line":"        )"},{"line_number":197,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":198,"context_line":"        subnet_pool_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":199,"context_line":"        subnet_pool_group.add_argument("},{"line_number":200,"context_line":"            \u0027--subnet-pool\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_ebab3b73","line":197,"in_reply_to":"9ad45d7e_9d7673d5","updated":"2016-08-11 04:17:37.000000000","message":"Done","commit_id":"c6acf764092ba9c296d095ef2fd381b1a6fbfa3f"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"33a5a648017d7685be5651ed217014803c77b44c","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            filters[\u0027enable_dhcp\u0027] \u003d True"},{"line_number":370,"context_line":"        elif parsed_args.no_dhcp:"},{"line_number":371,"context_line":"            filters[\u0027enable_dhcp\u0027] \u003d False"},{"line_number":372,"context_line":"        if \u0027project\u0027 in parsed_args and parsed_args.project is not None:"},{"line_number":373,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":374,"context_line":"                identity_client,"},{"line_number":375,"context_line":"                parsed_args.project,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_aeb4ac34","line":372,"range":{"start_line":372,"start_character":8,"end_line":372,"end_character":72},"updated":"2016-08-11 07:59:58.000000000","message":"\u0027project\u0027 will always in parsed_args, so I think here can just like this:\nif parsed_args.project:","commit_id":"b1378baca351f627f2674c0fa53f5094069b1a8f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"43b2adac86ffe905ed32439267bae246427de3de","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            filters[\u0027enable_dhcp\u0027] \u003d True"},{"line_number":370,"context_line":"        elif parsed_args.no_dhcp:"},{"line_number":371,"context_line":"            filters[\u0027enable_dhcp\u0027] \u003d False"},{"line_number":372,"context_line":"        if \u0027project\u0027 in parsed_args and parsed_args.project is not None:"},{"line_number":373,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":374,"context_line":"                identity_client,"},{"line_number":375,"context_line":"                parsed_args.project,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_eec224e8","line":372,"range":{"start_line":372,"start_character":8,"end_line":372,"end_character":72},"in_reply_to":"9ad45d7e_aeb4ac34","updated":"2016-08-11 08:06:36.000000000","message":"Sure","commit_id":"b1378baca351f627f2674c0fa53f5094069b1a8f"}],"openstackclient/tests/network/v2/test_subnet.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"29576ba209c243c1bcbdce07d6051b6a7662d828","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def test_subnet_list_project(self):"},{"line_number":620,"context_line":"        test_project \u003d \"fakeproject\""},{"line_number":621,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":622,"context_line":"        arglist \u003d ["},{"line_number":623,"context_line":"            \u0027--project\u0027, test_project,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_5f24f8ad","line":620,"range":{"start_line":620,"start_character":8,"end_line":620,"end_character":36},"updated":"2016-08-10 08:15:30.000000000","message":"We can use FakeProject class to create a fake project here for the test.\nYou can see Line 41 for example","commit_id":"0fec6b33d72077404be24d7c83914d5fe2bf7377"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"697107d74ccb8d66f57e5032996c939a3610a7bf","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def test_subnet_list_project(self):"},{"line_number":620,"context_line":"        test_project \u003d \"fakeproject\""},{"line_number":621,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":622,"context_line":"        arglist \u003d ["},{"line_number":623,"context_line":"            \u0027--project\u0027, test_project,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_5f3fd8d5","line":620,"range":{"start_line":620,"start_character":8,"end_line":620,"end_character":36},"in_reply_to":"9ad45d7e_5f24f8ad","updated":"2016-08-10 08:32:01.000000000","message":"Hey, Do we really need to make it more complicate?\nIn command line, we are only able to pass the string to the argument. Using the string make us can test the command line as it works. L631-L634 supports to get project and then project_id.","commit_id":"0fec6b33d72077404be24d7c83914d5fe2bf7377"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"d8d94645b2960c08e2deae861296de3f1eb379a4","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def test_subnet_list_project(self):"},{"line_number":620,"context_line":"        test_project \u003d \"fakeproject\""},{"line_number":621,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":622,"context_line":"        arglist \u003d ["},{"line_number":623,"context_line":"            \u0027--project\u0027, test_project,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_351325ba","line":620,"updated":"2016-08-10 08:57:40.000000000","message":"We need not only a project name for checking the arguments. find_resource() in take_action() will return a project object, we need to create a fake project object to specify the return value of find_resource(). And L631-L634 is necessary after using a fake project.","commit_id":"ebca18e760b4617f5641896abb9950c58c8b09da"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"71a312b10d7d565d36a76a8686bc9705da859996","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def test_subnet_list_project(self):"},{"line_number":620,"context_line":"        test_project \u003d \"fakeproject\""},{"line_number":621,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":622,"context_line":"        arglist \u003d ["},{"line_number":623,"context_line":"            \u0027--project\u0027, test_project,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_f094fbe2","line":620,"in_reply_to":"9ad45d7e_351325ba","updated":"2016-08-10 09:49:18.000000000","message":"Understood. Revised patch accessed your comment.","commit_id":"ebca18e760b4617f5641896abb9950c58c8b09da"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"9eba7ab107dca9010a4b9c65ef92537f4141264c","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def test_subnet_list_project(self):"},{"line_number":620,"context_line":"        test_project \u003d identity_fakes_v3.FakeProject.create_one_project()"},{"line_number":621,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":622,"context_line":"        arglist \u003d ["},{"line_number":623,"context_line":"            \u0027--project\u0027, test_project.id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_607f9866","line":620,"updated":"2016-08-10 10:34:54.000000000","message":"Please specify the return value of find_resource() of project like L184. Then L621 and L631-L634 can be removed, you need not find a project in this test.","commit_id":"c6acf764092ba9c296d095ef2fd381b1a6fbfa3f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"e8fd4a81f7b16e9d1754807dfc7b98c221608f0f","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        self.assertEqual(self.data, list(data))"},{"line_number":618,"context_line":""},{"line_number":619,"context_line":"    def test_subnet_list_project(self):"},{"line_number":620,"context_line":"        test_project \u003d identity_fakes_v3.FakeProject.create_one_project()"},{"line_number":621,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":622,"context_line":"        arglist \u003d ["},{"line_number":623,"context_line":"            \u0027--project\u0027, test_project.id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_2bb8b3c7","line":620,"in_reply_to":"9ad45d7e_607f9866","updated":"2016-08-11 04:17:37.000000000","message":"Got it :-)","commit_id":"c6acf764092ba9c296d095ef2fd381b1a6fbfa3f"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"f0bb42472ad00a20908fff99589f7eef4e0e6358","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        project_domain \u003d identity_fakes_v3.FakeDomain.create_one_domain()"},{"line_number":639,"context_line":"        self.projects_mock.get.return_value \u003d project_domain"},{"line_number":640,"context_line":"        arglist \u003d ["},{"line_number":641,"context_line":"            \u0027--project\u0027, project_domain.id,"},{"line_number":642,"context_line":"        ]"},{"line_number":643,"context_line":"        verifylist \u003d ["},{"line_number":644,"context_line":"            (\u0027project\u0027, project_domain.id),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_54ae6481","line":641,"updated":"2016-08-11 06:52:10.000000000","message":"\"--project-domain\" option is used to domain the project belongs to, it is a assist for \"--project\" option and cannot used without \"--project\" option. If you want to test it, it should be like this:\n\u0027--project\u0027, project.id,\n\u0027--project_domain\u0027, project.domain_id,","commit_id":"00b1ca826c8b5e51d51bca77cd64db6ac7eec32c"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"5589db5bca424fd9a0cf7c0a502d55c59c428b8f","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        project_domain \u003d identity_fakes_v3.FakeDomain.create_one_domain()"},{"line_number":639,"context_line":"        self.projects_mock.get.return_value \u003d project_domain"},{"line_number":640,"context_line":"        arglist \u003d ["},{"line_number":641,"context_line":"            \u0027--project\u0027, project_domain.id,"},{"line_number":642,"context_line":"        ]"},{"line_number":643,"context_line":"        verifylist \u003d ["},{"line_number":644,"context_line":"            (\u0027project\u0027, project_domain.id),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_5aa32b00","line":641,"in_reply_to":"9ad45d7e_1497ccec","updated":"2016-08-11 07:43:57.000000000","message":"Understood. Thanks!","commit_id":"00b1ca826c8b5e51d51bca77cd64db6ac7eec32c"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"7ad8c3e379caebff744f4d4132cdff084e414ab2","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        project_domain \u003d identity_fakes_v3.FakeDomain.create_one_domain()"},{"line_number":639,"context_line":"        self.projects_mock.get.return_value \u003d project_domain"},{"line_number":640,"context_line":"        arglist \u003d ["},{"line_number":641,"context_line":"            \u0027--project\u0027, project_domain.id,"},{"line_number":642,"context_line":"        ]"},{"line_number":643,"context_line":"        verifylist \u003d ["},{"line_number":644,"context_line":"            (\u0027project\u0027, project_domain.id),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_1497ccec","line":641,"in_reply_to":"9ad45d7e_54ae6481","updated":"2016-08-11 06:57:05.000000000","message":"Sorry, should be\n\u0027--project\u0027, project.id,\n\u0027--project-domain\u0027, project.domain_id,","commit_id":"00b1ca826c8b5e51d51bca77cd64db6ac7eec32c"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"33a5a648017d7685be5651ed217014803c77b44c","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            \u0027--project-domain\u0027, project.domain_id,"},{"line_number":643,"context_line":"        ]"},{"line_number":644,"context_line":"        verifylist \u003d ["},{"line_number":645,"context_line":"            (\u0027project\u0027, project.id),"},{"line_number":646,"context_line":"        ]"},{"line_number":647,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":648,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_ee64e4b9","line":645,"updated":"2016-08-11 07:59:58.000000000","message":"It would be nice if also add a verify:\n(\u0027project_domain\u0027, project.domain_id),","commit_id":"b1378baca351f627f2674c0fa53f5094069b1a8f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"43b2adac86ffe905ed32439267bae246427de3de","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            \u0027--project-domain\u0027, project.domain_id,"},{"line_number":643,"context_line":"        ]"},{"line_number":644,"context_line":"        verifylist \u003d ["},{"line_number":645,"context_line":"            (\u0027project\u0027, project.id),"},{"line_number":646,"context_line":"        ]"},{"line_number":647,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":648,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_4eb41081","line":645,"in_reply_to":"9ad45d7e_ee64e4b9","updated":"2016-08-11 08:06:36.000000000","message":"Done","commit_id":"b1378baca351f627f2674c0fa53f5094069b1a8f"}],"releasenotes/notes/bug-1610883-b2099ee794bae095.yaml":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"d8d94645b2960c08e2deae861296de3f1eb379a4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Make ``subnet list`` command supports listing up subnets"},{"line_number":5,"context_line":"    according to their project (name or id) by adding ``--project``"},{"line_number":6,"context_line":"    option to the command."},{"line_number":7,"context_line":"    [Bug `1610883 \u003chttps://bugs.launchpad.net/bugs/1610883\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_550df935","line":5,"range":{"start_line":5,"start_character":40,"end_line":5,"end_character":42},"updated":"2016-08-10 08:57:40.000000000","message":"ID","commit_id":"ebca18e760b4617f5641896abb9950c58c8b09da"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"71a312b10d7d565d36a76a8686bc9705da859996","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Make ``subnet list`` command supports listing up subnets"},{"line_number":5,"context_line":"    according to their project (name or id) by adding ``--project``"},{"line_number":6,"context_line":"    option to the command."},{"line_number":7,"context_line":"    [Bug `1610883 \u003chttps://bugs.launchpad.net/bugs/1610883\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9ad45d7e_d5a60952","line":5,"range":{"start_line":5,"start_character":40,"end_line":5,"end_character":42},"in_reply_to":"9ad45d7e_550df935","updated":"2016-08-10 09:49:18.000000000","message":"Done","commit_id":"ebca18e760b4617f5641896abb9950c58c8b09da"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"f0bb42472ad00a20908fff99589f7eef4e0e6358","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Make ``subnet list`` command supports listing up subnets"},{"line_number":5,"context_line":"    according to their project (name or ID) or project domain"},{"line_number":6,"context_line":"    (name or ID) by adding ``--project`` and ``--project-domain``"},{"line_number":7,"context_line":"    options to the command."},{"line_number":8,"context_line":"    [Bug `1610883 \u003chttps://bugs.launchpad.net/bugs/1610883\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ad45d7e_142eac42","line":6,"range":{"start_line":5,"start_character":44,"end_line":6,"end_character":16},"updated":"2016-08-11 06:52:10.000000000","message":"\"--project-domain\" option is used to domain the project belongs to, it is a assist for \"--project\" option and cannot used without \"--project\" option, so I think you need not refer \"--project-domain\" option in release note.","commit_id":"00b1ca826c8b5e51d51bca77cd64db6ac7eec32c"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"5589db5bca424fd9a0cf7c0a502d55c59c428b8f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Make ``subnet list`` command supports listing up subnets"},{"line_number":5,"context_line":"    according to their project (name or ID) or project domain"},{"line_number":6,"context_line":"    (name or ID) by adding ``--project`` and ``--project-domain``"},{"line_number":7,"context_line":"    options to the command."},{"line_number":8,"context_line":"    [Bug `1610883 \u003chttps://bugs.launchpad.net/bugs/1610883\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ad45d7e_ffef711b","line":6,"in_reply_to":"9ad45d7e_142eac42","updated":"2016-08-11 07:43:57.000000000","message":"Will update as it.","commit_id":"00b1ca826c8b5e51d51bca77cd64db6ac7eec32c"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"af4e8aa6fb3ca742c6ff8e671c49f4488543cf75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Make ``subnet list`` command supports listing up subnets"},{"line_number":5,"context_line":"    according to their project (name or ID) by adding ``--project``"},{"line_number":6,"context_line":"    and ``--project-domain`` options to the command."},{"line_number":7,"context_line":"    [Bug `1610883 \u003chttps://bugs.launchpad.net/bugs/1610883\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3ac371cc_62bc7abb","line":4,"updated":"2016-08-17 22:11:32.000000000","message":"It is preferred to use a single release note for these filtering options.  That is provided that they make the same release.","commit_id":"fcd1f3246d4ea307edbc1159a7fe7e21cb83d7d3"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"54b646c0ec154a212c4874337d92f5736bf841d5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Make ``subnet list`` command supports listing up subnets"},{"line_number":5,"context_line":"    according to their project (name or ID) by adding ``--project``"},{"line_number":6,"context_line":"    and ``--project-domain`` options to the command."},{"line_number":7,"context_line":"    [Bug `1610883 \u003chttps://bugs.launchpad.net/bugs/1610883\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3ac371cc_860a6388","line":4,"in_reply_to":"3ac371cc_62bc7abb","updated":"2016-08-18 01:54:51.000000000","message":"I see. So I will update patches related to this command into merged file [1].\n\n[1] https://review.openstack.org/#/c/352698/4/releasenotes/notes/bug-1610883-e6345c32a35cc290.yaml","commit_id":"fcd1f3246d4ea307edbc1159a7fe7e21cb83d7d3"}]}