)]}'
{"doc/source/command-objects/backup.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"520b6d9f8d060f2a865efaa2ad3385f52824a88e","unresolved":false,"context_lines":[{"line_number":107,"context_line":".. code:: bash"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    os backup restore"},{"line_number":110,"context_line":"        [--volume \u003cvolume\u003e | --name \u003cname\u003e]"},{"line_number":111,"context_line":"        \u003cbackup\u003e"},{"line_number":112,"context_line":"        \u003cvolume\u003e"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ad45d7e_6929ea89","line":110,"range":{"start_line":110,"start_character":11,"end_line":110,"end_character":17},"updated":"2016-08-11 17:39:06.000000000","message":"I dont like that we have just made a positional argument an optional one. what do you think about this instead, i have 2 suggestions.\n\n1) we keep volume as positional\n\nwe try to find \u003cvolume\u003e, if we have a match then restore to that volume, this keeps the same behaviour.\nIf no match is found, then we create a new one with name\u003dparsed_args.volume\nWe can debug or info messages saying that no match was found so the user knows something unusual happened\n\n2) we add a --new-volume flag\n\nThe flow would be `os backup restore \u003cbackup\u003e \u003cvolume\u003e --new-volume`\n\nIf the flag is used, we create a new volume with name \u003cvolume\u003e.\nIf no flag is used then we restore to \u003cvolume\u003e. If \u003cvolume\u003e doesn\u0027t exist then we error out.","commit_id":"dca59570a6dd00d8a16a0fb7f5c2111fd9664e2c"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"90032b87ee0ea0c9bbe87ebb270e1694242718bc","unresolved":false,"context_lines":[{"line_number":107,"context_line":".. code:: bash"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    os backup restore"},{"line_number":110,"context_line":"        [--volume \u003cvolume\u003e | --name \u003cname\u003e]"},{"line_number":111,"context_line":"        \u003cbackup\u003e"},{"line_number":112,"context_line":"        \u003cvolume\u003e"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ad45d7e_e7284c88","line":110,"range":{"start_line":110,"start_character":11,"end_line":110,"end_character":17},"in_reply_to":"9ad45d7e_6929ea89","updated":"2016-08-12 03:09:12.000000000","message":"Also, volume is allow to be created with the same name. In the case of suggestion 1, we cannot create a new volume whose name is the same as a existing volume name, because finding is before creating.","commit_id":"dca59570a6dd00d8a16a0fb7f5c2111fd9664e2c"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"becf22053167d2bf496687420474ccec75cafec1","unresolved":false,"context_lines":[{"line_number":107,"context_line":".. code:: bash"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    os backup restore"},{"line_number":110,"context_line":"        [--volume \u003cvolume\u003e | --name \u003cname\u003e]"},{"line_number":111,"context_line":"        \u003cbackup\u003e"},{"line_number":112,"context_line":"        \u003cvolume\u003e"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ad45d7e_4194a889","line":110,"range":{"start_line":110,"start_character":11,"end_line":110,"end_character":17},"in_reply_to":"9ad45d7e_6929ea89","updated":"2016-08-12 02:07:07.000000000","message":"Hi, Steve. I thought for a while， I agree with keeping \u003cvolume\u003e as positional， without \u003cvolume\u003e, a new volume named \"None\" will be create to restore to, this maybe an unusual behave for users.\nBut I have some questions about your first suggestion. In the case of suggestion 1, new volume will be created if no volume match the input, but in one case, if users want to restore to a existing volume but input a wrong name, a new volume with the wrong name will be also created and the restoring will be also implemented, this is not what the users want.\nComparing with suggestion 1, I think suggestion 2 can avoid the problem I mentioned above, Personally， I think your second suggestion is better, what do you think?","commit_id":"dca59570a6dd00d8a16a0fb7f5c2111fd9664e2c"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"6321a77f12597f712514c55c72aba1a16d1c7d64","unresolved":false,"context_lines":[{"line_number":107,"context_line":".. code:: bash"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    os backup restore"},{"line_number":110,"context_line":"        [--volume \u003cvolume\u003e | --name \u003cname\u003e]"},{"line_number":111,"context_line":"        \u003cbackup\u003e"},{"line_number":112,"context_line":"        \u003cvolume\u003e"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3ac371cc_353eefb8","line":110,"range":{"start_line":110,"start_character":11,"end_line":110,"end_character":17},"in_reply_to":"9ad45d7e_96f87bc6","updated":"2016-08-15 01:41:02.000000000","message":"Yes, I will do it following your second suggestion, Thanks!","commit_id":"dca59570a6dd00d8a16a0fb7f5c2111fd9664e2c"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b59e3f28aeb6bbed16a17bb0e430acd65fb1d368","unresolved":false,"context_lines":[{"line_number":107,"context_line":".. code:: bash"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    os backup restore"},{"line_number":110,"context_line":"        [--volume \u003cvolume\u003e | --name \u003cname\u003e]"},{"line_number":111,"context_line":"        \u003cbackup\u003e"},{"line_number":112,"context_line":"        \u003cvolume\u003e"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ad45d7e_96f87bc6","line":110,"range":{"start_line":110,"start_character":11,"end_line":110,"end_character":17},"in_reply_to":"9ad45d7e_e7284c88","updated":"2016-08-12 16:01:12.000000000","message":"ohhh great points about name being non-unique! \n\n\nOK - option #2 it is -- if you like the suggestion, of course","commit_id":"dca59570a6dd00d8a16a0fb7f5c2111fd9664e2c"}],"doc/source/command-objects/volume-backup.rst":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"11cc04e886e56ad96fa71c8fd4e6879e15d73248","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":".. option:: --name \u003cname\u003e"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    Name of a new volume to restore to (default to None, if \u0027--volume\u0027 and \u0027--name\u0027"},{"line_number":119,"context_line":"    options are not specified, a volume named \u0027None\u0027 will be created to restore to)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    *Volume version 2 only*"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ad45d7e_7c81b88e","line":119,"range":{"start_line":118,"start_character":57,"end_line":119,"end_character":83},"updated":"2016-08-11 13:34:02.000000000","message":"Can we have this in the new line?","commit_id":"dca59570a6dd00d8a16a0fb7f5c2111fd9664e2c"}]}