)]}'
{"openstackclient/identity/v2_0/service.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b76782608e45db0ae2f1a7b0d8142185bcd93749","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                endpoints \u003d identity_client.service_catalog.get_endpoints("},{"line_number":142,"context_line":"                    service_type\u003dparsed_args.service)"},{"line_number":143,"context_line":"                for (service, service_endpoints) in endpoints.iteritems():"},{"line_number":144,"context_line":"                    if len(service_endpoints) \u003e 0:"},{"line_number":145,"context_line":"                        info \u003d {\"type\": parsed_args.service}"},{"line_number":146,"context_line":"                        for ep in service_endpoints:"},{"line_number":147,"context_line":"                            info.update(ep)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fnag%3D","line":144,"updated":"2013-07-15 20:05:45.000000000","message":"if service_endpoints:","commit_id":"b0c5a430ecbf8ed0c5710963ac9256c4546fbe8a"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"b76782608e45db0ae2f1a7b0d8142185bcd93749","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                        info \u003d {\"type\": parsed_args.service}"},{"line_number":146,"context_line":"                        for ep in service_endpoints:"},{"line_number":147,"context_line":"                            info.update(ep)"},{"line_number":148,"context_line":"                            return zip(*sorted(info.iteritems()))"},{"line_number":149,"context_line":"            except Exception as ex:"},{"line_number":150,"context_line":"                msg \u003d (\"No service catalog with a type, name or ID of \u0027%s\u0027 \""},{"line_number":151,"context_line":"                       \"exists. %s\" % (parsed_args.service, ex))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2Fna4%3D","line":148,"updated":"2013-07-15 20:05:45.000000000","message":"I\u0027m not clear on the data model, but do you mean to only be returning one endpoint, or should the return be outside of the for loop here? This is a show command, so I would only expect one object, but there\u0027s a for loop, so...","commit_id":"b0c5a430ecbf8ed0c5710963ac9256c4546fbe8a"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"27db055dd80257554b77c69d0eeb254eced902aa","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                        info \u003d {\"type\": parsed_args.service}"},{"line_number":146,"context_line":"                        for ep in service_endpoints:"},{"line_number":147,"context_line":"                            info.update(ep)"},{"line_number":148,"context_line":"                            return zip(*sorted(info.iteritems()))"},{"line_number":149,"context_line":"            except Exception as ex:"},{"line_number":150,"context_line":"                msg \u003d (\"No service catalog with a type, name or ID of \u0027%s\u0027 \""},{"line_number":151,"context_line":"                       \"exists. %s\" % (parsed_args.service, ex))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FjjM%3D","line":148,"in_reply_to":"AAAAP3%2F%2Fna4%3D","updated":"2013-07-16 16:32:01.000000000","message":"I think I forgot to optimize out that for loop...we only want the first endpoint in the list.","commit_id":"b0c5a430ecbf8ed0c5710963ac9256c4546fbe8a"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8f983ad958e3ef893e0a32ebf5a5e9b0effc45a1","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        info \u003d {}"},{"line_number":173,"context_line":"        info.update(service._info)"},{"line_number":174,"context_line":"        return zip(*sorted(info.iteritems()))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FvdQ%3D","line":173,"updated":"2013-07-12 04:00:17.000000000","message":"I tested this out in my devstack env, for whatever reason, the endpoint set returned (for keystone service) in line 141 was empty {}, so it skipped down to here, but then blew up, since service was never defined. \n\nSuggest an early return in the if case if endpoints is empty?","commit_id":"b0c5a430ecbf8ed0c5710963ac9256c4546fbe8a"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"27db055dd80257554b77c69d0eeb254eced902aa","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                    raise exceptions.CommandError(msg)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        info \u003d {}"},{"line_number":173,"context_line":"        info.update(service._info)"},{"line_number":174,"context_line":"        return zip(*sorted(info.iteritems()))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FjhA%3D","line":173,"in_reply_to":"AAAAP3%2F%2FvdQ%3D","updated":"2013-07-16 16:32:01.000000000","message":"Yeah, execution should never have left that if parsed_args.catalog block.  No exception was being thrown when I expected one...","commit_id":"b0c5a430ecbf8ed0c5710963ac9256c4546fbe8a"}]}