)]}'
{"id":"openstack%2Fpython-openstackclient~358154","triplet_id":"openstack%2Fpython-openstackclient~master~I2729ef0e80166f4d49ccd9a48b653e2f215e3bfe","project":"openstack/python-openstackclient","branch":"master","topic":"volume-fake","hashtags":[],"change_id":"I2729ef0e80166f4d49ccd9a48b653e2f215e3bfe","subject":"Clean up FakeClient classes in volume fakes","status":"MERGED","created":"2016-08-20 02:01:10.000000000","updated":"2016-09-06 14:03:38.000000000","submitted":"2016-09-06 14:03:38.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"64e5b23f60966ae39fde7a023a044971f090b29c","_number":358154,"virtual_id_number":358154,"owner":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-09-06 14:03:38.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"value":0,"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-08-24 07:45:53.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":2,"date":"2016-09-06 13:01:31.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"value":1,"date":"2016-08-23 12:24:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"value":1,"date":"2016-09-06 13:01:31.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},{"value":0,"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-23 12:24:30.000000000","updated_by":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"reviewer":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"state":"REVIEWER"},{"updated":"2016-08-24 07:45:53.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2016-09-06 13:01:31.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-09-06 14:03:38.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"094c1edddb37704b81747a476bbda950c8cf65f3","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-08-20 02:01:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8f13b2a89db96ed849e44c8d9edb2e29590aeebd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-20 03:57:16.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/54/358154/1/check/gate-python-openstackclient-docs-ubuntu-xenial/d8e8c48//doc/build/html/ : SUCCESS in 4m 04s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/54/358154/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/0d1895e/ : SUCCESS in 4m 07s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/54/358154/1/check/gate-python-openstackclient-python27-ubuntu-xenial/9d2a1b5/ : SUCCESS in 2m 36s\n- gate-python-openstackclient-python34 http://logs.openstack.org/54/358154/1/check/gate-python-openstackclient-python34/896fa5d/ : SUCCESS in 2m 25s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/54/358154/1/check/gate-python-openstackclient-python35-nv/352a6c8/ : SUCCESS in 4m 29s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/54/358154/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/8c9cfb2/ : SUCCESS in 1h 08m 56s\n- check-osc-plugins http://logs.openstack.org/54/358154/1/check/check-osc-plugins/c5ddf18/ : SUCCESS in 5m 23s\n- gate-osc-dsvm-functional http://logs.openstack.org/54/358154/1/check/gate-osc-dsvm-functional/81ea624/ : FAILURE in 46m 12s","accounts_in_message":[],"_revision_number":1},{"id":"53d77d8e731d98f5ca140c432f4232aeacbc2f13","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-08-22 01:30:34.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"b4334edf617e17e2f5901f96878a53f3a6c31373","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-22 03:04:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/54/358154/1/check/gate-python-openstackclient-docs-ubuntu-xenial/14c763c//doc/build/html/ : SUCCESS in 4m 10s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/54/358154/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/9a29b5f/ : SUCCESS in 4m 37s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/54/358154/1/check/gate-python-openstackclient-python27-ubuntu-xenial/a26942f/ : SUCCESS in 4m 58s\n- gate-python-openstackclient-python34 http://logs.openstack.org/54/358154/1/check/gate-python-openstackclient-python34/7e7f365/ : SUCCESS in 4m 48s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/54/358154/1/check/gate-python-openstackclient-python35-nv/c781abf/ : SUCCESS in 4m 20s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/54/358154/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/ec0c586/ : SUCCESS in 1h 28m 11s\n- check-osc-plugins http://logs.openstack.org/54/358154/1/check/check-osc-plugins/7d80b76/ : SUCCESS in 6m 05s\n- gate-osc-dsvm-functional http://logs.openstack.org/54/358154/1/check/gate-osc-dsvm-functional/6d665b5/ : SUCCESS in 48m 12s","accounts_in_message":[],"_revision_number":1},{"id":"7360dfb697d722a71a3d3498b63900899409c6b1","author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"date":"2016-08-23 02:33:09.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5e3f46b609b41d92bf7591dc8617c04d5bdfa49e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-23 03:51:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/54/358154/2/check/gate-python-openstackclient-docs-ubuntu-xenial/76506e9//doc/build/html/ : SUCCESS in 4m 27s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/54/358154/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/026b37d/ : SUCCESS in 4m 13s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/54/358154/2/check/gate-python-openstackclient-python27-ubuntu-xenial/367168e/ : SUCCESS in 4m 11s\n- gate-python-openstackclient-python34 http://logs.openstack.org/54/358154/2/check/gate-python-openstackclient-python34/e032a3c/ : SUCCESS in 4m 01s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/54/358154/2/check/gate-python-openstackclient-python35-nv/a467b54/ : SUCCESS in 3m 19s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/54/358154/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/d088d5c/ : SUCCESS in 1h 11m 09s\n- check-osc-plugins http://logs.openstack.org/54/358154/2/check/check-osc-plugins/df9e5e2/ : SUCCESS in 4m 58s\n- gate-osc-dsvm-functional http://logs.openstack.org/54/358154/2/check/gate-osc-dsvm-functional/2455633/ : SUCCESS in 58m 12s","accounts_in_message":[],"_revision_number":2},{"id":"435b3d683a12e2b4d2a1cdab1a7dcceb5c704571","author":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"date":"2016-08-23 12:24:30.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"7149e28c6c5b7290b56e14a72bf883f8f1c58ea2","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-08-24 07:45:53.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"934ed658f236e3547b9111f9d1016ab658b41d81","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-09-06 13:01:31.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"be3b75273d392559c122aa6b1c3ea734e18bbf86","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-06 13:01:41.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"7c6a08707098de079561abcbab5c7329cc647ac1","date":"2016-09-06 14:03:38.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"c764348c4ef6dbdd60f2af73f91edfd547b8edc6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-06 14:03:38.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/54/358154/2/gate/gate-python-openstackclient-docs-ubuntu-xenial/0d900dd//doc/build/html/ : SUCCESS in 5m 07s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/54/358154/2/gate/gate-python-openstackclient-pep8-ubuntu-xenial/f19621b/ : SUCCESS in 4m 01s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/54/358154/2/gate/gate-python-openstackclient-python27-ubuntu-xenial/a4c0235/ : SUCCESS in 5m 18s\n- gate-python-openstackclient-python34 http://logs.openstack.org/54/358154/2/gate/gate-python-openstackclient-python34/adc73ab/ : SUCCESS in 2m 56s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/54/358154/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/47f9ac6/ : SUCCESS in 1h 01m 53s\n- gate-osc-dsvm-functional http://logs.openstack.org/54/358154/2/gate/gate-osc-dsvm-functional/63c3513/ : SUCCESS in 35m 19s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8f07fec3f2ccf510255f1ff2e4dab233be60d0f9","revisions":{"9f9cf0f5a3d194c279d55ac99e41a97ce7398815":{"kind":"REWORK","_number":1,"created":"2016-08-20 02:01:10.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/54/358154/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/54/358154/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/54/358154/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/54/358154/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/54/358154/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/54/358154/1"}}},"commit":{"parents":[{"commit":"8f63da46216053ef218a11e5809325b09462db6f","subject":"Merge \"Fix errors in volume set/unset image properties unit tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8f63da46216053ef218a11e5809325b09462db6f"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-08-19 13:56:24.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-08-20 01:39:38.000000000","tz":480},"subject":"Clean up FakeClient classes in volume v2 fake","message":"Clean up FakeClient classes in volume v2 fake\n\nPut FakeTransferClient and FakeServiceClient classes\ninto FakeVolumeClient class, I think we need not to\ncreate FakeClient classes for every objects, we can use\nonly FakeVolumeClient for all volume objects. This can\nreduce repetition, unified codes and make codes look\ncleaner and easier.\n\nChange-Id: I2729ef0e80166f4d49ccd9a48b653e2f215e3bfe\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9f9cf0f5a3d194c279d55ac99e41a97ce7398815"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/9f9cf0f5a3d194c279d55ac99e41a97ce7398815"}]},"branch":"refs/heads/master"},"8f07fec3f2ccf510255f1ff2e4dab233be60d0f9":{"kind":"REWORK","_number":2,"created":"2016-08-23 02:33:09.000000000","uploader":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"ref":"refs/changes/54/358154/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/54/358154/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/54/358154/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/54/358154/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/54/358154/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/54/358154/2"}}},"commit":{"parents":[{"commit":"684412ca4cc0abad2c2a800d8247d12992b994e5","subject":"Work around a version clash issue with os-client-config","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/684412ca4cc0abad2c2a800d8247d12992b994e5"}]}],"author":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-08-19 13:56:24.000000000","tz":480},"committer":{"name":"Huanxuan Ao","email":"huanxuan.ao@easystack.cn","date":"2016-08-23 02:31:24.000000000","tz":480},"subject":"Clean up FakeClient classes in volume fakes","message":"Clean up FakeClient classes in volume fakes\n\nPut FakeTransferClient and FakeServiceClient classes\ninto FakeVolumeClient class, I think we need not to\ncreate FakeClient classes for every objects, we can use\nonly FakeVolumeClient for all volume objects. This can\nreduce repetition, unified codes and make codes look\ncleaner and easier.\n\nChange-Id: I2729ef0e80166f4d49ccd9a48b653e2f215e3bfe\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8f07fec3f2ccf510255f1ff2e4dab233be60d0f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/8f07fec3f2ccf510255f1ff2e4dab233be60d0f9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}