)]}'
{"doc/source/command-objects/volume.rst":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"1b8d2c61399c28da053a494e979141822303318d","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":".. option:: --bootable"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    Mark volume as bootable"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    *Volume version 2 only*"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ac06dbe_ee629715","line":205,"updated":"2016-08-25 12:42:19.000000000","message":"This should match the help message","commit_id":"f4293a21709dff1cd1068339e62525aa06946392"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"9e677e75e2bf9645abf18c86b324e0881297062c","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":".. option:: --bootable"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    Mark volume as bootable"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    *Volume version 2 only*"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1ac06dbe_49bf4efc","line":205,"in_reply_to":"1ac06dbe_ee629715","updated":"2016-08-25 13:33:19.000000000","message":"Will update the help part in next set.\nThanks.~","commit_id":"f4293a21709dff1cd1068339e62525aa06946392"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"cebb56c8a7216e47113f28c4971791559663265b","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":".. option:: --bootable"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    Mark volume as bootable"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    *Volume version 2 only*"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa7ab95a_79ac99a0","line":205,"updated":"2016-08-29 10:19:42.000000000","message":"doc should be match the help message","commit_id":"011172f00ce3ad22611651a28c5cf6ca0f9b7b4b"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"17d4bad8a9b1cc55e9c5d50c85e63127f51b4764","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":".. option:: --bootable"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    Mark volume as bootable"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    *Volume version 2 only*"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa7ab95a_b98edecd","line":205,"in_reply_to":"fa7ab95a_79ac99a0","updated":"2016-08-30 03:46:08.000000000","message":"Done","commit_id":"011172f00ce3ad22611651a28c5cf6ca0f9b7b4b"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"50d195182268736fe10ba637d098930ed0c85fb4","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    Mark volume as bootable"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    *Volume version 2 only*"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":".. option:: --non-bootable"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa7ab95a_387be18d","line":207,"updated":"2016-08-29 10:35:42.000000000","message":"I see cinderclient also has the set_bootable() API in v1:\nhttps://github.com/openstack/python-cinderclient/blob/master/cinderclient/v1/volumes.py#L439\ncan you also add these options for volume v1 command?","commit_id":"011172f00ce3ad22611651a28c5cf6ca0f9b7b4b"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"17d4bad8a9b1cc55e9c5d50c85e63127f51b4764","unresolved":false,"context_lines":[{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    Mark volume as bootable"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    *Volume version 2 only*"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":".. option:: --non-bootable"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa7ab95a_d9bd6269","line":207,"in_reply_to":"fa7ab95a_387be18d","updated":"2016-08-30 03:46:08.000000000","message":"Done","commit_id":"011172f00ce3ad22611651a28c5cf6ca0f9b7b4b"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"cebb56c8a7216e47113f28c4971791559663265b","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":".. option:: --non-bootable"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    Mark volume as non-bootable"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    *Volume version 2 only*"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa7ab95a_f9a0a9a1","line":211,"updated":"2016-08-29 10:19:42.000000000","message":"ditto","commit_id":"011172f00ce3ad22611651a28c5cf6ca0f9b7b4b"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"17d4bad8a9b1cc55e9c5d50c85e63127f51b4764","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":".. option:: --non-bootable"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    Mark volume as non-bootable"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    *Volume version 2 only*"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa7ab95a_f9c226e8","line":211,"in_reply_to":"fa7ab95a_f9a0a9a1","updated":"2016-08-30 03:46:08.000000000","message":"Done","commit_id":"011172f00ce3ad22611651a28c5cf6ca0f9b7b4b"}],"openstackclient/tests/volume/v2/test_volume.py":[{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"1b8d2c61399c28da053a494e979141822303318d","unresolved":false,"context_lines":[{"line_number":884,"context_line":"    def test_volume_set_bootable(self):"},{"line_number":885,"context_line":"        arglist \u003d ["},{"line_number":886,"context_line":"            self.new_volume.id,"},{"line_number":887,"context_line":"            \u0027--bootable\u0027"},{"line_number":888,"context_line":"        ]"},{"line_number":889,"context_line":"        verifylist \u003d ["},{"line_number":890,"context_line":"            (\u0027volume\u0027, self.new_volume.id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_f1d27833","line":887,"updated":"2016-08-25 12:42:19.000000000","message":"Positional parameter usually at the end of the list\n    \u0027--bootable\u0027,\n    self.new_volume.id,","commit_id":"f4293a21709dff1cd1068339e62525aa06946392"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"1e5d5c1ca833b93b61990fcc54847e7a59628cd8","unresolved":false,"context_lines":[{"line_number":884,"context_line":"    def test_volume_set_bootable(self):"},{"line_number":885,"context_line":"        arglist \u003d ["},{"line_number":886,"context_line":"            self.new_volume.id,"},{"line_number":887,"context_line":"            \u0027--bootable\u0027"},{"line_number":888,"context_line":"        ]"},{"line_number":889,"context_line":"        verifylist \u003d ["},{"line_number":890,"context_line":"            (\u0027volume\u0027, self.new_volume.id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_6995ea3e","line":887,"in_reply_to":"1ac06dbe_2941320c","updated":"2016-08-25 13:35:43.000000000","message":"Will exchange the order in next set.~","commit_id":"f4293a21709dff1cd1068339e62525aa06946392"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"9e677e75e2bf9645abf18c86b324e0881297062c","unresolved":false,"context_lines":[{"line_number":884,"context_line":"    def test_volume_set_bootable(self):"},{"line_number":885,"context_line":"        arglist \u003d ["},{"line_number":886,"context_line":"            self.new_volume.id,"},{"line_number":887,"context_line":"            \u0027--bootable\u0027"},{"line_number":888,"context_line":"        ]"},{"line_number":889,"context_line":"        verifylist \u003d ["},{"line_number":890,"context_line":"            (\u0027volume\u0027, self.new_volume.id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_2941320c","line":887,"in_reply_to":"1ac06dbe_f1d27833","updated":"2016-08-25 13:33:19.000000000","message":"Will update the help part in next set.\nThanks.~","commit_id":"f4293a21709dff1cd1068339e62525aa06946392"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"cebb56c8a7216e47113f28c4971791559663265b","unresolved":false,"context_lines":[{"line_number":881,"context_line":"        self.volumes_mock.reset_state.assert_called_with("},{"line_number":882,"context_line":"            self.new_volume.id, \u0027error\u0027)"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    def test_volume_set_bootable(self):"},{"line_number":885,"context_line":"        arglist \u003d ["},{"line_number":886,"context_line":"            [\u0027--bootable\u0027, self.new_volume.id],"},{"line_number":887,"context_line":"            [\u0027--non-bootable\u0027, self.new_volume.id]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_92604c03","line":884,"updated":"2016-08-29 10:19:42.000000000","message":"You\u0027d better check whether bootable is None or not when no options specified.\nYou can do it in an existent test which not specify \"--bootable\" and \"--non-bootable\" options.","commit_id":"011172f00ce3ad22611651a28c5cf6ca0f9b7b4b"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"17d4bad8a9b1cc55e9c5d50c85e63127f51b4764","unresolved":false,"context_lines":[{"line_number":881,"context_line":"        self.volumes_mock.reset_state.assert_called_with("},{"line_number":882,"context_line":"            self.new_volume.id, \u0027error\u0027)"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    def test_volume_set_bootable(self):"},{"line_number":885,"context_line":"        arglist \u003d ["},{"line_number":886,"context_line":"            [\u0027--bootable\u0027, self.new_volume.id],"},{"line_number":887,"context_line":"            [\u0027--non-bootable\u0027, self.new_volume.id]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_39b9ee79","line":884,"in_reply_to":"fa7ab95a_92604c03","updated":"2016-08-30 03:46:08.000000000","message":"Done","commit_id":"011172f00ce3ad22611651a28c5cf6ca0f9b7b4b"}],"openstackclient/volume/v1/volume.py":[{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"67183914615fbc508abb165bec84ae5e04fa5c88","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        bootable_group.add_argument("},{"line_number":374,"context_line":"            \"--non-bootable\","},{"line_number":375,"context_line":"            dest\u003d\"bootable\","},{"line_number":376,"context_line":"            action\u003d\"store_false\","},{"line_number":377,"context_line":"            help\u003d_(\"Mark volume as non-bootable\")"},{"line_number":378,"context_line":"        )"},{"line_number":379,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_a82696b7","line":376,"range":{"start_line":376,"start_character":20,"end_line":376,"end_character":31},"updated":"2016-09-13 09:06:31.000000000","message":"Sorry, please follow the rules here:\nhttp://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options","commit_id":"e6a28ba4649e222695a032a94028f27780fb1362"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"8e0a16cfcc23b3f5c7f1edacc77477935b5d0307","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        bootable_group.add_argument("},{"line_number":374,"context_line":"            \"--non-bootable\","},{"line_number":375,"context_line":"            dest\u003d\"bootable\","},{"line_number":376,"context_line":"            action\u003d\"store_false\","},{"line_number":377,"context_line":"            help\u003d_(\"Mark volume as non-bootable\")"},{"line_number":378,"context_line":"        )"},{"line_number":379,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_59b6ba3e","line":376,"range":{"start_line":376,"start_character":20,"end_line":376,"end_character":31},"in_reply_to":"9a89bdaa_a82696b7","updated":"2016-09-13 09:44:09.000000000","message":"Done","commit_id":"e6a28ba4649e222695a032a94028f27780fb1362"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"175e4ae1b1f765aaf58837d643369d251d525c0a","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        )"},{"line_number":379,"context_line":"        return parser"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def take_action(self, parsed_args):"},{"line_number":382,"context_line":"        volume_client \u003d self.app.client_manager.volume"},{"line_number":383,"context_line":"        volume \u003d utils.find_resource(volume_client.volumes, parsed_args.volume)"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_bbdfd538","line":381,"range":{"start_line":381,"start_character":8,"end_line":381,"end_character":19},"updated":"2016-09-12 21:23:12.000000000","message":"a note about a future (separate) patch, we should treat this one the same as we do for v2, where we add up the failures and emit a single message at the end","commit_id":"e6a28ba4649e222695a032a94028f27780fb1362"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"6a970cf5bc8b33b4383d1e1e83c7ae4b4415914f","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        )"},{"line_number":379,"context_line":"        return parser"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def take_action(self, parsed_args):"},{"line_number":382,"context_line":"        volume_client \u003d self.app.client_manager.volume"},{"line_number":383,"context_line":"        volume \u003d utils.find_resource(volume_client.volumes, parsed_args.volume)"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_ebac258a","line":381,"range":{"start_line":381,"start_character":8,"end_line":381,"end_character":19},"in_reply_to":"9a89bdaa_bbdfd538","updated":"2016-09-13 03:32:25.000000000","message":"Yes, maybe we need to enhance the v1 code to keep it the same action response as the v2 when there are no big difference between them.","commit_id":"e6a28ba4649e222695a032a94028f27780fb1362"}],"openstackclient/volume/v2/volume.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a0f751e69bd07b1958ed1951f5fbef39370cc7d1","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        )"},{"line_number":391,"context_line":"        parser.add_argument("},{"line_number":392,"context_line":"            \"--bootable\","},{"line_number":393,"context_line":"            dest\u003d\"bootable\","},{"line_number":394,"context_line":"            action\u003d\"store_true\","},{"line_number":395,"context_line":"            default\u003dFalse,"},{"line_number":396,"context_line":"            help\u003d_(\"Specifies the volume should be marked as bootable\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_4ec81575","line":393,"range":{"start_line":393,"start_character":12,"end_line":393,"end_character":28},"updated":"2016-08-25 03:42:00.000000000","message":"this is not necessary, its the default","commit_id":"757e7382fb3ac85891c1871a41dfb0f466686167"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"3a93f5b352d7021034ed8e38373ef9b10933598f","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        )"},{"line_number":391,"context_line":"        parser.add_argument("},{"line_number":392,"context_line":"            \"--bootable\","},{"line_number":393,"context_line":"            dest\u003d\"bootable\","},{"line_number":394,"context_line":"            action\u003d\"store_true\","},{"line_number":395,"context_line":"            default\u003dFalse,"},{"line_number":396,"context_line":"            help\u003d_(\"Specifies the volume should be marked as bootable\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_d6abf7d4","line":393,"range":{"start_line":393,"start_character":12,"end_line":393,"end_character":28},"in_reply_to":"1ac06dbe_4ec81575","updated":"2016-08-25 05:43:19.000000000","message":"Done in the set 2. Thanks, Steve.","commit_id":"757e7382fb3ac85891c1871a41dfb0f466686167"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"1b8d2c61399c28da053a494e979141822303318d","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            action\u003d\"store_true\","},{"line_number":394,"context_line":"            default\u003dFalse,"},{"line_number":395,"context_line":"            help\u003d_(\"Specifies the volume should be marked as bootable\")"},{"line_number":396,"context_line":"        )"},{"line_number":397,"context_line":"        return parser"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_b4490ed3","line":396,"updated":"2016-08-25 12:42:19.000000000","message":"\"--bootable\" option can only set bootable to Ture, should we add a mutually exclusive option to set bootable to False?","commit_id":"f4293a21709dff1cd1068339e62525aa06946392"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"9e677e75e2bf9645abf18c86b324e0881297062c","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            action\u003d\"store_true\","},{"line_number":394,"context_line":"            default\u003dFalse,"},{"line_number":395,"context_line":"            help\u003d_(\"Specifies the volume should be marked as bootable\")"},{"line_number":396,"context_line":"        )"},{"line_number":397,"context_line":"        return parser"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_29f3f20b","line":396,"in_reply_to":"1ac06dbe_b4490ed3","updated":"2016-08-25 13:33:19.000000000","message":"Same as my below comments.","commit_id":"f4293a21709dff1cd1068339e62525aa06946392"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"1b8d2c61399c28da053a494e979141822303318d","unresolved":false,"context_lines":[{"line_number":436,"context_line":"            except Exception as e:"},{"line_number":437,"context_line":"                LOG.error(_(\"Failed to set volume state: %s\"), e)"},{"line_number":438,"context_line":"                result +\u003d 1"},{"line_number":439,"context_line":"        try:"},{"line_number":440,"context_line":"            volume_client.volumes.set_bootable("},{"line_number":441,"context_line":"                volume.id, parsed_args.bootable)"},{"line_number":442,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_d4148aa0","line":439,"updated":"2016-08-25 12:42:19.000000000","message":"In this case, if without \"--bootable\" option, the API \"set_bootable()\" will still be called with \"parsed_args.bootable\u003dFalse\", it is not correct.","commit_id":"f4293a21709dff1cd1068339e62525aa06946392"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"58cd3ac2f681f0fc1a8151e7b8516fee133d8e9e","unresolved":false,"context_lines":[{"line_number":436,"context_line":"            except Exception as e:"},{"line_number":437,"context_line":"                LOG.error(_(\"Failed to set volume state: %s\"), e)"},{"line_number":438,"context_line":"                result +\u003d 1"},{"line_number":439,"context_line":"        try:"},{"line_number":440,"context_line":"            volume_client.volumes.set_bootable("},{"line_number":441,"context_line":"                volume.id, parsed_args.bootable)"},{"line_number":442,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_df176c52","line":439,"in_reply_to":"1ac06dbe_3cbfaefd","updated":"2016-08-25 14:04:35.000000000","message":"Well, seems there are two ways to set this attr in cinder.\n\nMy ref cinder command is: cinder manage which I think maybe more similar to volume set in openstack.\nSo which one should be as the ref command here.\nMaybe this is a question for me...\n\nroot@controller01:/home/viouser# cinder help manage\nusage: cinder manage [--id-type \u003cid-type\u003e] [--name \u003cname\u003e]\n                     [--description \u003cdescription\u003e]\n                     [--volume-type \u003cvolume-type\u003e]\n                     [--availability-zone \u003cavailability-zone\u003e]\n                     [--metadata [\u003ckey\u003dvalue\u003e [\u003ckey\u003dvalue\u003e ...]]] [--bootable]\n                     \u003chost\u003e \u003cidentifier\u003e\n\nManage an existing volume.\n\nPositional arguments:\n  \u003chost\u003e                Cinder host on which the existing volume resides;\n                        takes the form: host@backend-name#pool\n  \u003cidentifier\u003e          Name or other Identifier for existing volume\n\nOptional arguments:\n  --id-type \u003cid-type\u003e   Type of backend device identifier provided, typically\n                        source-name or source-id (Default\u003dsource-name)\n  --name \u003cname\u003e         Volume name (Default\u003dNone)\n  --description \u003cdescription\u003e\n                        Volume description (Default\u003dNone)\n  --volume-type \u003cvolume-type\u003e\n                        Volume type (Default\u003dNone)\n  --availability-zone \u003cavailability-zone\u003e\n                        Availability zone for volume (Default\u003dNone)\n  --metadata [\u003ckey\u003dvalue\u003e [\u003ckey\u003dvalue\u003e ...]]\n                        Metadata key\u003dvalue pairs (Default\u003dNone)\n  --bootable            Specifies that the newly created volume should be\n                        marked as bootable","commit_id":"f4293a21709dff1cd1068339e62525aa06946392"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"7ae7a684328c8cdaef1205655aad688a1ac8a946","unresolved":false,"context_lines":[{"line_number":436,"context_line":"            except Exception as e:"},{"line_number":437,"context_line":"                LOG.error(_(\"Failed to set volume state: %s\"), e)"},{"line_number":438,"context_line":"                result +\u003d 1"},{"line_number":439,"context_line":"        try:"},{"line_number":440,"context_line":"            volume_client.volumes.set_bootable("},{"line_number":441,"context_line":"                volume.id, parsed_args.bootable)"},{"line_number":442,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_3cbfaefd","line":439,"in_reply_to":"1ac06dbe_c984de5e","updated":"2016-08-25 13:44:06.000000000","message":"In cinderclient I see the usage is:\ncinder set-bootable \u003cvolume\u003e \u003cTrue|true|False|false\u003e\nIs it?","commit_id":"f4293a21709dff1cd1068339e62525aa06946392"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"9e677e75e2bf9645abf18c86b324e0881297062c","unresolved":false,"context_lines":[{"line_number":436,"context_line":"            except Exception as e:"},{"line_number":437,"context_line":"                LOG.error(_(\"Failed to set volume state: %s\"), e)"},{"line_number":438,"context_line":"                result +\u003d 1"},{"line_number":439,"context_line":"        try:"},{"line_number":440,"context_line":"            volume_client.volumes.set_bootable("},{"line_number":441,"context_line":"                volume.id, parsed_args.bootable)"},{"line_number":442,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_c984de5e","line":439,"in_reply_to":"1ac06dbe_d4148aa0","updated":"2016-08-25 13:33:19.000000000","message":"Hi Huanxuan,\nYes, the bootable will be set to False when volume set without the --bootable option.\nBut this is the same design of cinderclient which I have confirmed before my fix.\nShall we still follow this in the openstack client?","commit_id":"f4293a21709dff1cd1068339e62525aa06946392"},{"author":{"_account_id":21514,"name":"Huanxuan Ao","email":"aohuanxuan@163.com","username":"aohuanxuan"},"change_message_id":"cebb56c8a7216e47113f28c4971791559663265b","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                   \u0027\"deleting\", \"in-use\", \"attaching\", \"detaching\", \u0027"},{"line_number":389,"context_line":"                   \u0027\"error_deleting\" or \"maintenance\")\u0027),"},{"line_number":390,"context_line":"        )"},{"line_number":391,"context_line":"        parser.add_argument("},{"line_number":392,"context_line":"            \"--bootable\","},{"line_number":393,"context_line":"            action\u003d\"store_true\","},{"line_number":394,"context_line":"            default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_f9aee983","line":391,"updated":"2016-08-29 10:19:42.000000000","message":"These two options should be in a mutually exclusive group.","commit_id":"011172f00ce3ad22611651a28c5cf6ca0f9b7b4b"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"17d4bad8a9b1cc55e9c5d50c85e63127f51b4764","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                   \u0027\"deleting\", \"in-use\", \"attaching\", \"detaching\", \u0027"},{"line_number":389,"context_line":"                   \u0027\"error_deleting\" or \"maintenance\")\u0027),"},{"line_number":390,"context_line":"        )"},{"line_number":391,"context_line":"        parser.add_argument("},{"line_number":392,"context_line":"            \"--bootable\","},{"line_number":393,"context_line":"            action\u003d\"store_true\","},{"line_number":394,"context_line":"            default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_99a83a22","line":391,"in_reply_to":"fa7ab95a_f9aee983","updated":"2016-08-30 03:46:08.000000000","message":"Done","commit_id":"011172f00ce3ad22611651a28c5cf6ca0f9b7b4b"},{"author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"change_message_id":"67183914615fbc508abb165bec84ae5e04fa5c88","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        bootable_group.add_argument("},{"line_number":415,"context_line":"            \"--non-bootable\","},{"line_number":416,"context_line":"            dest\u003d\"bootable\","},{"line_number":417,"context_line":"            action\u003d\"store_false\","},{"line_number":418,"context_line":"            help\u003d_(\"Mark volume as non-bootable\")"},{"line_number":419,"context_line":"        )"},{"line_number":420,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_4838aad3","line":417,"range":{"start_line":417,"start_character":20,"end_line":417,"end_character":31},"updated":"2016-09-13 09:06:31.000000000","message":"Sorry, please follow the rules here:\nhttp://docs.openstack.org/developer/python-openstackclient/command-options.html#boolean-options","commit_id":"e6a28ba4649e222695a032a94028f27780fb1362"},{"author":{"_account_id":22754,"name":"Qiang Tang","email":"qtang@vmware.com","username":"qtang"},"change_message_id":"8e0a16cfcc23b3f5c7f1edacc77477935b5d0307","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        bootable_group.add_argument("},{"line_number":415,"context_line":"            \"--non-bootable\","},{"line_number":416,"context_line":"            dest\u003d\"bootable\","},{"line_number":417,"context_line":"            action\u003d\"store_false\","},{"line_number":418,"context_line":"            help\u003d_(\"Mark volume as non-bootable\")"},{"line_number":419,"context_line":"        )"},{"line_number":420,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_b987c65f","line":417,"range":{"start_line":417,"start_character":20,"end_line":417,"end_character":31},"in_reply_to":"9a89bdaa_4838aad3","updated":"2016-09-13 09:44:09.000000000","message":"Done","commit_id":"e6a28ba4649e222695a032a94028f27780fb1362"}]}