)]}'
{"id":"openstack%2Fpython-openstackclient~360277","triplet_id":"openstack%2Fpython-openstackclient~master~I2eb35dc53f0fdb61c31022bb70293d1df8aaf482","project":"openstack/python-openstackclient","branch":"master","topic":"cleancode","hashtags":[],"change_id":"I2eb35dc53f0fdb61c31022bb70293d1df8aaf482","subject":"Clean imports in code","status":"MERGED","created":"2016-08-25 06:53:38.000000000","updated":"2016-08-29 13:13:32.000000000","submitted":"2016-08-29 13:13:32.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"75c8428bd02a48aa1af2e0967980c36cad14a181","_number":360277,"virtual_id_number":360277,"owner":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-08-29 13:13:32.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-08-25 16:49:04.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-08-29 12:00:31.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-08-29 12:00:31.000000000","_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-25 16:49:04.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-08-29 12:00:31.000000000","updated_by":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"reviewer":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"state":"REVIEWER"},{"updated":"2016-08-29 13:13:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"71edeab952f425ca8a78610e6b5df126756ea547","author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"date":"2016-08-25 06:53:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5468597968e7df40ffe5042952db7169a9ff8329","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-25 08:06:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/77/360277/1/check/gate-python-openstackclient-docs-ubuntu-xenial/e9ff297//doc/build/html/ : SUCCESS in 2m 39s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/77/360277/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/4073e20/ : SUCCESS in 2m 38s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/77/360277/1/check/gate-python-openstackclient-python27-ubuntu-xenial/f6ec20b/ : SUCCESS in 4m 57s\n- gate-python-openstackclient-python34 http://logs.openstack.org/77/360277/1/check/gate-python-openstackclient-python34/34b6684/ : SUCCESS in 3m 04s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/77/360277/1/check/gate-python-openstackclient-python35-nv/3d11882/ : SUCCESS in 3m 14s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/77/360277/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/fe1b30e/ : SUCCESS in 1h 11m 17s\n- check-osc-plugins http://logs.openstack.org/77/360277/1/check/check-osc-plugins/6d0b665/ : SUCCESS in 3m 02s\n- gate-osc-dsvm-functional http://logs.openstack.org/77/360277/1/check/gate-osc-dsvm-functional/a680ad1/ : SUCCESS in 35m 48s","accounts_in_message":[],"_revision_number":1},{"id":"a8c496ba9d4524fb0b679ce09f35527acb9025b3","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-08-25 16:48:17.000000000","message":"Patch Set 1:\n\nyes, this matches what we have defined in hacking","accounts_in_message":[],"_revision_number":1},{"id":"dea8b2f85179756517275061991a2cd2c41e0248","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-08-25 16:49:04.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7c8d25989ca02ca0f2439b07e2df9d8a260f92a6","author":{"_account_id":14937,"name":"Tang Chen","email":"imtangchen@163.com","username":"tangchen"},"date":"2016-08-29 12:00:31.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"1a9b781e80423c4b9bf65653c387265b6ee81605","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-29 12:00:41.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"4b8af7a2ecfe5341104e7994e42a3a9067891d76","date":"2016-08-29 13:13:32.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"6f0b40222266308c01590daf9a1959bc38484d2c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-29 13:13:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/77/360277/1/gate/gate-python-openstackclient-docs-ubuntu-xenial/fd304b9//doc/build/html/ : SUCCESS in 4m 30s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/77/360277/1/gate/gate-python-openstackclient-pep8-ubuntu-xenial/ce0e3cf/ : SUCCESS in 5m 44s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/77/360277/1/gate/gate-python-openstackclient-python27-ubuntu-xenial/7b0adfb/ : SUCCESS in 3m 14s\n- gate-python-openstackclient-python34 http://logs.openstack.org/77/360277/1/gate/gate-python-openstackclient-python34/f95938b/ : SUCCESS in 3m 14s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/77/360277/1/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/974cb06/ : SUCCESS in 1h 12m 14s\n- gate-osc-dsvm-functional http://logs.openstack.org/77/360277/1/gate/gate-osc-dsvm-functional/d9dfd2d/ : SUCCESS in 38m 22s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f854b7d6ea1c67cf7f313e039691c4cb40ff1236","revisions":{"f854b7d6ea1c67cf7f313e039691c4cb40ff1236":{"kind":"REWORK","_number":1,"created":"2016-08-25 06:53:38.000000000","uploader":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"ref":"refs/changes/77/360277/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/77/360277/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/360277/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/360277/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/77/360277/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/77/360277/1"}}},"commit":{"parents":[{"commit":"afda6f846fc3abea47c83e6384974cb9bdb8db3b","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/afda6f846fc3abea47c83e6384974cb9bdb8db3b"}]}],"author":{"name":"Cao Xuan Hoang","email":"hoangcx@vn.fujitsu.com","date":"2016-08-25 06:50:38.000000000","tz":420},"committer":{"name":"Cao Xuan Hoang","email":"hoangcx@vn.fujitsu.com","date":"2016-08-25 06:50:38.000000000","tz":420},"subject":"Clean imports in code","message":"Clean imports in code\n\nIn some part in the code we import objects.\nIn the Openstack style guidelines they recommend to import only modules.\n\nhttp://docs.openstack.org/developer/hacking/#imports\n\nChange-Id: I2eb35dc53f0fdb61c31022bb70293d1df8aaf482\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f854b7d6ea1c67cf7f313e039691c4cb40ff1236"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/f854b7d6ea1c67cf7f313e039691c4cb40ff1236"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}