)]}'
{"doc/source/command-objects/volume.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"6d99a00e3204c070384e7917ccbad3f81185e735","unresolved":false,"context_lines":[{"line_number":28,"context_line":".. option:: --size \u003csize\u003e"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    Volume size in GB. If :option:`--snapshot` and :option:`--source`"},{"line_number":31,"context_line":"    are specified :option:`--size` aren\u0027t required."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. option:: --type \u003cvolume-type\u003e"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa7ab95a_39e7d5e5","line":31,"range":{"start_line":31,"start_character":35,"end_line":31,"end_character":41},"updated":"2016-08-26 05:43:07.000000000","message":"isn\u0027t*\n\nor \"is not\"","commit_id":"b5568b07b2d5682fa730db2d4f57d9c50d5cf424"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cf621f7944276f695e649a5772904b21a1de4e02","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":".. option:: --size \u003csize\u003e"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    Volume size in GB. If :option:`--snapshot` and :option:`--source`"},{"line_number":31,"context_line":"    are specified :option:`--size` isn\u0027t required."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. option:: --type \u003cvolume-type\u003e"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8ec9b2_7c062087","line":31,"range":{"start_line":30,"start_character":23,"end_line":31,"end_character":50},"updated":"2016-09-16 05:26:10.000000000","message":"A bit shorter:\n\"Not required if using :option:`--snapshot` or :option:`--source`.\"","commit_id":"152ed8c6296eb5ee6fd815f95bd2a25329b745ae"}],"openstackclient/volume/v1/volume.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"6d99a00e3204c070384e7917ccbad3f81185e735","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            metavar\u003d\u0027\u003csize\u003e\u0027,"},{"line_number":45,"context_line":"            action\u003dCheckSizeArgForCreate,"},{"line_number":46,"context_line":"            type\u003dint,"},{"line_number":47,"context_line":"            help\u003d_(\u0027Volume size in GB\u0027),"},{"line_number":48,"context_line":"        )"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027--type\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_79d15dfb","line":47,"range":{"start_line":47,"start_character":20,"end_line":47,"end_character":37},"updated":"2016-08-26 05:43:07.000000000","message":"this should be updated to match the help text is the rst file","commit_id":"b5568b07b2d5682fa730db2d4f57d9c50d5cf424"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cf621f7944276f695e649a5772904b21a1de4e02","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            metavar\u003d\u0027\u003csize\u003e\u0027,"},{"line_number":46,"context_line":"            action\u003dparseactions.CheckSizeArgForCreate,"},{"line_number":47,"context_line":"            type\u003dint,"},{"line_number":48,"context_line":"            help\u003d_(\u0027Volume size in GB. If :option:`--snapshot` and "},{"line_number":49,"context_line":"                   :option:`--source` are specified :option:`--size` "},{"line_number":50,"context_line":"                   aren\\\u0027t required.\u0027),"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \u0027--type\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_dc01f46b","line":50,"range":{"start_line":48,"start_character":39,"end_line":50,"end_character":36},"updated":"2016-09-16 05:26:10.000000000","message":"a quick suggestion:\n\n\"Not required if using --snapshot or --source.\"","commit_id":"152ed8c6296eb5ee6fd815f95bd2a25329b745ae"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cf621f7944276f695e649a5772904b21a1de4e02","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                volume.id,"},{"line_number":472,"context_line":"                parsed_args.property,"},{"line_number":473,"context_line":"            )"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_3cf1f895","line":475,"range":{"start_line":474,"start_character":0,"end_line":475,"end_character":0},"updated":"2016-09-16 05:26:10.000000000","message":"undo these whitespace changes","commit_id":"152ed8c6296eb5ee6fd815f95bd2a25329b745ae"}],"openstackclient/volume/v2/volume.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"6d99a00e3204c070384e7917ccbad3f81185e735","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            metavar\u003d\"\u003csize\u003e\","},{"line_number":47,"context_line":"            type\u003dint,"},{"line_number":48,"context_line":"            action\u003dCheckSizeArgForCreate,"},{"line_number":49,"context_line":"            help\u003d_(\"Volume size in GB\"),"},{"line_number":50,"context_line":"        )"},{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \"--type\","}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_99ce2159","line":49,"range":{"start_line":49,"start_character":20,"end_line":49,"end_character":37},"updated":"2016-08-26 05:43:07.000000000","message":"this should be updated to match the help text is the rst file","commit_id":"b5568b07b2d5682fa730db2d4f57d9c50d5cf424"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"6d99a00e3204c070384e7917ccbad3f81185e735","unresolved":false,"context_lines":[{"line_number":522,"context_line":""},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"#TODO: Move to single place"},{"line_number":525,"context_line":"class CheckSizeArgForCreate(argparse.Action):"},{"line_number":526,"context_line":"    def __call__(self, parser, args, values, option_string\u003dNone):"},{"line_number":527,"context_line":"        if ((args.snapshot_id or args.source_volid or args.source_replica)"},{"line_number":528,"context_line":"                is None and values is None):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_d9c18930","line":525,"range":{"start_line":525,"start_character":6,"end_line":525,"end_character":27},"updated":"2016-08-26 05:43:07.000000000","message":"we typically place these in https://github.com/openstack/osc-lib/blob/master/osc_lib/cli/parseractions.py\n\nthough i\u0027m not sure if we can make this generic enough... you could create a common.py under openstackclient/volume","commit_id":"b5568b07b2d5682fa730db2d4f57d9c50d5cf424"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"23a2e22232df0ef41d2a355ff4817b407c4851a6","unresolved":false,"context_lines":[{"line_number":522,"context_line":""},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"#TODO: Move to single place"},{"line_number":525,"context_line":"class CheckSizeArgForCreate(argparse.Action):"},{"line_number":526,"context_line":"    def __call__(self, parser, args, values, option_string\u003dNone):"},{"line_number":527,"context_line":"        if ((args.snapshot_id or args.source_volid or args.source_replica)"},{"line_number":528,"context_line":"                is None and values is None):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_4d092c2c","line":525,"range":{"start_line":525,"start_character":6,"end_line":525,"end_character":27},"in_reply_to":"fa7ab95a_d9c18930","updated":"2016-08-26 08:34:26.000000000","message":"I saw the link above but I wasn\u0027t sure how to organize contribution workflow. I\u0027ve found https://github.com/openstack/python-openstackclient/blob/master/openstackclient/common/parseractions.py but for some unknown to me reason it deprecated(Could you explain why?). Copy-paste also not good so anyway we should make it generic somehow. I suggest to create parseaction.py inside openstackclient/volume or 1) to add CheckSizeArgForCreate class to https://github.com/openstack/osc-lib/blob/master/osc_lib/cli/parseractions.py 2) then in dependent patch(current patch) use it","commit_id":"b5568b07b2d5682fa730db2d4f57d9c50d5cf424"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cf621f7944276f695e649a5772904b21a1de4e02","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            metavar\u003d\"\u003csize\u003e\","},{"line_number":47,"context_line":"            type\u003dint,"},{"line_number":48,"context_line":"            action\u003dparseactions.CheckSizeArgForCreate,"},{"line_number":49,"context_line":"            help\u003d_(\"Volume size in GB. If :option:`--snapshot` and "},{"line_number":50,"context_line":"                   :option:`--source` are specified :option:`--size` "},{"line_number":51,"context_line":"                   aren\u0027t required.\"),"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":"        parser.add_argument("},{"line_number":54,"context_line":"            \"--type\","}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_3c4818cc","line":51,"range":{"start_line":49,"start_character":39,"end_line":51,"end_character":35},"updated":"2016-09-16 05:26:10.000000000","message":"same suggestion as in v1","commit_id":"152ed8c6296eb5ee6fd815f95bd2a25329b745ae"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cf621f7944276f695e649a5772904b21a1de4e02","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            \"--property\","},{"line_number":95,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":96,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":97,"context_line":"            type\u003dint,"},{"line_number":98,"context_line":"            help\u003d_(\"Set a property to this volume \""},{"line_number":99,"context_line":"                   \"(repeat option to set multiple properties)\"),"},{"line_number":100,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_7c2d40fd","line":97,"range":{"start_line":97,"start_character":12,"end_line":97,"end_character":21},"updated":"2016-09-16 05:26:10.000000000","message":"undo this change, properties are not ints","commit_id":"152ed8c6296eb5ee6fd815f95bd2a25329b745ae"}]}