)]}'
{"id":"openstack%2Fpython-openstackclient~364518","triplet_id":"openstack%2Fpython-openstackclient~master~Ia4eae350e6904c9eb2c8507d9b3429fe52418726","project":"openstack/python-openstackclient","branch":"master","topic":"bug/1619274","hashtags":[],"change_id":"Ia4eae350e6904c9eb2c8507d9b3429fe52418726","subject":"Defer auth prompting until it is actually needed","status":"MERGED","created":"2016-09-01 19:19:18.000000000","updated":"2016-09-19 19:14:43.000000000","submitted":"2016-09-08 17:40:13.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"87a7fa68686898be63b5c4a5efecd0898f1160ab","_number":364518,"virtual_id_number":364518,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2016-09-08 17:40:13.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":2,"date":"2016-09-08 15:42:28.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-09-08 16:29:06.000000000","_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"all":[{"value":1,"date":"2016-09-08 16:43:52.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-08 16:29:06.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-09-08 16:43:52.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2016-09-08 17:40:13.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"f0ea8cbc227824efad9601dab7d92d1d3ee34ad2","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-09-01 19:19:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bf586fb12438f76d6a02fc1a83104d43a3f28d68","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-01 20:28:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/18/364518/1/check/gate-python-openstackclient-docs-ubuntu-xenial/f74bcb7//doc/build/html/ : SUCCESS in 4m 51s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/18/364518/1/check/gate-python-openstackclient-pep8-ubuntu-xenial/ab372f4/ : SUCCESS in 2m 44s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/18/364518/1/check/gate-python-openstackclient-python27-ubuntu-xenial/e8c0961/ : SUCCESS in 2m 44s\n- gate-python-openstackclient-python34 http://logs.openstack.org/18/364518/1/check/gate-python-openstackclient-python34/f367f8c/ : SUCCESS in 2m 44s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/18/364518/1/check/gate-python-openstackclient-python35-nv/eb5d126/ : SUCCESS in 3m 17s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/18/364518/1/check/gate-tempest-dsvm-neutron-src-python-openstackclient/96b359a/ : SUCCESS in 1h 09m 18s\n- check-osc-plugins http://logs.openstack.org/18/364518/1/check/check-osc-plugins/ec43d64/ : SUCCESS in 5m 16s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/18/364518/1/check/gate-osc-dsvm-functional/eed6a8d/ : SUCCESS in 27m 52s","accounts_in_message":[],"_revision_number":1},{"id":"232e0244eaf5668cd23a62315d7e976a1376d25c","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-09-02 10:54:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e4c2695bd08c4a7607af698c3f77b43e440644db","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-09-05 03:48:56.000000000","message":"Patch Set 1: Code-Review-1\n\nthis didn\u0027t work for me:\n\n(oscprompt) stevemar@ubuntu:/opt/stack/python-openstackclient$ openstack complete\nMissing value auth-url required for auth plugin password\n\nmore at: http://paste.openstack.org/show/566766/","accounts_in_message":[],"_revision_number":1},{"id":"b0e9397418f839dabaad25d3e2352e4410337388","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-09-06 17:30:23.000000000","message":"Patch Set 1:\n\ni double checked this to make sure, but i\u0027m still getting the same error :(","accounts_in_message":[],"_revision_number":1},{"id":"ab2ebc216a859009595827bb4c123d5bdb2aa153","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-09-06 17:58:56.000000000","message":"Patch Set 1:\n\nI get the same result as stevemar.","accounts_in_message":[],"_revision_number":1},{"id":"5b80a571a038ffeab1fba309d8664705ca2ab7af","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-09-06 18:09:35.000000000","message":"Patch Set 1:\n\n\u003e I get the same result as stevemar.\n\nJudging from the commit message, this result should be expected with no authentication information is present.","accounts_in_message":[],"_revision_number":1},{"id":"242ac35e23be9dc2384c48fbbd0c3429926d9e59","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-09-06 19:12:18.000000000","message":"Patch Set 1: -Code-Review\n\n\u003e \u003e I get the same result as stevemar.\n \u003e \n \u003e Judging from the commit message, this result should be expected\n \u003e with no authentication information is present.\n\nAlthough, do we need to support https://review.openstack.org/#/c/366296/ like before?","accounts_in_message":[],"_revision_number":1},{"id":"94d92cbc07b3e5ecc6063ee3f5b34759dc6a678c","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-09-06 19:30:20.000000000","message":"Patch Set 1:\n\ni proposed https://review.openstack.org/#/c/366296/ to see if this works","accounts_in_message":[],"_revision_number":1},{"id":"112df03648d7ad6695efd25b87f3da8f9f57d6ab","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2016-09-08 15:34:35.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"43672ca6d88ea7f8866b8c7702be4a8d4d14fd89","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-09-08 15:42:28.000000000","message":"Patch Set 2: Code-Review+2\n\nworked for me!","accounts_in_message":[],"_revision_number":2},{"id":"38cb868d6b0b2c6d0aa8038f8fd79d172031cd00","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-09-08 16:29:06.000000000","message":"Patch Set 2: Code-Review+2\n\nworks for me too","accounts_in_message":[],"_revision_number":2},{"id":"0b1a4fc9bf439eb0f80334988c648b3d8af8c461","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2016-09-08 16:43:52.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"7cdf83e70ad372e2fc8e3f3ad518d4991ba42ff0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-08 16:46:17.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/18/364518/2/check/gate-python-openstackclient-docs-ubuntu-xenial/f228f39//doc/build/html/ : SUCCESS in 4m 10s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/18/364518/2/check/gate-python-openstackclient-pep8-ubuntu-xenial/c482463/ : SUCCESS in 4m 44s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/18/364518/2/check/gate-python-openstackclient-python27-ubuntu-xenial/27ca543/ : SUCCESS in 4m 30s\n- gate-python-openstackclient-python34 http://logs.openstack.org/18/364518/2/check/gate-python-openstackclient-python34/ef6a91c/ : SUCCESS in 2m 55s\n- gate-python-openstackclient-python35-nv http://logs.openstack.org/18/364518/2/check/gate-python-openstackclient-python35-nv/cf1e001/ : SUCCESS in 5m 10s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/18/364518/2/check/gate-tempest-dsvm-neutron-src-python-openstackclient/892718a/ : SUCCESS in 1h 05m 44s\n- check-osc-plugins http://logs.openstack.org/18/364518/2/check/check-osc-plugins/f90e2eb/ : SUCCESS in 4m 54s (non-voting)\n- gate-osc-dsvm-functional http://logs.openstack.org/18/364518/2/check/gate-osc-dsvm-functional/149e4cd/ : SUCCESS in 41m 32s","accounts_in_message":[],"_revision_number":2},{"id":"23995f1fd9ab8e95698701c3dac2aa5ada1b85b1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-08 16:46:28.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"b079f6225500465046ccc1898e354b42b6766490","date":"2016-09-08 17:40:13.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"164da2f6deeeeca32b8a4d3ca4ef6c78fe6e636d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-08 17:40:13.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-openstackclient-docs-ubuntu-xenial http://docs-draft.openstack.org/18/364518/2/gate/gate-python-openstackclient-docs-ubuntu-xenial/600c413//doc/build/html/ : SUCCESS in 5m 29s\n- gate-python-openstackclient-pep8-ubuntu-xenial http://logs.openstack.org/18/364518/2/gate/gate-python-openstackclient-pep8-ubuntu-xenial/c9bda55/ : SUCCESS in 3m 54s\n- gate-python-openstackclient-python27-ubuntu-xenial http://logs.openstack.org/18/364518/2/gate/gate-python-openstackclient-python27-ubuntu-xenial/03037bf/ : SUCCESS in 4m 05s\n- gate-python-openstackclient-python34 http://logs.openstack.org/18/364518/2/gate/gate-python-openstackclient-python34/5544a86/ : SUCCESS in 3m 49s\n- gate-tempest-dsvm-neutron-src-python-openstackclient http://logs.openstack.org/18/364518/2/gate/gate-tempest-dsvm-neutron-src-python-openstackclient/12c9bf8/ : SUCCESS in 52m 56s\n- gate-osc-dsvm-functional http://logs.openstack.org/18/364518/2/gate/gate-osc-dsvm-functional/8e60bfe/ : SUCCESS in 27m 24s","accounts_in_message":[],"_revision_number":2},{"id":"02d85edbfc1c3632bcb1760aeeaf92291cd3c3b5","author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"date":"2016-09-19 19:14:43.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/newton as commit a2cd3a7e29955bac69cf4492a3d159bff8db598d","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"14dbfe44741b65c9e0514a34669f52de8629b1c0","revisions":{"a16bd6da421d841b76ff138962eb0f9cfea6481b":{"kind":"REWORK","_number":1,"created":"2016-09-01 19:19:18.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/18/364518/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/18/364518/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/18/364518/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/18/364518/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/18/364518/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/18/364518/1"}}},"commit":{"parents":[{"commit":"59404393d305d4e209f2a3af4a80c56a9a42a7d9","subject":"Merge \"Rearrange integration tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/59404393d305d4e209f2a3af4a80c56a9a42a7d9"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2016-09-01 15:54:29.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2016-09-01 19:19:02.000000000","tz":-300},"subject":"Defer auth prompting until it is actually needed","message":"Defer auth prompting until it is actually needed\n\nAuth option prompting happens waaaay to early in the default\nos-client-config flow, we need to defer it until adter the commands\nhave been parsed.  This is why ClientManager.setup_auth() exists,\nas it is not called until the first attempt to connect to a server\noccurs.  Commands that do not require authentication never hit this.\n\nAlso, required options were not being enforced.  By doing this we handle\nwhen no authentication info is present, we fail on missing auth-url rather\nthan attempt to prompt for a password (default auth is password).\n\nCloses-Bug: 1619274\nChange-Id: Ia4eae350e6904c9eb2c8507d9b3429fe52418726\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a16bd6da421d841b76ff138962eb0f9cfea6481b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/a16bd6da421d841b76ff138962eb0f9cfea6481b"}]},"branch":"refs/heads/master"},"14dbfe44741b65c9e0514a34669f52de8629b1c0":{"kind":"REWORK","_number":2,"created":"2016-09-08 15:34:35.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/18/364518/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-openstackclient","ref":"refs/changes/18/364518/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/18/364518/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/18/364518/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-openstackclient refs/changes/18/364518/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-openstackclient refs/changes/18/364518/2"}}},"commit":{"parents":[{"commit":"59404393d305d4e209f2a3af4a80c56a9a42a7d9","subject":"Merge \"Rearrange integration tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/59404393d305d4e209f2a3af4a80c56a9a42a7d9"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2016-09-01 15:54:29.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2016-09-08 15:31:13.000000000","tz":-300},"subject":"Defer auth prompting until it is actually needed","message":"Defer auth prompting until it is actually needed\n\nAuth option prompting happens waaaay to early in the default\nos-client-config flow, we need to defer it until adter the commands\nhave been parsed.  This is why ClientManager.setup_auth() exists,\nas it is not called until the first attempt to connect to a server\noccurs.  Commands that do not require authentication never hit this.\n\nAlso, required options were not being enforced.  By doing this we handle\nwhen no authentication info is present, we fail on missing auth-url rather\nthan attempt to prompt for a password (default auth is password).\n\nCloses-Bug: 1619274\nChange-Id: Ia4eae350e6904c9eb2c8507d9b3429fe52418726\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/14dbfe44741b65c9e0514a34669f52de8629b1c0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-openstackclient/commit/14dbfe44741b65c9e0514a34669f52de8629b1c0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}